On Thu, Jun 4, 2020 at 2:43 PM Richard Biener <rguent...@suse.de> wrote: > > On Thu, 4 Jun 2020, Hongtao Liu wrote: > > > Hi Richard: > > Could you help review this patch. > > uros said he wouldn't review patches related to x86 vector ISA anymore. > > I can't spot anything wrong but I know nothing about what a > define_subst is. You say "Bootstrap is ok, regression test on i386/x86-64 > backend is ok". Please make sure to run the entire testsuite > for all default languages as required. Esp. there are vectorizer > testcases throughout the testsuite (not only in vect.exp). Ok. > > ISTR there was a bug about this, please make sure to refer to it > in the commit message and the ChangeLog part. Ok. > > OK if that passes. > > Thanks, > Richard. > > > On Wed, Jun 3, 2020 at 10:26 AM Hongtao Liu <crazy...@gmail.com> wrote: > > > > > > Hi: > > > When dest is memory, zero-masking is not valid, only merging-masking > > > is available, > > > > > > Bootstrap is ok, regression test on i386/x86-64 backend is ok. > > > > > > gcc/ChangeLog: > > > * gcc/config/i386/sse.md (*vcvtps2ph_store<merge_mask_name>): > > > Refine from *vcvtps2ph_store<mask_name>. > > > (vcvtps2ph256<mask_name>): Refine constraint from vm to v. > > > (<mask_codefor>avx512f_vcvtps2ph512<mask_name>): Ditto. > > > (*vcvtps2ph256<merge_mask_name>): New define_insn. > > > (*avx512f_vcvtps2ph512<merge_mask_name>): Ditto. > > > * gcc/config/i386/subst.md (merge_mask): New define_subst. > > > (merge_mask_name): New define_subst_attr. > > > (merge_mask_operand3): Ditto. > > > > > > gcc/testsuite/ChangeLog: > > > * gcc.target/i386/avx512f-vcvtps2ph-pr95254.c: New test. > > > * gcc.target/i386/avx512vl-vcvtps2ph-pr95254.c: Ditto. > > > -- > > > BR, > > > Hongtao > > > > > > > > > > -- > Richard Biener <rguent...@suse.de> > SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, > Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg) Thanks.
-- BR, Hongtao
