[pushed] c++: *this capture in const member fn [PR95193].

2020-06-02 Thread Jason Merrill via Gcc-patches
Here, the capture proxy for *this is const, but its DECL_VALUE_EXPR is not. Don't ICE on this; it's a reasonable difference, since in C++ an rvalue of scalar type does not have cv-qualifiers. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: PR c++/95193 * pt.c (ts

[PATCH] c++: constrained nested partial specialization [PR92103]

2020-06-02 Thread Patrick Palka via Gcc-patches
When determining the most specialized partial specialization of a primary template that is nested inside a class template, we first tsubst the outer template arguments into the TEMPLATE_DECL of each partial specialization, and then check for satisfaction of the new TEMPLATE_DECL's constraints. But

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On 24/05/20 15:43 +0200, François Dumont via Libstdc++ wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ok to co

Re: [PATCH] rs6000: Use REAL_TYPE to copy when block move array in structure[PR65421]

2020-06-02 Thread Segher Boessenkool
Hi Xiong Hu, On Tue, Jun 02, 2020 at 04:41:50AM -0500, Xionghu Luo wrote: > Double array in structure as function arguments or return value is accessed > by BLKmode, they are stored to stack and load from stack with redundant > conversion from DF->DI->DF. This patch checks the homogeneous type an

Re: [PATCH] rs6000: Use REAL_TYPE to copy when block move array in structure[PR65421]

2020-06-02 Thread David Edelsohn via Gcc-patches
On Tue, Jun 2, 2020 at 4:32 PM Segher Boessenkool wrote: > > Hi Xiong Hu, > > On Tue, Jun 02, 2020 at 04:41:50AM -0500, Xionghu Luo wrote: > > Double array in structure as function arguments or return value is accessed > > by BLKmode, they are stored to stack and load from stack with redundant > >

[PATCH] rs6000: identify lfs prefixed case PR95347

2020-06-02 Thread Aaron Sawdey via Gcc-patches
The same problem also arises for plfs where prefixed_load_p() doesn't recognize it so we get just lfs in the asm output with a @pcrel address. OK for trunk if regstrap on ppc64le passes? Thanks, Aaron PR target/95347 * config/rs6000/rs6000.c (is_stfs_insn): Rename to

[PATCH] c++: more constrained nested partial specialization

2020-06-02 Thread Patrick Palka via Gcc-patches
When checking that a constrained partial specialization is more constrained than the primary template, we pass only the innermost level of generic template arguments to strictly_subsumes. This leads to us doing a nonsensical substitution from normalize_concept_check if the full set of template arg

Re: [PATCH] Add pattern for pointer-diff on addresses with same base/offset (PR 94234)

2020-06-02 Thread Marc Glisse
On Mon, 1 Jun 2020, Feng Xue OS via Gcc-patches wrote: * match.pd ((PTR + A) - (PTR + B)) -> (ptrdiff_t)(A - B): New simplification. Not new, modified. * ((PTR_A + O) - (PTR_B + O)) -> (PTR_A - PTR_B): New simplification. O might not be the best choice because of ho

[committed] jit: fix __builtin_unreachable [PR 95426]

2020-06-02 Thread David Malcolm via Gcc-patches
PR jit/95426 reports a crash deep inside "expand" when using __builtin_unreachable via gcc_jit_context_get_builtin_function, due to BLOCK_FOR_INSN being erroneously used on a barrier within rtl_verify_bb_pointers. The root cause turns out to be that I didn't implement LANG_HOOKS_COMMON_ATTRIBUTE_T

Re: [PATCH] rs6000: Use REAL_TYPE to copy when block move array in structure[PR65421]

2020-06-02 Thread Segher Boessenkool
On Tue, Jun 02, 2020 at 04:56:49PM -0400, David Edelsohn wrote: > > > + if (TREE_CODE (type) == RECORD_TYPE > > > + && rs6000_discover_homogeneous_aggregate (TYPE_MODE (type), type, > > > NULL, > > > + NULL)) > > > +{ > > > + tree field_ty

[PATCH] avoid false positives due to compute_objsize (PR 95353)

2020-06-02 Thread Martin Sebor via Gcc-patches
The compute_objsize() function started out as a thin wrapper around compute_builtin_object_size(), but over time developed its own features to compensate for the other function's limitations (such as its inability to work with ranges). The interaction of these features and the limitations has sta

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-06-02 Thread Gerald Pfeifer
On Tue, 2 Jun 2020, Martin Liška wrote: > Ready for master? Before that, my nightly tester on i386-unknown-freebsd11 just ran into the following: /scratch/tmp/gerald/GCC-HEAD/gcc/../libgcc/libgcov.h:396:51: error: cannot initialize a parameter of type 'gcov_type' (aka 'long long') with a

Re: [PATCH 1/2] Introduce flag_cunroll_grow_size for cunroll

2020-06-02 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Tue, Jun 2, 2020 at 4:10 AM Jiufu Guo wrote: >> >> Jiufu Guo writes: >> >> Hi, >> >> I updated the patch just a little accordinlgy. Thanks! >> >> diff --git a/gcc/common.opt b/gcc/common.opt >> index 4464049fc1f..570e2aa53c8 100644 >> --- a/gcc/common.opt >> +++ b/g

[PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-02 Thread Hongtao Liu via Gcc-patches
Hi: When dest is memory, zero-masking is not valid, only merging-masking is available, Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog: * gcc/config/i386/sse.md (*vcvtps2ph_store): Refine from *vcvtps2ph_store. (vcvtps2ph256): Refine constr

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

2020-06-02 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/6/2 下午3:14, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> Thanks for the comments! >> >> on 2020/6/2 上午1:59, Richard Sandiford wrote: >>> Could you go into more detail about this choice of cost calculation? >>> It looks like we first calculate per-group f

Re: [PATCH 6/7] PowerPC tests: Add PC-relative tests.

2020-06-02 Thread Michael Meissner via Gcc-patches
On Mon, Jun 01, 2020 at 05:45:34PM -0500, will schmidt wrote: > Similar/same comment as was made in Apr.I recommend something like > > "Test whether pc-relative prefixed instructions > are generated for the _Decimal64 type." Ok, I missed that comment in April. -- Michael Meissner, IBM IBM

Re: [PATCH 0/4] IVOPTs consider step cost for different forms when unrolling

2020-06-02 Thread Kewen.Lin via Gcc-patches
Hi Richi, on 2020/6/2 下午7:38, Richard Biener wrote: > On Thu, 28 May 2020, Kewen.Lin wrote: > >> Hi, >> >> This is one repost and you can refer to the original series >> via https://gcc.gnu.org/pipermail/gcc-patches/2020-January/538360.html. >> >> As we discussed in the thread >> https://gcc.gnu

Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Alexandre Oliva
Hello, Martin, On Jun 2, 2020, Martin Liška wrote: > The problem happens when we generate temp file > for .res file. Tested locally with the problematic > options. Thanks for looking into this. > Ready for master? Erhm, no, I don't think that's correct. With local analysis, the length compu

[PATCH V2] PING^ correct COUNT and PROB for unrolled loop

2020-06-02 Thread Jiufu Guo via Gcc-patches
Jiufu Guo via Gcc-patches writes: Hi, I would like to reping this, hope to get approval for this patch. https://gcc.gnu.org/legacy-ml/gcc-patches/2020-02/msg00927.html BR, Jiufu Guo > Jiufu Guo writes: > > Hi, > > I'd like to ping this patch for trunk on stage 1. > > This patch could fix the

PING Re: testsuite: clarify scan-dump file globbing behavior

2020-06-02 Thread Frederik Harwath
Frederik Harwath writes: ping :-) > Frederik Harwath writes: > > Hi Rainer, hi Mike, > ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545803.html > > Best regards, > Frederik > >> Hi Thomas, >> >> Thomas Schwinge writes: >> >>> I can't formally approve testsuite patches, but did a re

Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Martin Liška
On 6/3/20 5:58 AM, Alexandre Oliva wrote: Please let me know if you'd prefer me to take this PR over. Yes, please take a look. Martin

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-06-02 Thread Martin Liška
On 6/3/20 3:07 AM, Gerald Pfeifer wrote: On Tue, 2 Jun 2020, Martin Liška wrote: Ready for master? Before that, my nightly tester on i386-unknown-freebsd11 just ran into the following: /scratch/tmp/gerald/GCC-HEAD/gcc/../libgcc/libgcov.h:396:51: error: cannot initialize a parameter of t

[PATCH] gcov: Fix build on AIX

2020-06-02 Thread Martin Liška
We must guard used atomic builtins with GCOV_SUPPORTS_ATOMIC. The patch is tested on AIX and I'm going to push it. libgcc/ChangeLog: PR gcov-profile/95480 * libgcov-profiler.c (GCOV_SUPPORTS_ATOMIC): Move to... * libgcov.h (GCOV_SUPPORTS_ATOMIC): ...here. (gcov_co

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-06-02 Thread Martin Liška
On 6/2/20 3:19 PM, Martin Liška wrote: I'm suggesting to pre-allocate 16 gcov_kvp in the gcov run-time library. Please take a look at the attached patch. I also added a test-case that stresses that. I've just finished LTO PGO bootstrap of the GCC. Ready for master? There's V2 of the patch: -

Re: [PATCH 5/7 v3] vect: Support vector load/store with length in vectorizer

2020-06-02 Thread Kewen.Lin via Gcc-patches
Hi Richard, Thanks a lot for your great comments! on 2020/6/2 下午7:50, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> on 2020/5/29 下午4:32, Richard Sandiford wrote: >>> "Kewen.Lin" writes: on 2020/5/27 下午6:02, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi

RE: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at config/aarch64/aarch64.c:16803

2020-06-02 Thread Yangfei (Felix)
Hi Richard, > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Wednesday, June 3, 2020 1:19 AM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at > config/aarch64/aarch64.c:16

<    1   2