On 6/3/20 3:07 AM, Gerald Pfeifer wrote:
On Tue, 2 Jun 2020, Martin Liška wrote:
Ready for master?
Before that, my nightly tester on i386-unknown-freebsd11 just ran into
the following:
/scratch/tmp/gerald/GCC-HEAD/gcc/../libgcc/libgcov.h:396:51: error:
cannot initialize a parameter of type 'gcov_type' (aka 'long long')
with an rvalue of type 'nullptr_t'
return !__sync_val_compare_and_swap (counter, NULL, (intptr_t)node);
^~~~
/usr/include/sys/_null.h:35:14: note: expanded from macro 'NULL'
#define NULL nullptr
^~~~~~~
Hello.
Sorry for the breakage. Can you please paste full build output for the
problematic
.o file?
I bet it's a C file compilation, where we should use:
__sync_val_compare_and_swap (counter, 0, (intptr_t)node);
Can you please test it?
That seems to have come in via 871e5ada6d53d5eb495cc9f323983f347487c1b2
Author: Martin Liska <mli...@suse.cz>
Date: Fri Jan 31 13:10:14 2020 +0100
Make TOPN counter dynamically allocated.
:
* libgcov.h (gcov_counter_add): New.
(gcov_counter_set_if_null): Likewise.
(gcov_topn_add_value): New.
which added the gcov_counter_set_if_null function.
(The data is quite misleading and appears to be when you first
committed this locally? Does git have a good way to show when
something was pushed?)
I would recommend:
$ git show --format=fuller 871e5ada6d53d5eb495cc9f323983f347487c1b2
...
commit 871e5ada6d53d5eb495cc9f323983f347487c1b2
Author: Martin Liska <mli...@suse.cz>
AuthorDate: Fri Jan 31 13:10:14 2020 +0100
Commit: Martin Liska <mli...@suse.cz>
CommitDate: Tue Jun 2 12:11:02 2020 +0200
Martin
Gerald
