[PATCH] match.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! On x86 (the only target with umulv4_optab) one can use mull; seto to check for overflow instead of performing wider multiplication and performing comparison on the high bits. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2020-05-05 Jakub Jelinek PR tree-opt

[PATCH] x86: Fix *vec_dupv4hi constraints [PR94942]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! This insn and split splits into HI->V?HImode broadcast for avx2 and later, but either the operands need to be %xmm0-%xmm15 (i.e. VEX encoded insn), or the insn needs both AVX512BW and AVX512VL. Now, Yv constraint is v for AVX512VL and x otherwise, so for -mavx512vl -mno-avx512bw we ICE if we

[PATCH] c++: Don't synthesize sfk_comparison method multiple times [PR94907]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! On the following testcase we ICE, because synthesize_method is called twice on the same sfk_comparison method fndecl, the first time it works fine because start_preparsed_function in that case sets both current_function_decl and cfun, but second time it is called it only sets the former and ke

Re: [PATCH] match.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Jakub Jelinek wrote: > Hi! > > On x86 (the only target with umulv4_optab) one can use mull; seto to check > for overflow instead of performing wider multiplication and performing > comparison on the high bits. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for

[PATCH] match.pd: Canonicalize (x + (x << cst)) into (x * cst2) [PR94800]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! The popcount* testcases show yet another creative way to write popcount, but rather than adjusting the popcount matcher to deal with it, I think we just should canonicalize those (X + (X << C) to X * (1 + (1 << C)) and (X << C1) + (X << C2) to X * ((1 << C1) + (1 << C2)), because for multiplic

Re: [PATCH] match.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
On Tue, May 05, 2020 at 09:21:13AM +0200, Richard Biener wrote: > > On x86 (the only target with umulv4_optab) one can use mull; seto to check > > for overflow instead of performing wider multiplication and performing > > comparison on the high bits. > > > > Bootstrapped/regtested on x86_64-linux

Re: [PATCH] csa, postreload: Improve csa after recent cselib changes [PR94516]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! On Wed, Apr 22, 2020 at 12:02:12PM -0600, Jeff Law via Gcc-patches wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > > > 2020-04-20 Jakub Jelinek > > > > PR rtl-optimization/94516 > > * postreload.c (reload_cse_simplify): When replacing sp = sp +

Re: [PATCH] match.pd: Canonicalize (x + (x << cst)) into (x * cst2) [PR94800]

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Jakub Jelinek wrote: > Hi! > > The popcount* testcases show yet another creative way to write popcount, > but rather than adjusting the popcount matcher to deal with it, I think > we just should canonicalize those (X + (X << C) to X * (1 + (1 << C)) > and (X << C1) + (X << C2)

Re: [PATCH] match.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Jakub Jelinek wrote: > On Tue, May 05, 2020 at 09:21:13AM +0200, Richard Biener wrote: > > > On x86 (the only target with umulv4_optab) one can use mull; seto to check > > > for overflow instead of performing wider multiplication and performing > > > comparison on the high bits

Re: [PATCH 2/4] x86: Add -mzero-caller-saved-regs=[skip|used-gpr|all-gpr|used|all]

2020-05-05 Thread Uros Bizjak via Gcc-patches
On Mon, May 4, 2020 at 9:01 PM H.J. Lu wrote: > > Add -mzero-caller-saved-regs=[skip|used-gpr|all-gpr|used|all] command-line > option and zero_caller_saved_regs("skip|used|all") function attribue: > > 1. -mzero-caller-saved-regs=skip and zero_caller_saved_regs("skip") > > Don't zero caller-saved r

Re: [PATCH 2/4] x86: Add -mzero-caller-saved-regs=[skip|used-gpr|all-gpr|used|all]

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Uros Bizjak wrote: > On Mon, May 4, 2020 at 9:01 PM H.J. Lu wrote: > > > > Add -mzero-caller-saved-regs=[skip|used-gpr|all-gpr|used|all] command-line > > option and zero_caller_saved_regs("skip|used|all") function attribue: > > > > 1. -mzero-caller-saved-regs=skip and zero_cal

(patch] Do not put incomplete CONSTRUCTORs into static memory

2020-05-05 Thread Eric Botcazou
Hi, the CONSTRUCTOR_NO_CLEARING flag was invented to avoid generating a memset for CONSTRUCTORS that lack elements, but it turns out that the gimplifier can generate a memcpy for them instead, which is even worse performance-wise, so this prevents it from doing that for them. Tested on x86-64/

[patch] Silence warning in LTO mode on VxWorks

2020-05-05 Thread Eric Botcazou
Hi, the link phase is always partial (-r) for VxWorks in kernel mode, which means that it uses incremental LTO linking by default (-flinker-output=rel). But in this mode the LTO plugin outputs a warning if one of the object files involved in the link does not contain LTO bytecode, before switc

Re: (patch] Do not put incomplete CONSTRUCTORs into static memory

2020-05-05 Thread Richard Biener via Gcc-patches
On Tue, May 5, 2020 at 10:30 AM Eric Botcazou wrote: > > Hi, > > the CONSTRUCTOR_NO_CLEARING flag was invented to avoid generating a memset for > CONSTRUCTORS that lack elements, but it turns out that the gimplifier can > generate a memcpy for them instead, which is even worse performance-wise, so

[patch] Fix a few DWARF bugs with -fgnat-encodings=minimal

2020-05-05 Thread Eric Botcazou
Hi, The -fgnat-encodings=minimal switch tells the compiler to generate motly pure DWARF for the GNAT compiler and it contains some bugs related to discriminated record types with variant part. Tested on x86-64/Linux, OK for the mainline? 2020-05-05 Eric Botcazou Pierre-Marie de

Re: [patch] Silence warning in LTO mode on VxWorks

2020-05-05 Thread Richard Biener via Gcc-patches
On Tue, May 5, 2020 at 10:36 AM Eric Botcazou wrote: > > Hi, > > the link phase is always partial (-r) for VxWorks in kernel mode, which means > that it uses incremental LTO linking by default (-flinker-output=rel). But in > this mode the LTO plugin outputs a warning if one of the object files in

[PATCH] tree-optimization/94949 - fix load eliding in SM

2020-05-05 Thread Richard Biener
This fixes the case of not using the multithreaded model when only conditionally storing to the destination. We cannot elide the load in this case. Bootstrap / regtest running on x86_64-unknown-linux-gnu. 2020-05-05 Richard Biener PR tree-optimization/94949 * tree-ssa-loop-im

Re: [PATCH] x86: Fix *vec_dupv4hi constraints [PR94942]

2020-05-05 Thread Uros Bizjak via Gcc-patches
On Tue, May 5, 2020 at 9:11 AM Jakub Jelinek wrote: > > Hi! > > This insn and split splits into HI->V?HImode broadcast for avx2 and later, > but either the operands need to be %xmm0-%xmm15 (i.e. VEX encoded insn), or > the insn needs both AVX512BW and AVX512VL. > Now, Yv constraint is v for AVX512

Re: [Patch, Fortran] OpenMP/OpenACC – fix more issues with OPTIONAL

2020-05-05 Thread Tobias Burnus
On 4/30/20 9:17 AM, Jakub Jelinek wrote: I'll try to do something about that early in stage1 and eventually backport, we need to follow OpenMP rules anyway and those require auto-discovery of referenced functions (if they are definitions rather than just declarations), and similarly in some case

Re: [patch] Silence warning in LTO mode on VxWorks

2020-05-05 Thread Eric Botcazou
> I know it's hidden but can we make the plugin option more specific, > like -linker-output-auto-notlo-rel? There's also no documentation for > the lto-plugin switches, I think a good place is a comment before > > + else if (strcmp (option, "-linker-output-no-warning") == 0) > +linker_output

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Szabolcs Nagy
The 05/04/2020 20:02, Joseph Myers wrote: > On Mon, 4 May 2020, Szabolcs Nagy wrote: > > i think __getauxval needs to be declared where it is used. > > Yes. > > > and libgcc should do a link test in configure becasuse a > > libc may provide sys/auxv.h but not have __getauxval e.g. > > musl libc d

[PATCH] fix build of targets not implementing add_stmt_cost

2020-05-05 Thread Richard Biener
Pushed as obvious. C++ makes mismatched prototype and implementation OK. 2020-05-05 Richard Biener * targhooks.h (default_add_stmt_cost): Add vec_info * parameter. --- gcc/targhooks.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/targhooks.h b/gcc/targho

Re: [Patch] PR fortran/93366 - ICE on invalid, reject invalid use of NULL() as argument

2020-05-05 Thread Tobias Burnus
On 5/4/20 10:14 PM, Harald Anlauf wrote: The attached patch fixes a couple of cases where an invalid NULL() argument provided to intrinsics produced either an ICE or was silently accepted. We now reject them. Steve Kargl provided an initial version, which I extended to catch a few more cases.

[committed] i386: Use int_nonimmediate_operand more

2020-05-05 Thread Uros Bizjak via Gcc-patches
Pattern explosing and manual mode checks can be avoided by using int_nonimmediate_operand special predicate. While there, rewrite *x86_movcc_0_m1_neg_leu to a combine pass splitter. 2020-05-05 Uroš Bizjak * config/i386/i386.md (*testqi_ext_3): Use int_nonimmediate_operand instead of m

RE: [PATCH] aarch64: eliminate redundant zero extend after bitwise negation

2020-05-05 Thread Kyrylo Tkachov
Hi Alex, > -Original Message- > From: Alex Coplan > Sent: 22 April 2020 21:41 > To: gcc-patches@gcc.gnu.org > Cc: Richard Earnshaw ; Richard Sandiford > ; Marcus Shawcroft > ; Kyrylo Tkachov ; > nd > Subject: [PATCH] aarch64: eliminate redundant zero extend after bitwise > negation > >

Re: [patch] Silence warning in LTO mode on VxWorks

2020-05-05 Thread Richard Biener via Gcc-patches
On Tue, May 5, 2020 at 11:16 AM Eric Botcazou wrote: > > > I know it's hidden but can we make the plugin option more specific, > > like -linker-output-auto-notlo-rel? There's also no documentation for > > the lto-plugin switches, I think a good place is a comment before > > > > + else if (strcmp

Re: [PATCH] fix build of targets not implementing add_stmt_cost

2020-05-05 Thread Alexander Monakov via Gcc-patches
On Tue, 5 May 2020, Richard Biener wrote: > > Pushed as obvious. > > C++ makes mismatched prototype and implementation OK. (because of overloads) I think this would have been caught if GCC enabled -Wmissing-declarations during bootstrap, and the main reason we have this problem is that the

Re: [PATCH] fix build of targets not implementing add_stmt_cost

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Alexander Monakov wrote: > > > On Tue, 5 May 2020, Richard Biener wrote: > > > > > Pushed as obvious. > > > > C++ makes mismatched prototype and implementation OK. > > (because of overloads) Yes, of course. I'll also try to remember to compile at least one unaffected cc

[PATCH] tree-optimization/57359 - rewrite SM code

2020-05-05 Thread Richard Biener
This rewrites store-motion to process candidates where we can ensure order preserving separately and with no need to disambiguate against all stores. Those candidates we cannot handle this way are validated to be independent on all stores (w/o TBAA) and then processed as "unordered" (all conditi

Re: Should ARMv8-A generic tuning default to -moutline-atomics

2020-05-05 Thread Andrew Haley via Gcc-patches
On 5/1/20 11:48 AM, JiangNing OS via Gcc-patches wrote: > In reality, a lot of users are still using old gcc versions running on new > hardware. OpenJDK is a typical example, I think. We can change the OpenJDK build scripts to use -moutline-atomics if it's available. I agree with Richard that we

[PATCH] ipa/94947 - fix test for externally visible variables for IPA PTA

2020-05-05 Thread Richard Biener
This fixes lack of an escape point of externally declared variables. 2020-05-05 Richard Biener PR ipa/94947 * tree-ssa-structalias.c (ipa_pta_execute): Use varpool_node::externally_visible_p (). (refered_from_nonlocal_var): Likewise. * gcc.dg/torture/

[PATCH] doc: Update install.texi for GCC 10 on Solaris

2020-05-05 Thread Rainer Orth
This patch updates install.texi for GCC 10 on Solaris. It includes some general cleanup and updates and includes a couple of caveats, some of them found when testing GCC 10.1.0 RC1 with only the bundled tools. The reference to TGCware on the binaries page is gone because they only provide binarie

[PATCH] rewrite hybrid SLP detection

2020-05-05 Thread Richard Biener
This rewrites hybrid SLP detection to be simpler and cope with group size changes in the SLP graph. In particular detection works starting from non-SLP stmts following use->def chains rather than walking the SLP graph and following def->use chains. It's all temporary of course since non-SLP and

Re: [PATCH v3] [Stage1] Refactor tree-ssa-operands.c

2020-05-05 Thread Richard Biener via Gcc-patches
On Tue, May 5, 2020 at 12:00 AM Giuliano Belinassi wrote: > > Hi, > > This patch Refactors tree-ssa-operands.c by wrapping the global > variables into a class, and also removes unused code. > > The difference between this version and v2 is: > * Disable the copy of operands_scanner > * remove v

Re: [PATCH] c-attribs.c: Fix use of uninitialized variable nunits

2020-05-05 Thread Richard Biener via Gcc-patches
On Mon, May 4, 2020 at 4:07 PM Stefan Schulze Frielinghaus wrote: > > On Mon, May 04, 2020 at 03:19:02PM +0200, Richard Biener wrote: > > On Mon, May 4, 2020 at 1:44 PM Stefan Schulze Frielinghaus > > wrote: > > > > > > On Tue, Apr 28, 2020 at 08:27:12PM +0200, Stefan Schulze Frielinghaus > > >

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Kyrylo Tkachov
> -Original Message- > From: Joseph Myers > Sent: 04 May 2020 21:03 > To: Szabolcs Nagy > Cc: Kyrylo Tkachov ; Florian Weimer > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > detection code in libgcc > > On Mon, 4 May 2020, Szabo

Re: [PATCH v5] c++: Member template function lookup failure [PR94799]

2020-05-05 Thread Marek Polacek via Gcc-patches
On Tue, May 05, 2020 at 01:01:00AM -0400, Jason Merrill wrote: > On 5/4/20 9:51 PM, Marek Polacek wrote: > > On Mon, May 04, 2020 at 05:41:37PM -0400, Jason Merrill via Gcc-patches > > wrote: > > > On 5/4/20 4:37 PM, Marek Polacek wrote: > > > > On Fri, May 01, 2020 at 04:12:35PM -0400, Jason Merr

[PATCH] testsuite/92177 - adjust expected patterns for gcc.dg/vect/bb-slp-22.c

2020-05-05 Thread Richard Biener
We now always vectorize two BBs, adjust the selector to also scan for integer multiplication vectorization explicitely. Tested on x86_64-unknown-linux-gnu, tested on sparc-sun-solaris2.11 and i386-pc-solaris2.11 by Rainer, pushed. Richard. 2020-05-05 Richard Biener PR testsuite/921

[PATCH] move permutation validity check

2020-05-05 Thread Richard Biener
This delays the SLP permutation check to vectorizable_load and optimizes permutations only after all SLP instances have been generated and the vectorization factor is determined. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2020-05-05 Richard Biener * tree-ve

Re: [PATCH v5] c++: Member template function lookup failure [PR94799]

2020-05-05 Thread Jason Merrill via Gcc-patches
On 5/5/20 9:36 AM, Marek Polacek wrote: On Tue, May 05, 2020 at 01:01:00AM -0400, Jason Merrill wrote: On 5/4/20 9:51 PM, Marek Polacek wrote: On Mon, May 04, 2020 at 05:41:37PM -0400, Jason Merrill via Gcc-patches wrote: On 5/4/20 4:37 PM, Marek Polacek wrote: On Fri, May 01, 2020 at 04:12:3

Re: [PATCH] csa, postreload: Improve csa after recent cselib changes [PR94516]

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-05-05 at 09:38 +0200, Jakub Jelinek wrote: > Hi! > > On Wed, Apr 22, 2020 at 12:02:12PM -0600, Jeff Law via Gcc-patches wrote: > > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > > > > > 2020-04-20 Jakub Jelinek > > > > > > PR rtl-optimization/94516 >

Re: [1/6 CRIS cc0-preparations] try to generate zero-based comparisons

2020-05-05 Thread Jeff Law via Gcc-patches
On Mon, 2020-02-10 at 17:55 +0100, Hans-Peter Nilsson wrote: > * config/cris/cris.c (cris_reduce_compare): New function. > * config/cris/cris-protos.h (cris_reduce_compare): Add prototype. > * config/cris/cris.md ("cbranch4", "cbranchdi4", "cstoredi4") > (cstore4"): Apply cris_reduce_compare in ex

[PR 94807] Consistently name lambda fn's this pointer

2020-05-05 Thread Nathan Sidwell
Iain discovered that a lambda fn's this pointer arg could be named 'this' and satisfy is_this_parameter, or be called __closure and not satisfy it. Turns out the parser explicitly zaps the name to be __closure, but instantiation of a lambda fn doesn't. That's just confusing. I tried not zap

wwwdocs: Add symver and -fprofile-prefix-path to changes.html

2020-05-05 Thread Jan Hubicka
Hi, this patch adds mention of -fprofile-prefix-path and symver attribute. diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 4497be14..45cb906f 100644 --- a/htdocs/gcc-10/changes.html +++ b/htdocs/gcc-10/changes.html @@ -98,6 +98,12 @@ a work-in-progress. This ma

Re: [cris-decc0 0/14] A set of compare-elimination-fixes.

2020-05-05 Thread Jeff Law via Gcc-patches
On Wed, 2020-02-12 at 07:47 +0100, Hans-Peter Nilsson wrote: > I just rebased and updated the vendors/axis branch > axis/cris-decc0 with the following commits, which should bring > back compare-elimination results to that of cc0 on master. > > With the exception of the bit-test patterns (btst / bt

Re: [PATCH 1/4] Remove 2 dead variables in bid_internal.h.

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-02-04 at 14:54 +0100, Martin Liska wrote: > libgcc/config/libbid/ChangeLog: > > 2020-02-04 Martin Liska > > PR libgcc/92565 > * bid_internal.h (handle_UF_128_rem): Remove unused variable. > (handle_UF_128): Likewise. OK for master. And patches that drop unused v

Re: [PATCH 2/4] Use const for some function arguments.

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-02-04 at 14:55 +0100, Martin Liska wrote: > gcc/ChangeLog: > > 2020-02-04 Martin Liska > > PR c/92472. > * alloc-pool.h: Use const for some arguments. > * bitmap.h: Likewise. > * mem-stats.h: Likewise. > * sese.h (get_entry_bb): Likewise. > (get

Re: [PATCH 4/4] Use const for template argument.

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-02-04 at 14:55 +0100, Martin Liska wrote: > libstdc++-v3/ChangeLog: > > 2020-02-04 Martin Liska > > PR c/92472. > * include/parallel/multiway_merge.h: > Use const for _Compare template argument. OK jeff >

Re: [PATCH 3/4] Put index check before use.

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-02-04 at 14:57 +0100, Martin Liska wrote: > liboffloadmic/ChangeLog: > > 2020-02-04 Martin Liska > > PR other/89860. > * runtime/offload_target.cpp: Put index check > before its use. OK jeff >

[PATCH] wwwdocs: Document OpenMP changes in gcc-10/changes.html

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch documents OpenMP 5 changes in GCC 10. Ok for wwwdocs? diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index 4497be14..5233fc93 100644 --- a/htdocs/gcc-10/changes.html +++ b/htdocs/gcc-10/changes.html @@ -182,6 +182,16 @@ a work-in-progress. https:

Re: [PATCH] c-attribs.c: Fix use of uninitialized variable nunits

2020-05-05 Thread Stefan Schulze Frielinghaus via Gcc-patches
On Tue, May 05, 2020 at 02:58:51PM +0200, Richard Biener wrote: > On Mon, May 4, 2020 at 4:07 PM Stefan Schulze Frielinghaus > wrote: > > > > On Mon, May 04, 2020 at 03:19:02PM +0200, Richard Biener wrote: > > > On Mon, May 4, 2020 at 1:44 PM Stefan Schulze Frielinghaus > > > wrote: > > > > > > >

Re: [PATCH] wwwdocs: Document OpenMP changes in gcc-10/changes.html

2020-05-05 Thread Gerald Pfeifer
On Tue, 5 May 2020, Jakub Jelinek wrote: > Ok for wwwdocs? > + Version 5.0 of the https://www.openmp.org/specifications/"; > +>OpenMP specification is still only partially supported in the C > and C++ > + compilers. GCC 10 release has various newly implemented features (not > +

Re: [PATCH v2 0/5] Updates for PRU backend

2020-05-05 Thread Jeff Law via Gcc-patches
On Sun, 2020-05-03 at 19:11 +0300, Dimitar Dimitrov wrote: > One of the changes frees a previously fixed register, per > ABI clarification from TI, for local usage from function. > The change is backwards compatible. > > Rest of changes are cleanups. > > Testsuite did not reveal any regressions.

[committed] i386: Use "clobber (scratch)" in expanders

2020-05-05 Thread Uros Bizjak via Gcc-patches
Use "clobber (scratch:M)" instad of "clobber (match_scratch:M N)" in expanders. 2020-05-05 Uroš Bizjak * config/i386/i386.md (fixuns_truncsi2): Use "clobber (scratch:M)" instad of "clobber (match_scratch:M N)". (addqi3_cconly_overflow): Ditto. (umulv4): Ditto. (mul3_highpar

Re: [PATCH] testsuite:analyzer: Fix header include for FreeBSD

2020-05-05 Thread Jeff Law via Gcc-patches
On Sun, 2020-05-03 at 22:31 +0200, Andreas Tobler wrote: > On 03.05.20 18:27, Kamil Rytarowski wrote: > > On 01.05.2020 21:49, Andreas Tobler wrote: > > > Hi all, > > > > > > FreeBSD does not have the alloca.h header. Do not include it in the test > > > cases which do include alloca.h. > > > > >

Re: [PATCH] doc: Update install.texi for GCC 10 on Solaris

2020-05-05 Thread Jeff Law via Gcc-patches
On Tue, 2020-05-05 at 14:38 +0200, Rainer Orth wrote: > This patch updates install.texi for GCC 10 on Solaris. It includes some > general cleanup and updates and includes a couple of caveats, some of > them found when testing GCC 10.1.0 RC1 with only the bundled tools. > > The reference to TGCwar

Re: [PATCH 1/4] matcher-1.m: Change return type to int

2020-05-05 Thread Jeff Law via Gcc-patches
On Mon, 2020-05-04 at 12:01 -0700, H.J. Lu wrote: > my_exception_matcher must return int. Otherwise, this test fails. > > PR testsuite/84324 > * objc/execute/exceptions/matcher-1.m (my_exception_matcher): > Change return type to int. OK jeff >

Re: [PATCH] Adjust integer <-> pointer conversion IL checking

2020-05-05 Thread Jeff Law via Gcc-patches
On Mon, 2020-05-04 at 14:11 +0200, Richard Biener wrote: > This patch sits in my trees for quite some years and I always forget > to push it - it usually gets triggered by weird targets (PSImode > pointers/sizetype) which run into GIMPLE IL checking asserts for > pointer -> integer conversions and

*ping* | Re: Follow-up Patch – Re: [Patch][OpenMP] Fix 'omp exit data' for Fortran arrays (PR 94635)

2020-05-05 Thread Tobias Burnus
OK for mainline and (once it opens) the GCC 10 branch? This is a simple & quick to review patch. Tobias On 4/23/20 3:43 PM, Tobias Burnus wrote: On 4/20/20 11:33 PM, Thomas Schwinge wrote: Really 'GOMP_MAP_DELETE', or should that rather be 'GOMP_MAP_RELEASE'? Depends on the previous item,

*ping* | Re: [Patch][Fortran] OpenMP - permit lastprivate in distribute + SIMD fixes (PR94690)

2020-05-05 Thread Tobias Burnus
OK for mainline and GCC 10? The LASTPRIVATE part is trivial, but as C→Fortran porting the test case revealed an SIMD issue, it is a bit longer. Tobias On 4/23/20 8:52 AM, Tobias Burnus wrote: As found via sollve_vv: the Fortran OpenMP parser missed 'lastprivate' as permitted clause in 'distri

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-05-05 Thread Jeff Law via Gcc-patches
On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote: > Hello, > > I'm not sure if this is the right mailing list for this patch but it modifies > the top level directory of binutils-gdb for which I understand GCC to be the > upstream. The purpose of this patch is to use PKG_CHEC

Re: [PATCH v2 0/5] Updates for PRU backend

2020-05-05 Thread Dimitar Dimitrov
On вторник, 5 май 2020 г. 19:00:29 EEST Jeff Law wrote: > On Sun, 2020-05-03 at 19:11 +0300, Dimitar Dimitrov wrote: > > One of the changes frees a previously fixed register, per > > ABI clarification from TI, for local usage from function. > > The change is backwards compatible. > > > > Rest of c

[PATCH] tree-optimization: Fix use of uninitialized variables warnings [PR94952]

2020-05-05 Thread Stefan Schulze Frielinghaus via Gcc-patches
While bootstrapping GCC on S/390 with --enable-checking=release several warnings about use of uninitialized variables bitpos, bitregion_start, and bitregion_end of function pass_store_merging::process_store are raised. According to PR94952 these seem to be false positives which are silenced by init

Re: wwwdocs: Add symver and -fprofile-prefix-path to changes.html

2020-05-05 Thread Gerald Pfeifer
On Tue, 5 May 2020, Jan Hubicka wrote: > this patch adds mention of -fprofile-prefix-path and symver attribute. Thank you, Honza! > + href="https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Optimize-Options.html#index-fprofile-prefix-path";>-fprofile-prefix-path > + can be used in combina

[PATCH] c++: template instantiation during fold_for_warn [PR94038]

2020-05-05 Thread Patrick Palka via Gcc-patches
Unfortunately, the previous fix to PR94038 is fragile. When the argument to fold_for_warn is a bare CALL_EXPR, then all is well: the result of maybe_constant_value from fold_for_warn (with uid_sensitive=true) is reused via the cv_cache in the subsequent call to maybe_constant_value from cp_fold (w

[pushed] coroutines: Replace extra checks for co_yield with asserts.

2020-05-05 Thread Iain Sandoe
Hi, The lowering of co_yield to a promise method call and a co_await was moved to the initial analysis phase with the intention of avoiding the need to handle the two cases later. Before removing the later checks entirely, this patch replaces them with checking asserts. tested on x86-64-darwin16

[libitm] testsuite tweak

2020-05-05 Thread Nathan Sidwell
I had reason to wander into libitm's testsuite, and discovered gcc emitting colorized diagnostics. Those are hard to read in a log file. This patch disables colorizing. pushed as obvious -- Nathan Sidwell 2020-05-05 Nathan Sidwell * testsuite/lib/libitm.exp (libitm_init): Add -fdiagnosti

[libitm] eh specifications are lax

2020-05-05 Thread Nathan Sidwell
I discovered that libitm: (a) declares __cxa_allocate_exception and friends directly, (b) doesn't mark them as 'throw()' (c) doesn't mark the replacment fns _ITM_$foo as nothrow either We happen to get away with it because of code in the compiler that, although it checks the parameter types, doe

Aw: Re: [Patch] PR fortran/93366 - ICE on invalid, reject invalid use of NULL() as argument

2020-05-05 Thread Harald Anlauf
Hi Tobias, > Two points regarding future patches: > > Please attach files with a file suffix – such that the MIME > type is "text/..." and not "application/octet-stream". > (.patch, .diff or even a simple .txt should do.) noted. > Additionally, given that we now use GIT and start to move > to a

[ping] libgomp: Allow overriding via 'GOMP_OFFLOAD_PLUGINS' the configured set of libgomp plugins

2020-05-05 Thread Thomas Schwinge
Hi! Ping. Grüße Thomas On 2020-04-27T15:33:10+0200, I wrote: > Hi! > > Is the attached patch for "libgomp: Allow overriding via > 'GOMP_OFFLOAD_PLUGINS' the configured set of libgomp plugins" OK for > master and release branches? If approving this patch, please respond > with "Reviewed-by: N

Re: [PATCH] c++: template instantiation during fold_for_warn [PR94038]

2020-05-05 Thread Patrick Palka via Gcc-patches
On Tue, 5 May 2020, Patrick Palka wrote: > Unfortunately, the previous fix to PR94038 is fragile. When the > argument to fold_for_warn is a bare CALL_EXPR, then all is well: the > result of maybe_constant_value from fold_for_warn (with > uid_sensitive=true) is reused via the cv_cache in the subse

Re: [PATCH] match.pd: Canonicalize (x + (x << cst)) into (x * cst2) [PR94800]

2020-05-05 Thread H.J. Lu via Gcc-patches
On Tue, May 5, 2020 at 12:27 AM Jakub Jelinek via Gcc-patches wrote: > > Hi! > > The popcount* testcases show yet another creative way to write popcount, > but rather than adjusting the popcount matcher to deal with it, I think > we just should canonicalize those (X + (X << C) to X * (1 + (1 << C)

Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES

2020-05-05 Thread Aaron Merey via Gcc-patches
On Tue, May 5, 2020 at 12:41 PM Jeff Law wrote: > > On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote: > > Hello, > > > > I'm not sure if this is the right mailing list for this patch but it > > modifies > > the top level directory of binutils-gdb for which I understand GCC to

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Joseph Myers
On Tue, 5 May 2020, Szabolcs Nagy wrote: > > A design principle is that glibc built with libgcc configured without > > glibc headers but with --with-glibc-version should produce an identical > > stripped binary to the glibc resulting from a longer alternating sequence > > of GCC and glibc build

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Joseph Myers
On Tue, 5 May 2020, Kyrylo Tkachov wrote: > This version of the fix uses __getauxval instead of getauxval. > The whole thing is guarded simply on __GLIBC__ >= 2. > __getauxval was introduced in 2.16 but the aarch64 port was added in 2.17 so > in practice I expect all aarch64 glibcs to support __g

Re: [PATCH v2] c++: ICE in value_dependent_expression_p in C++98 mode [PR94938]

2020-05-05 Thread Marek Polacek via Gcc-patches
On Mon, May 04, 2020 at 09:18:57PM -0400, Jason Merrill wrote: > On 5/4/20 7:32 PM, Marek Polacek wrote: > > Here we ICE with -std=c++98 since the newly added call to > > uses_template_parms > > (r10-6357): we hit > > 26530 gcc_assert (cxx_dialect >= cxx11 > > 26531

[pushed] c++: constexpr and lambda capture [PR90212]

2020-05-05 Thread Jason Merrill via Gcc-patches
This is the same issue as PR86429, just in potential_constant_expression_1 rather than cxx_eval_constant_expression. As in that case, when we're trying to evaluate a constant expression within a lambda, we don't have a constant closure object to refer to, but we can try to refer directly to the ca

[pushed] c++: CWG2235 partial ordering and non-dependent types

2020-05-05 Thread Jason Merrill via Gcc-patches
Issue 2235 removed the rule previously added for issues 1391/1847 that had partial ordering completely ignore function parameters with no deducible template parameters. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog 2020-05-05 Jason Merrill CWG 2235 * pt.c (mo

Re: [1/6 CRIS cc0-preparations] try to generate zero-based comparisons

2020-05-05 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law > Date: Tue, 5 May 2020 16:52:07 +0200 > On Mon, 2020-02-10 at 17:55 +0100, Hans-Peter Nilsson wrote: > > * config/cris/cris.c (cris_reduce_compare): New function. > > * config/cris/cris-protos.h (cris_reduce_compare): Add prototype. > > * config/cris/cris.md ("cbranch4", "cbran

Re: [cris-decc0 0/14] A set of compare-elimination-fixes.

2020-05-05 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law via Gcc-patches > Date: Tue, 5 May 2020 17:05:01 +0200 > On Wed, 2020-02-12 at 07:47 +0100, Hans-Peter Nilsson wrote: > > I just rebased and updated the vendors/axis branch > > axis/cris-decc0 with the following commits, which should bring > > back compare-elimination results to

[PATCH] c++: ICE with -Wall and constexpr if [PR94937]

2020-05-05 Thread Marek Polacek via Gcc-patches
An ICE arises here because we call cp_get_callee_fndecl_nofold in a template, and we've got a CALL_EXPR whose CALL_EXPR_FN is a BASELINK. This tickles the INDIRECT_TYPE_P assert in cp_get_fndecl_from_callee. Jakub said in the PR that he'd hit a similar problem too and dealt with it in omp_declare_

[PATCH] c++: Avoid strict_aliasing_warning on dependent types or expressions [PR94951]

2020-05-05 Thread Jakub Jelinek via Gcc-patches
Hi! The following testcase gets a bogus warning during build_base_path, when cp_build_indirect_ref* calls strict_aliasing_warning with a dependent expression. IMHO calling get_alias_set etc. on dependent types feels wrong to me, we should just defer the warnings in those cases until instantiation

Re: [PATCH] PowerPC -mcpu=future Patch 3 of 7, Add test for generating prefixed load/store

2020-05-05 Thread Hans-Peter Nilsson
On Fri, 1 May 2020, Segher Boessenkool wrote: > On Mon, Apr 27, 2020 at 05:01:34PM -0500, will schmidt wrote: > > On Mon, 2020-04-27 at 15:53 -0400, Michael Meissner via Gcc-patches wrote: > > > +unsigned long > > > +load_us_offset1 (unsigned char *p) > > > +{ > > > + return *(unsigned short *)(p

Re: [PATCH] Enable GCC support for TSXLDTRK

2020-05-05 Thread Hongtao Liu via Gcc-patches
On Mon, May 4, 2020 at 12:58 AM Uros Bizjak wrote: > > The part above is OK, but you are missing support for > __attribute__((__target__("..."))). Please see how for example -msgx > is handled in isa2_opts in i386-options.c and in > gcc.target/i386/funcspec-56.h test source. > > Please repost the

Re: [PATH] Enable GCC support for SERIALIZE

2020-05-05 Thread Hongtao Liu via Gcc-patches
On Mon, May 4, 2020 at 1:17 AM Uros Bizjak wrote: > > On Wed, Apr 1, 2020 at 9:23 AM Hongtao Liu wrote: > > > > Hi: > > This patch is about to enable GCC support for SERIALIZE which would > > be in GLC. There's only 1 instruction: SERIALIZE, more details please > > refer to > > https://softwar

Re: [PATCH] c++: template instantiation during fold_for_warn [PR94038]

2020-05-05 Thread Patrick Palka via Gcc-patches
On Tue, 5 May 2020, Patrick Palka wrote: > On Tue, 5 May 2020, Patrick Palka wrote: > > > Unfortunately, the previous fix to PR94038 is fragile. When the > > argument to fold_for_warn is a bare CALL_EXPR, then all is well: the > > result of maybe_constant_value from fold_for_warn (with > > uid_s

Re: [PATH] Enable GCC support for SERIALIZE

2020-05-05 Thread Uros Bizjak via Gcc-patches
On Wed, May 6, 2020 at 5:11 AM Hongtao Liu wrote: > > On Mon, May 4, 2020 at 1:17 AM Uros Bizjak wrote: > > > > On Wed, Apr 1, 2020 at 9:23 AM Hongtao Liu wrote: > > > > > > Hi: > > > This patch is about to enable GCC support for SERIALIZE which would > > > be in GLC. There's only 1 instructio

Re: [PATCH] Adjust integer <-> pointer conversion IL checking

2020-05-05 Thread Richard Biener
On Tue, 5 May 2020, Jeff Law wrote: > On Mon, 2020-05-04 at 14:11 +0200, Richard Biener wrote: > > This patch sits in my trees for quite some years and I always forget > > to push it - it usually gets triggered by weird targets (PSImode > > pointers/sizetype) which run into GIMPLE IL checking asse

Re: [PATCH] Enable GCC support for TSXLDTRK

2020-05-05 Thread Uros Bizjak via Gcc-patches
On Wed, May 6, 2020 at 4:48 AM Hongtao Liu wrote: > > On Mon, May 4, 2020 at 12:58 AM Uros Bizjak wrote: > > > > The part above is OK, but you are missing support for > > __attribute__((__target__("..."))). Please see how for example -msgx > > is handled in isa2_opts in i386-options.c and in > >