Re: [PATCH] Make scatter/gather vectorization failures non-fatal (PR tree-optimization/91033)

2019-07-03 Thread Richard Biener
On Wed, 3 Jul 2019, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, I'm afraid we can't easily move the scatter/gather > verification from vect_analyze_data_refs to vectorizable_{load,store}, > because we need to process_use in between on the gsinfo.offset to determine > what statements ne

[PATCH] Fix out-of-ssa with unsupported vector types (PR rtl-optimization/90756)

2019-07-03 Thread Jakub Jelinek
Hi! This weird hink has been added by Alex in r228175, it isn't clear why nor how it ever can be correct. While say for DECL_MODE we have the problem that for global vars when switching between functions with different ISA selections the mode might not be ok, TYPE_MODE is stored as a raw vector m

Re: [PATCH] Fix out-of-ssa with unsupported vector types (PR rtl-optimization/90756)

2019-07-03 Thread Richard Biener
On Wed, 3 Jul 2019, Jakub Jelinek wrote: > Hi! > > This weird hink has been added by Alex in r228175, it isn't clear why > nor how it ever can be correct. While say for DECL_MODE we have the problem > that for global vars when switching between functions with different ISA > selections the mode

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Richard Biener
On Mon, Jul 1, 2019 at 10:52 AM Aldy Hernandez wrote: > > As discussed before, this enforces types on undefined and varying, which > makes everything more regular, and removes some special casing > throughout range handling. I don't like it too much given you need to introduce that "cache". Why

[Ada] Spurious error on dynamic predicate in a generic context

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes a spurious error on the conformance checking between the expression for an aspect analyzed at the freeze point of the type, and the analysis of a copy of the expression performed at the end of the enclosing list of declarationss. In a generic context the first may not have been ana

[Ada] Make loop labels unique for front-end inlined calls

2019-07-03 Thread Pierre-Marie de Rodat
This patch transforms loop labels in the body of subprograms that are to be inlined by the front-end, to prevent accidental duplication of loop labels, which might make the resulting source illegal. Source program: package P is procedure Get_Rom_Addr_Offset with Inline_Always; en

[Ada] Fix bogus error on array with overaligned scalar component

2019-07-03 Thread Pierre-Marie de Rodat
The compiler would wrongly reject an alignment clause larger than 8 on the component type of an array of scalars, which is valid albeit pathological. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Eric Botcazou gcc/ada/ * layout.adb (Layout_Type): Do not set the compone

[Ada] Spurious error on predicate of subtype in generic

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes a spurious error on a dynamic predicate of a record subtype when the expression for the predicate includes a selected component that denotes a component of the subtype. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Ed Schonberg gcc/ada/ * sem_ch8.adb (

[Ada] Spurious error with static predicate in generic unit

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes a spurious error in a generic unit that invludes a subtype with a static predicate, when the type is used in a case expression. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Ed Schonberg gcc/ada/ * sem_ch13.adb (Build_Predicate_Functions): In a generic

[Ada] Extend -gnatw.z warning to array types

2019-07-03 Thread Pierre-Marie de Rodat
The -gnatw.z switch causes the compiler to issue a warning on record types subject to both an alignment clause and a size clause, when the specified size is not a multiple of the alignment in bits, because this means that the Object_Size will be strictly larger than the specified size. It makes se

[Ada] Style check for mixed-case identifiers

2019-07-03 Thread Pierre-Marie de Rodat
This patch implements a new switch, -gnatyD, enables a style check that requires defining identifiers to be in mixed case. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Bob Duff gcc/ada/ * par-ch3.adb (P_Defining_Identifier): Call Check_Defining_Identifier_Casi

[Ada] New routine to access file on command line

2019-07-03 Thread Pierre-Marie de Rodat
This patch adds a new routine to query the first file argument of the commandline without moving to the next file. This is needed in SPARK. There is no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Johannes Kanig gcc/ada/ * osint.ads, osint.adb

[Ada] SPARK pointer support extended to local borrowers and observers

2019-07-03 Thread Pierre-Marie de Rodat
SPARK rules allow local borrowers and observers to be declared. During their lifetime, the access to the borrowed/observed object is restricted. There is no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Yannick Moy gcc/ada/ * sem_spark.adb: Add

[Ada] Improve warnings about infinite loops

2019-07-03 Thread Pierre-Marie de Rodat
The compiler now has fewer false alarms when warning about infinite loops. For example, a loop of the form "for X of A ...", where A is an array, cannot be infinite. The compiler no longer warns in this case. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-07-03 Bob Duff gcc/ada/

[Ada] Suppress warnings in generic instantiations with pragma Warnings

2019-07-03 Thread Pierre-Marie de Rodat
Warnings issued by GNAT or GNATprove inside generic instantiations can now be suppressed by using pragma Warnings Off/On around the instance. This has mostly an effect on GNATprove, since GNAT typically does not issue warnings on instantiations, only on the generic code itself. Tested on x86_64-pc

[Ada] Crash on anonymous access-to-class-wide with tasks

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes a bug in which if an object declaration is of an anonymous access type whose designated type is a limited class-wide type (but not an interface), and the object is initialized with an allocator, and the designated type of the allocator contains tasks, the compiler would crash. Tes

[Ada] Missing consistency check for constant modifier

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes an issue whereby instantiations of generic packages were incorrectly allowed despite formal and actual subprograms not having matching declarations with anonymous constant access type parameters. -- Source -- -- gen1.ads package Gen1 is generic

[Ada] Crash on front-end inlining of subp. with aspect specifications

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes a gap in the handling of formals when inlining a call to a subprogram marked Inline_Always. For the inlining, the formals are replaced by the actuals in the block constructed for inlining, The traversal that performs this replacement does not apply to aspect specifications that may

[Ada] Incorrect expansion on renamings of formal parameters

2019-07-03 Thread Pierre-Marie de Rodat
This patch fixes an issue whereby a renaming of an unconstrained formal parameter leads to spurious runtime errors; manifesting either as a storage or constraint error due to incorrect bounds being assumed. This issue also occurs when the renamings are implicit such as through generic instantiatio

[Ada] Spurious visibility error in inlined function

2019-07-03 Thread Pierre-Marie de Rodat
This patch corrects the use of tree replication when inlining a function that returns an unconstrained result, and its sole statement is an extended return statement. The use of New_Copy_Tree ensires that global references saved in a generic template are properly carried over when the function is i

[Ada] Forced elaboration order in Elaboration order v4.0

2019-07-03 Thread Pierre-Marie de Rodat
This patch refactors the forced elaboration order functionality, reintegrates it in Binde, and impelements it in Bindo. -- Source -- -- server.ads package Server is end Server; -- client.ads with Server; package Client is end Client; -- main.adb with Client; pr

Re: [PATCH, Modula-2 (C/C++/D/F/Go/Jit)] (Register spec fn) (v2)

2019-07-03 Thread Rainer Orth
Hi Gaius, > here is version two of the patches which introduce Modula-2 into the > GCC trunk. The patches include: > > (*) a patch to allow all front ends to register a lang spec function. >(included are patches for all front ends to provide an empty > callback function). > (

Re: [GCC][middle-end] Add rules to strip away unneeded type casts in expressions (2nd patch)

2019-07-03 Thread Richard Biener
On Tue, 2 Jul 2019, Tamar Christina wrote: > > Hi All, > > Here's an updated patch with the changes processed from the previous review. > > I've bootstrapped and regtested on aarch64-none-linux-gnu and > x86_64-pc-linux-gnu and no issues. > > Ok for trunk? + (if (TYPE_OVERFLOW_WRAPS (TRE

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-07-03 Thread Jan Hubicka
> Hi. > > So the first part is about support of N tracked values to be supported. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > From f3e361fb6d799acf538bc76a91bfcc8e265b7cbe Mon Sep 17 00:00:00 2001 > From: Martin Lisk

Re: [PATCH 2/2] Rename SINGE_VALUE to TOPN_VALUES counters.

2019-07-03 Thread Jan Hubicka
> And the second part is rename so that it reflect reality > that single value can actually track multiple values. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > From cc9e93d43941176e92b5821e5a8134a5319a10b4 Mon Sep 17 0

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Aldy Hernandez
On 7/3/19 4:28 AM, Richard Biener wrote: On Mon, Jul 1, 2019 at 10:52 AM Aldy Hernandez wrote: As discussed before, this enforces types on undefined and varying, which makes everything more regular, and removes some special casing throughout range handling. I don't like it too much given

[PATCH, committed] Add myself to MAINTAINERS

2019-07-03 Thread Andrea Corallo
Hi all, I have committed the attached patch adding myself to the Write After Approval section of the MAINTAINERS file. Bests Andrea ChangeLog: 2019-07-02 Andrea Corallo * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAINTAINERS b/MAINTAINERS index b8d703c..7c1eebc 1

[patch1/2][arm][PR90317]: fix sha1 patterns

2019-07-03 Thread Sylvia Taylor
Greetings, This patch fixes: 1) Ice message thrown when using the crypto_sha1h intrinsic due to incompatible mode used for zero_extend. Removed zero extend as it is not a good choice for vector modes and using an equivalent single mode like TI (128bits) instead of V4SI produces extra instructions

[patch2/2][arm]: remove builtin expand for sha1

2019-07-03 Thread Sylvia Taylor
Greetings, This patch removes the builtin expand handling for sha1h/c/m/p and replaces it with expand patterns. This should make it more consistent with how we handle intrinsic implementations and cleans up the custom sha1 code in the arm_expand builtins for unop and ternop. Bootstrapped and test

Re: [range-ops] patch 02/04: enforce canonicalization in value_range

2019-07-03 Thread Aldy Hernandez
On 7/2/19 5:36 PM, Jeff Law wrote: I don't see anything inherently concerning here. I do wonder if there's any value in having a debugging function in the class that would iterate over the ranges and check them for proper canonicalization, verify that VR_{VARYING,UNDEFINED} objects do not have

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Aldy Hernandez
On 7/2/19 4:17 PM, Jeff Law wrote: On 7/1/19 2:52 AM, Aldy Hernandez wrote: As discussed before, this enforces types on undefined and varying, which makes everything more regular, and removes some special casing throughout range handling. The min/max fields will contain TYPE_MIN_VALUE and TY

Re: [PATCH][ARM] Add support for "noinit" attribute

2019-07-03 Thread Richard Earnshaw
On 02/07/2019 15:49, Christophe Lyon wrote: On Tue, 2 Jul 2019 at 12:30, Richard Earnshaw wrote: On 02/07/2019 11:13, Richard Earnshaw wrote: On 02/07/2019 09:39, Richard Earnshaw wrote: On 01/07/2019 16:58, Kyrill Tkachov wrote: Hi Christophe, On 6/13/19 4:13 PM, Christophe Lyon

[patch] Fix debug info for discriminated record types

2019-07-03 Thread Eric Botcazou
Hi, this is a regression present on the mainline and 9 branch: since https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01066.html the debug info emitted in Ada with -fgnat-encodings=minimal for discriminated record types containing an array component whose bound is a discriminant is incomplete, i.

[PATCH] PR libstdc++/91067 fix missing exports for filesystem iterators

2019-07-03 Thread Jonathan Wakely
The copy assignment operator for recursive_directory_iterator was not exported despite being needed. The __shared_ptr default constructors are not needed when compiling with GCC but Clang requires them for -O1. PR libstdc++/91067 * acinclude.m4 (libtool_VERSION): Bump to 6:27:0.

[PATCH] Add dbgcnt for gimple_match and generic_match.

2019-07-03 Thread Martin Liška
Hi. The patch is about dbgcnt support for match in GIMPLE and GENERIC. It's handy for isolation of a problem. Ready to be installed after it survives tests? Thanks, Martin gcc/ChangeLog: 2019-07-03 Martin Liska * dbgcnt.def (DEBUG_COUNTER): Add gimple_match and generic_match

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-03 Thread Prathamesh Kulkarni
On Tue, 2 Jul 2019 at 18:22, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford > > wrote: > >> > >> Thanks for fixing this. > >> > >> Prathamesh Kulkarni writes: > >> > diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c > >> > index 89

[patch] Small improvements to coverage info (1/n)

2019-07-03 Thread Eric Botcazou
Hi, we have collected a number of small improvements to coverage info generated by the compiler over the years. One of the issues is when a new expression or statement is built without source location information and ends up inheriting the source location information of the previous instructio

[PATCH] Fix PR91069

2019-07-03 Thread Richard Biener
Late FRE uncovered a bug in vec-perm folding. Boostrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2019-07-03 Richard Biener PR middle-end/91069 * match.pd (vec_perm -> bit_insert): Fix element read from first vector. * gcc.dg/pr91069.c: New tes

[PATCH] Fix PR91062

2019-07-03 Thread Richard Biener
The following avoids GC collecting during pass execution when a pass calls cgraph::get_body. Bootstrapped / tested on x86_64-unknown-linux-gnu. OK? Thanks, Richard. 2019-07-03 Richard Biener PR ipa/91062 * tree-pass.h (execute_all_ipa_transforms): Add a flag parame

Re: [PATCH] Try fix PR90911

2019-07-03 Thread Richard Biener
On Tue, 25 Jun 2019, Richard Biener wrote: > > PR90911 reports a slowdown of 456.hmmer with the recent introduction > of vectorizer versioning of outer loops, more specifically the case > of re-using if-conversion created versions. > > The patch below fixes things up to adjust the edge probabili

[PATCH] Fix BIT_INSERT_EXPR dumping

2019-07-03 Thread Richard Biener
It currently shows weirdly, fixed as follows. Committed to trunk. Richard. 2019-07-03 Richard Biener * gimple-pretty-print.c (dump_ternary_rhs): Fix BIT_INSERT_EXPR dumping. Index: gcc/gimple-pretty-print.c ==

Re: [patch][aarch64]: fix frame pointer setup before tlsdesc call

2019-07-03 Thread Richard Earnshaw
On 25/06/2019 17:51, Sylvia Taylor wrote: > Greetings, > > This patch fixes a bug with TLS in which the frame pointer is not > established until after the tlsdesc call, thus not conforming to > the aarch64 procedure call standard. > > Changed the tlsdesc instruction patterns to set a dependency

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Richard Biener
On Wed, Jul 3, 2019 at 11:19 AM Aldy Hernandez wrote: > > > > On 7/3/19 4:28 AM, Richard Biener wrote: > > On Mon, Jul 1, 2019 at 10:52 AM Aldy Hernandez wrote: > >> > >> As discussed before, this enforces types on undefined and varying, which > >> makes everything more regular, and removes some

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-03 Thread Richard Sandiford
Prathamesh Kulkarni writes: > On Tue, 2 Jul 2019 at 18:22, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford >> > wrote: >> >> >> >> Thanks for fixing this. >> >> >> >> Prathamesh Kulkarni writes: >> >> > diff --git a/gcc/simplify-

Re: [patch] Fix debug info for discriminated record types

2019-07-03 Thread Richard Biener
On Wed, Jul 3, 2019 at 12:12 PM Eric Botcazou wrote: > > Hi, > > this is a regression present on the mainline and 9 branch: since > https://gcc.gnu.org/ml/gcc-patches/2018-08/msg01066.html > the debug info emitted in Ada with -fgnat-encodings=minimal for discriminated > record types containing a

Re: [PATCH] Add dbgcnt for gimple_match and generic_match.

2019-07-03 Thread Richard Biener
On Wed, Jul 3, 2019 at 12:39 PM Martin Liška wrote: > > Hi. > > The patch is about dbgcnt support for match in GIMPLE and GENERIC. > It's handy for isolation of a problem. > > Ready to be installed after it survives tests? Hmm, I think we only want this on (simplify...), not (match...), no? Thus

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Aldy Hernandez
On 7/3/19 7:08 AM, Richard Biener wrote: On Wed, Jul 3, 2019 at 11:19 AM Aldy Hernandez wrote: On 7/3/19 4:28 AM, Richard Biener wrote: On Mon, Jul 1, 2019 at 10:52 AM Aldy Hernandez wrote: As discussed before, this enforces types on undefined and varying, which makes everything more reg

Re: [PATCH V3] PR88497 - Extend reassoc for vector bit_field_ref

2019-07-03 Thread Richard Biener
On Wed, 3 Jul 2019, Kewen.Lin wrote: > Hi Richard, > > Thanks very much for reviewing my patch. I'll update it as your comments. > Before sending the next version, I've several questions embedded for further > check. > > on 2019/7/2 下午8:43, Richard Biener wrote: > > On Wed, 20 Mar 2019, Kewen.

Re: [PATCH v2] S/390: Improve storing asan frame_pc

2019-07-03 Thread Segher Boessenkool
Hi Ilya, This looks great, thanks! You'll an okay from a global maintainer though, or of all affected maintainers separately. Segher On Tue, Jul 02, 2019 at 05:34:07PM +0200, Ilya Leoshkevich wrote: > Bootstrap and regtest running on x86_64-redhat-linux, s390x-redhat-linux > and ppc64le-redha

Re: [PATCH,RFC,V3 0/5] Support for CTF in GCC

2019-07-03 Thread Richard Biener
On Wed, Jul 3, 2019 at 5:18 AM Jeff Law wrote: > > On 7/2/19 11:54 AM, Indu Bhagat wrote: > > Ping. > > Can someone please review these patches ? We would like to get the > > support for CTF integrated soon. > I'm not sure there's really even consensus that we want CTF support in > GCC. Though I

Re: [PATCH] Add dbgcnt for gimple_match and generic_match.

2019-07-03 Thread Martin Liška
On 7/3/19 1:48 PM, Richard Biener wrote: > On Wed, Jul 3, 2019 at 12:39 PM Martin Liška wrote: >> >> Hi. >> >> The patch is about dbgcnt support for match in GIMPLE and GENERIC. >> It's handy for isolation of a problem. >> >> Ready to be installed after it survives tests? > > Hmm, I think we only

Re: Enable nonoverallping_component_refs even after the base pointers are equivalent

2019-07-03 Thread Richard Biener
On Tue, 2 Jul 2019, Jan Hubicka wrote: > Hi, > this patch adds the shortcut for must aliases discussed earlier and enables > access path even if bases are proved to be equivalent - it could still do > useful job for arrays etc. > > tramp3d stats go from: > > Alias oracle query stats: > refs_ma

Re: [PATCH 2/2] Rename SINGE_VALUE to TOPN_VALUES counters.

2019-07-03 Thread Martin Liška
On 7/3/19 11:09 AM, Jan Hubicka wrote: > OK, > I would rename the __gcov_topn_values_profiler to _v2 since we had this > function before. It's bit tricky, but we hadn't because I named that *_values_*. We used to have *_value_* :) Martin

Re: [PATCH] Add dbgcnt for gimple_match and generic_match.

2019-07-03 Thread Richard Biener
On Wed, Jul 3, 2019 at 2:39 PM Martin Liška wrote: > > On 7/3/19 1:48 PM, Richard Biener wrote: > > On Wed, Jul 3, 2019 at 12:39 PM Martin Liška wrote: > >> > >> Hi. > >> > >> The patch is about dbgcnt support for match in GIMPLE and GENERIC. > >> It's handy for isolation of a problem. > >> > >>

Re: [PATCH][ARM] Add support for "noinit" attribute

2019-07-03 Thread Christophe Lyon
On Wed, 3 Jul 2019 at 11:51, Richard Earnshaw wrote: > > > > On 02/07/2019 15:49, Christophe Lyon wrote: > > On Tue, 2 Jul 2019 at 12:30, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 02/07/2019 11:13, Richard Earnshaw wrote: > >>> > >>> > >>> On 02/07/2019 09:39, Richard Earnshaw wrote: >

Re: [Mingw-w64-public] Fwd: [patch] Reimplement GNU threads library on native Windows

2019-07-03 Thread Liu Hao
在 2019/7/2 下午8:27, Jonathan Wakely 写道: > > What do you mean by "unclosed thread"? If I read it correctly, the MSDN > page > refers to closing a handle (which makes sense), not closing a thread. > Yes, it meant a thread which has terminated but not deleted due to some handles left open. >> This

Go patch committed: Include transitive imports in type descriptor list

2019-07-03 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang includes transitive imports in the type descriptor list. In https://golang.org/cl/179598, we were using Gogo::packages_, when compiling the main package, as the list of packages of which we need to register the type descriptors. This is not complete.

[patch] Small improvements to coverage info (2/n)

2019-07-03 Thread Eric Botcazou
Hi, this is a series of fixes for the exception handling code, with the same goal of preventing instructions from inheriting random source location information in the debug info generated by the compiler. Tested on x86_64-suse-linux, both GCC and GDB, OK for mainline? 2019-07-03 Eric Botcazo

[PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification of (extend ashiftrt (ashift ..))) Otherwise the gcc_assert can catch when dealing with partial int modes.

2019-07-03 Thread John Darrington
--- gcc/ChangeLog | 6 ++ gcc/simplify-rtx.c | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c206ab6..47035ca 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2019-07-03 John Darrington + + simplify-r

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-07-03 Thread Giuliano Belinassi
Hi, Jeff. On 07/02, Jeff Law wrote: > On 1/24/19 12:51 PM, Giuliano Belinassi wrote: > > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the functions > > 'expand_all_functions' and 'ipa_passes', respectivelly. > > > > T

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-07-03 Thread Marek Polacek
On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: > On 6/13/19 5:03 PM, Marek Polacek wrote: > > Case values are converted constant expressions, so narrowing conversion is > > not > > permitted. This patch adds detecting narrowing to case_conversion; it's a > > handy spot because we

Re: [PATCH v2 3/5] or1k: Add mrori option, fix option docs

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 12:33:49PM +0900, Stafford Horne wrote: > @@ -179,11 +183,11 @@ >[(set (match_operand:SI 0 "register_operand" "=r,r") > (rotatert:SI (match_operand:SI 1 "register_operand" "r,r") > (match_operand:SI 2 "reg_or_u6_operand" "r,n")))] > - "TARGET_ROR"

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.

2019-07-03 Thread Martin Liška
On 7/2/19 7:15 PM, Marc Glisse wrote: > On Tue, 2 Jul 2019, Martin Liška wrote: > >> After the discussion with Richi and Nathan, I made a place in >> tree_function_decl >> and I rebased the original Dominik's patch on top of that. > > So, last time there were some questions about the legality of

Re: [PATCH][AArch64] Remove constraint strings from define_expand constructs in the back end

2019-07-03 Thread Dennis Zhang
Hi Richard, Thanks for the tips. The special exceptions according to TARGET_SECONDARY_RELOAD hook are revised. Some related patterns still need constraints in order to work in an expected way in the TARGET_SECONDARY_RELOAD function. The updated patch is tested for targets: aarch64_be-linux-gnu,

Re: [PATCH v2 4/5] or1k: Initial support for FPU

2019-07-03 Thread Segher Boessenkool
Hi Stafford, On Wed, Jul 03, 2019 at 12:33:50PM +0900, Stafford Horne wrote: > +case 'd': > + if (REG_P (x)) > + if (GET_MODE (x) == DFmode || GET_MODE (x) == DImode) > + fprintf (file, "%s,%s", reg_names[REGNO (operand)], > + reg_names[REGNO

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.

2019-07-03 Thread Richard Biener
On July 3, 2019 4:53:30 PM GMT+02:00, "Martin Liška" wrote: >On 7/2/19 7:15 PM, Marc Glisse wrote: >> On Tue, 2 Jul 2019, Martin Liška wrote: >> >>> After the discussion with Richi and Nathan, I made a place in >tree_function_decl >>> and I rebased the original Dominik's patch on top of that. >>

[COMMITTED] Fix store merging tests on Arm

2019-07-03 Thread Wilco Dijkstra
Fix the failing store merging test on Arm. Aligning variables fixes a few cases, otherwise disable the test on Arm. All store merging tests now pass. Committed as obvious. ChangeLog: 2019-07-03 Wilco Dijkstra testsuite/ * gcc.dg/store_merging_27.c: Fix test for Arm. * gcc.dg

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > On Tue, Jul 02, 2019 at 07:36:21PM -0400, Michael Meissner wrote: > > On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > > > The entry before the 8 is split as well. Maybe that should be "4", to > > > stand ou

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > Hi Mike, > > Sorry I missed this patch :-( > > On Thu, Jun 27, 2019 at 04:18:00PM -0400, Michael Meissner wrote: > > As we discussed off-line earlier, I changed all of the "4" lengths to be > > "*", > > even for instruction al

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 12:50:37PM -0400, Michael Meissner wrote: > On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > > We'll need to update our insn_cost for prefixed, sure, it currently does > > int n = get_attr_length (insn) / 4; > > to figure out how many machine instructi

Re: C++ PATCH to detect narrowing in case values (PR c++/90805)

2019-07-03 Thread Jason Merrill
On 7/3/19 10:13 AM, Marek Polacek wrote: On Sat, Jun 22, 2019 at 11:28:36PM -0400, Jason Merrill wrote: On 6/13/19 5:03 PM, Marek Polacek wrote: Case values are converted constant expressions, so narrowing conversion is not permitted. This patch adds detecting narrowing to case_conversion; it'

Re: [patch, c++ openmp] Improve diagnostics for unmappable types

2019-07-03 Thread Jason Merrill
On 7/1/19 7:16 AM, Andrew Stubbs wrote: On 28/06/2019 17:21, Jason Merrill wrote: +  inform ((decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION), +  "incomplete types are not mappable"); It's better to use input_location as a fallback; essentially no diagnostics should use UNK

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Michael Meissner
On Wed, Jul 03, 2019 at 12:55:41PM -0500, Segher Boessenkool wrote: > On Wed, Jul 03, 2019 at 12:50:37PM -0400, Michael Meissner wrote: > > On Tue, Jul 02, 2019 at 07:09:20PM -0500, Segher Boessenkool wrote: > > > We'll need to update our insn_cost for prefixed, sure, it currently does > > > int

[Darwin.comitted] Some TLC for older Darwin versions.

2019-07-03 Thread Iain Sandoe
The command lines and build options for some of the crts for the older PPC Darwin versions had bit-rotted somewhat. This adjusts the build criteria for the crts to avoid newer ld64 versions warnings about mismatches in build and object versions. Added some more comments so that it's documented w

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 01:06:27PM -0400, Michael Meissner wrote: > On Mon, Jul 01, 2019 at 04:27:05PM -0500, Segher Boessenkool wrote: > > > @@ -7385,8 +7385,8 @@ (define_insn "*mov_softfloat" > > > *, *, *, *") > > > > > > (set_attr "length" > > > - "4,

[Darwin] Revise pie,no-pie and rdynamic driver specs.

2019-07-03 Thread Iain Sandoe
Processing these in the driver self-specs and pushing the corresponding Xlinker lines seemed like a good idea (nominally the Right Place to process driver specs). However, it has the effect that the driver then supposes that there are linker inputs, and causes a link line to be created even if

Re: [OpenRISC] [PATCH v2 4/5] or1k: Initial support for FPU

2019-07-03 Thread Richard Henderson
On 7/3/19 5:43 PM, Segher Boessenkool wrote: >> @@ -212,6 +214,7 @@ enum reg_class >> #define REG_CLASS_CONTENTS \ >> { { 0x, 0x }, \ >>{ SIBCALL_REGS_MASK, 0 }, \ >> + { 0x7efe, 0x }, \ > > Above you said r0, r30, r31 are excluded, but t

Re: [PATCH] Prepare for prefixed instructions on PowerPC

2019-07-03 Thread Segher Boessenkool
On Wed, Jul 03, 2019 at 02:36:11PM -0400, Michael Meissner wrote: > On Wed, Jul 03, 2019 at 12:55:41PM -0500, Segher Boessenkool wrote: > > I don't think this is a good idea. You can set "cost" directly, if that > > is the only thing you need this for? > > The trouble is the cost is currently a f

Re: [PATCH][AArch64] Remove constraint strings from define_expand constructs in the back end

2019-07-03 Thread Richard Sandiford
Dennis Zhang writes: > Hi Richard, Thanks for the tips. > > The special exceptions according to TARGET_SECONDARY_RELOAD hook are > revised. Some related patterns still need constraints in order to work > in an expected way in the TARGET_SECONDARY_RELOAD function. > > The updated patch is tested

Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification

2019-07-03 Thread Richard Sandiford
> diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c > index 89a46a9..d74a4ba 100644 > --- a/gcc/simplify-rtx.c > +++ b/gcc/simplify-rtx.c > @@ -1504,12 +1504,12 @@ simplify_unary_operation_1 (enum rtx_code code, > machine_mode mode, rtx op) > && CONST_INT_P (XEXP (op, 1)) > && X

Re: [PATCH] Fix few build warnings with LLVM toolchain

2019-07-03 Thread Richard Sandiford
Jeff Law writes: > On 6/28/19 12:46 PM, Richard Sandiford wrote: >> Segher Boessenkool writes: >>> On Fri, Jun 28, 2019 at 08:55:00AM -0600, Martin Sebor wrote: Jeff reminded me in a code review the other day that GCC does have a guideline for defining POD structs with the keyword

Re: [PATCH] S/390: Improve storing asan frame_pc

2019-07-03 Thread Richard Sandiford
Segher Boessenkool writes: > On Tue, Jul 02, 2019 at 03:55:56PM +0200, Ilya Leoshkevich wrote: >> > Am 02.07.2019 um 15:39 schrieb Jakub Jelinek : >> > On Tue, Jul 02, 2019 at 03:33:28PM +0200, Ilya Leoshkevich wrote: >> >>> Am 02.07.2019 um 15:19 schrieb Segher Boessenkool >> >>> : >> >>> >> >>

Re: [PATCH v2 3/5] or1k: Add mrori option, fix option docs

2019-07-03 Thread Stafford Horne
On Wed, Jul 03, 2019 at 09:49:02AM -0500, Segher Boessenkool wrote: > On Wed, Jul 03, 2019 at 12:33:49PM +0900, Stafford Horne wrote: > > @@ -179,11 +183,11 @@ > >[(set (match_operand:SI 0 "register_operand" "=r,r") > > (rotatert:SI (match_operand:SI 1 "register_operand" "r,r") > >

Re: [patch] Small improvements to coverage info (1/n)

2019-07-03 Thread Jeff Law
On 7/3/19 4:46 AM, Eric Botcazou wrote: > Hi, > > we have collected a number of small improvements to coverage info generated > by > the compiler over the years. One of the issues is when a new expression or > statement is built without source location information and ends up inheriting > the

Re: [patch] Small improvements to coverage info (2/n)

2019-07-03 Thread Jeff Law
On 7/3/19 7:35 AM, Eric Botcazou wrote: > Hi, > > this is a series of fixes for the exception handling code, with the same goal > of preventing instructions from inheriting random source location information > in the debug info generated by the compiler. > > Tested on x86_64-suse-linux, both GC

Re: [PATCH v2 4/5] or1k: Initial support for FPU

2019-07-03 Thread Stafford Horne
On Wed, Jul 03, 2019 at 10:43:01AM -0500, Segher Boessenkool wrote: > Hi Stafford, > > On Wed, Jul 03, 2019 at 12:33:50PM +0900, Stafford Horne wrote: > > +case 'd': > > + if (REG_P (x)) > > + if (GET_MODE (x) == DFmode || GET_MODE (x) == DImode) > > + fprintf (file, "%s,%s", re

Re: [PATCH] PowerPC Prefixed Memory, Patch #4, Add pc-relative reference support

2019-07-03 Thread Segher Boessenkool
Hi Mike, On Fri, Jun 28, 2019 at 02:50:33PM -0400, Michael Meissner wrote: > --- gcc/config/rs6000/rs6000-logue.c (revision 272714) > +++ gcc/config/rs6000/rs6000-logue.c (working copy) > @@ -1406,23 +1406,13 @@ uses_TOC (void) > } > #endif > > +/* Create a TOC style reference for a symbol.

Re: [OpenRISC] [PATCH v2 4/5] or1k: Initial support for FPU

2019-07-03 Thread Stafford Horne
On Wed, Jul 03, 2019 at 09:09:51PM +0200, Richard Henderson wrote: > On 7/3/19 5:43 PM, Segher Boessenkool wrote: > >> @@ -212,6 +214,7 @@ enum reg_class > >> #define REG_CLASS_CONTENTS \ > >> { { 0x, 0x }, \ > >>{ SIBCALL_REGS_MASK, 0 }, \ > >> + { 0x7efe,

Call for testers: improve move2add_use_add2_insn for targets with HAVE_POST_MODIFY_DISP and/or clobber-encumbered add

2019-07-03 Thread Joern Wolfgang Rennecke
2019-07-03 Joern Rennecke * postreload.c (rtl-iter.h): Include. (reg_addr_use_luid, reg_addr_use_insn): New static variables. (reg_addr_use, move2add_last_jump_luid): Likewise. (move2add_use_add2_insn): Try to use a POST_MODIFY before and add. (reload_c

C++ PATCH for DR 1813, c++/83374 - __is_standard_layout wrong for a class with repeated bases.

2019-07-03 Thread Marek Polacek
This resolves DR 1813 which says that for a class to be a standard-layout class, it may not have two (possibly indirect) base class subobjects of the same type. I was going to play DFS games but then I noticed we'd already set CLASSTYPE_REPEATED_BASE_P, making this significantly easier. There are

Re: [PATCH v2 3/5] or1k: Add mrori option, fix option docs

2019-07-03 Thread Segher Boessenkool
On Thu, Jul 04, 2019 at 06:49:17AM +0900, Stafford Horne wrote: > On Wed, Jul 03, 2019 at 09:49:02AM -0500, Segher Boessenkool wrote: > > On Wed, Jul 03, 2019 at 12:33:49PM +0900, Stafford Horne wrote: > > > @@ -179,11 +183,11 @@ > > >[(set (match_operand:SI 0 "register_operand" "=r,r") > > >

Go patch committed: Set varargs lowered for imported call expressions

2019-07-03 Thread Ian Lance Taylor
This Go frontend patch by Than McIntosh fixes a Go frontend buglet: varargs lowering happens before inlinable function bodies are written out to export data, so set the "varargs lowered" flag on call expressions that we import. This fixes https://golang.org/issue/32922. The test case is in https:

Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification

2019-07-03 Thread Jeff Law
On 7/3/19 2:17 PM, Richard Sandiford wrote: >> diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c >> index 89a46a9..d74a4ba 100644 >> --- a/gcc/simplify-rtx.c >> +++ b/gcc/simplify-rtx.c >> @@ -1504,12 +1504,12 @@ simplify_unary_operation_1 (enum rtx_code code, >> machine_mode mode, rtx op) >>

[PATCH] [Ada] Make clockid_t type public on GNU/kFreeBSD

2019-07-03 Thread James Clarke
From: James Clarke Monotonic_Clock and RT_Resolution in the recently-added s-tpopmo.adb call clock_gettime/clock_getres with the integral constants from OSC and thus rely on clockid_t being an integral type, so we cannot hide it on GNU/kFreeBSD. Instead, make the definition public to match all th

Re: [OpenRISC] [PATCH v2 4/5] or1k: Initial support for FPU

2019-07-03 Thread Segher Boessenkool
On Thu, Jul 04, 2019 at 07:19:56AM +0900, Stafford Horne wrote: > On Wed, Jul 03, 2019 at 09:09:51PM +0200, Richard Henderson wrote: > > On 7/3/19 5:43 PM, Segher Boessenkool wrote: > > >> @@ -212,6 +214,7 @@ enum reg_class > > >> #define REG_CLASS_CONTENTS \ > > >> { { 0x, 0x000

Re: [range-ops] patch 01/04: types for VR_UNDEFINED and VR_VARYING

2019-07-03 Thread Jeff Law
On 7/3/19 3:46 AM, Aldy Hernandez wrote: > > > On 7/2/19 4:17 PM, Jeff Law wrote: >> On 7/1/19 2:52 AM, Aldy Hernandez wrote: >>> As discussed before, this enforces types on undefined and varying, which >>> makes everything more regular, and removes some special casing >>> throughout range handli

Re: [PATCH v2 3/5] or1k: Add mrori option, fix option docs

2019-07-03 Thread Stafford Horne
On Wed, Jul 03, 2019 at 05:26:58PM -0500, Segher Boessenkool wrote: > On Thu, Jul 04, 2019 at 06:49:17AM +0900, Stafford Horne wrote: > > On Wed, Jul 03, 2019 at 09:49:02AM -0500, Segher Boessenkool wrote: > > > On Wed, Jul 03, 2019 at 12:33:49PM +0900, Stafford Horne wrote: > > > > @@ -179,11 +183

Re: [MIPS][Testsuite] specify msa-fmadd.c abis

2019-07-03 Thread Jeff Law
On 7/3/19 12:52 AM, Paul Hua wrote: > Hi, > > The msa-fmadd.c fails on abi=64, the attached patch fixed by specify the abis. > > spawn -ignore SIGHUP > /home/xuchenghua/GCC/test/gcc-r272929_obj/gcc/xgcc > -B/home/xuchenghua/GCC/test/gcc-r272929_obj/gcc/ > /home/xuchenghua/GCC/gcc_git_trunk/gcc/te

Re: [range-ops] patch 02/04: enforce canonicalization in value_range

2019-07-03 Thread Jeff Law
On 7/3/19 3:35 AM, Aldy Hernandez wrote: > On 7/2/19 5:36 PM, Jeff Law wrote: > >> I don't see anything inherently concerning here.  I do wonder if there's >> any value in having a debugging function in the class that would iterate >> over the ranges and check them for proper canonicalization, ver

Re: [PATCH] Fix out-of-ssa with unsupported vector types (PR rtl-optimization/90756)

2019-07-03 Thread Jeff Law
On 7/3/19 1:59 AM, Jakub Jelinek wrote: > Hi! > > This weird hink has been added by Alex in r228175, it isn't clear why > nor how it ever can be correct. While say for DECL_MODE we have the problem > that for global vars when switching between functions with different ISA > selections the mode mi

  1   2   >