[committed] Unbreak non-ELF target bootstrap (PR bootstrap/89539)

Hi! The new early_lto_debug argument is right now used solely in #if defined (OBJECT_FORMAT_ELF) guarded parts of the function, so on other targets it warns about unused parameter. Fixed thusly, committed to trunk as obvious. 2019-03-01 Jakub Jelinek PR bootstrap/89539 * dwar

Re: [patch] Fix wrong code for boolean negation in condition at -O

> The BIT_AND_EXPR case is clearly correct for all possible values. The code > says that if the result of BIT_AND_EXPR is known to be a non-zero constant, > and one or both of the BIT_AND_EXPR arguments have known value ranges [0,1] > (or boolean or precision 1, not talking about those now), then

[PATCH GCC10] ipa-inline.c: Trivial fix on function not declared inline check in want_inline_small_function_p

Hi Since MAX_INLINE_INSNS_AUTO should be below or equal to MAX_INLINE_INSNS_SINGLE (see params.def), there is no need to do second inlining limit check on growth when function not declared inline, this patch removes it. Bootstrapped and tested on x86_64-unknown-linux-gnu, is it ok

Re: [PATCH] Fix up --enable-checking=fold (PR middle-end/89503)

On Fri, 1 Mar 2019, Jakub Jelinek wrote: > Hi! > > Some of the builtin folding sets TREE_NO_WARNING flags, which triggers as > --enable-checking=fold errors. I think we should allow setting of > TREE_NO_WARNING flag when folding, so this patch arranges that. > > Tested on: > ../configure --enab

Re: [PATCH] Fix up --enable-checking=fold (PR middle-end/89503)

On Fri, Mar 01, 2019 at 09:49:03AM +0100, Richard Biener wrote: > On Fri, 1 Mar 2019, Jakub Jelinek wrote: > > Some of the builtin folding sets TREE_NO_WARNING flags, which triggers as > > --enable-checking=fold errors. I think we should allow setting of > > TREE_NO_WARNING flag when folding, so t

Re: [PATCH] Fix up --enable-checking=fold (PR middle-end/89503)

On Fri, 1 Mar 2019, Jakub Jelinek wrote: > On Fri, Mar 01, 2019 at 09:49:03AM +0100, Richard Biener wrote: > > On Fri, 1 Mar 2019, Jakub Jelinek wrote: > > > Some of the builtin folding sets TREE_NO_WARNING flags, which triggers as > > > --enable-checking=fold errors. I think we should allow sett

Re: [PATCH] Fix PR89497

On Wed, 27 Feb 2019, Richard Biener wrote: > > CFG cleanup is now set up to perform trivial unreachable code > elimination before doing anything that would require up-to-date > SSA form. Unfortunately a pending SSA update still will cause > breakage to stmt folding triggered for example by basic

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

Hi Jakub, On 2/28/19 9:43 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs on ARM, because the backend creates CONST_INTs that aren't valid for SImode, in which they are used (0x8000 rather than the canonical -0x8000). This is fixed by the 3 gen_int_mode calls instead of just G

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On Fri, Mar 01, 2019 at 09:21:16AM +, Kyrill Tkachov wrote: > > Ok for trunk? > > Ok. Thanks. I'll wait for my regtest, previously I've regtested it only with an older version of this patch. > > Or is there an easy way to estimate if a constant satisfies both "I" and "L" > > constraints at

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On 3/1/19 9:36 AM, Jakub Jelinek wrote: On Fri, Mar 01, 2019 at 09:21:16AM +, Kyrill Tkachov wrote: Ok for trunk? Ok. Thanks. I'll wait for my regtest, previously I've regtested it only with an older version of this patch. Or is there an easy way to estimate if a constant satisfies bo

Re: [PATCH] PR d/89177 - Fix unaligned access in std.digest.murmurhash

On Sun, 24 Feb 2019 at 16:30, Johannes Pfau wrote: > > Backport latest murmurhash version from upstream (2.084.1). Ran gdc testsuite > on X86_64 linux and got feedback on the bugzilla this really fixes the issue. > Raise a pull request with upstream (dmd-cxx is the branch), then this is OK to com

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On 3/1/19 9:42 AM, Kyrill Tkachov wrote: On 3/1/19 9:36 AM, Jakub Jelinek wrote: > On Fri, Mar 01, 2019 at 09:21:16AM +, Kyrill Tkachov wrote: >>> Ok for trunk? >> Ok. > Thanks.  I'll wait for my regtest, previously I've regtested it only with > an older version of this patch. > >>> Or i

Re: [arm][RFC] PR target/88469 fix incorrect argument passing with 64-bit bitfields

On 28/02/2019 14:51, Bernd Edlinger wrote: > On 2/28/19 1:10 PM, Richard Earnshaw (lists) wrote: >> On 27/01/2019 11:20, Bernd Edlinger wrote: >>> >>> $ arm-linux-gnueabihf-gcc -march=armv5te -O3 -S test.c >>> $ cat test.s >>> f: >>> @ args = 12, pretend = 0, frame = 0 >>> @ frame_needed =

[PATCH] Fix PR89541

This follows last years change of allowing virtual operands for STRING_CSTs. Here we run into stores into CONST_DECLs. For IL hygiene these are regular memory references (that they trigger undefined behavior at runtime is another issue). Bootstrap & regtest running on x86_64-unknown-linux-gnu

[libgo] Properly determine executable path on Solaris

One of the remaining libgo testsuite failures on Solaris/SPARC is --- FAIL: TestExecutable (0.04s) executable_test.go:46: exec(self) failed: fork/exec .: permission denied FAIL: os This happens only for 64-bit. truss indeed shows 3181: execve(".", 0xC000170240, 0xC000178340) Err#

Re: [PATCH] [ARC] Fix logic set UNALIGNED_ACCESS

* Vineet Gupta [2019-02-28 10:04:24 -0800]: > From: Claudiu Zissulescu > > gcc/ > -xx-xx Claudiu Zissulescu > > * config/arc/arc-c.def (__ARC_UNALIGNED__): Set it on > unaligned_access variable. > * config/arc/arc.c (arc_override_options): Set unaligned access >

[PATCH, d] Committed merge with upstream dmd

Hi, This patch merges the D front-end implementation with dmd upstream ed71446aa. Backports support for extern(C++, "namespace"), which makes the core.stdcpp package compilable. Added predefined condition for CppRuntime_Gcc unconditionally, as it is unlikely that D code will be linking to anythi

Re: [PATCH] Fix not 8-byte aligned ldrd/strd on ARMv5

On 05/02/2019 15:07, Bernd Edlinger wrote: > Hi, > > due to the AAPCS parameter passing of 8-byte aligned structures, which happen > to > be 8-byte aligned or only 4-byte aligned in the test case, ldrd instructions > are generated that may access 4-byte aligned stack slots, which will trap on >

Fix mask type choice in vectorizable_call (PR 89535)

This is another case in which we were failing to pass the expected mask vector type to vect_get_vec_def_for_operand. Really looking forward to seeing this non-SLP structure go away :-) Tested on aarch64-linux-gnu (with and without SVE), aarch64_be-elf and x86_64-linux-gnu. OK to install? Richar

Re: [PATCH PR89487]Avoid taking address of register variable in loop list

On Fri, Mar 1, 2019 at 7:54 AM bin.cheng wrote: > > Hi, > This patch fixes PR89487 by following comments in PR. It simply avoid > checking runtime > alias by versioning in loop distribution if address of register variable may > need to be taken. > > One thing I am not sure is if we should avoid

Re: Fix mask type choice in vectorizable_call (PR 89535)

On Fri, Mar 1, 2019 at 11:45 AM Richard Sandiford wrote: > > This is another case in which we were failing to pass the expected > mask vector type to vect_get_vec_def_for_operand. Really looking > forward to seeing this non-SLP structure go away :-) > > Tested on aarch64-linux-gnu (with and witho

[PATCH][GCC][AArch64] Make every option in options.def one line

Hi All, Due to config.gcc all the options need to be on one line because of the grep lines which would select only the first line of the option. This causes it not to select the right bits on options that are spread over multiple lines when the --with-arch configure option is used. The issue hap

[PATCH][GCC][AArch64] Make every option in options.def one line (GCC-8).

Hi All, Due to config.gcc all the options need to be on one line because of the grep lines which would select only the first line of the option. This causes it not to select the right bits on options that are spread over multiple lines when the --with-arch configure option is used. The issue hap

Re: [PATCH][GCC][AArch64] Make every option in options.def one line

On 01/03/2019 12:57, Tamar Christina wrote: > Hi All, > > Due to config.gcc all the options need to be on one line because of the grep > lines which would select only the first line of the option. > > This causes it not to select the right bits on options that are spread over > multiple lines whe

Re: [PATCH][GCC][AArch64] Make every option in options.def one line (GCC-8).

On 01/03/2019 12:58, Tamar Christina wrote: > Hi All, > > Due to config.gcc all the options need to be on one line because of the grep > lines which would select only the first line of the option. > > This causes it not to select the right bits on options that are spread over > multiple lines whe

[PATCH] C++2a Utility functions to implement uses-allocator construction (P0591R4)

* include/std/memory (uses_allocator_construction_args): New set of overloaded functions. (make_obj_using_allocator, uninitialized_construct_using_allocator): New functions. * include/std/memory_resource (polymorphic_allocator::construct) [__cplusplu

[PATCH] Fix test memory_resource to work without sized deallocation

The checking memory_resource in the testsuite assumes sized deallocation is supported, which might not be true for other compilers. * testsuite/util/testsuite_allocator.h (__gnu_test::memory_resource) [!__cpp_sized_deallocation]: Do not pass size to operator delete. Tested powerp

Re: [PATCH] C++2a Utility functions to implement uses-allocator construction (P0591R4)

On 01/03/19 13:50 +, Jonathan Wakely wrote: * include/std/memory (uses_allocator_construction_args): New set of overloaded functions. (make_obj_using_allocator, uninitialized_construct_using_allocator): New functions. * include/std/memory_resource (poly

Re: C++ PATCH for c++/89537 - missing location for error with non-static member fn

On 2/28/19 2:45 PM, Marek Polacek wrote: On Thu, Feb 28, 2019 at 02:33:37PM -0500, Jason Merrill wrote: On 2/28/19 2:00 PM, Marek Polacek wrote: Here we issued the "invalid use of non-static member function" error with UNKNOWN_LOCATION, which merely shows "cc1plus" and no file/line. We can gre

Re: [C++ PATCH] Reject constexpr functions with function-try-block (PR c++/89513, take 2)

On 2/28/19 6:03 PM, Jakub Jelinek wrote: On Wed, Feb 27, 2019 at 06:48:13PM -0500, Jason Merrill wrote: Or would you prefer to have P1002R1 implemented and thus make this perhaps a pedwarn before cxx2a, similarly for the error on try block in the body and tweak build_constexpr_constructor_member

Re: C++ PATCH for c++/89532 - ICE with incomplete type in decltype

On 2/28/19 3:04 PM, Marek Polacek wrote: If get_target_expr_sfinae gets an expression whose type is incomplete, it's upset. digest_init returns error_mark_node if it gets an expression with incomplete type, so we need to respect that, and not call get_target_expr_sfinae on ORIG_CL in that case.

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

On 31/01/2019 14:54, Sam Tebbs wrote: > >> ping 3. The preceding two patches were committed a while ago but require >> the minor libgcc changes in this patch, which are the only parts left to >> be reviewed. > ping 4 Attached is a rebased patch made to work on top of Sudi Das' BTI patch (by ren

Re: [PATCH GCC10] ipa-inline.c: Trivial fix on function not declared inline check in want_inline_small_function_p

Hi! On Fri, Mar 01, 2019 at 04:39:38PM +0800, JunMa wrote: >Since MAX_INLINE_INSNS_AUTO should be below or equal to >MAX_INLINE_INSNS_SINGLE (see params.def), there is no need >to do second inlining limit check on growth when function not >declared inline, this patch removes it. >

Re: [libgo] Properly determine executable path on Solaris

On Fri, Mar 1, 2019 at 2:06 AM Rainer Orth wrote: > > One of the remaining libgo testsuite failures on Solaris/SPARC is > > --- FAIL: TestExecutable (0.04s) > executable_test.go:46: exec(self) failed: fork/exec .: permission denied > > FAIL: os > > This happens only for 64-bit. truss indeed

Re: [PATCH] C++2a Utility functions to implement uses-allocator construction (P0591R4)

On 01/03/19 14:06 +, Jonathan Wakely wrote: + if constexpr (sizeof...(__args) == 0) + { + return std::make_tuple(piecewise_construct, + std::__uses_alloc_args<_Tp1>(__a), + std::__uses_alloc_args<_Tp2>(__a)); + } +

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

Hi Jakub, > Well, with the patch the decision which insn is chosen is done in C code. > So it could look like: >  if (operands[2] == const0_rtx >  || INTVAL (operands[2]) == -HOST_WIDE_INT_C (0x8000) >    subs; // mandatory >  else if (TARGET_THUMB2 >    && arm_immediate_operand (ope

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On Fri, Mar 01, 2019 at 02:57:57PM +, Wilco Dijkstra wrote: > > This can be done incrementally, I just have no idea what the rules > > for thumb2 constant encoding are. > > This is overcomplicating something simple - adds/subs are completely > symmetrical on all Arm targets. So for addition yo

[wwwdocs] update projects/cxx-status.html

On Tue, Feb 26, 2019 at 02:11:03PM -0500, Nathan Sidwell wrote: > now modules and coroutines are slated to be in C++20, here's a doc patch for > them, pointing at their respective wiki pages. Several more papers have been accepted apparently, so I've incorporated your changed into a larger patch.

Re: [wwwdocs] update projects/cxx-status.html

On 3/1/19 10:30 AM, Jakub Jelinek wrote: On Tue, Feb 26, 2019 at 02:11:03PM -0500, Nathan Sidwell wrote: now modules and coroutines are slated to be in C++20, here's a doc patch for them, pointing at their respective wiki pages. > Several more papers have been accepted apparently, so I've incor

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

Hi Jakub, >> This is overcomplicating something simple - adds/subs are completely >> symmetrical on all Arm targets. So for addition you simply place adds >> alternative first and then subs. For comparison/subtraction place the > > As I wrote, that is what I have done, That's not what your pro

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On Fri, Mar 01, 2019 at 03:41:33PM +, Wilco Dijkstra wrote: > >> This is overcomplicating something simple - adds/subs are completely > >> symmetrical on all Arm targets. So for addition you simply place adds > >> alternative first and then subs. For comparison/subtraction place the > > > > A

Re: [PATCH] ARM cmpsi2_addneg fixes (PR target/89506)

On Fri, Mar 01, 2019 at 05:04:24PM +0100, Jakub Jelinek wrote: > + /* For 0 and INT_MIN it is essential that we use subs, as adds > + will result in different condition codes (like cmn rather than > + like cmp). Both alternatives can match also for -1/1 with > + TARGET_THUMB2, prefer

[PATCH] rs6000: Add -mdejagnu-cpu=

This adds an option -mdejagnu-cpu=. This option simply overrides what is given in -mcpu=. The reason for this is that with older versions of DejaGnu the value given in the RUNTESTFLAGS will override the value a testcase wants to have. Ill commit this patch with the first changelog, and also the

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > This adds an option -mdejagnu-cpu=. This option simply overrides what > is given in -mcpu=. The reason for this is that with older versions > of DejaGnu the value given in the RUNTESTFLAGS will override the value > a testcase w

Re: A bug in vrp_meet?

Jeff, thanks a lot for the reply. this is really helpful. I double checked the dumped intermediate file for pass “dom3", and located the following for _152: BEFORE the pass “dom3”, there is no _152, the corresponding Block looks like: [local count: 12992277]: _98 = (int) ufcMSR_52(D

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

On Fri, Mar 01, 2019 at 06:07:57PM +0100, Jakub Jelinek wrote: > On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > > This adds an option -mdejagnu-cpu=. This option simply overrides what > > is given in -mcpu=. The reason for this is that with older versions > > of DejaGnu the

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

On Fri, Mar 01, 2019 at 12:00:50PM -0600, Segher Boessenkool wrote: > On Fri, Mar 01, 2019 at 06:07:57PM +0100, Jakub Jelinek wrote: > > On Fri, Mar 01, 2019 at 05:02:58PM +, Segher Boessenkool wrote: > > > This adds an option -mdejagnu-cpu=. This option simply overrides what > > > is given in

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

On Fri, Mar 01, 2019 at 07:09:05PM +0100, Jakub Jelinek wrote: > > Having separate flags for the testcases that say "override the RUNTESTFLAGS" > > gives the best of both worlds. Even with with new dejagnu, where normally > > the RUNTESTFLAGS always wins. > > I thought new dejagnu behavior is RUN

Re: [PATCH] rs6000: Add -mdejagnu-cpu=

On Fri, Mar 01, 2019 at 07:09:05PM +0100, Jakub Jelinek wrote: > > > Can't we just detect the old dejagnu and override > > > whatever tcl method is responsible for that? > > > > Not sure. We probably could. But are the new semantics actually > > better? Sometimes you want the testcase flags to

Re: [PATCH] Fix PR89497

On Fri, Mar 01, 2019 at 10:20:05AM +0100, Richard Biener wrote: > 2019-03-01 Richard Biener > > PR middle-end/89497 > * tree-cfgcleanup.h (cleanup_tree_cfg): Add SSA update flags > argument, defaulted to zero. > * passes.c (execute_function_todo): Pass down SSA update fl

Re: A bug in vrp_meet?

On March 1, 2019 6:49:20 PM GMT+01:00, Qing Zhao wrote: >Jeff, > >thanks a lot for the reply. > >this is really helpful. > >I double checked the dumped intermediate file for pass “dom3", and >located the following for _152: > >BEFORE the pass “dom3”, there is no _152, the corresponding Block >

[PATCH, rs6000] Fix PR88845: ICE in lra_set_insn_recog_data

PR88845 shows a problem where LRA spilled an input operand of an inline asm statement by calling our generic movsf pattern which ended up generating an insn we don't have a pattern for, so we ICE. The insn was: (insn (set (reg:SF 125) (subreg:SF (reg:SI 124) 0))) The problem is th

[wwwdocs] Buildstat update for 8.x

Latest results for 8.x. -tgc Testresults for 8.3.0: aarch64-unknown-linux-gnu mips64el-unknown-linux-gnu mips64-unknown-linux-gnu powerpc64le-unknown-linux-gnu powerpc-unknown-linux-gnu x86_64-pc-linux-gnu x86_64-w64-mingw32 Testresults for 8.2.0: aarch64-unknown-linux-gnu armv

Re: A bug in vrp_meet?

> On Mar 1, 2019, at 1:25 PM, Richard Biener wrote: > > On March 1, 2019 6:49:20 PM GMT+01:00, Qing Zhao > wrote: >> Jeff, >> >> thanks a lot for the reply. >> >> this is really helpful. >> >> I double checked the dumped intermediate file for pass “dom3", and >>

Re: [C++ PATCH] Partially fix designated-initializer-list handling in overload resolution (PR c++/71446)

On 3/1/19 1:53 PM, Jakub Jelinek wrote: Hi! http://eel.is/c++draft/dcl.init.list#3.1 says that for designated initializers only aggregate conversion should be performed, while our current code would happily try std::initializer_list initialization, or (as extension) complex initialization, or sc

Re: [PATCH] PR c/89524 - Ignore -Wno-error=

On Thu, 28 Feb 2019, Alex Henrie wrote: > * opts.c: Ignore -Wno-error=. I'd expect this to follow the same logic as how -Wno- is ignored (see the comment on postpone_unknown_option_warning). That is, the option would still be diagnosed if there is some error message that might have been turne

libgo patch committed: Restore passing D to ar

In the update of libgo to Go1.12beta2 I accidentally lost the code that passes D to the ar program. This patch restores it. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

[PATCH] Fix overflowing integer to an integer exponent

Consider, the program program foo i = 10**23 x = 6.02 * 10**23 print *, i, x end % gfc8 -o z a.f90 && ./z -159383552 6.0181E+23 Now, if 10**23 = -159383552, then 6.02 * 10**23 should be -959488983.04. Moreover raising a positive number to a positive exponent should

[PR fortran/77583, patch ]- ICE in pp_quoted_string, at pretty-print.c:966

The attached patch (originally by Steve Kargl) fixes a NULL pointer dereference that may occur when checking for a conflict. Regtested successfully. OK for trunk? Backport to active branches? Thanks, Harald 2019-03-02 Harald Anlauf Steve Kargl PR fortran/77583

Re: [PR fortran/77583, patch ]- ICE in pp_quoted_string, at pretty-print.c:966

On Sat, Mar 02, 2019 at 12:12:10AM +0100, Harald Anlauf wrote: > The attached patch (originally by Steve Kargl) fixes a NULL pointer > dereference that may occur when checking for a conflict. > > Regtested successfully. > > OK for trunk? Backport to active branches? > > > 2019-03-02 Harald An

libgo patch committed: Remove temporary directories in gccgoimporter test

This libgo patches fixes the go/internal/gccgoimporter test to remove temporary directories. This is for PR 89406. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: [PATCH v2 0/2] RISC-V: Support ELF attribute for GCC

On Tue, Feb 26, 2019 at 7:00 PM Kito Cheng wrote: > This version 2 of patch series for of RISC-V ELF attribute[1], first version > can be found in[2-4]. > Most changes between last version is typo fixing and coding sytle fix, and a > missing re-generated > configure file. This looks good. I se

Re: [patch, fortran] Fix pointers not escaping via C_PTR

On Thu, Feb 28, 2019 at 09:14:48PM +0100, Thomas Koenig wrote: > > the attached patch fixes a wrong-code bug for gfortran where pointers > were not marked as escaping. A C_PTR can be stashed away and reused > later (at least as long as the variable it points to remains active). > > This is not a