Re: [PATCH] Fix excess warnings from -Wtype-limits with location wrappers (PR c++/88680)

2019-02-14 Thread David Malcolm
On Thu, 2019-02-14 at 10:38 -0500, Jason Merrill wrote: > On 2/6/19 9:23 PM, David Malcolm wrote: > > PR c++/88680 reports excess warnings from -Wtype-limits after the > > C++ > > FE's use of location wrappers was extended in r267272 for cases > > such as: > > > >const unsigned n = 8; > >s

Re: [rs6000] 64-bit integer loads/stores and FP instructions

2019-02-14 Thread Eric Botcazou
> Yeah, something like that. It will need some serious testing, to make > sure we don't regress (including not regressing what that patch that took > them away was meant to do). I can arrange some testing, will you do the > patch though? I can do the patch and also (correctness) testing for 32-b

Re: [PATCH] Fix excess warnings from -Wtype-limits with location wrappers (PR c++/88680)

2019-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2019 at 11:26:15AM -0500, David Malcolm wrote: > There's an asymmetry in the warning; it's looking for a comparison of a > LHS expression against an RHS constant 0, spelled as "0". > > If we fold_for_warn on the RHS, then that folding introduces a warning > for expressions that are

Re: [PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-14 Thread Tamar Christina
Hi Kyrill, I couldn't find a way to actually generate this case so I have instead removed the entry from ANY128. New patch and changelog below. -- The iterator ANY64 are used in various general split patterns and is supposed to contain all 64 bit modes. For some reason the pattern has HI but n

Re: [PATCH][GCC][Arm] Add HF modes to ANY iterators

2019-02-14 Thread Kyrill Tkachov
On 2/14/19 4:52 PM, Tamar Christina wrote: Hi Kyrill, I couldn't find a way to actually generate this case so I have instead removed the entry from ANY128. New patch and changelog below. -- The iterator ANY64 are used in various general split patterns and is supposed to contain all 64 bit m

Re: [PATCH] Update libstdc++ documentation for implementation status

2019-02-14 Thread Jonathan Wakely
On 14/02/19 15:12 +, Jonathan Wakely wrote: * doc/xml/manual/status_cxx2017.xml: Add P0063R3 to status table. * doc/html/*: Regenerate. And another update, thanks to Ulrich for pointing this out. Committed to trunk. commit 0fcc9bcdcb3923e50c6261bcdeb6f26694b3e245 Author:

Re: Provide __start_minfo/__stop_minfo for linkers that don't (PR d/87864)

2019-02-14 Thread Iain Buclaw
On Thu, 14 Feb 2019 at 11:13, Rainer Orth wrote: > > Hi Iain, > > > On Tue, 29 Jan 2019 at 13:24, Rainer Orth > > wrote: > >> > >> Solaris ld only gained support for section bracketing in Solaris 11.4. > >> Fortunately, in gdc it is only used for the minfo section, so it's easy > >> to provide a

[PATCH 41/40] Prevent allocation of MMX registers with TARGET_MMX_WITH_SSE

2019-02-14 Thread Uros Bizjak
You will also need the following (untested) patch that prevents allocation of MMX registers with TARGET_MMX_WITH_SSE in several insn patterns. 2019-02-14 Uroš Bizjak PR target/89021 * config/i386/i386.md (*zero_extendsidi2): Add mmx_isa attribute. * config/i386/sse.md (*vec_concatv

[Committed][PATCH][GCC][Arm] Fix test directive

2019-02-14 Thread Tamar Christina
Hi All, This patch fixes a failing testcase due to a use of dg-options instead of dg-additional-options. Committed under the GCC obvious Bootstrapped Regtested on arm-none-eabi and no issues. Ok for trunk? Thanks, Tamar gcc/testsuite/ChangeLog: 2019-02-14 Tamar Christina * gcc.ta

Re: Fortran vector math header

2019-02-14 Thread Joseph Myers
On Tue, 5 Feb 2019, Martin Liška wrote: > #ifdef NATIVE_SYSTEM_HEADER_DIR >/* Then search: /usr/include/finclude/ */ >add_sysrooted_hdrs_prefix (&prefixes, NATIVE_SYSTEM_HEADER_DIR > "/finclude/", > - NULL, 0, 0, false); > + NULL, 0, 0, 0

New Danish PO file for 'gcc' (version 9.1-b20190203)

2019-02-14 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Danish team of translators. The file is available at: https://translationproject.org/latest/gcc/da.po (This file, 'gcc-9.1-b20190203.da.po',

Go patch committed: Error for duplicate map string keys in composite literal

2019-02-14 Thread Ian Lance Taylor
This Go frontend patch by Ben Shi gives an error for duplicate string keys in a map composite literal. This is a step toward fixing https://golang.org/issue/28104. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

New Danish PO file for 'cpplib' (version 9.1-b20190203)

2019-02-14 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Danish team of translators. The file is available at: https://translationproject.org/latest/cpplib/da.po (This file, 'cpplib-9.1-b20190203

Contents of PO file 'cpplib-9.1-b20190203.da.po'

2019-02-14 Thread Translation Project Robot
cpplib-9.1-b20190203.da.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread Uros Bizjak
On Thu, Feb 14, 2019 at 1:33 PM H.J. Lu wrote: > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't enable MMX ISA > by default with TARGET_MMX_WITH_SSE. > > For pr82483-1.c and pr82483-2.c, "-mssse3 -mno-mmx" compiles in 64-bit > mode since MMX intrinsics can be emulated wit SSE. > > gcc

Backports for GCC 8

2019-02-14 Thread Segher Boessenkool
I backported my fixes for PR85805 (combine), PR88892 (rs6000), PR86684 and the first part of PR87149 (rs6000) to the GCC 8 branch. Segher 2019-02-14 Segher Boessenkool Backport from trunk 2018-08-31 Segher Boessenkool PR target/86684 PR target/87149

Re: Go patch committed: Compile thunks with -Os

2019-02-14 Thread Ian Lance Taylor
On Thu, Feb 14, 2019 at 1:41 AM Richard Biener wrote: > > On Thu, Feb 14, 2019 at 2:21 AM Ian Lance Taylor wrote: > > > > Nikhil Benesch noticed that changes in the GCC backend were making the > > use of defer functions that call recover less efficient. A defer > > thunk is a generated function

Re: [PATCH 40/40] i386: Also enable SSSE3 __m64 tests in 64-bit mode

2019-02-14 Thread Uros Bizjak
On Thu, Feb 14, 2019 at 1:30 PM H.J. Lu wrote: > > Since we now emulate MMX intrinsics with SSE in 64-bit mode, we can > enable SSSE3 __m64 tests even when AVX is enabled. > > PR target/89021 > * gcc.target/i386/ssse3-pabsb.c: Also enable __m64 check in > 64-bit mode. >

Re: [PR fortran/88248, patch] - [F18] Bogus warning about obsolescent feature: Labeled DO statement

2019-02-14 Thread Harald Anlauf
Commited as rev. 268895: Sendinggcc/fortran/ChangeLog Sendinggcc/fortran/symbol.c Sendinggcc/testsuite/ChangeLog Sendinggcc/testsuite/gfortran.dg/f2018_obs.f90 Adding gcc/testsuite/gfortran.dg/pr88248.f90 Transmitting file data .done Committing transacti

[PATCH] v2: Fix excess warnings from -Wtype-limits with location wrappers (PR c++/88680)

2019-02-14 Thread David Malcolm
On Thu, 2019-02-14 at 17:32 +0100, Jakub Jelinek wrote: > On Thu, Feb 14, 2019 at 11:26:15AM -0500, David Malcolm wrote: > > There's an asymmetry in the warning; it's looking for a comparison > > of a > > LHS expression against an RHS constant 0, spelled as "0". > > > > If we fold_for_warn on the

Re: [PATCH 40/40] i386: Also enable SSSE3 __m64 tests in 64-bit mode

2019-02-14 Thread Uros Bizjak
On Thu, Feb 14, 2019 at 9:21 PM Uros Bizjak wrote: > > On Thu, Feb 14, 2019 at 1:30 PM H.J. Lu wrote: > > > > Since we now emulate MMX intrinsics with SSE in 64-bit mode, we can > > enable SSSE3 __m64 tests even when AVX is enabled. > > > > PR target/89021 > > * gcc.target/i386/ss

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread H.J. Lu
On Thu, Feb 14, 2019 at 12:07 PM Uros Bizjak wrote: > > On Thu, Feb 14, 2019 at 1:33 PM H.J. Lu wrote: > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't enable MMX ISA > > by default with TARGET_MMX_WITH_SSE. > > > > For pr82483-1.c and pr82483-2.c, "-mssse3 -mno-mmx" compiles in

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread Uros Bizjak
On Thu, Feb 14, 2019 at 9:50 PM H.J. Lu wrote: > > On Thu, Feb 14, 2019 at 12:07 PM Uros Bizjak wrote: > > > > On Thu, Feb 14, 2019 at 1:33 PM H.J. Lu wrote: > > > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't enable MMX ISA > > > by default with TARGET_MMX_WITH_SSE. > > > > >

Re: [PATCH 40/40] i386: Also enable SSSE3 __m64 tests in 64-bit mode

2019-02-14 Thread H.J. Lu
On Thu, Feb 14, 2019 at 12:43 PM Uros Bizjak wrote: > > On Thu, Feb 14, 2019 at 9:21 PM Uros Bizjak wrote: > > > > On Thu, Feb 14, 2019 at 1:30 PM H.J. Lu wrote: > > > > > > Since we now emulate MMX intrinsics with SSE in 64-bit mode, we can > > > enable SSSE3 __m64 tests even when AVX is enable

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread H.J. Lu
On Thu, Feb 14, 2019 at 12:54 PM Uros Bizjak wrote: > > On Thu, Feb 14, 2019 at 9:50 PM H.J. Lu wrote: > > > > On Thu, Feb 14, 2019 at 12:07 PM Uros Bizjak wrote: > > > > > > On Thu, Feb 14, 2019 at 1:33 PM H.J. Lu wrote: > > > > > > > > Allow MMX intrinsic emulation with SSE/SSE2/SSSE3. Don't

Re: [Committed][PATCH][GCC][Arm] Fix test directive

2019-02-14 Thread Christophe Lyon
On Thu, 14 Feb 2019 at 19:27, Tamar Christina wrote: > > Hi All, > > This patch fixes a failing testcase due to a use of dg-options instead of > dg-additional-options. > Makes sense. It doesn't fail in any of the configurations I test though, in what case do you see it failing? > Committed under

Go patch committed: Copy has_padding field if struct backend type exists

2019-02-14 Thread Ian Lance Taylor
This patch fixes the Go frontend to copy the has_padding field if a struct backend type already exists. The has_padding field is set when creating the struct backend type, and checked when creating a composite literal of that struct type. When two structs shared the same backend type, because the

Re: Fortran vector math header

2019-02-14 Thread Steve Ellcey
On Wed, 2019-02-13 at 12:34 +0100, Martin Liška wrote: > May I please ping this so that we can reach mainline soon? > > Thanks, > Martin Martin, I can't approve this patch but I can say that I have used it on Aarch64 and created a follow up patch for aarch64 to create a get_multilib_abi_name targ

Re: [PATCH][DOC] Document new features for GCC 9.

2019-02-14 Thread Martin Sebor
On 2/13/19 6:48 AM, Martin Liška wrote: Hi. I'm sending patch where I document changes I made during GCC 9 development. I would appreciate both language and factical comments about the patch. Nothing technical, just a few very minor language nits/suggestions. Martin diff --git a/htdocs/gcc-9

[PATCH, d] Committed Add netbsd support to GDC

2019-02-14 Thread Iain Buclaw
Hi, This is a combine of netbsd patches sent by Maya, and related upstream druntime changes. Bootstrapped and regression tested on x86_64-linux-gnu, which only confirms that the scoping is correct. I trust that Maya tested the netbsd-d.c part, nothing looks out of place there anyway. Committed

[PATCH, fortran] PR 81552 Improve and document -flag-init-integer

2019-02-14 Thread Janne Blomqvist
Make the option handling code parse the -flag-init-integer value as a C long type, allowing a larger range on systems where long is a larger type than int. Document the behavior. Regtested on x86_64-pc-linux-gnu, committed as obvious. 2019-02-14 Janne Blomqvist PR fortran/81552

[PATCH, testsuite]: Re-enable 64-bit form in gcc.target/i386/ssse3-*.c on AVX targets

2019-02-14 Thread Uros Bizjak
2019-02-14 Uroš Bizjak * gcc.target/i386/ssse3-pabsb.c: Re-enable 64-bit form on AVX targets. * gcc.target/i386/ssse3-pabsd.c: Ditto. * gcc.target/i386/ssse3-pabsw.c: Ditto. * gcc.target/i386/ssse3-palignr.c: Ditto. * gcc.target/i386/ssse3-phaddd.c: Ditto. * gcc.target/i

[PATCH 1/7] Don't offer suggestions for compiler-generated variables (PR c++/85515)

2019-02-14 Thread David Malcolm
gcc/cp/ChangeLog: Backport of r259720 from trunk. 2018-04-27 David Malcolm PR c++/85515 * name-lookup.c (consider_binding_level): Skip compiler-generated variables. * search.c (lookup_field_fuzzy_info::fuzzy_lookup_field): Flatten nested i

[PATCH 4/7] docs: fix stray duplicated words

2019-02-14 Thread David Malcolm
gcc/ChangeLog: Backport of 263295 from trunk. 2018-08-03 David Malcolm * doc/gcov.texi (-x): Remove duplicate "to". * doc/invoke.texi (-Wnoexcept-type): Remove duplicate "calls". (-Wif-not-aligned): Remove duplicate "is". (-flto): Remove duplicate

Backport of various patches to gcc 8

2019-02-14 Thread David Malcolm
It's not clear to me what the rules are on backports (do I need approval, or re-review?) but the following have all been bootstrapped and regression-tested relative to today's gcc-8-branch (on x86_64-pc-linux-gnu): r259720: "Don't offer suggestions for compiler-generated variables (PR c++/85515)"

[PATCH 2/7] C++: don't offer bogus "._0" suggestions (PR c++/86329)

2019-02-14 Thread David Malcolm
PR c++/86329 reports that the C++ frontend can offer bogus suggestions like: #include int compare() { return __n1 - __n2; } suggested.cc: In function 'int compare()': suggested.cc:5:10: error: '__n1' was not declared in this scope return __n1 - __n2; ^~~~ suggested.cc:5

[PATCH 7/7] C++ concepts: fix ICE with requires on dtors (PR c++/89036)

2019-02-14 Thread David Malcolm
PR c++/89036 reports an ICE due to this assertion failing 1136 /* A class should never have more than one destructor. */ 1137 gcc_assert (!current_fns || via_using || !DECL_DESTRUCTOR_P (method)); on this template with a pair of dtors, with mutually exclusive "requires" clauses: templ

[PATCH 6/7] Fix ICE on class-template argument deduction (PR c++/88795)

2019-02-14 Thread David Malcolm
PR c++/88795 reports an ICE building a function_type for a deduction guide when the substitution into the function signature fails, due to an error_mark_node being returned from tsubst_arg_types but not being checked for. This error_mark_node gets used as the TYPE_ARG_TYPES, leading to ICEs in var

[PATCH 3/7] Fix memory leak of pretty_printer prefixes

2019-02-14 Thread David Malcolm
We were rather sloppy about handling the ownership of prefixes for pretty_printer, and this lead to a memory leak for any time a diagnostic_show_locus call emits multiple line spans. This showed up in "make selftest-valgrind" as: 3,976 bytes in 28 blocks are definitely lost in loss record 632 of

[PATCH 5/7] Fix memory leak in selftest::test_expansion_to_rtl

2019-02-14 Thread David Malcolm
"make selftest-valgrind" shows: 187 bytes in 1 blocks are definitely lost in loss record 567 of 669 at 0x4A081D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x1F08260: xcalloc (xmalloc.c:162) by 0xB24F32: init_emit() (emit-rtl.c:5843) by 0xC10080: prepare

Re: [PATCH][DOC] Document new features for GCC 9.

2019-02-14 Thread David Malcolm
On Thu, 2019-02-14 at 14:19 -0700, Martin Sebor wrote: > On 2/13/19 6:48 AM, Martin Liška wrote: > > Hi. > > > > I'm sending patch where I document changes I made during GCC 9 > > development. I would appreciate both language and factical comments > > about the patch. > > Nothing technical, just

Re: Backport of various patches to gcc 8

2019-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2019 at 06:23:37PM -0500, David Malcolm wrote: > It's not clear to me what the rules are on backports (do > I need approval, or re-review?) but the following have > all been bootstrapped and regression-tested relative to > today's gcc-8-branch (on x86_64-pc-linux-gnu): > > r259720:

[PATCH] Fix tree-loop-distribution.c ICE with -ftrapv (PR tree-optimization/89278)

2019-02-14 Thread Jakub Jelinek
Hi! The following testcase ICEs, because we try to gimplify a complex expression that with -ftrapv wants to emit multiple bbs. Fixed by using rewrite_to_non_trapping_overflow. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk and 8.3? 2019-02-14 Richard Biener J

[PATCH] Fix ICE with optimize("Ofast") due to option handling (PR other/89342)

2019-02-14 Thread Jakub Jelinek
Hi! We ICE on the following testcase, because while we save optimize, and optimize_{size,debug} vars during option saving/restoring, we don't save optimize_fast, and because of that end up with optimize 0 optimize_fast 1 which the option handling code ICEs on - if (fast) gcc_assert (level =

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread Uros Bizjak
On Thu, Feb 14, 2019 at 10:02 PM H.J. Lu wrote: > > > > > gcc/ > > > > > > > > > > PR target/89021 > > > > > * config/i386/i386-builtin.def: Enable MMX intrinsics with > > > > > SSE/SSE2/SSSE3. > > > > > * config/i386/i386.c (ix86_option_override_internal): Don't >

[C PATCH] Reject weak nested functions (PR c/89340)

2019-02-14 Thread Jakub Jelinek
Hi! We ICE on the following testcase, because C nested functions are turned into !TREE_PUBLIC ones very soon, and the IPA code asserts that DECL_WEAK functions are either TREE_PUBLIC or DECL_EXTERNAL. As we reject static __attribute__((weak)) void foo () {}, I think we should reject weak nested f

Re: [C++ PATCH] preview: Fix braces around scalar initializer (C++/88572) Inbox x

2019-02-14 Thread Jason Merrill
On 2/12/19 6:04 PM, will wray wrote: A proposed patch for Bug 88572 is attached to the bug report along with a short description and Change Log (a link there gives a pretty diff of the patch): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88572#c15 I'd appreciate any review of this patch, as wel

Re: [PATCH][DOC] Document new features for GCC 9.

2019-02-14 Thread Martin Sebor
On 2/14/19 3:37 PM, David Malcolm wrote: On Thu, 2019-02-14 at 14:19 -0700, Martin Sebor wrote: On 2/13/19 6:48 AM, Martin Liška wrote: Hi. I'm sending patch where I document changes I made during GCC 9 development. I would appreciate both language and factical comments about the patch. Noth

Re: [PATCH 37/40] i386: Allow MMX intrinsic emulation with SSE

2019-02-14 Thread H.J. Lu
On Thu, Feb 14, 2019 at 2:57 PM Uros Bizjak wrote: > > On Thu, Feb 14, 2019 at 10:02 PM H.J. Lu wrote: > > > > > > > gcc/ > > > > > > > > > > > > PR target/89021 > > > > > > * config/i386/i386-builtin.def: Enable MMX intrinsics with > > > > > > SSE/SSE2/SSSE3. > > > > > >

<    1   2