Re: [PATCH, libstdc++] Implement P0415 More constexpr for std::complex.

2018-11-26 Thread Christophe Lyon
On Thu, 22 Nov 2018 at 10:20, Jonathan Wakely wrote: > > On 20/11/18 17:58 -0500, Ed Smith-Rowland wrote: > >On 11/19/18 6:13 AM, Jonathan Wakely wrote: > >>On 16/11/18 19:39 -0500, Ed Smith-Rowland wrote: > >>>@@ -322,67 +323,43 @@ > >>> //@{ > >>> /// Return new complex value @a x plus @a y.

not posted ada patch breaks ada build on alpha-linux-gnu

2018-11-26 Thread Matthias Klose
r266136 broke the ada build on alpha-linux-gnu, filed as PR88191. I didn't find this patch posted to gcc-patches. Matthias

[PATCH] PR880088 Enable -Wtrampolines for no-exec-stack targets with -Wall.

2018-11-26 Thread Mark Wielaard
With -Wtrampolines a warning is produced whenever gcc generates executable code on the stack at runtime to support taking a nested function address that is used to call the nested function indirectly when it needs to access any variables in its lexical scope. As a result the stack has to be marked

[patch] [jit] Fix compilation of jit test with -Wformat-security

2018-11-26 Thread Matthias Klose
test-long-names.c fails to build when -Wformat-security is turned on. Fixed by the below patch. Alternatives would be to use a plain strcpy, or to turn off the option in a dg header. Ok to commit, including active branches? Matthias gcc/testsuite/ 2018-11-26 Matthias Klose * jit.dg/test-lo

Re: not posted ada patch breaks ada build on alpha-linux-gnu

2018-11-26 Thread Arnaud Charlet
> r266136 broke the ada build on alpha-linux-gnu, filed as PR88191. I didn't > find this patch posted to gcc-patches. Thanks for the heads up. This is this change: [Ada] Update signal constants for GNU/Linux Add the signal SIGSYS and mark the glibc reserved real-time signals (32-34) as reserve

Re: [PATCH, libgcc/ARM & testsuite, ping] Optimize executable size when using softfloat fmul/dmul

2018-11-26 Thread Thomas Preudhomme
Ping? Best regards, Thomas On Mon, 19 Nov 2018 at 10:51, Thomas Preudhomme wrote: > > FWIW, the testcases were taken from > https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01026.html > > Previous approach for fixing tying of fmul to fdiv can be seen in > https://gcc.gnu.org/ml/gcc-patches/2015-04

Re: [PATCH, ARM, ping] Improve robustness of -mslow-flash-data

2018-11-26 Thread Thomas Preudhomme
Ping? Best regards, Thomas On 19/11/2018 17:56, Thomas Preudhomme wrote: Hi, Current code to handle -mslow-flash-data in machine description files suffers from a number of issues which this patch fixes: 1) The insn_and_split in vfp.md to load a generic floating-point constant via GPR first a

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

2018-11-26 Thread Christophe Lyon
Ping? Thanks On Fri, 16 Nov 2018 at 16:48, Christophe Lyon wrote: > > From: Christophe Lyon > > Hello, > > This patch series implements the GCC contribution of the FDPIC ABI for > ARM targets. > > This ABI enables to run Linux on ARM MMU-less cores and supports > shared libraries to reduce the

Re: [patch] [jit] Fix compilation of jit test with -Wformat-security

2018-11-26 Thread David Malcolm
On Mon, 2018-11-26 at 10:20 +0100, Matthias Klose wrote: > test-long-names.c fails to build when -Wformat-security is turned > on. Fixed by > the below patch. Alternatives would be to use a plain strcpy, or to > turn off the > option in a dg header. Ok to commit, including active branches? > > Ma

Re: [PATCH] x86: Add -march=cascadelake

2018-11-26 Thread Martin Liška
On 11/24/18 12:34 AM, Andi Kleen wrote: > Uros Bizjak writes: > >> On Thu, Nov 22, 2018 at 12:48 PM Martin Liška wrote: >>> >>> On 11/22/18 8:07 AM, Wei Xiao wrote: Jakub, Thanks for the comments! I have addressed them as attached. >>> >>> Hi. >>> >>> Can you please add the n

Re: [PATCH, libstdc++] Implement P0415 More constexpr for std::complex.

2018-11-26 Thread Jonathan Wakely
On 26/11/18 09:30 +0100, Christophe Lyon wrote: On Thu, 22 Nov 2018 at 10:20, Jonathan Wakely wrote: On 20/11/18 17:58 -0500, Ed Smith-Rowland wrote: >On 11/19/18 6:13 AM, Jonathan Wakely wrote: >>On 16/11/18 19:39 -0500, Ed Smith-Rowland wrote: >>>@@ -322,67 +323,43 @@ >>> //@{ >>> /// Ret

Re: [PATCH] x86: Add -march=cascadelake

2018-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2018 at 12:03:53PM +0100, Martin Liška wrote: > > For Cascade Lake the model number is the same as Skylake Server, > > it can only be distinguished based on the stepping (5 vs 4) > > Very interesting, probably the first time a distinguish is based on stepping > number? Wouldn't

Re: [PATCH, libstdc++] Uniform container erasure for c++20.

2018-11-26 Thread Jonathan Wakely
On 24/11/18 13:54 -0500, Ed Smith-Rowland wrote: All, I's very late but uniform container erasure is, I think, the last little tidbit to graduate from fundamentals/v2 to std at the last meeting.  I think it would be a shame not to nudge this into gcc-9.  The routines are very short so I just

Re: Fix hashtable memory leak

2018-11-26 Thread Jonathan Wakely
On 24/11/18 22:58 +0100, François Dumont wrote: Tests have shown a regression. I was building the _ReuseOrAllocNode instance too early, node ownership was transfered but was still owned by _Hashtable instance. This new version pass all tests. This is why it's worth waiting until tests have r

[PATCH v4] Repeat jump threading after combine

2018-11-26 Thread Ilya Leoshkevich
Bootstrapped and regtested on x86_64-redhat-linux, s390x-redhat-linux and ppc64le-redhat-linux. Previous iteration: https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00495.html In the end, the main question was: does this make the code better on architectures other than s390? https://gcc.gnu.org/ml/g

Re: Fix hashtable memory leak

2018-11-26 Thread Jonathan Wakely
On 24/11/18 22:58 +0100, François Dumont wrote: --- a/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/move_assign.cc +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/allocator/move_assign.cc @@ -18,6 +18,8 @@ // { dg-do run { target c++11 } } #include +#include + #includ

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Martin Liška
On 11/23/18 7:08 PM, Joseph Myers wrote: > In the multiarch case, do you want > /include/finclude/ or > /include//finclude? (This is where I'd hope Debian > / Ubuntu GCC people would comment.) Mathias can you please reply to this? Thanks, Martin

Re: Fix hashtable memory leak

2018-11-26 Thread Jonathan Wakely
On 26/11/18 12:03 +, Jonathan Wakely wrote: On 24/11/18 22:58 +0100, François Dumont wrote: Tests have shown a regression. I was building the _ReuseOrAllocNode instance too early, node ownership was transfered but was still owned by _Hashtable instance. This new version pass all tests.

Re: [PATCH] PR880088 Enable -Wtrampolines for no-exec-stack targets with -Wall.

2018-11-26 Thread Paul Koning
> On Nov 26, 2018, at 4:13 AM, Mark Wielaard wrote: > > With -Wtrampolines a warning is produced whenever gcc generates executable > code on the stack at runtime to support taking a nested function address > that is used to call the nested function indirectly when it needs to access > any vari

Re: not posted ada patch breaks ada build on alpha-linux-gnu

2018-11-26 Thread Matthias Klose
On 26.11.18 10:22, Arnaud Charlet wrote: >> r266136 broke the ada build on alpha-linux-gnu, filed as PR88191. I didn't >> find this patch posted to gcc-patches. > > Thanks for the heads up. > > This is this change: > > [Ada] Update signal constants for GNU/Linux > > Add the signal SIGSYS and m

Re: not posted ada patch breaks ada build on alpha-linux-gnu

2018-11-26 Thread Arnaud Charlet
> that fixes the build, taken from the sparc64 file. not sure if that is > appropriate. The patch looks good, you can go ahead and commit it. > --- gcc/ada/libgnarl/s-linux__alpha.ads (revision 266457) > +++ gcc/ada/libgnarl/s-linux__alpha.ads (working copy) > @@ -87,6 +87,7 @@ >

Re: not posted ada patch breaks ada build on alpha-linux-gnu

2018-11-26 Thread Matthias Klose
On 26.11.18 14:30, Arnaud Charlet wrote: >> that fixes the build, taken from the sparc64 file. not sure if that is >> appropriate. > > The patch looks good, you can go ahead and commit it. done. >> The build continues, but then fails with: >> >> /home/packages/cross/9/p/gcc-cross-ports/gcc/build

Re: [PATCH] x86: Add -march=cascadelake

2018-11-26 Thread Martin Liška
On 11/26/18 12:18 PM, Jakub Jelinek wrote: > On Mon, Nov 26, 2018 at 12:03:53PM +0100, Martin Liška wrote: >>> For Cascade Lake the model number is the same as Skylake Server, >>> it can only be distinguished based on the stepping (5 vs 4) >> >> Very interesting, probably the first time a distingui

[PATCH] Added information about inline assembler in stack calculations (.su files)

2018-11-26 Thread Torbjorn SVENSSON
Hi, Attached is a small patch that, in case of inline assembler code, indicates that the function stack usage is uncertain due to inline assembler. The test suite are using "nop" as an assembler instruction on all targets, is this acceptable or is there a better way to test this? Patch has be

Re: [PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-26 Thread Martin Liška
On 11/23/18 6:10 PM, Martin Sebor wrote: > On 11/23/18 8:06 AM, Martin Liška wrote: >> Hi. >> >> It's patch proposal that suggests to use an enum instead of 'int endp' for >> functions that expand memory move builtins. I've touch the code multiple >> times >> and it always take me time to realize

Re: [PATCH] PR880088 Enable -Wtrampolines for no-exec-stack targets with -Wall.

2018-11-26 Thread Mark Wielaard
On Mon, 2018-11-26 at 08:19 -0500, Paul Koning wrote: > > On Nov 26, 2018, at 4:13 AM, Mark Wielaard wrote: > > > > With -Wtrampolines a warning is produced whenever gcc generates > > executable > > code on the stack at runtime to support taking a nested function > > address > > that is used to c

[Committed] S/390: Document z14/arch12 -march option.

2018-11-26 Thread Andreas Krebbel
gcc/ChangeLog: 2018-11-26 Andreas Krebbel * doc/invoke.texi: Document z14/arch12 -march option. --- gcc/doc/invoke.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 38e27a5..e70db55 100644 --- a/gcc/doc/invoke.

Re: [PATCH v4] Repeat jump threading after combine

2018-11-26 Thread Segher Boessenkool
Hi! On Mon, Nov 26, 2018 at 01:11:40PM +0100, Ilya Leoshkevich wrote: > In the end, the main question was: does this make the code better on > architectures other than s390? > https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00993.html Yup. > - Code size decreases in most cases. In general, the ma

Re: [PATCH v4] Repeat jump threading after combine

2018-11-26 Thread Ilya Leoshkevich
> Am 26.11.2018 um 16:07 schrieb Segher Boessenkool > : > >> # ppc64le-redhat-linux: >> 511.povray_r -1.29% >> 482.sphinx3-0.65% >> 456.hmmer -0.53% >> 519.lbm_r -0.51% >> # skip |dt| < 0.5% >> 549.fotonik3d_r+1.13% >> 403.gcc+1.76% >> 500.perlbench

[PATCH] Fix PR88182

2018-11-26 Thread Richard Biener
With the relatex outer loop reduction support we need to avoid picking up a different nested cycles reduction def. That's easy given we record the PHI we are looking at - almost, at least. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-11-26 Richard Bien

Re: [PATCH, libgcc/ARM & testsuite, ping] Optimize executable size when using softfloat fmul/dmul

2018-11-26 Thread Mike Stump
On Nov 26, 2018, at 1:46 AM, Thomas Preudhomme wrote: > Ping? The testsuite parts are Ok. > On Mon, 19 Nov 2018 at 10:51, Thomas Preudhomme > wrote: >> >> FWIW, the testcases were taken from >> https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01026.html

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Matthias Klose
On 26.11.18 13:20, Martin Liška wrote: > On 11/23/18 7:08 PM, Joseph Myers wrote: >> In the multiarch case, do you want >> /include/finclude/ or >> /include//finclude? (This is where I'd hope Debian >> / Ubuntu GCC people would comment.) > > Mathias can you please reply to this? this should n

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Martin Liška
On 11/26/18 5:19 PM, Matthias Klose wrote: > On 26.11.18 13:20, Martin Liška wrote: >> On 11/23/18 7:08 PM, Joseph Myers wrote: >>> In the multiarch case, do you want >>> /include/finclude/ or >>> /include//finclude? (This is where I'd hope Debian >>> / Ubuntu GCC people would comment.) >> >> M

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Martin Liška
On 11/23/18 7:08 PM, Joseph Myers wrote: > On Fri, 23 Nov 2018, Martin Liška wrote: > >> Looks the problematic is quite complex as I can understand. I prepared a >> patch >> that should hopefully follow advises provided. Hello. > > I don't see how this version ensures that NATIVE_SYSTEM_HEADER

C++ PATCH for c++/88120, ICE with save_expr in template

2018-11-26 Thread Marek Polacek
The problem here was that we were calling save_expr in a template, which we shouldn't, as the comment in cp_save_expr explains. This problem only appears on ptrmemfunc_vbit_in_delta targets. Bootstrapped/regtested on aarch64-linux, ok for trunk? 2018-11-26 Marek Polacek PR c++/88120

Re: [doc,committed] clarify docs for function attribute "const"

2018-11-26 Thread Martin Sebor
On 11/25/18 6:40 PM, Sandra Loosemore wrote: I've checked in the attached patch for PR79738. I think we have lost something important with the clarification of attribute const: The @code{const} attribute imposes greater restrictions on a function's definition than the similar @code{pure} a

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-11-26 Thread Joseph Myers
On Fri, 23 Nov 2018, Martin Sebor wrote: > I have now committed this patch as r266418. This commit introduced spurious warnings that break the glibc testsuite build. bug-ungetwc2.c:62:17: error: '%ls' directive argument is not a nul-terminated string [-Werror=format-overflow=] 62 | fprint

[PATCH, libphobos] Committed fix backtraces in Fibers on AArch64

2018-11-26 Thread Iain Buclaw
Hi, This patch is backported from druntime 2.083, in continuation of finishing off AArch64 library support. When throwing an Exception in the Fiber the backtrace generation crashes. This happens because backtrace does not func the stack bottom. Using '.cfi_undefined x30' tells the debug info th

Re: [PATCH][GCC][DOC] Remove obsolete arm and aarch64 CPU names from invoke.texi

2018-11-26 Thread Kyrill Tkachov
Hi Sam, On 23/11/18 16:55, Sam Tebbs wrote: Hi all, The mtune= documentation in doc/invoke.texi contains some obsolete CPU names that have been removed from the Arm and AArch64 backends. This patch removes them. All removed CPU names: * arm2 * arm250 * arm3 * ar

[PATCH][arm][1/3] Rename mul64 attr to widen_mul64

2018-11-26 Thread Kyrill Tkachov
Hi all, The mul64 attribute in types.md causes some confusion as it is used to represent aarch32 instructions that do widening multiplication to generate 32->64 bit results. But these types are shared with aarch64, which has native 64-bit multiplication operations. Those are currently not prop

[PATCH][AArch64][2/3] Correct type attribute for mul and mneg instructions

2018-11-26 Thread Kyrill Tkachov
Hi all, In the AAarch64 ISA the MUL and MNEG instructions are actually aliases of MADD and MSUB. Therefore they should have the type attribute mla, rather than mul, which should only be used for AArch32 32-bit multiplication instructions. This will ensure more consistent scheduling decisions.

[PATCH][AArch64][3/3] Introduce mla64 type

2018-11-26 Thread Kyrill Tkachov
Hi all, On some cores the X-register MADD/MSUB (and hence MUL and MNEG) instructions may behave differently than the W-register forms and the scheduling models may want to reflect that. That is currently not possible because both sizes use the mla scheduling type. This patch introduces the mla6

Re: [PATCH v3] [aarch64] Add CPU support for Ampere Computing's eMAG.

2018-11-26 Thread Kyrill Tkachov
Hi Christoph, On 22/11/18 08:00, Christoph Müllner wrote: On 11/22/18 8:54 AM, Andrew Pinski wrote: One small comment. On Tue, Nov 20, 2018 at 10:01 AM Christoph Muellner wrote: Tested with "make check" and no regressions found. This patch depends on the struct xgene1_prefetch_tune, which

[PATCH][AArch64][committed] Fix typo in aarch64_mangle_type

2018-11-26 Thread Kyrill Tkachov
Committing as obvious. Thanks, Kyrill 2018-11-26 Kyrylo Tkachov * config/aarch64/aarch64.c (aarch64_mangle_type): Fix typo in comment. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 77d12603e3b9bfdf0f65733162a4320ffc9239f7..58858ef935ba744e6e50b9ceb8cdf182

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-11-26 Thread Rainer Orth
Hi Martin, > I have now committed this patch as r266418. this patch has created a bunch of XPASSes everywhere: +XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for warnings, line 119) +XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for warnings, line 120) +XPASS: g

[PATCH/coding style] clarify pointers and operators

2018-11-26 Thread Martin Sebor
Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators. Below is the patch. As an aside, regarding the space convention in casts: a crude grep search yields about 10,000 instances of the

Re: [doc,committed] clarify docs for function attribute "const"

2018-11-26 Thread Sandra Loosemore
On 11/26/18 10:17 AM, Martin Sebor wrote: On 11/25/18 6:40 PM, Sandra Loosemore wrote: I've checked in the attached patch for PR79738. I think we have lost something important with the clarification of attribute const:   The @code{const} attribute imposes greater restrictions on   a functio

[doc, committed] document that -freorder-functions also uses hot/cold attributes

2018-11-26 Thread Sandra Loosemore
I've checked in this patch for PR 57182. -Sandra 2018-11-26 Sandra Loosemore PR c/57182 gcc/ * doc/invoke.texi (Optimize Options): Document that -freorder-functions also uses "hot" and "cold" attributes. Index: gcc/doc/invoke.texi =

Re: [PATCH] PR880088 Enable -Wtrampolines for no-exec-stack targets with -Wall.

2018-11-26 Thread Joseph Myers
On Mon, 26 Nov 2018, Mark Wielaard wrote: > Define a new target macro TARGET_HAS_DEFAULT_NOEXEC_STACK for those targets > that have a non-executable default stack based on when they call > file_end_indicate_exec_stack. Some targets (e.g. ia64) may default to no-exec stacks without needing that h

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Joseph Myers
On Mon, 26 Nov 2018, Martin Liška wrote: > The header file will be install by glibc (glibc-devel package). To confirm: you intend to submit a patch to glibc upstream to install this file (rather than it only being something in distribution packaging)? -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

2018-11-26 Thread Joseph Myers
On Mon, 26 Nov 2018, Martin Liška wrote: > > I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is > > properly sysrooted. Note there's add_sysrooted_prefix separate from > > add_prefix (but that's *not* the correct thing to use here because it uses > > target_sysroot_suffix wh

Re: [PATCH] PR880088 Enable -Wtrampolines for no-exec-stack targets with -Wall.

2018-11-26 Thread Mark Wielaard
On Mon, 2018-11-26 at 18:29 +, Joseph Myers wrote: > On Mon, 26 Nov 2018, Mark Wielaard wrote: > > > Define a new target macro TARGET_HAS_DEFAULT_NOEXEC_STACK for those > > targets > > that have a non-executable default stack based on when they call > > file_end_indicate_exec_stack. > > Some

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-11-26 Thread Martin Sebor
On 11/26/18 10:27 AM, Joseph Myers wrote: On Fri, 23 Nov 2018, Martin Sebor wrote: I have now committed this patch as r266418. This commit introduced spurious warnings that break the glibc testsuite build. bug-ungetwc2.c:62:17: error: '%ls' directive argument is not a nul-terminated string

[PATCH v3] [aarch64] Correct the maximum shift amount for shifted operands.

2018-11-26 Thread Christoph Muellner
The aarch64 ISA specification allows a left shift amount to be applied after extension in the range of 0 to 4 (encoded in the imm3 field). This is true for at least the following instructions: * ADD (extend register) * ADDS (extended register) * SUB (extended register) The result of this patc

Re: [PATCH 10/10] Port testsuite to GCN

2018-11-26 Thread Mike Stump
On Nov 20, 2018, at 5:00 PM, Jeff Law wrote: > > On 11/16/18 9:29 AM, Andrew Stubbs wrote: >> This collection of miscellaneous patches configures the testsuite to run on >> AMD >> GCN in a standalone (i.e. not offloading) configuration. It assumes you have >> your Dejagnu set up to run binaries

Re: [PATCH 3/7][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-26 Thread Mike Stump
On Nov 14, 2018, at 7:48 AM, Jozef Lawrynowicz wrote: > > Patch 3 sets up require-effective-target directives for tests which > require the compilation of large arrays. Ok.

Re: [PATCH 3/7][v2][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-26 Thread Mike Stump
On Nov 21, 2018, at 2:39 PM, Jozef Lawrynowicz wrote: > > On Wed, 14 Nov 2018 15:41:00 + > Jozef Lawrynowicz wrote: > >> Patch 3 sets up require-effective-target directives for tests which >> require the compilation of large arrays. >> Targets which have 16-bit or 20-bit size_t fail to comp

Re: [PATCH 6/7][MSP430][TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io

2018-11-26 Thread Mike Stump
On Nov 14, 2018, at 7:58 AM, Jozef Lawrynowicz wrote: > > Patch 6 fixes tests expecting printf float support for targets which have been > configured with "newlib-nano-formatted-io". When newlib is configured in this > way, float printf is enabled at build time by registering _printf_float as an

Re: [PATCH 4/7][MSP430][TESTSUITE] Fix tests when int is 16-bit by default

2018-11-26 Thread Mike Stump
On Nov 14, 2018, at 7:52 AM, Jozef Lawrynowicz wrote: > > Patch 4 fixes tests when int is 16-bits by default. Ok,

Re: [PATCH/coding style] clarify pointers and operators

2018-11-26 Thread Jeff Law
On 11/26/18 10:59 AM, Martin Sebor wrote: > Martin suggested we update the Coding Conventions to describe > the expected style for function declarations with a pointer > return types, and for overloaded operators.  Below is the patch. THanks. That's fine. > > As an aside, regarding the space con

[PATCH] Fix ICEs on invalid rs6000 asm (PR target/88188)

2018-11-26 Thread Jakub Jelinek
Hi! The following patch fixes a bunch of ICEs in rs6000 print_operand; we shouldn't ICE on them when users write mess in their inline asm. Bootstrapped/regtested on powerpc64{,le}-linux (including -m32 testing on powerpc64-linux), ok for trunk? 2018-11-26 Jakub Jelinek PR target/8818

Re: [PATCH][RFC] Come up with memop_ret enum instead of int endp for memory operations.

2018-11-26 Thread Jeff Law
On 11/26/18 7:03 AM, Martin Liška wrote: > On 11/23/18 6:10 PM, Martin Sebor wrote: >> On 11/23/18 8:06 AM, Martin Liška wrote: >>> Hi. >>> >>> It's patch proposal that suggests to use an enum instead of 'int endp' for >>> functions that expand memory move builtins. I've touch the code multiple >>

[C++ PATCH] Fix ICE in grokdeclarator (PR c++/88187)

2018-11-26 Thread Jakub Jelinek
Hi! Marek has changed grokdeclarator in r263836, so that in this part of code it is either a funcdecl_p (previously the only allowed one), which implies inner_declarator is non-NULL and therefore unqualified_id too, or newly inner_declarator == NULL. In that case, we IMHO shouldn't be testing for

Re: [PATCH 5/7][MSP430][TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests

2018-11-26 Thread Mike Stump
On Nov 14, 2018, at 7:56 AM, Jozef Lawrynowicz wrote: > > Patch 5 deals with ISO C errors emitted by tests when the large memory model > is > used. size_t and ptrdiff_t are __int20 with -mlarge, and if the test is > compiled with -pedantic-errors and -std=* or -ansi, then use of these types > ca

[PATCH] Fix ptwrite64 handling with -m32 (PR target/88195)

2018-11-26 Thread Jakub Jelinek
Hi! The following patch makes def_builtin2 behave consistently wrt. OPTION_MASK_ISA_64BIT requirement to def_builtin. The latter has: tree decl = NULL_TREE; if (!(mask & OPTION_MASK_ISA_64BIT) || TARGET_64BIT) { ... } return decl; and so if some builtin requires TARGET_64BIT, it is

[PATCH, i386]: Fix PR 88178, ICE in dbx_reg_number, at dwarf2out.c

2018-11-26 Thread Uros Bizjak
2018-11-26 Uros Bizjak PR target/88178 * config/i386/i386.c (dbx_register_map): Use IGNORED_DWARF_REGNUM for registers for which no debug information can be generated. Use INVALID_REGNUM for non-existent registers. (dbx64_register_map): Ditto. (svr4_dbx_register_map): Di

[C++ PATCH] Propagate TYPE_PACKED to template variants (PR c++/88181)

2018-11-26 Thread Jakub Jelinek
Hi! On the following patch -fpack-struct forces TYPE_PACKED on all the classes and their variants, but we then create a variant of a class instantiation (const) which doesn't have the TYPE_PACKED set and later finalize the template main variant, but don't propagate that to the already created vari

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-11-26 Thread Martin Sebor
In the committed patch I forgot that the CONSTRUCTOR to STRING_CST transformation introduced this summer only takes place for arrays of char and not also those of wide characters. That resulted in sprintf incorrectly getting STRING_CSTs for individual elements of constant wide character arrays li

[PATCH] Fix dwarf5 -ffunction-section with hot/cold partitioning (PR c++/86900)

2018-11-26 Thread Jakub Jelinek
Hi! The following testcase fails to assemble, because with -ffunction-sections and hot/cold partitioning, secname_for_decl returns the same section for both the hot and cold partition, even when we actually use two different sections - .text._Z3fooi and .text.unlikely._Z3fooi. If the secname is t

Re: [PATCH] Fix PR88182

2018-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2018 at 04:36:26PM +0100, Richard Biener wrote: > > With the relatex outer loop reduction support we need to avoid picking > up a different nested cycles reduction def. That's easy given we > record the PHI we are looking at - almost, at least. Thanks for fixing it. Just a nit,

[committed] Tweak libgomp env vars in parallel make check (take 2)

2018-11-26 Thread Jakub Jelinek
On Fri, Nov 23, 2018 at 03:09:49PM +0100, Jakub Jelinek wrote: > On Fri, Nov 23, 2018 at 02:57:44PM +0100, Martin Liška wrote: > > > Unfortunately, haven't figured out how to convince automake that I want to > > > write my own check-am goal, so had to drop dejagnu automake option and > > > add all

Re: [PATCH] Fix dwarf5 -ffunction-section with hot/cold partitioning (PR c++/86900)

2018-11-26 Thread Jeff Law
On 11/26/18 2:00 PM, Jakub Jelinek wrote: > Hi! > > The following testcase fails to assemble, because with -ffunction-sections > and hot/cold partitioning, secname_for_decl returns the same section > for both the hot and cold partition, even when we actually use two different > sections - .text._Z

[PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-26 Thread Aaron Sawdey
When I previously added the use of unaligned vsx stores to inline expansion of memset, I didn't do a good job of managing boundary conditions. The intention was to only use unaligned vsx if the block being cleared was more than 32 bytes. What it actually did was to prevent the use of unaligned vsx

Re: [PATCH 10/10] Port testsuite to GCN

2018-11-26 Thread Mike Stump
On Nov 26, 2018, at 12:04 PM, Mike Stump wrote: > > I'll Ok the signal one, if you prefer it over a dummy signal routine. > Though, would be nice for you to add signal if possible/reasonable. Oh, and my long term thinking on signal is that logically, it's fine to have: #if __has_include("sign

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-11-26 Thread Jeff Law
On 11/26/18 1:55 PM, Martin Sebor wrote: > In the committed patch I forgot that the CONSTRUCTOR to STRING_CST > transformation introduced this summer only takes place for arrays > of char and not also those of wide characters.  That resulted in > sprintf incorrectly getting STRING_CSTs for individu

Re: [PATCH] target/58397: add host_hooks for NetBSD to make precompiled headers work

2018-11-26 Thread Jeff Law
On 11/25/18 1:13 PM, Maya Rashish wrote: > --- > gcc/config.host | 4 ++ > gcc/config/host-netbsd.c | 85 > gcc/config/x-netbsd | 4 ++ > 3 files changed, 93 insertions(+) > create mode 100644 gcc/config/host-netbsd.c > create mode 100644

Re: [PATCH] Fix up method-nonnull-1.mm testcase on Solaris (PR testsuite/88090)

2018-11-26 Thread Mike Stump
On Nov 20, 2018, at 12:36 PM, Jakub Jelinek wrote: > > The following testcase fails on Solaris, because it doesn't print there > 'size_t', but 'std::size_t', as the type is defined by system headers and > it is not under gcc control how exactly is size_t defined. > > The following patch fixes th

Re: [PATCH] Fix ptwrite64 handling with -m32 (PR target/88195)

2018-11-26 Thread Uros Bizjak
On Mon, Nov 26, 2018 at 9:52 PM Jakub Jelinek wrote: > > Hi! > > The following patch makes def_builtin2 behave consistently wrt. > OPTION_MASK_ISA_64BIT requirement to def_builtin. > The latter has: > tree decl = NULL_TREE; > > if (!(mask & OPTION_MASK_ISA_64BIT) || TARGET_64BIT) > { > ...

Re: [PATCH 3/7][v2][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-26 Thread Jozef Lawrynowicz
On Mon, 26 Nov 2018 12:20:10 -0800 Mike Stump wrote: > On Nov 21, 2018, at 2:39 PM, Jozef Lawrynowicz > wrote: > > > > On Wed, 14 Nov 2018 15:41:00 + > > Jozef Lawrynowicz wrote: > > > >> Patch 3 sets up require-effective-target directives for tests which > >> require the compilation o

Ping: [PATCH] update-copyright.py: Add filters for D language sources

2018-11-26 Thread Iain Buclaw
Hi, This adds filters for upstream dmd, druntime, and phobos libraries, so that the update-copyright script doesn't complain or try to update the copyright years for those files. OK for trunk? -- Iain --- contrib/ChangeLog: 2018-11-13 Iain Buclaw * update-copyright.py (TestsuiteFilt

Re: Ping: [PATCH] update-copyright.py: Add filters for D language sources

2018-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2018 at 10:32:40PM +0100, Iain Buclaw wrote: > Hi, > > This adds filters for upstream dmd, druntime, and phobos libraries, so > that the update-copyright script doesn't complain or try to update the > copyright years for those files. > > OK for trunk? > -- > Iain > > --- > contri

Go patch committed: Initial support for exporting function bodies

2018-11-26 Thread Ian Lance Taylor
This patch to the Go frontend adds initial support for exporting function bodies. It creates a framework for putting function bodies in export data. At present only empty functions will be put there, and they will be ignored on import. Later patches will get this to the point of supporting inlin

Re: [PATCH][driver] Ensure --help=params lines end with period

2018-11-26 Thread Mike Stump
On Nov 20, 2018, at 3:51 AM, Tom de Vries wrote: > > this patch ensures that gcc --help=params lines end with a period by: > - fixing the help message of param HOT_BB_COUNT_FRACTION, and > - adding a test-case. > > Build and tested on x86_64. > > OK for trunk? So, normally we'd punt approval t

Re: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87626

2018-11-26 Thread Jeff Law
On 11/21/18 6:24 AM, Umesh Kalappa wrote: > Hi Jakub and All, > > We don't have the commit access ,can someone please commit for us ? Looks like Uros took care of it a few days ago. jeff

Re: [PATCH 07/10] Add dg-require-effective-target exceptions

2018-11-26 Thread Mike Stump
On Nov 16, 2018, at 8:28 AM, Andrew Stubbs wrote: > > [This patch was previously approved by Richard Sandiford (with added > documentation I've still not done), but objected to by Mike Stump. I > need to figure out who's right.] Since the planned port is done and someone isn't actively finishin

Re: C++ PATCH for c++/88120, ICE with save_expr in template

2018-11-26 Thread Jason Merrill
OK. On Mon, Nov 26, 2018 at 12:12 PM Marek Polacek wrote: > > The problem here was that we were calling save_expr in a template, which > we shouldn't, as the comment in cp_save_expr explains. This problem > only appears on ptrmemfunc_vbit_in_delta targets. > > Bootstrapped/regtested on aarch64-li

Re: [Patch][gcc][testsuite] Skip testcases using freopen when on wrapped board

2018-11-26 Thread Mike Stump
On Nov 16, 2018, at 8:16 AM, Matthew Malcomson wrote: > > On 16/11/18 16:04, Jeff Law wrote: >> On 11/15/18 12:06 PM, Martin Sebor wrote: >>> On 11/15/2018 02:39 AM, Matthew Malcomson wrote: If not we could add an { dg-require-effective-target unwrapped } directive in the test

Re: [PATCH v4] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-26 Thread Mike Gulick
On 11/13/18 3:12 PM, David Malcolm wrote: > On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: >> 2018-11-13 Mike Gulick > > [...] > >> * gcc/diagnostic-core.h (num_digits): Add extern definition. > > FWIW you moved the decl to diagnostic.h, but didn't update the above > ChangeLog ent

Re: [PATCH] Fix ICEs on invalid rs6000 asm (PR target/88188)

2018-11-26 Thread Segher Boessenkool
Hi Jakub, On Mon, Nov 26, 2018 at 09:43:47PM +0100, Jakub Jelinek wrote: > The following patch fixes a bunch of ICEs in rs6000 print_operand; we > shouldn't ICE on them when users write mess in their inline asm. > 2018-11-26 Jakub Jelinek > > PR target/88188 > * config/rs6000/rs60

[PATCH v5] PR preprocessor/83173: Enhance -fdump-internal-locations output

2018-11-26 Thread Mike Gulick
2018-11-26 Mike Gulick PR preprocessor/83173 * gcc/input.c (dump_location_info): Dump reason and included_from fields from line_map_ordinary struct. Fix indentation when location > 5 digits. * libcpp/location-example.txt: Update example -fdump-in

Re: [PATCH][driver] Ensure --help=params lines end with period

2018-11-26 Thread Tom de Vries
On 26-11-18 22:43, Mike Stump wrote: > On Nov 20, 2018, at 3:51 AM, Tom de Vries wrote: >> >> this patch ensures that gcc --help=params lines end with a period by: >> - fixing the help message of param HOT_BB_COUNT_FRACTION, and >> - adding a test-case. >> >> Build and tested on x86_64. >> >> OK f

Re: [PATCH 2/4][libbacktrace] Avoid realloc with size == 0 in backtrace_vector_release

2018-11-26 Thread Jeff Law
On 11/23/18 1:51 PM, Tom de Vries wrote: > [ was: Re: [PATCH 1/2][libbacktrace] Handle realloc returning NULL if size == > 0 ] > > On Thu, Nov 22, 2018 at 06:16:20PM +, Joseph Myers wrote: >> On Thu, 22 Nov 2018, Tom de Vries wrote: >> >>> Hi, >>> >>> If realloc is called with size 0, realloc

Re: [PATCH 3/4][libbacktrace] Don't point to released memory in backtrace_vector_release

2018-11-26 Thread Jeff Law
On 11/23/18 1:55 PM, Tom de Vries wrote: > [ was: Re: [PATCH 2/2][libbacktrace] Don't point to released memory in > backtrace_vector_release ] > > On Thu, Nov 22, 2018 at 01:36:49PM +0100, Tom de Vries wrote: >> Hi, >> >> When backtrace_vector_release is called with vec.size == 0, it releases the

Re: [PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-26 Thread Segher Boessenkool
On Mon, Nov 26, 2018 at 03:08:32PM -0600, Aaron Sawdey wrote: > When I previously added the use of unaligned vsx stores to inline expansion > of memset, I didn't do a good job of managing boundary conditions. The > intention > was to only use unaligned vsx if the block being cleared was more than

Re: [RS6000] Don't pass -many to the assembler

2018-11-26 Thread Mike Stump
On Nov 13, 2018, at 10:39 AM, Peter Bergner wrote: > > On 11/13/18 12:06 PM, Iain Sandoe wrote: >> As far as I expect, Darwin should be untouched by this - we have a separate >> assembler (which doesn’t even respond to -many), so unless there’s some >> higher level translation done (it’s not me

Re: [PATCH 5/7][MSP430][TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests

2018-11-26 Thread Jozef Lawrynowicz
On Mon, 26 Nov 2018 12:51:26 -0800 Mike Stump wrote: > On Nov 14, 2018, at 7:56 AM, Jozef Lawrynowicz > wrote: > > > > Patch 5 deals with ISO C errors emitted by tests when the large memory > > model is > > used. size_t and ptrdiff_t are __int20 with -mlarge, and if the test is > > compiled w

Re: [RS6000] Use config/linux.h for powerpc*-*-linux*

2018-11-26 Thread Segher Boessenkool
Hi Alan, On Mon, Nov 12, 2018 at 09:56:37PM +1030, Alan Modra wrote: > Using the macros in config/linux.h rather than duplicating them helps > stop future bitrot, and repairs existing bitrot (4 choices for libc in > linux.h, fewer in the rs6000 files not that it matters much). Also > fixes the fa

Re: rs6000/sysv4.h using gnu-user.h

2018-11-26 Thread Segher Boessenkool
On Mon, Nov 12, 2018 at 10:05:03PM +1030, Alan Modra wrote: > This patch removes some duplication in rs6000/sysv4.h of macros found > in gnu-user.h that we want for linux. Including gnu-user.h will mean > powerpc doesn't miss updates to that file. > > Requires https://gcc.gnu.org/ml/gcc-patches/2

Re: [PATCH] Fix ICEs on invalid rs6000 asm (PR target/88188)

2018-11-26 Thread Jakub Jelinek
On Mon, Nov 26, 2018 at 04:20:18PM -0600, Segher Boessenkool wrote: > > --- gcc/config/rs6000/rs6000.c.jj 2018-11-16 21:35:42.497982764 +0100 > > +++ gcc/config/rs6000/rs6000.c 2018-11-26 10:56:28.079516458 +0100 > > @@ -20644,7 +20644,11 @@ print_operand (FILE *file, rtx x, int co > > > >

Re: [PATCH 1/7][v2][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-26 Thread Jeff Law
On 11/21/18 1:42 PM, Jozef Lawrynowicz wrote: > On Wed, 21 Nov 2018 20:19:29 +0100 > Rainer Orth wrote: > >> new effective-target keywords always need documenting in >> gcc/doc/sourcebuild.texi. >> >> Rainer >> > Whoops, thanks for the heads up, fixed in attached. > > I'll add documentation

  1   2   >