Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-16 Thread Paolo Carlini
Hi, On 16/11/2017 06:31, Petr Ovtchenkov wrote: Is we really worry about frozen sizeof of instantiated template? Yes we do. See https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html under "Prohibited Changes", point 8. Of course removing the buffering has performance implications too - th

[Ada] Spurious ineffective use_clause warning on use in boolean condition

2017-11-16 Thread Pierre-Marie de Rodat
This patch prevents spurious ineffective use_clause warnings in certain cases due to the possible rewritting of nodes within boolean expressions. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-11-16 Justin Squirek * sem.adb (Analyze): Remove requirement that the original node

[Ada] Compiler abort or infinite loop in malformed declaration

2017-11-16 Thread Pierre-Marie de Rodat
This patch fixes a compiler abort (or an infinite loop in a compiler whose internal assertions are not enabled) when the subtype indication in an object declaration does not denote a type. Syntactically this may happen when the subtype indication is missing altogether and the expression in the decl

Re: [PATCH 02/14] Support for adding and stripping location_t wrapper nodes

2017-11-16 Thread Richard Biener
On Wed, Nov 15, 2017 at 4:33 PM, David Malcolm wrote: > On Wed, 2017-11-15 at 12:11 +0100, Richard Biener wrote: >> On Wed, Nov 15, 2017 at 7:17 AM, Trevor Saunders > rg> wrote: >> > On Fri, Nov 10, 2017 at 04:45:17PM -0500, David Malcolm wrote: >> > > This patch provides a mechanism in tree.c for

Re: [PATCH] Replace has_single_use guards in store-merging

2017-11-16 Thread Christophe Lyon
Hi Jakub, On 9 November 2017 at 13:58, Richard Biener wrote: > On Wed, 8 Nov 2017, Jakub Jelinek wrote: > >> On Wed, Nov 08, 2017 at 04:20:15PM +0100, Richard Biener wrote: >> > Can't you simply use >> > >> >unsigned ret = 0; >> >FOR_EACH_SSA_TREE_OPERAND (op, stmt, iter, SSA_OP_USE) >> >

Re: [PATCH] Replace has_single_use guards in store-merging

2017-11-16 Thread Jakub Jelinek
On Thu, Nov 16, 2017 at 11:00:01AM +0100, Christophe Lyon wrote: > I've noticed that this patch (r254579) introduces an ICE on aarch64: > gcc.target/aarch64/vect-compile.c (internal compiler error) > gcc.target/aarch64/vect.c (internal compiler error) That should have been fixed in r254628

Re: [PATCH] enhance -Warray-bounds to handle strings and excessive indices

2017-11-16 Thread Richard Biener
On Thu, Nov 16, 2017 at 4:08 AM, Martin Sebor wrote: > On 11/15/2017 03:51 AM, Richard Biener wrote: >> >> On Tue, Nov 14, 2017 at 6:45 PM, Martin Sebor wrote: >>> >>> On 11/14/2017 05:28 AM, Richard Biener wrote: On Mon, Nov 13, 2017 at 6:37 PM, Martin Sebor wrote: > > >>

[Ada] Disallow renamings declaring tagged primitives

2017-11-16 Thread Pierre-Marie de Rodat
This patch implements the following SPARK rules from SPARK RM 6.1.1(3): A subprogram_renaming_declaration shall not declare a primitive operation of a tagged type. -- Source -- -- renamings.ads package Renamings with SPARK_Mode is type T is tagged null record

[Ada] Crash on early call region of SPARK subprogram body

2017-11-16 Thread Pierre-Marie de Rodat
This patch accounts for the case where the early call region of a subprogram body declared in a package body spans into the empty corresponding spec due to pragma Elaborate_Body. -- Source -- -- gnat.adc pragma SPARK_Mode (On); -- pack.ads package Pack with Elaborat

Re: [PATCH] Canonicalize constant multiplies in division

2017-11-16 Thread Richard Biener
On Wed, Nov 15, 2017 at 3:39 PM, Wilco Dijkstra wrote: > Richard Biener wrote: >> On Tue, Oct 17, 2017 at 6:32 PM, Wilco Dijkstra >> wrote: > >>> (if (flag_reciprocal_math) >>> - /* Convert (A/B)/C to A/(B*C) */ >>> + /* Convert (A/B)/C to A/(B*C). */ >>> (simplify >>>(rdiv (rdiv:s @0 @1

Re: [PATCH, rs6000] Correct some Power9 scheduling info

2017-11-16 Thread Segher Boessenkool
Hi Pat, That look good, thanks! Okay for trunk. Segher

Re: [PATCH] Fix PowerPC testsuite not to look for *.c*~ files

2017-11-16 Thread Segher Boessenkool
Hi! On Wed, Nov 15, 2017 at 07:51:24PM -0500, Michael Meissner wrote: > I was back-porting some changes to the IBM Advance Toolchain branch, and I was > doing this via creating a patch file, and applying the patch output. I tend > to > always use the -b option to patch to create a backup file.

Re: [PATCH] Replace has_single_use guards in store-merging

2017-11-16 Thread Christophe Lyon
On 16 November 2017 at 11:04, Jakub Jelinek wrote: > On Thu, Nov 16, 2017 at 11:00:01AM +0100, Christophe Lyon wrote: >> I've noticed that this patch (r254579) introduces an ICE on aarch64: >> gcc.target/aarch64/vect-compile.c (internal compiler error) >> gcc.target/aarch64/vect.c (interna

[Ada] Fix more precise mode for parameter

2017-11-16 Thread Pierre-Marie de Rodat
CodePeer analysis of GNAT showed that a parameter was not read and always set on all paths, making it an out rather than an in-out. This was not detected by the compiler, because one path ends up raising an exception, which is not taken into account in the simpler analysis done in GNAT. Tested on

[Ada] Disallow renamings declaring tagged primitives

2017-11-16 Thread Pierre-Marie de Rodat
This patch enables the check which ensures that a subprogram renaming does not declare a primitive operation of a tagged type in instantiations. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-11-16 Hristian Kirtchev * sem_ch8.adb (Check_SPARK_Primitive_Operation): Enable the c

[Ada] Allow calls to Is_CCT_Instance for records

2017-11-16 Thread Pierre-Marie de Rodat
Routine Is_CCT_Instance (where CCT stands for Current Concurrent Type) is now used in the SPARK backend for checking references to the current type instance within default expressions of discriminants and components of (single) concurrent units. The same backend code was already used for similar r

Re: [PATCH, rs6000] correct implementation of _mm_add_pi32

2017-11-16 Thread Segher Boessenkool
Hi! On Wed, Nov 15, 2017 at 08:58:21PM -0600, Steven Munroe wrote: > A small thinko in the implementation of _mm_add_pi32 that only shows > when compiling for power9. This is okay, it is trivial and obvious. Please commit. Thanks, Segher > 2017-11-15 Steven Munroe > > * config/rs6

Cleanup profile update after loop duplication

2017-11-16 Thread Jan Hubicka
Hi, this patch removes use of frequencies in duplicate_loop_to_header_edge. I have checked that things go well with all three transofmrations it supports (complette peeling, peeling and unrolling). In simple testcases there are small mismatches after but that is because profile can not be maintai

cleanup RTL loop insns accounting

2017-11-16 Thread Jan Hubicka
Hi, this patch removes frequencies from RTL loop accounting. Honza * cfgloopanal.c: Include sreal.h (average_num_loop_insns): Use counts and sreal for accounting. Index: cfgloopanal.c === --- cfgloopanal.c (revi

cleanup profile use in final.c

2017-11-16 Thread Jan Hubicka
Hi this patch turns final to use counts rather than frequencies when deciding on alignments. Honza * final.c (compute_alignments): Use counts rather than frequencies. Index: final.c === --- final.c (revision 254767) +++ f

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread Segher Boessenkool
On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: > David tells me that the patch to enable float128 built-in functions to work > with the -mabi=ieeelongdouble option broke AIX because on AIX, the float128 > insns are disabled, and they all become CODE_FOR_nothing. The switch > st

Re: [PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-16 Thread Jonathan Wakely
On 15/11/17 20:28 -0700, Martin Sebor wrote: On 11/15/2017 07:31 AM, Jonathan Wakely wrote: The docs for -Wmaybe-uninitialized have some issues: - That first sentence is looong. - Apparently some C++ programmers think "automatic variable" means one declared with C++11 `auto`, rather than si

Re: [PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-16 Thread Jonathan Wakely
On 10/10/17 22:55 +0300, Petr Ovtchenkov wrote: This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067 (svn r253417). I'm not even going to bother to review patches sent without any explanation or rationale for the change. I will repeat what Paolo said: changing the ABI is not acceptable

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread Jonathan Wakely
On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: On Mon, 6 Nov 2017 22:19:22 +0100 François Dumont wrote: Hi     Any final decision regarding this patch ? François https://gcc.gnu.org/ml/libstdc++/2017-11/msg00036.html https://gcc.gnu.org/ml/libstdc++/2017-11/msg00035.html https://gcc.gnu.

Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 10:39:02 +0100 Paolo Carlini wrote: > Hi, > > On 16/11/2017 06:31, Petr Ovtchenkov wrote: > > Is we really worry about frozen sizeof of instantiated template? > Yes we do. See https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html > under "Prohibited Changes", point 8. >

Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-16 Thread Paolo Carlini
Hi, On 16/11/2017 12:03, Petr Ovtchenkov wrote: On Thu, 16 Nov 2017 10:39:02 +0100 Paolo Carlini wrote: Hi, On 16/11/2017 06:31, Petr Ovtchenkov wrote: Is we really worry about frozen sizeof of instantiated template? Yes we do. See https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html u

[COMMITTED][AArch64] Fix frame tests

2017-11-16 Thread Wilco Dijkstra
Improve the AArch64 frame tests - add -f(no-)omit-frame-pointer, update checks and add missing tests. As a result all tests now pass. Committed as obvious. ChangeLog: 2017-11-16 Wilco Dijkstra * gcc.target/aarch64/lr_free_2.c: Fix test. * gcc.target/aarch64/spill_1.c: Likewis

Re: [PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 10:56:29 + Jonathan Wakely wrote: > On 10/10/17 22:55 +0300, Petr Ovtchenkov wrote: > >This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067 > >(svn r253417). > > I'm not even going to bother to review patches sent without any > explanation or rationale for the cha

Re: [PATCH, GCC/testsuite/ARM] Rework expectation for call to Armv8-M nonsecure function

2017-11-16 Thread Kyrill Tkachov
On 15/11/17 17:04, Thomas Preudhomme wrote: Hi, Testcase gcc.target/arm/cmse/cmse-14.c checks whether bar is called via __gnu_cmse_nonsecure_call libcall and not via a direct call. However the pattern is a bit surprising in that it needs to explicitely allow "by" due to allowing anything before

Re: [PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-16 Thread Jonathan Wakely
On 16/11/17 14:35 +0300, Petr Ovtchenkov wrote: On Thu, 16 Nov 2017 10:56:29 + Jonathan Wakely wrote: On 10/10/17 22:55 +0300, Petr Ovtchenkov wrote: >This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067 >(svn r253417). I'm not even going to bother to review patches sent without a

Re: [PATCH, GCC/testsuite/ARM] Fix selection of effective target for cmse tests

2017-11-16 Thread Kyrill Tkachov
Hi Thomas, On 15/11/17 16:59, Thomas Preudhomme wrote: Hi, Some of the tests in the gcc.target/arm/cmse directory (eg. gcc.target/arm/cmse/mainline/bitfield-4.c) are failing when run without an architecture specified in RUNTESTFLAGS due to them not adding the option to select an Armv8-M archite

Re: [PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-16 Thread Jonathan Wakely
On 16/11/17 11:39 +, Jonathan Wakely wrote: On 16/11/17 14:35 +0300, Petr Ovtchenkov wrote: On Thu, 16 Nov 2017 10:56:29 + Jonathan Wakely wrote: On 10/10/17 22:55 +0300, Petr Ovtchenkov wrote: This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067 (svn r253417). I'm not even

Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 12:29:37 +0100 Paolo Carlini wrote: > Hi, > > On 16/11/2017 12:03, Petr Ovtchenkov wrote: > > On Thu, 16 Nov 2017 10:39:02 +0100 > > Paolo Carlini wrote: > > > >> Hi, > >> > >> On 16/11/2017 06:31, Petr Ovtchenkov wrote: > >>> Is we really worry about frozen sizeof of instan

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-16 Thread Tamar Christina
> > > > > > I see. But then the slow_unaligned_access implementation should use > > > non_strict_align as default somehow as SLOW_UNALIGNED_ACCESS is > > > defaulted to STRICT_ALIGN. > > > > > > Given that SLOW_UNALIGNED_ACCESS has different values for different > > > modes it would also make se

Re: [PING][patch] PR81794: have "would be stringified in traditional C" warning in libcpp/macro.c be controlled by -Wtraditional

2017-11-16 Thread Eric Gallager
Ping yet again: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00123.html On 11/9/17, Eric Gallager wrote: > Ping again: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00123.html > > On 11/2/17, Eric Gallager wrote: >> Ping: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01834.html >> >> On 10/25/1

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread Jonathan Wakely
On 16/11/17 10:57 +, Jonathan Wakely wrote: On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: On Mon, 6 Nov 2017 22:19:22 +0100 François Dumont wrote: Hi     Any final decision regarding this patch ? François https://gcc.gnu.org/ml/libstdc++/2017-11/msg00036.html https://gcc.gnu.org/ml/

Re: [PATCH 3/4] libstdc++: avoid character accumulation in istreambuf_iterator

2017-11-16 Thread Paolo Carlini
Hi, On 16/11/2017 12:41, Petr Ovtchenkov wrote: This part of code is from SGI, so I suspect that nobody here really measure performance difference between "bufferred" and "non-buffered" implementations. Here where? The GNU libstdc++-v3 implementation? Certainly we did, as I tried to tell you th

Re: [PATCH 1/4] Revert "2017-10-04 Petr Ovtchenkov "

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 11:39:30 + Jonathan Wakely wrote: > On 16/11/17 14:35 +0300, Petr Ovtchenkov wrote: > >On Thu, 16 Nov 2017 10:56:29 + > >Jonathan Wakely wrote: > > > >> On 10/10/17 22:55 +0300, Petr Ovtchenkov wrote: > >> >This reverts commit 0dfbafdf338cc6899d146add5161e52efb02c067

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-16 Thread Richard Biener
On Thu, 16 Nov 2017, Tamar Christina wrote: > > > > > > > > I see. But then the slow_unaligned_access implementation should use > > > > non_strict_align as default somehow as SLOW_UNALIGNED_ACCESS is > > > > defaulted to STRICT_ALIGN. > > > > > > > > Given that SLOW_UNALIGNED_ACCESS has differe

Re: [PATCH] New lang hook

2017-11-16 Thread Richard Biener
On Tue, Nov 14, 2017 at 1:31 PM, Nathan Sidwell wrote: > This patch addresses c++/82836 & c++/82737. The root cause was a bad > assumption I made when moving the mangling alias machinery to its own hash > table. > > I had thought that once we SET_DECL_ASSEMBLER_NAME, it never becomes unset > (or

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 11:46:48 + Jonathan Wakely wrote: > On 16/11/17 10:57 +, Jonathan Wakely wrote: > >On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: > >>On Mon, 6 Nov 2017 22:19:22 +0100 > >>François Dumont wrote: > >> > >>>Hi > >>> > >>>     Any final decision regarding this patch ? >

[PR c++/81060] ICE with invalid initialzer via lambda

2017-11-16 Thread Nathan Sidwell
This patch fixes a regression my name lookup changes caused earlier this year. We'd already emitted an error about a bogus template definition, but the fallout from that now killed us :( I restored some of the handling r247909 removed. Namely restoring the pushing of a lambda type into the s

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-11-16 Thread Maxim Ostapenko
Hi Christophe, On 13/11/17 15:47, Christophe Lyon wrote: On 30 October 2017 at 16:21, Maxim Ostapenko wrote: On 30/10/17 17:08, Christophe Lyon wrote: On 30/10/2017 11:12, Maxim Ostapenko wrote: Hi, sorry for the late response. On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October

[PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Alan Hayward
This is a set of patches aimed at supporting aarch64 SVE register preservation around TLS calls. Across a TLS call, Aarch64 SVE does not explicitly preserve the SVE vector registers. However, the Neon vector registers are preserved. Due to overlapping of registers, this means the lower 128bits of

[PATCH 3/7] Add func to check if register is clobbered by clobber_high

2017-11-16 Thread Alan Hayward
This patch adds the function reg_is_clobbered_by_clobber_high. Given a CLOBBER_HIGH expression and a register, it checks if the register will be clobbered. A second version exists for the cases where the expressions are not available. The function will be used throughout the following patches. A

[PATCH 2/7] Support >26 operands in generation code.

2017-11-16 Thread Alan Hayward
This patch adds support for CLOBBER_HIGH in the generation code. An aarch64 will require 31 clobber high expressions, plus two clobbers. The exisiting gen code restricts to 26 vector operands by virtue of using the operators [a-z]. This patch extends this to 52 by supporting [a-zA-Z]. Alan. 201

[PATCH 4/7]: lra support for clobber_high

2017-11-16 Thread Alan Hayward
This patch simply adds the lra specific changes for clobber_high. Alan. 2017-11-16 Alan Hayward * lra-eliminations.c (lra_eliminate_regs_1): Check for clobber high. (mark_not_eliminable): Likewise. * lra-int.h (struct lra_insn_reg): Add clobber high marker. *

[PATCH 5/7]: cse support for clobber_high

2017-11-16 Thread Alan Hayward
This patch simply adds the cse specific changes for clobber_high. Alan. 2017-11-16 Alan Hayward * cse.c (invalidate_reg): New function extracted from... (invalidate): ...here. (canonicalize_insn): Check for clobber high. (invalidate_from_clobbers): invalidate c

[PATCH 6/7]: Remaining support for clobber high

2017-11-16 Thread Alan Hayward
This patch simply adds the remainder of clobber high checks. Happy to split this into smaller patches if required (there didn't seem anything obvious to split into). Alan. 2017-11-16 Alan Hayward * alias.c (record_set): Check for clobber high. * cfgexpand.c (expand_gimple_stm

[PATCH 7/7]: Enable clobber high for tls descs on Aarch64

2017-11-16 Thread Alan Hayward
This final patch adds the clobber high expressions to tls_desc for aarch64. It also adds three tests. In addition I also tested by taking the gcc torture test suite and making all global variables __thread. Then emended the suite to compile with -fpic, save the .s file and only for one given O lev

[Ada] Spurious error on System'To_Address in -gnatc mode

2017-11-16 Thread Pierre-Marie de Rodat
This patch fixes a bug where if an address clause specifies a call to System'To_Address as the address, and the code is compiled with the -gnatc switch, the compiler gives a spurious error message. The following test should compile quietly with -gnatc: gcc -c -gnatc counter.ads with System; pac

Re: Hurd port for gcc-7 go PATCH 1-3(15)

2017-11-16 Thread Svante Signell
On Wed, 2017-11-15 at 21:54 +0100, Svante Signell wrote: > On Wed, 2017-11-15 at 21:40 +0100, Matthias Klose wrote: > > On 06.11.2017 16:36, Svante Signell wrote: > > > Hi, > > > > > > Attached are patches to enable gccgo to build properly on Debian > > > GNU/Hurd on gcc-7 (7-7.2.0-12). > > > > s

[Ada] Handling of elaboration warnings

2017-11-16 Thread Pierre-Marie de Rodat
This patch modifies the elaboration warnings produced by the ABE mechanism to depend on the status of flag Elab_Warnings. The flag is enabled by compilation switch -gnatwl. This change allows for selective suppression of warnings, as well as total suppression. In order to preserve the behaviour of

Re: [PATCH] Factor out division by squares and remove division around comparisons (2/2)

2017-11-16 Thread Wilco Dijkstra
ping From: Jackson Woodruff Sent: 06 September 2017 10:55 To: Richard Biener Cc: Wilco Dijkstra; kyrylo.tkac...@foss.arm.com; Joseph S. Myers; GCC Patches Subject: Re: [PATCH] Factor out division by squares and remove division around comparisons (2/2)   Hi all, A minor improvement came to m

Re: [PATCH] BRIG frontend: request for a global review

2017-11-16 Thread Pekka Jääskeläinen
Hi, I added some content to gccbrig.texi in r254820 as below. If you have something that I could describe further there, please just let me know. Index: gcc/brig/gccbrig.texi === --- gcc/brig/gccbrig.texi (revision 254819) +++ gcc/br

[PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Wilco Dijkstra
GCC currently defaults to -ftrapping-math. This is supposed to generate code for correct user-visible traps and FP status flags. However it doesn't work as expected since it doesn't block any floating point optimizations. For example it continues to perform CSE, moves FP operations across calls,

[PATCH] Add noexcept to std::shared_future copy operations (LWG DR 2799)

2017-11-16 Thread Jonathan Wakely
These functions just increment a refcount (and the base class functions that do that are already noexcept anyway). * include/std/future (shared_future): Add noexcept to copy constructor and copy-assignment operator (LWG 2799). Tested pwoerpc64le-linux, committed to trunk. commit

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Richard Biener
On Thu, Nov 16, 2017 at 3:33 PM, Wilco Dijkstra wrote: > GCC currently defaults to -ftrapping-math. This is supposed to generate > code for correct user-visible traps and FP status flags. > > However it doesn't work as expected since it doesn't block any floating > point optimizations. For examp

Re: [PATCH] New lang hook

2017-11-16 Thread Nathan Sidwell
On 11/16/2017 07:03 AM, Richard Biener wrote: Looks reasonable apart from + /* Overwrite the DECL_ASSEMBLER_NAME for a node. The name is being + changed (including to or from NULL_TREE). */ which suggests the default implementation of set_decl_assembler_name would call this hook (which

Re: [PATCH, GCC/ARM] Fix ICE in Armv8-M Security Extensions code

2017-11-16 Thread Kyrill Tkachov
Hi Thomas, On 15/11/17 16:57, Thomas Preudhomme wrote: Hi, Commit r253825 which introduced some sanity checks for sbitmap revealed a bug in the conversion of cmse_nonsecure_entry_clear_before_return () to using bitmap structure. bitmap_and expects that the two bitmaps have the same length, yet

Re: [PATCH GCC]A simple implementation of loop interchange

2017-11-16 Thread Bin.Cheng
On Tue, Oct 24, 2017 at 3:30 PM, Michael Matz wrote: > Hello, > > On Fri, 22 Sep 2017, Bin.Cheng wrote: > >> This is updated patch for loop interchange with review suggestions >> resolved. Changes are: >> 1) It does more light weight checks like rectangle loop nest check >> earlier than before.

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2017-11-16 Thread Tamar Christina
Hi Richard, > > I'd have made it > > if { ([is-effective-target non_strict_align] > && ! ( [istarget ...] || )) > > thus default it to 1 for non-strict-align targets. > Fair, I've switched it to a black list and have excluded the only one I know should not work. Most of the rest

RE: [PATCH, committed] Add myself to MAINTAINERS

2017-11-16 Thread Peryt, Sebastian
Message didn't get thru for some reason. Resending. Sebastian From: Peryt, Sebastian Sent: Wednesday, November 15, 2017 1:44 PM To: gcc-patches@gcc.gnu.org Cc: Peryt, Sebastian Subject: [PATCH, committed] Add myself to MAINTAINERS ChangeLog: 2017-11-15  Sebastian Peryt      * MAINTAINER

[patch] remove cilk-plus

2017-11-16 Thread Koval, Julia
// I failed to send patch itself, it is too big even in gzipped form. What is the right way to send such big patches? Hi, this patch removes cilkplus. Ok for trunk? 2017-11-16 Julia Koval Sebastian Peryt gcc/ * Makefile.def (target_modules): Remove libcilkrts.

Re: [patch] remove cilk-plus

2017-11-16 Thread Marek Polacek
On Thu, Nov 16, 2017 at 03:33:40PM +, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? You can split the patch and then post each part in a separate e-mail. Easier to review, too. > Hi, this patch

Re: [PATCH] Disable -ftrapping-math by default

2017-11-16 Thread Wilco Dijkstra
Richard Biener wrote: > We are generally not preserving traps but we guard any transform that > might introduce traps with -ftrapping-math.  That's similar to how we treat > -ftrapv and pointer dereferences. Right. It appears it's mostly concerned about division - if it is about division by zero

Re: [patch] remove cilk-plus

2017-11-16 Thread Jakub Jelinek
On Thu, Nov 16, 2017 at 03:33:40PM +, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? Don't include the libcilkrts subtree in the patch nor /cilk-plus/ testcases that are going to be removed? > Hi,

Re: [PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-16 Thread Martin Sebor
On 11/16/2017 03:49 AM, Jonathan Wakely wrote: On 15/11/17 20:28 -0700, Martin Sebor wrote: On 11/15/2017 07:31 AM, Jonathan Wakely wrote: The docs for -Wmaybe-uninitialized have some issues: - That first sentence is looong. - Apparently some C++ programmers think "automatic variable" mean

[PATCH][PR c++/82888] smarter code for default initialization of scalar arrays

2017-11-16 Thread Nathan Froyd
Default-initialization of scalar arrays in C++ member initialization lists produced rather slow code, laboriously setting each element of the array to zero. It would be much faster to block-initialize the array, and that's what this patch does. The patch works for me, but I'm not sure if it's the

Re: [patch] remove cilk-plus

2017-11-16 Thread Eric Gallager
On 11/16/17, Koval, Julia wrote: > // I failed to send patch itself, it is too big even in gzipped form. What > is the right way to send such big patches? > > Hi, this patch removes cilkplus. Ok for trunk? I'm not a reviewer, but just as an onlooker, I'd want to see notes about the removal in th

Use profile count scaling in vect_do_peeling

2017-11-16 Thread Jan Hubicka
Hi, this is one of two remiaing places we scale by integer ratios rather than counts which lose quality info. This is because we scale up here which is technically bad idea we lose precision and all code duplication should perform scale at once as last step to avoid cumulating mistakes. Bot since

Avoid integer profile scaling in tree_transform_and_unroll_loop

2017-11-16 Thread Jan Hubicka
Hi, this is the last remaining case of integer scaling. The issue is again the same. We scale up which is not best idea and unrolling done via cfgloopmanip gets around wtihout doing it. Again I decided to keep the logic for now, just update it to profile counts. Bootstrapped/regtested x86_64-li

Remove scale_bbs_frequencies_int, scale_bbs_frequencies_int

2017-11-16 Thread Jan Hubicka
Hi, since all uses of those functions are now updated to profile counts and probabilities, we can rmeove these. Bootstrapped/retested x86_64-linux, comitted. Honza * cfg.c (scale_bbs_frequencies_int, cale_bbs_frequencies_gcov_type): Remove. * cfg.h (scale_bbs_frequencies

[PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-16 Thread Sudi Das
Hi This patch fixes the test case armv8_2-fp16-move-1.c for arm-none-linux-gnueabihf where 2 of the scan-assembler directives were failing. We now generate less vmov between core and VFP registers. Thus changing those directives to reflect that. Is this ok for trunk? If yes could someone commi

Set edges to region known to be executed 0 times to have probability 0

2017-11-16 Thread Jan Hubicka
Hi, this patch fixes one profilemismatch issue in testsuite where we end up with non-zero probability with edge to BB calling abort. When detecting regions known to be executed 0 times, we should also set edges leading to them to be executed 0 times. The other change makes combine_predictions_for

Accumulate time in sreals consistently in ipa-fnsummary

2017-11-16 Thread Jan Hubicka
Hi, this patch drops use of integer bb frequencies in ipa-fnsummary. This avoids capping to 100 for frequency and makes it consistent with edge accounting. ipcp-2.c needs updating becuase the cumulated time is now more realistic. There is loop iterating 32*32 times and we accounted it as loop ite

Accumulate time in sreals in ipa-fnsplit

2017-11-16 Thread Jan Hubicka
Hi, this patch does same change to ipa-split as previous patch did to fnsummary. Bootstrapped/regtested x86_64-linux. Honza * ipa-split.c (split_bb_info): Turn time to sreal. (split_point): Likewise. (dump_split_point): Likewise. (fine_split_points): Likewise.

Remove write only bb_freq in tree-emutls.c

2017-11-16 Thread Jan Hubicka
Hi, this var is actually write only, so I have removed it. Honza * tree-emutls.c (lower_emutls_data): Remove unused bb_freq. (lower_emutls_function_body): Do not compute it. Index: tree-emutls.c === --- tree-emutls.c

RE: [patch] remove cilk-plus

2017-11-16 Thread Koval, Julia
Thanks for your comments, fixed it. 2017-11-16 Julia Koval Sebastian Peryt * Makefile.def (target_modules): Remove libcilkrts. * Makefile.in: Ditto. * configure: Ditto. * configure.ac: Ditto. contrib/ * contrib/gcc_update: Ditto. gcc/

Re: [PATCH][ARM] Fix test armv8_2-fp16-move-1.c

2017-11-16 Thread Kyrill Tkachov
Hi Sudi, On 16/11/17 16:37, Sudi Das wrote: Hi This patch fixes the test case armv8_2-fp16-move-1.c for arm-none-linux-gnueabihf where 2 of the scan-assembler directives were failing. We now generate less vmov between core and VFP registers. Thus changing those directives to reflect that.

[PATCH] Use bswap framework in store-merging (PR tree-optimization/78821)

2017-11-16 Thread Jakub Jelinek
Hi! This patch uses the bswap pass framework inside of the store merging pass to handle adjacent stores which produce together a 16/32/64 bit store of bswapped value (loaded or from SSA_NAME) or identity (usually only from SSA_NAME, the code prefers to use the existing store merging code if coming

[PATCH] [BRIGFE] Reduce the number of type conversions due to the untyped HSAIL regs

2017-11-16 Thread Pekka Jääskeläinen
Instead of always representing the HSAIL's untyped registers as unsigned int, the gccbrig now pre-analyzes the BRIG code and builds the register variables as a type used the most when storing or reading data to/from each register. This reduces the total conversions which cannot be always optimized

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread François Dumont
On 16/11/2017 12:46, Jonathan Wakely wrote: On 16/11/17 10:57 +, Jonathan Wakely wrote: On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: On Mon, 6 Nov 2017 22:19:22 +0100 François Dumont wrote: Hi     Any final decision regarding this patch ? François https://gcc.gnu.org/ml/libstdc++/

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-16 Thread Marek Polacek
On Tue, Nov 14, 2017 at 07:34:54AM +0100, Richard Biener wrote: > On November 14, 2017 6:21:41 AM GMT+01:00, Jason Merrill > wrote: > >On Mon, Nov 13, 2017 at 1:02 PM, Marek Polacek > >> In the end I did two bootstraps with the patch, but modifed one of > >them > >> to always return false for ix

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread Michael Meissner
On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: > On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: > > David tells me that the patch to enable float128 built-in functions to work > > with the -mabi=ieeelongdouble option broke AIX because on AIX, the float128 > >

Re: [committed][PATCH] Change order of processing blocks/threads in tree-ssa-threadupdate.c

2017-11-16 Thread Jeff Law
On 11/15/2017 12:57 AM, Aldy Hernandez wrote: > > > On 11/14/2017 10:46 PM, Jeff Law wrote: >> With my local patches to remove jump threading from VRP I was seeing a >> fairly obvious jump threading path left in the CFG after DOM.  This >> missed jump thread ultimately caused a false positive uni

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread David Edelsohn
On Thu, Nov 16, 2017 at 12:48 PM, Michael Meissner wrote: > On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: >> On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: >> > David tells me that the patch to enable float128 built-in functions to work >> > with the -mabi=

Re: [patch] remove cilk-plus

2017-11-16 Thread Jeff Law
On 11/16/2017 09:22 AM, Eric Gallager wrote: > On 11/16/17, Koval, Julia wrote: >> // I failed to send patch itself, it is too big even in gzipped form. What >> is the right way to send such big patches? >> >> Hi, this patch removes cilkplus. Ok for trunk? > > I'm not a reviewer, but just as an

Re: [PING] [PATCH] Remove CANADIAN, that break compilation for foreign target

2017-11-16 Thread Petr Ovtchenkov
On Wed, 20 Sep 2017 13:44:59 +0300 Petr Ovtchenkov wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71212 > > On Fri, 20 May 2016 16:10:50 +0300 > Petr Ovtchenkov wrote: > > > Some old ad-hoc (adding -I/usr/include to compiler > > flags) break compilation of libstdc++ for foreign > > targ

Re: [PATCH] Improve -Wmaybe-uninitialized documentation

2017-11-16 Thread Jeff Law
On 11/16/2017 03:49 AM, Jonathan Wakely wrote: > On 15/11/17 20:28 -0700, Martin Sebor wrote: >> On 11/15/2017 07:31 AM, Jonathan Wakely wrote: >>> The docs for -Wmaybe-uninitialized have some issues: >>> >>> - That first sentence is looong. >>> - Apparently some C++ programmers think "automati

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Jeff Law
On 11/16/2017 05:34 AM, Alan Hayward wrote: > This is a set of patches aimed at supporting aarch64 SVE register > preservation around TLS calls. > > Across a TLS call, Aarch64 SVE does not explicitly preserve the > SVE vector registers. However, the Neon vector registers are preserved. > Due to ov

Re: Make istreambuf_iterator::_M_sbuf immutable and add debug checks

2017-11-16 Thread Petr Ovtchenkov
On Thu, 16 Nov 2017 18:40:08 +0100 François Dumont wrote: > On 16/11/2017 12:46, Jonathan Wakely wrote: > > On 16/11/17 10:57 +, Jonathan Wakely wrote: > >> On 16/11/17 08:51 +0300, Petr Ovtchenkov wrote: > >>> On Mon, 6 Nov 2017 22:19:22 +0100 > >>> François Dumont wrote: > >>> > Hi >

Re: [PATCH v2] [libcc1] Rename C{,P}_COMPILER_NAME and remove triplet from them

2017-11-16 Thread Jeff Law
On 11/15/2017 09:12 PM, Sergio Durigan Junior wrote: > On Wednesday, November 15 2017, Jim Wilson wrote: > >> On 11/13/2017 01:10 PM, Sergio Durigan Junior wrote: >>> On Tuesday, September 26 2017, I wrote: >>> Ping^2. >>> >>> Ping^3. >>> >>> I'm sending the updated ChangeLog/patch. I'm also

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Richard Biener
On November 16, 2017 7:05:30 PM GMT+01:00, Jeff Law wrote: >On 11/16/2017 05:34 AM, Alan Hayward wrote: >> This is a set of patches aimed at supporting aarch64 SVE register >> preservation around TLS calls. >> >> Across a TLS call, Aarch64 SVE does not explicitly preserve the >> SVE vector regist

Re: [PATCH] c-family: add name_hint/deferred_diagnostic (v3)

2017-11-16 Thread Jeff Law
On 11/02/2017 06:21 PM, David Malcolm wrote: > Jeff: You previously had concerns about the refcounting used in v1 > of this patch; this avoids that in favor of using gnu::unique_ptr. > Joseph already approved the C frontend parts of v2 of this > patch. I had to go back and find my original messag

Re: [PATCH #2], make Float128 built-in functions work with -mabi=ieeelongdouble

2017-11-16 Thread Segher Boessenkool
On Thu, Nov 16, 2017 at 12:54:54PM -0500, David Edelsohn wrote: > On Thu, Nov 16, 2017 at 12:48 PM, Michael Meissner > wrote: > > On Thu, Nov 16, 2017 at 04:48:18AM -0600, Segher Boessenkool wrote: > >> On Wed, Nov 15, 2017 at 04:56:10PM -0500, Michael Meissner wrote: > >> > David tells me that th

Re: [PATCH 1/7]: SVE: Add CLOBBER_HIGH expression

2017-11-16 Thread Alan Hayward
> On 16 Nov 2017, at 18:24, Richard Biener wrote: > > On November 16, 2017 7:05:30 PM GMT+01:00, Jeff Law wrote: >> On 11/16/2017 05:34 AM, Alan Hayward wrote: >>> This is a set of patches aimed at supporting aarch64 SVE register >>> preservation around TLS calls. >>> >>> Across a TLS call, Aa

Re: Improve spilling for variable-size slots

2017-11-16 Thread Jeff Law
On 11/03/2017 10:35 AM, Richard Sandiford wrote: > Once SVE is enabled, a general AArch64 spill slot offset will be > > A + B * VL > > where A is a constant and B is a multiple of the SVE vector length. > The offsets in SVE load and store instructions are a multiple of VL > (and so can encode s

Re: [patch, doc] Document that new Perl version breaks required automake

2017-11-16 Thread Jeff Law
On 11/09/2017 12:28 AM, Thomas Koenig wrote: > Hello world, > > while PR 82856 remains unsolved so far, this documentation patch at > least points people into the right direction if --enable-maintainer-mode > fails due to the incompatibility of the latest Perl version with > the required automkake

Re: [PATCH 14/22] Enable building libsanitizer with Intel CET

2017-11-16 Thread Jeff Law
On 11/08/2017 04:22 PM, Tsimbalist, Igor V wrote: > The revised patch is attached. The differences are in what options are > defined and propagated to Makefiles for CET enabling. > > Ok for trunk? OK once the set as a whole is ack'd. JEff

  1   2   >