Re: Add more subreg offset helpers

2016-11-22 Thread Richard Sandiford
Eric Botcazou writes: >> subreg_offset_from_lsb was supposed to be the inverse operation of >> subreg_lsb, which also returns a bit number. > > It would have helped the reviewer to state it in the function comment. ;-) > >> Should I change that to return a byte number as well? > > Both functions a

Re: [PATCH] Fix divmod expansion (PR middle-end/78416, take 2)

2016-11-22 Thread Richard Biener
On Mon, Nov 21, 2016 at 8:09 PM, Jakub Jelinek wrote: > Hi! > > On Fri, Nov 18, 2016 at 11:10:58PM +0100, Richard Biener wrote: >> I wonder if transforming the const-int to wide int makes this all easier to >> read? > > Here is updated patch that does that. > Bootstrapped/regtested on x86_64-linu

Re: [PATCH] Fix ICE with masked stores (PR tree-optimization/78445)

2016-11-22 Thread Richard Biener
On Mon, Nov 21, 2016 at 8:25 PM, Jakub Jelinek wrote: > On Wed, Nov 16, 2016 at 09:14:57PM -0600, Bill Schmidt wrote: >> 2016-11-16 Bill Schmidt >> Richard Biener >> >> PR tree-optimization/77848 >> * tree-if-conv.c (tree_if_conversion): Always version loops unless >>

Re: Rework subreg_get_info

2016-11-22 Thread Richard Sandiford
Eric Botcazou writes: >> Well, I think it's probably grammatical, but how about: >> >> If the register representation of a non-scalar mode has holes in it, >> we expect the scalar units to be concatenated together, with the holes >> distributed evenly among the scalar units. Each scalar un

Tighten check for whether a sibcall references local variables

2016-11-22 Thread Richard Sandiford
This loop: /* Make sure the tail invocation of this function does not refer to local variables. */ FOR_EACH_LOCAL_DECL (cfun, idx, var) { if (TREE_CODE (var) != PARM_DECL && auto_var_in_fn_p (var, cfun->decl) && (ref_maybe_used_by_stmt_p (call, var)

Re: Add more subreg offset helpers

2016-11-22 Thread Eric Botcazou
> 2016-11-15 Richard Sandiford > Alan Hayward > David Sherwood > > * rtl.h (subreg_size_offset_from_lsb): Declare. > (subreg_offset_from_lsb): New function. > (subreg_size_lowpart_offset): Declare. > (subreg_lowpart_offset): Turn into an inline fu

Re: Rework subreg_get_info

2016-11-22 Thread Eric Botcazou
> Actually, thinking more about it: the assumption we're making in the > WORDS_BIG_ENDIAN != REG_WORDS_BIG_ENDIAN condition discussed below is > really: > > /* We assume that the ordering of registers within a multi-register > value has a consistent endianness: if bytes and register words >

[PATCH][ARM] PR target/78439: Update movdi constraints for Cortex-A8 tuning to handle LDRD/STRD

2016-11-22 Thread Kyrill Tkachov
Hi all, This PR is an ICE while bootstrapping GCC with Cortex-A8 tuning, which we also get from the default ARMv7-A tuning. The ldrd/strd peepholes were recently made more aggressive and in this case they transform: (insn 13 33 40 2 (set (mem/c:SI (plus:SI (reg/f:SI 11 fp) (cons

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-22 Thread Szabolcs Nagy
On 21/11/16 14:16, FX wrote: > Can you XFAIL the test on your platform, open a PR and assign it to me? OK. Committed. ARM and AArch64 may not support trapping so runtime and compile time check can differ. gcc/testsuite/ 2016-11-22 Szabolcs Nagy PR libgfortran/78449 * gfortran

Re: [PATCH 01/11] use rtx_insn * more places where it is obvious

2016-11-22 Thread Andreas Schwab
../../gcc/config/ia64/ia64.c:7141:13: error: 'void ia64_emit_insn_before(rtx, rtx)' declared 'static' but never defined [-Werror=unused-function] static void ia64_emit_insn_before (rtx, rtx); ^ Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key finge

Re: Fix PR78154

2016-11-22 Thread Prathamesh Kulkarni
On 21 November 2016 at 15:34, Richard Biener wrote: > On Fri, 18 Nov 2016, Prathamesh Kulkarni wrote: > >> On 17 November 2016 at 15:24, Richard Biener wrote: >> > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: >> > >> >> On 17 November 2016 at 14:21, Richard Biener wrote: >> >> > On Thu, 17 No

Re: [www-patch] Document new -Wshadow= variants in gcc-7/changes.html

2016-11-22 Thread Mark Wielaard
On Mon, 2016-11-21 at 15:10 +0100, Gerald Pfeifer wrote: > On Mon, 21 Nov 2016, Mark Wielaard wrote: > Index: htdocs/gcc-7/changes.html > === > +The -Wshadow warning has been split into 3 > > I believe for small numbers one usually sp

Re: [PATCH, GCC/ARM] Fix PR77904: callee-saved register trashed when clobbering sp

2016-11-22 Thread Thomas Preudhomme
On 17/11/16 09:11, Kyrill Tkachov wrote: On 17/11/16 08:56, Thomas Preudhomme wrote: On 16/11/16 10:30, Kyrill Tkachov wrote: Hi Thomas, On 03/11/16 16:52, Thomas Preudhomme wrote: Hi, When using a callee-saved register to save the frame pointer the Thumb-1 prologue fails to save the callee

Re: Tighten check for whether a sibcall references local variables

2016-11-22 Thread Richard Biener
On Tue, Nov 22, 2016 at 10:00 AM, Richard Sandiford wrote: > This loop: > > /* Make sure the tail invocation of this function does not refer > to local variables. */ > FOR_EACH_LOCAL_DECL (cfun, idx, var) > { > if (TREE_CODE (var) != PARM_DECL > && auto_var_in_fn_p (v

[arm-embedded] [PATCH, GCC/ARM, ping] Fix PR77904: callee-saved register trashed when clobbering sp

2016-11-22 Thread Thomas Preudhomme
Hi, We have decided to backport this patch to fix callee-saved register corruption when clobbering sp to our embedded-6-branch. *** gcc/ChangeLog.arm *** PR target/77904 * config/arm/arm.c (thumb1_compute_save_reg_mask): Mark frame pointer in save register mask if it i

Re: [RFC][PATCH] Speed-up use-after-scope (re-writing to SSA)

2016-11-22 Thread Martin Liška
On 11/16/2016 05:28 PM, Jakub Jelinek wrote: > On Wed, Nov 16, 2016 at 05:01:31PM +0100, Martin Liška wrote: >> + use_operand_p use_p; >> + imm_use_iterator imm_iter; >> + FOR_EACH_IMM_USE_FAST (use_p, imm_iter, poisoned_var) >> +{ >> + gimple *use = USE_STMT (use_p); >> + if (is_g

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-22 Thread Michael Matz
Hi, On Mon, 21 Nov 2016, Richard Biener wrote: > >> Btw, this probably means that on haswell (or other archs with vf==4) mgrid > >> is slower than necessary. On mgrid you really really want predictive > >> commoning to happen. Vectorization isn't that interesting there. > > Interesting, I will

Re: [PATCH][ARM] PR target/78439: Update movdi constraints for Cortex-A8 tuning to handle LDRD/STRD

2016-11-22 Thread Ramana Radhakrishnan
On Tue, Nov 22, 2016 at 9:57 AM, Kyrill Tkachov wrote: > Hi all, > > This PR is an ICE while bootstrapping GCC with Cortex-A8 tuning, which we > also get from the default ARMv7-A tuning. > The ldrd/strd peepholes were recently made more aggressive and in this case > they transform: > (insn 13 33 4

[Patch, Fortran, OOP] PR 78443: Incorrect behavior with non_overridable keyword

2016-11-22 Thread Janus Weil
Hi all, here is a patch for a wrong-code problem with non_overridable type-bound procedures. For details see the PR. Regtests cleanly. Ok for trunk? Since the patch is very simple and it fixes wrong code which can silently give bad runtime results, I think backporting to the release branches migh

Re: [PATCH] Fix ICE with -Wuninitialized (PR tree-optimization/78455)

2016-11-22 Thread Aldy Hernandez
On 11/22/2016 02:49 AM, Jakub Jelinek wrote: On Mon, Nov 21, 2016 at 04:02:40PM -0800, Marek Polacek wrote: What seems like a typo caused an ICE here. We've got a vector of vectors here and we're trying to walk all the elements, so the second loop oughta use 'j'. Bootstrapped/regtested on x86_

[PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Uros Bizjak
Hello! New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make argument doesn't work in the later case. Attached patch reworks this functionali

[patch,avr] Fix PR60300: Minor prologue improvement.

2016-11-22 Thread Georg-Johann Lay
This patch is a minor improvement of prologue length. It now allows frame sizes of up to 11 to be allocated by RCALL + PUSH 0 sequences but limits the number of RCALLs to 3. The PR has some discussion on size vs. speed consideration w.r. to using RCALL in prologues, and following that I picke

Re: PR78153

2016-11-22 Thread Prathamesh Kulkarni
On 21 November 2016 at 15:10, Richard Biener wrote: > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: > >> Hi, >> As suggested by Martin in PR78153 strlen's return value cannot exceed >> PTRDIFF_MAX. >> So I set it's range to [0, PTRDIFF_MAX - 1] in extract_range_basic() >> in the attached patch.

Re: [PATCH, GCC/ARM 1/2] Add multilib support for embedded bare-metal targets

2016-11-22 Thread Ramana Radhakrishnan
On Thu, Oct 13, 2016 at 4:35 PM, Thomas Preudhomme wrote: > Hi ARM maintainers, > > This patchset aims at adding multilib support for R and M profile ARM > architectures and allowing it to be built alongside multilib for A profile > ARM architectures. This specific patch adds the t-rmprofile multi

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Dominik Vogt
On Wed, Oct 12, 2016 at 04:37:26PM -0400, David Malcolm wrote: > On Wed, 2016-10-12 at 19:31 +0200, Bernd Schmidt wrote: > > On 10/12/2016 07:48 PM, David Malcolm wrote: > > > This patch implements a "compact" mode for print_rtx_function, > > > implementing most of the ideas above. > > > > > > Exa

Re: [PATCH 1/4] Remove build dependence on HSA run-time

2016-11-22 Thread Martin Jambor
Hi, On Fri, Nov 18, 2016 at 11:23:10AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 08:02:41PM +0100, Martin Jambor wrote: > > @@ -143,6 +240,12 @@ init_enviroment_variables (void) > > suppress_host_fallback = true; > >else > > suppress_host_fallback = false; > > + > > + hs

Re: [PATCH 2/4] HSA specific built-ins

2016-11-22 Thread Martin Jambor
On Fri, Nov 18, 2016 at 11:27:24AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 08:39:35PM +0100, Martin Jambor wrote: > > Hello, > > > > this patch adds a small file hsa-builtins.def which defines a few > > builtins that I then use in OpenMP lowering and expansion. > > > > After we spli

Re: [PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Jonathan Wakely
On 22/11/16 13:25 +0100, Uros Bizjak wrote: OK for mainline SVN and release branches? Yes, the libstdc++ parts are ok, thanks.

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Bernd Schmidt
On 11/22/2016 02:18 PM, Dominik Vogt wrote: @@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, int idx) if (INSN_HAS_LOCATION (in_insn)) { expanded_location xloc = insn_location (in_insn); - fprintf (outfile, " %s:%i", xloc.file, xloc.line); +

Re: [PATCH] Introduce emit_status::ensure_regno_capacity (v5)

2016-11-22 Thread Bernd Schmidt
On 11/18/2016 10:19 PM, David Malcolm wrote: - regno_reg_rtx = ggc_vec_alloc (crtl->emit.regno_pointer_align_length); + regno_reg_rtx = +ggc_cleared_vec_alloc (crtl->emit.regno_pointer_align_length); When wrapping lines, put the operator first. Otherwise ok. Bernd

Re: [v3 PATCH] LWG 2766, LWG 2749

2016-11-22 Thread Jonathan Wakely
On 17/11/16 23:38 +0200, Ville Voutilainen wrote: @@ -478,6 +478,14 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION swap(pair<_T1, _T2>& __x, pair<_T1, _T2>& __y) noexcept(noexcept(__x.swap(__y))) { __x.swap(__y); } + +#if __cplusplus > 201402L || !defined(__STRICT_ANSI__) // c++1z or gnu++11 +

Re: [Patch, fortran, RFC] Add warning for missing location information

2016-11-22 Thread Janus Weil
Hi Thomas, >> the attached patch runs through gfortran's AST to check for missing >> location information. one small comment: Is it necessary to introduce the extra CHECK_LOCUS macro? Couldn't you just use CHECKING_P alone? In your patch CHECK_LOCUS is basically just replicating CHECKING_P. And:

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > >>@@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, int idx) > >> if (INSN_HAS_LOCATION (in_insn)) > >>{ > >> expanded_location xloc = insn_location (in_ins

Re: [PATCH] Propagate cv qualifications in variant_alternative

2016-11-22 Thread Jonathan Wakely
On 21/11/16 22:46 -0800, Tim Shen wrote: PR libstdc++/78441 * include/std/variant: Propagate cv qualifications to types returned by variant_alternative. * testsuite/20_util/variant/compile.cc: Tests. OK for trunk, thanks.

Re: [PATCH 3/4] OpenMP lowering changes from the hsa branch

2016-11-22 Thread Martin Jambor
Hi, On Fri, Nov 18, 2016 at 11:38:56AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 10:42:01PM +0100, Martin Jambor wrote: > > + size_t collapse = gimple_omp_for_collapse (for_stmt); > > + struct omp_for_data_loop *loops > > += (struct omp_for_data_loop *) > > +alloca (gimple_om

[testsuite,committed]: Fix a test that assumed int is 32 bits.

2016-11-22 Thread Georg-Johann Lay
Committed as obvious because the test case is clearly about a vector of 4 * int. Johann gcc/testsuite/ * c-c++-common/builtin-shuffle-1.c (V): Use 4 * int in vector. Index: c-c++-common/builtin-shuffle-1.c === --- c-c++-c

Re: [PATCH 1/4] Remove build dependence on HSA run-time

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 02:27:44PM +0100, Martin Jambor wrote: > I have basically copied what libgfortran did, with additional checking > for HAVE_UNISTD_H when attempting to implement secure_getenv in its > absence (which is maybe unnecessary but should not do any harm) and I > also needed to add

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread David Malcolm
On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > @@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, > > > > int idx) > > > > if (INSN_HAS_LOCATION

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Bernd Schmidt
On 11/22/2016 02:37 PM, Jakub Jelinek wrote: Can't it be done only if xloc.file contains any fancy characters? Sure, but why? Strings generally get emitted with quotes around them, I don't see a good reason for filenames to be different, especially if it makes the output easier to parse. I

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Dominik Vogt
On Tue, Nov 22, 2016 at 09:25:03AM -0500, David Malcolm wrote: > On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > > > @@ -284,7 +292,7 @@ print_rtx_operand_code_i

Re: [arm-embedded][PATCH, GCC/ARM, 2/3] Error out for incompatible ARM multilibs

2016-11-22 Thread Thomas Preudhomme
Hi, We decided to also apply this patch to the ARM embedded 6 branch. Best regards, Thomas On 17/12/15 09:32, Thomas Preud'homme wrote: Hi, We decided to apply the following patch to the ARM embedded 5 branch. Best regards, Thomas -Original Message- From: gcc-patches-ow...@gcc.gn

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

2016-11-22 Thread Kyrill Tkachov
On 22/11/16 14:42, Bernd Edlinger wrote: Hi, does this follow-up patch look reasonable? See: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01945.html Is it OK for trunk? Ah yes, this one slipped my attention. This is ok. Thanks, Kyrill Thanks Bernd. On 11/21/16 21:46, Christophe Lyon wr

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > >Can't it be done only if xloc.file contains any fancy characters? > > Sure, but why? Strings generally get emitted with quotes around them, I > don't see a good reason for filenames to

[arm-embedded] [PATCH, GCC/ARM 1/2] Add multilib support for embedded bare-metal targets

2016-11-22 Thread Thomas Preudhomme
Hi, We have decided to backport this patch to add support for multilib for embedded bare-metal targets to our embedded-6-branch. *** gcc/ChangeLog.arm *** 2016-11-22 Thomas Preud'homme Backport from mainline 2016-11-22 Thomas Preud'homme * config.gcc: Allow new

Re: Fix PR78154

2016-11-22 Thread Richard Biener
On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 21 November 2016 at 15:34, Richard Biener wrote: > > On Fri, 18 Nov 2016, Prathamesh Kulkarni wrote: > > > >> On 17 November 2016 at 15:24, Richard Biener wrote: > >> > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > >> > > >> >> On 17 Novem

Re: PR78153

2016-11-22 Thread Richard Biener
On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 21 November 2016 at 15:10, Richard Biener wrote: > > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: > > > >> Hi, > >> As suggested by Martin in PR78153 strlen's return value cannot exceed > >> PTRDIFF_MAX. > >> So I set it's range to [0, PTRDI

Re: [v3 PATCH] LWG 2766, LWG 2749

2016-11-22 Thread Ville Voutilainen
On 22 November 2016 at 15:36, Jonathan Wakely wrote: >> +#if __cplusplus > 201402L || !defined(__STRICT_ANSI__) // c++1z or >> gnu++11 >> + template >> +inline >> +typename enable_if<__not_<__and_<__is_swappable<_T1>, >> +__is_swappable<_T2>>>::value>::

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

2016-11-22 Thread Bernd Edlinger
Hi, does this follow-up patch look reasonable? See: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01945.html Is it OK for trunk? Thanks Bernd. On 11/21/16 21:46, Christophe Lyon wrote: > On 18 November 2016 at 16:50, Bernd Edlinger > wrote: >> On 11/18/16 12:58, Christophe Lyon wrote: >>> O

Re: [v3 PATCH] LWG 2766, LWG 2749

2016-11-22 Thread Jonathan Wakely
On 22/11/16 16:59 +0200, Ville Voutilainen wrote: On 22 November 2016 at 15:36, Jonathan Wakely wrote: +#if __cplusplus > 201402L || !defined(__STRICT_ANSI__) // c++1z or gnu++11 + template +inline +typename enable_if<__not_<__and_<__is_swappable<_T1>, +

Re: [PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Jeff Law
On 11/22/2016 05:25 AM, Uros Bizjak wrote: Hello! New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make argument doesn't work in the later c

[testsuite,committed]: Restrict 2 test cases to big targets.

2016-11-22 Thread Georg-Johann Lay
This adds requirements for 2 test cases: loop-split.c needs 32-bit int at least. Use int32plus as I didn't intend to change the very test case. gcc.dg/stack-layout-dynamic-1.c aligns the stack to 16 bits so ptr32plus seems reasonable. Committed to trunk. Johann gcc/testsuite/

Re: [Patch, Fortran, OOP] PR 78443: Incorrect behavior with non_overridable keyword

2016-11-22 Thread Steve Kargl
On Tue, Nov 22, 2016 at 01:14:46PM +0100, Janus Weil wrote: > > here is a patch for a wrong-code problem with non_overridable > type-bound procedures. For details see the PR. Regtests cleanly. Ok > for trunk? OK. > Since the patch is very simple and it fixes wrong code which can > silently give

Re: PR78153

2016-11-22 Thread Prathamesh Kulkarni
On 22 November 2016 at 20:18, Richard Biener wrote: > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > >> On 21 November 2016 at 15:10, Richard Biener wrote: >> > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> As suggested by Martin in PR78153 strlen's return value cannot e

Re: PR78153

2016-11-22 Thread Richard Biener
On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 22 November 2016 at 20:18, Richard Biener wrote: > > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > > > >> On 21 November 2016 at 15:10, Richard Biener wrote: > >> > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: > >> > > >> >> Hi, > >> >>

[PATCH] Fix PR78472

2016-11-22 Thread Richard Biener
The following fixes a C/C++ interoperability issue with LTO when zero-sized fields appear in one variant of a struct but not in another. Bootstrap & regtest in progress on x86_64-unknown-linux-gnu. Richard. 2016-11-22 Richard Biener PR lto/78472 * tree.c (gimple_canonical_ty

[testsuite,committed] Fix prototype of memset in a test case.

2016-11-22 Thread Georg-Johann Lay
One test case used unsigned long for the 3rd parameter of memset, which should be size_t. This made the test crash for targets where correct parameter passing depends on correct prototypes. Fixed and committed as obvious. Johann gcc/testsuite/ * gcc.c-torture/execute/pr30778.c (mems

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread David Malcolm
On Tue, 2016-11-22 at 15:45 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > > > Can't it be done only if xloc.file contains any fancy characters? > > > > Sure, but why? Strings generally get emitted wit

[PATCH] Fix up handle_pragma_target (PR target/78451)

2016-11-22 Thread Jakub Jelinek
Hi! #pragma GCC targets when used more than once without being undone through #pragma GCC pop_options in between seems to act wierdly and is the reason why sse-22a.c testcase now fails on x86_64/i686-linux. The problem is that to some extent #pragma GCC target ("f1", "f2,f3") #pragma GCC target ("

Re: [PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Marc Glisse
On Tue, 22 Nov 2016, Uros Bizjak wrote: New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make argument doesn't work in the later case. Atta

Re: [PATCH PR68030/PR69710][RFC]Introduce a simple local CSE interface and use it in vectorizer

2016-11-22 Thread Bin.Cheng
On Mon, Nov 21, 2016 at 9:34 PM, Doug Gilmore wrote: > I haven't seen any followups to this discussion of Bin's patch to > PR68303 and PR69710, the patch submission: > http://gcc.gnu.org/ml/gcc-patches/2016-05/msg02000.html > > Discussion: > http://gcc.gnu.org/ml/gcc-patches/2016-07/msg00761.html

Re: [Patch, Fortran, OOP] PR 78443: Incorrect behavior with non_overridable keyword

2016-11-22 Thread Janus Weil
2016-11-22 16:16 GMT+01:00 Steve Kargl : >> here is a patch for a wrong-code problem with non_overridable >> type-bound procedures. For details see the PR. Regtests cleanly. Ok >> for trunk? > > OK. Thanks, Steve. Committed as r242703. >> Since the patch is very simple and it fixes wrong code wh

[PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

2016-11-22 Thread Jakub Jelinek
Hi! _mm_setzero_di is problematic, because it is outside of AVX512* guarded area, but it actually requires SSE2 which might not be enabled. As discussed in the PR, I don't see neither _mm_setzero_[dh]i routines in ICC headers nor in AVX/AVX512 manuals, and fail to see what the difference is betwee

Re: PR78153

2016-11-22 Thread Prathamesh Kulkarni
On 22 November 2016 at 20:53, Richard Biener wrote: > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > >> On 22 November 2016 at 20:18, Richard Biener wrote: >> > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: >> > >> >> On 21 November 2016 at 15:10, Richard Biener wrote: >> >> > On Sun, 20 No

[PATCH] Add avx5124fmaps,avx5124vnniw to sse-22.c target pragma (PR target/78451)

2016-11-22 Thread Jakub Jelinek
Hi! As mentioned in the PR, these 2 ISAs were added to just the first of the two Intel specific target pragmas (the first one is used in the sse-22.c test itself, the second one when it is included from sse-22a.c). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-11-22

Re: [PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Jonathan Wakely
On 22/11/16 16:54 +0100, Marc Glisse wrote: On Tue, 22 Nov 2016, Uros Bizjak wrote: New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make a

[PATCH] PR78465 Remove runtime tests for macros

2016-11-22 Thread Jonathan Wakely
Andrew MacLeod did some digging and foudn that this test was changed from using #if to using a runtime if and abort() because the LOCK_FREE macros resolved to runtime calls at one point. However, they later got changed to predefined macros, and so can be changed back to using #if. This should fix

Re: [PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

2016-11-22 Thread Uros Bizjak
On Tue, Nov 22, 2016 at 5:09 PM, Jakub Jelinek wrote: > Hi! > > _mm_setzero_di is problematic, because it is outside of AVX512* guarded > area, but it actually requires SSE2 which might not be enabled. > As discussed in the PR, I don't see neither _mm_setzero_[dh]i routines > in ICC headers nor in

Re: [PATCH] Add avx5124fmaps,avx5124vnniw to sse-22.c target pragma (PR target/78451)

2016-11-22 Thread Uros Bizjak
On Tue, Nov 22, 2016 at 5:12 PM, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, these 2 ISAs were added to just the first of the two > Intel specific target pragmas (the first one is used in the sse-22.c test > itself, the second one when it is included from sse-22a.c). > > Bootstrapped/re

Re: [PATCH][ARM] PR target/78439: Update movdi constraints for Cortex-A8 tuning to handle LDRD/STRD

2016-11-22 Thread Ramana Radhakrishnan
On Tue, Nov 22, 2016 at 9:57 AM, Kyrill Tkachov wrote: > Hi all, > > This PR is an ICE while bootstrapping GCC with Cortex-A8 tuning, which we > also get from the default ARMv7-A tuning. > The ldrd/strd peepholes were recently made more aggressive and in this case > they transform: > (insn 13 33 4

Re: [PR target/78213] Do not ICE on non-empty -fself-test

2016-11-22 Thread Bernd Schmidt
On 11/16/2016 11:45 AM, Aldy Hernandez wrote: I would prefer Jakub's suggestion of running in finish_options(). I suspect we'll want both. Selftests should really run in an environment that's as close as possible to what would normally be going on in the compiler. I assume there are other

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-22 Thread Kyrill Tkachov
On 18/11/16 12:50, Segher Boessenkool wrote: On Fri, Nov 18, 2016 at 09:29:13AM +, Kyrill Tkachov wrote: So your COMPONENTS_FOR_BB returns both components in a pair whenever one of those is needed? That should work afaics. I mean I still want to have one component per register and since e

Re: [PATCH, testsuite]: Fix detection of -j make argument

2016-11-22 Thread Uros Bizjak
On Tue, Nov 22, 2016 at 4:54 PM, Marc Glisse wrote: > On Tue, 22 Nov 2016, Uros Bizjak wrote: > >> New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a >> different way. While older makes pass only "-j", newer makes pass e.g. >> "-j4" when -j is specified on the command line. The detect

Re: [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

2016-11-22 Thread Jeff Law
On 11/08/2016 05:09 PM, Martin Sebor wrote: The -Wformat-length checker relies on the compute_builtin_object_size function to determine the size of the buffer it checks for overflow. The function returns either a size computed by the tree-object-size pass for objects referenced by the __builtin_o

Re: [PATCH] Fix PR78230

2016-11-22 Thread Jeff Law
On 11/08/2016 07:43 PM, Kito Cheng wrote: gcc/testsuite/ChangeLog: 2016-11-09 Kito Cheng PR target/78230 * gcc.dg/torture/pr66178.c (test): Use uintptr_t instead of int. (test2) Ditto. OK. jeff

Re: [PATCH] Delete GCJ

2016-11-22 Thread Sandra Loosemore
On 11/21/2016 04:23 PM, Matthias Klose wrote: On 21.11.2016 18:16, Rainer Orth wrote: Hi Matthias, ahh, didn't see that :-/ Now fixed, is this clearer now? The options @option{--with-target-bdw-gc-include} and @option{--with-target-bdw-gc-lib} must always specified together for

Re: gomp-nvptx branch - middle-end changes

2016-11-22 Thread Alexander Monakov
On Fri, 11 Nov 2016, Jakub Jelinek wrote: > Ok for trunk, once the needed corresponding config/nvptx bits are committed, > with one nit below that needs immediate action and the rest can be resolved > incrementally. I'd like to check in afterwards the attached patch, at least > for now, so that no

Re: [PATCH] Add map clauses to libgomp test device-3.f90

2016-11-22 Thread Alexander Monakov
On Tue, 15 Nov 2016, Alexander Monakov wrote: > On Tue, 15 Nov 2016, Alexander Monakov wrote: > > Yep, I do see new test execution failures with both Intel MIC and PTX > > offloading > > on device-1.f90, device-3.f90 and target2.f90. Here's an actually-tested > > patch > > for the first two (on

Re: gomp-nvptx branch - middle-end changes

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 08:25:45PM +0300, Alexander Monakov wrote: > On Fri, 11 Nov 2016, Jakub Jelinek wrote: > > Ok for trunk, once the needed corresponding config/nvptx bits are committed, > > with one nit below that needs immediate action and the rest can be resolved > > incrementally. I'd lik

Go patch committed: Rewrite panic/defer code from C to Go

2016-11-22 Thread Ian Lance Taylor
This patch to the Go frontend and libgo rewrites the panic/defer code from C to Go. The actual stack unwind code is still in C, but the rest of the code, notably all the memory allocation, is now in Go. The names are changed to the names used in the Go 1.7 runtime, but the code is necessarily some

[PATCH, Fortran, cosmetics] Use convenience functions and constants

2016-11-22 Thread Andre Vehreschild
Hi all, during more hacking on the allocatable components in derived type coarrays, I encountered the improvable code fragments in the patch attached. Bootstraps and regtests ok on x86_64-linux/F23. Ok for trunk? Regards, Andre PS: The patch that motivated these changes follows as soon

Re: [patch,avr] Fix PR60300: Minor prologue improvement.

2016-11-22 Thread Denis Chertykov
2016-11-22 15:41 GMT+03:00 Georg-Johann Lay : > This patch is a minor improvement of prologue length. It now allows frame > sizes of up to 11 to be allocated by RCALL + PUSH 0 sequences but limits the > number of RCALLs to 3. > > The PR has some discussion on size vs. speed consideration w.r. to u

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-22 Thread Denis Chertykov
Do you have any objections, George ? 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote: >> >> Ping! >> >> On Thursday 10 November 2016 01:53 PM, Pitchumani Sivanupandi wrote: >>> >>> On Wednesday 09 November 2016 08:05

formatting cleanups

2016-11-22 Thread Nathan Sidwell
I noticed some wonky formatting. Fixed as obvious. nathan -- Nathan Sidwell 2016-11-22 Nathan Sidwell gcc/ * gcc-ar.c (main): Fix indentation. * gcov-io.c (gcov_write_summary): Remove extraneous {...} * ggc-page.c (move_ptes_to_front): Fix formatting. * hsa-dump.c (dump_has_cfun): Fix i

Re: formatting cleanups

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 01:45:07PM -0500, Nathan Sidwell wrote: > - tree ii_tree = array_exprs[ii][jj]; > - (*node)[ii][jj].is_vector = true; > - (*node)[ii][jj].value = ARRAY_NOTATION_ARRAY (ii_tree); > - (*node)[ii][jj].start = ARRAY_NOTATION_START (ii_tree); > -

[PATCH, Fortran, accaf, v1] Add caf-API-calls to asynchronously handle allocatable components in derived type coarrays.

2016-11-22 Thread Andre Vehreschild
Hi all, attached patch addresses the need of extending the API of the caf-libs to enable allocatable components asynchronous allocation. Allocatable components in derived type coarrays are different from regular coarrays or coarrayed components. The latter have to be allocated on all images or on

Re: [PATCH] OpenACC routines -- middle end

2016-11-22 Thread Cesar Philippidis
On 11/18/2016 04:14 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:43:02PM -0800, Cesar Philippidis wrote: >> +error_at (OMP_CLAUSE_LOCATION (c), >> + "%qs specifies a conflicting level of parallelism", >> + omp_clause_code_name[OMP_CLAUSE_CODE (c)])

Re: [PATCH] OpenACC routines -- c front end

2016-11-22 Thread Cesar Philippidis
On 11/18/2016 04:21 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:43:23PM -0800, Cesar Philippidis wrote: >> @@ -11801,12 +11807,11 @@ c_parser_oacc_shape_clause (c_parser *parser, >> omp_clause_code kind, >> } >> >>location_t expr_loc = c_parser_peek_token (parser)->loc

Re: [PATCH] OpenACC routines -- middle end

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 11:53:50AM -0800, Cesar Philippidis wrote: > I've incorporated those changes in this patch. Is it ok for trunk? The ChangeLog mentions omp-low.[ch] changes, but the patch doesn't include them. Have they been dropped, or moved to another patch? > 2016-11-22 Cesar Philippid

Re: [PATCH] OpenACC routines -- fortran front end

2016-11-22 Thread Cesar Philippidis
On 11/18/2016 04:29 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:44:07PM -0800, Cesar Philippidis wrote: >> --- a/gcc/fortran/gfortran.h >> +++ b/gcc/fortran/gfortran.h >> @@ -314,6 +314,15 @@ enum save_state >> { SAVE_NONE = 0, SAVE_EXPLICIT, SAVE_IMPLICIT >> }; >> >> +/* Flags to kee

Re: [PATCH] OpenACC routines -- middle end

2016-11-22 Thread Cesar Philippidis
On 11/22/2016 11:58 AM, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 11:53:50AM -0800, Cesar Philippidis wrote: >> I've incorporated those changes in this patch. Is it ok for trunk? > > The ChangeLog mentions omp-low.[ch] changes, but the patch doesn't include > them. > Have they been dropped, o

Re: formatting cleanups

2016-11-22 Thread Nathan Sidwell
On 11/22/2016 01:48 PM, Jakub Jelinek wrote: When you are already changing this, the = should be on the next line. done -- Nathan Sidwell 2016-11-22 Nathan Sidwell * array-notation-common.c (cilkplus_extract_an_trplets): Fix indentation and formatting. Index: c-family/array-notation-c

Re: [PATCH] OpenACC routines -- c++ front end

2016-11-22 Thread Cesar Philippidis
On 11/11/2016 03:43 PM, Cesar Philippidis wrote: > Like it's c FE counterpart, this contains the following changes: > > * Updates c_parser_oacc_shape_clause to accept a location_t >argument in order to make the diagnostics more precise. > > * Adds support for the bind and nohost clauses. >

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-22 Thread Georg-Johann Lay
Denis Chertykov schrieb: Do you have any objections, George ? No, the last delta rev3 from 2016-11-10 looks fine to me. 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi : Ping! On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote: Ping! On Thursday 10 November 2016 01:53 PM,

Re: [PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 05:36:38PM +0100, Uros Bizjak wrote: > > Note that there is still _mm512_setzero_qi and _mm512_setzero_hi, > > shall those be replaced with _mm512_setzero_si512 too? > > Even those 2 aren't mentioned in ICC headers nor AVX512 manuals. > > Yes, please also remove these two.

[patch] boehm-gc removal and libobjc changes to build with an external bdw-gc

2016-11-22 Thread Matthias Klose
Re-posting this top-level, discussions and review happened in the GCJ removal thread: - https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02069.html (last patch review). - https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00387.html (first patch sent) - https://gcc.gnu.org/ml/gcc-patches/2016-10/

[C++ PATCH] Fix ICE during VEC_INIT_EXPR gimplification (PR c++/77739)

2016-11-22 Thread Jakub Jelinek
Hi! As mentioned in the PR, we ICE because part of the body is genericized twice and each time it wraps is_invisiref_parm RESULT_DECL (in this case, could be also PARM_DEC) into REFERENCE_REF_P INDIRECT_REF. The first time it is desirable, but when done again during VEC_INIT_EXPR gimplification wh

[PATCH] PR fortran/78479 -- allocate a charlen

2016-11-22 Thread Steve Kargl
The patch and ChangeLog shuod be sufficient to explain the change. Regression tested on x86_64-*-freebsd. OK to commit? 2016-11-22 Steven G. Kargl PR fortran/78479 * expr.c (gfc_apply_init): Allocate a charlen if needed. 2016-11-22 Steven G. Kargl PR fortran/7847

libgo patch committed: Don't check standard packages in go tool with gccgo

2016-11-22 Thread Ian Lance Taylor
When using the go tool with gccgo, we can't check for whether the standard packages are up to date, because we can't assume that the source code is available. And we can't read runtime/internal/sys/zversion.go, because that too is not generally available. This was fixed in the gc repository with

Re: [PATCH] PR fortran/78479 -- allocate a charlen

2016-11-22 Thread Janus Weil
Hi Steve, > The patch and ChangeLog shuod be sufficient to explain the change. > Regression tested on x86_64-*-freebsd. OK to commit? the patch itself looks good. For the test case, I'd prefer a somewhat more meaningful name (e.g. char_component_initializer_3.f90 or similar) and a mention of th

Re: [PATCH 6/9] Split class rtx_reader into md_reader vs rtx_reader

2016-11-22 Thread Richard Sandiford
Sorry, only just realised that this one hadn't been approved as part of the earlier series. David Malcolm writes: > gcc/ChangeLog: > * genpreds.c (write_tm_constrs_h): Update for renaming of > rtx_reader_ptr to md_reader_ptr. > (write_tm_preds_h): Likewise. > (write_insn_p

  1   2   >