Hi Thomas, >> the attached patch runs through gfortran's AST to check for missing >> location information.
one small comment: Is it necessary to introduce the extra CHECK_LOCUS macro? Couldn't you just use CHECKING_P alone? In your patch CHECK_LOCUS is basically just replicating CHECKING_P. And: Why not use DK_WARNING instead of DK_NOTE? Apart from that I don't see anything wrong with your patch (but I'm probably not the best person to review it) ... Cheers, Janus > 2016-11-14 Thomas Koenig <tkoe...@gcc.gnu.org> > > PR fortran/78226 > * error.c (gfc_warning_internal): New function. > * frontend-passes.c (CHECK_LOCUS): New macro. > (gfc_run_passes): Call check_locus if CHECK_LOCUS > is defined. > (check_locus_code): New function. > (check_locus_expr): New function. > (check_locus): New function. > * gfortran.h: Add prototype for gfc_warning_internal. > >
