[PATCH, PING*2] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-09-27 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted at . Thanks! -- Pierre-Marie de Rodat

[PATCH, PING] DWARF: remove pessimistic DWARF version checks for imported entities

2016-09-27 Thread Pierre-Marie de Rodat
Hello, On 08/18/2016 10:12 PM, Jeff Law wrote: Jakub -- you want to take a looksie at this one? Jason is on PTO for the next couple weeks. I'm not well versed enough to verify that d_i_m_o_d_1 has all the right checks or not. Ping for the patch submitted at

Re: [PATCH] [ARC] Add simple shift/rotate ops.

2016-09-27 Thread Andrew Burgess
* Claudiu Zissulescu [2016-06-17 11:13:08 +0200]: > Basic ARC cpus are having only simple shift operations. Here they are. > > OK to apply? This looks good to me. Thanks, Andrew > > gcc/ > 2016-06-09 Claudiu Zissulescu > > * config/arc/arc.md (*rotrsi3_cnt1): New pattern, >

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-27 Thread Florian Weimer
* Bernd Edlinger: >> “0 << 0” is used in a similar context, to create a zero constant for a >> multi-bit subfield of an integer. >> >> This example comes from GDB, in bfd/elf64-alpha.c: >> >> | insn = INSN_ADDQ | (16 << 21) | (0 << 16) | (0 << 0); >> > > Of course that is not a boolean context,

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 03:53:25PM +0200, Bernd Schmidt wrote: > What's the ratio of comments "fixed" to actual bugs found? IMO this is not > something we should inflict on users unasked. One might argue that users actually *asked* for this by turning on -Wextra. Marek

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-27 Thread Bernd Edlinger
On 09/27/16 16:10, Florian Weimer wrote: > * Bernd Edlinger: > >>> “0 << 0” is used in a similar context, to create a zero constant for a >>> multi-bit subfield of an integer. >>> >>> This example comes from GDB, in bfd/elf64-alpha.c: >>> >>> | insn = INSN_ADDQ | (16 << 21) | (0 << 16) | (0 << 0)

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-27 Thread Jason Merrill
On Tue, Sep 27, 2016 at 10:28 AM, Bernd Edlinger wrote: > On 09/27/16 16:10, Florian Weimer wrote: >> * Bernd Edlinger: >> “0 << 0” is used in a similar context, to create a zero constant for a multi-bit subfield of an integer. This example comes from GDB, in bfd/elf64-alpha.c:

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Jason Merrill
On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: > On Tue, 27 Sep 2016, Jakub Jelinek wrote: > >> Just compare that to the number of real bugs the warning found in gcc >> codebase. It is really worth it for -Wextra. > > All those bugs would also have been found as well when it had simply > ac

Re: [PATCH] [ARC] Fix emitting jump tables for ARCv2

2016-09-27 Thread Andrew Burgess
* Claudiu Zissulescu [2016-04-26 13:28:58 +0200]: > The compact casesi option only make sens for ARCv1 cores. For ARCv2 cores we > use the regular expansion. > > OK to apply? Claudiu, Could you rebase this onto the current head please. I couldn't get this to merge cleanly. Thanks, Andrew

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 10:48:50AM -0400, Jason Merrill wrote: > On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: > > On Tue, 27 Sep 2016, Jakub Jelinek wrote: > > > >> Just compare that to the number of real bugs the warning found in gcc > >> codebase. It is really worth it for -Wextra. > >

Re: [C++ PATCH] Fix -fsanitize=return on small functions (PR c++/77722)

2016-09-27 Thread Jason Merrill
On Tue, Sep 27, 2016 at 3:57 AM, Jakub Jelinek wrote: > @@ -1570,14 +1570,22 @@ cp_ubsan_maybe_instrument_return (tree f > + if (TREE_CODE (*p) == STATEMENT_LIST) > { > + tree_stmt_iterator i = tsi_last (*p); >tsi_link_after (&i, t, TSI_NEW_STMT); > } > + else > +{ > +

Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
Hi, I was asked by Ozkan Sezer (CC'ed) whether I'd agree to relicense include/filenames.h under LGPL2+ instead of GPL2+. I talked to Richard Stallman (in private email), and he authorized the change. So now I'm proposing the corresponding change to you. Thanks. P.S. Please CC me on any respon

Re: [PATCH] [ARC] New CPU C-define handler.

2016-09-27 Thread Andrew Burgess
* Claudiu Zissulescu [2016-05-19 13:57:44 +0200]: > This patch refactors how we handle the built-in preprocessor macros and > assertions for ARC. > > OK to apply? This looks like a good improvement to me. Thanks, Andrew > Claudiu > > gcc/ > 2016-05-02 Claudiu Zissulescu > > * con

Re: [wwwdocs] Add some missing C++17 features

2016-09-27 Thread Jason Merrill
On Mon, Sep 26, 2016 at 12:35 PM, Jakub Jelinek wrote: > > + New Rules for auto deduction from braced-init-list > + href="http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3922.html";>N3922 > > + No > + > + This is in GCC 5. OK with that change. Jason

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 04:54:28PM +0200, Marek Polacek wrote: > On Tue, Sep 27, 2016 at 10:48:50AM -0400, Jason Merrill wrote: > > On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: > > > On Tue, 27 Sep 2016, Jakub Jelinek wrote: > > > > > >> Just compare that to the number of real bugs the war

Re: Split c-common.c?

2016-09-27 Thread Jason Merrill
Sure. On Mon, Sep 26, 2016 at 10:57 AM, Jeff Law wrote: > On 09/26/2016 07:38 AM, Marek Polacek wrote: >> >> On Mon, Sep 26, 2016 at 03:26:28PM +0200, Jakub Jelinek wrote: >>> >>> On Mon, Sep 26, 2016 at 03:22:08PM +0200, Marek Polacek wrote: Before I spend time on this, I wanted to che

RE: [PATCH] MIPS/doc: Fix `d' constraint description

2016-09-27 Thread Maciej W. Rozycki
On Mon, 26 Sep 2016, Matthew Fortune wrote: > > * config/mips/constraints.md (d): Fix documentation. > > * doc/md.texi (Machine Constraints): Update accordingly. > > > > OK to apply? > > OK, thanks for the patch. Committed, thanks. Maciej

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-27 Thread Bernd Edlinger
On 09/27/16 16:42, Jason Merrill wrote: > On Tue, Sep 27, 2016 at 10:28 AM, Bernd Edlinger > wrote: >> On 09/27/16 16:10, Florian Weimer wrote: >>> * Bernd Edlinger: >>> > “0 << 0” is used in a similar context, to create a zero constant for a > multi-bit subfield of an integer. > >

[PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-27 Thread Jonathan Wakely
This adds the new 3D std::hypot() functions. This implementation seems to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or hypot(hypot(x, y), z), and should be a bit more accurate at very large or very small values due to reducing the arguments by the largest one. Improvements wel

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Bernd Schmidt
On 09/27/2016 05:04 PM, Jakub Jelinek wrote: On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: All those bugs would also have been found as well when it had simply accepted /fall.*thr/i anywhere in the preceding comment on one line. But all the recent spelling changes of comments to cater

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 05:04:23PM +0200, Jakub Jelinek wrote: > On Tue, Sep 27, 2016 at 04:54:28PM +0200, Marek Polacek wrote: > > On Tue, Sep 27, 2016 at 10:48:50AM -0400, Jason Merrill wrote: > > > On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: > > > > On Tue, 27 Sep 2016, Jakub Jelinek w

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 05:19:10PM +0200, Bernd Schmidt wrote: > On 09/27/2016 05:04 PM, Jakub Jelinek wrote: > >>>On Tue, Sep 27, 2016 at 9:56 AM, Michael Matz wrote: > All those bugs would also have been found as well when it had simply > accepted > /fall.*thr/i > anywhere in t

Re: debug container mutex association

2016-09-27 Thread Jonathan Wakely
On 20/09/16 09:53 +0100, Jonathan Wakely wrote: On 19/09/16 21:56 +0200, François Dumont wrote: Hi Following our conversation here is a much simpler patch. I just consider that all debug containers will have the same alignment. Even if I submit this patch as a whole I will commit into pi

Re: [PATCH] Last bit from Early LTO debug merge -- move break_out_includes

2016-09-27 Thread Jason Merrill
OK. On Tue, Sep 27, 2016 at 9:47 AM, Richard Biener wrote: > > This is moving break_out_includes (aka -feliminate-dwarf2-dups handling) > to early finish. It requires some massaging with the way we pick > up its results which previously "conveniently" ended up in the > limbo list but after movin

[PATCH] Define feature macro and update C++17 library status

2016-09-27 Thread Jonathan Wakely
This adds the missing feature macro for the searchers and updates the docs. * doc/xml/manual/status_cxx2017.xml: Update status. * doc/html/*: Regenerate. * include/std/functional (__cpp_lib_boyer_moore_searcher): Define. * testsuite/20_util/function_objects/searche

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Michael Matz
Hi, On Tue, 27 Sep 2016, Marek Polacek wrote: > > Perhaps we want -Wimplicit-fallthrough{,=1,=2,=3,=4}, where =1 would > > match indeed /fall.*thr/i (note, it will be really costly in this > > case, one will have to parse all comments in detail in the > > preprocessor, so I'd be against making

[COMMITTED, aarch64] Delete one redundant word in target-supports.exp comment

2016-09-27 Thread Jiong Wang
This patch deletes one redundant word in target-supports.exp function comment for "check_effective_target_arm_v8_2a_fp16_scalar_hw". s/instructions floating point instructions/floating point instructions/ The comment is re-indented. No other changes. Committed as obivious as r240551. gcc/t

Re: [AArch64][0/14] ARMv8.2-A FP16 extension support

2016-09-27 Thread Jiong Wang
On 25/07/16 12:26, James Greenhalgh wrote: On Thu, Jul 07, 2016 at 05:12:48PM +0100, Jiong Wang wrote: Hello, As a follow up of https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01240.html, This patch set adds ARMv8.2-A FP16 scalar and vector intrinsics support, gcc middle-end will also be aware

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Tom Tromey
> "Michael" == Michael Matz writes: Michael> All those bugs would also have been found as well when it had simply Michael> accepted Michael> /fall.*thr/i Michael> anywhere in the preceding comment on one line. But all the recent Michael> spelling changes of comments to cater for the stri

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread James Greenhalgh
On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: > Hi, > > This patch requires int32plus for > gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of > failures for a 16 bit int target like the avr. The "%u" format > specifier tests, for example, use int

PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
Currently Makefile.in contains -Wno-error for several of the insn-* files, but after further investigation I think with this patch we won't need them anymore. I'm not removing it until I bootstrap gcc on more arches, though. Meanwhile, this patch at least makes the code more robust. Richard S., c

Re: Add configure check for -Wimplicit-fallthrough

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 03:23:52PM +0200, Richard Biener wrote: > On Tue, Sep 27, 2016 at 3:13 PM, Jakub Jelinek wrote: > > On Tue, Sep 27, 2016 at 03:09:36PM +0200, Richard Biener wrote: > >> On Tue, Sep 27, 2016 at 3:05 PM, Marek Polacek wrote: > >> > Using -Wno-error where only -Wno-implicit-f

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 01:31:15PM +0200, Jakub Jelinek wrote: > On Tue, Sep 27, 2016 at 12:56:29PM +0200, Marek Polacek wrote: > > On Tue, Sep 27, 2016 at 12:47:50PM +0200, Jakub Jelinek wrote: > > > On Tue, Sep 27, 2016 at 12:39:41PM +0200, Markus Trippelsdorf wrote: > > > > On 2016.09.27 at 10:4

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Martin Sebor
On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at gimple-ssa-sprintf.c:1165 four or so days ago. https://

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Martin Sebor
On 09/27/2016 11:29 AM, Martin Sebor wrote: On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at gimple-ssa-s

Re: [BUILDROBOT] tic6x-uclinux: undefined reference to `gnu_libc_printf_pointer_format(tree_node*, char const**)'

2016-09-27 Thread Martin Sebor
On 09/26/2016 04:08 PM, Jan-Benedict Glaw wrote: Hi Martin, On Thu, 2016-09-08 13:03:12 -0600, Martin Sebor wrote: Attached is another update to the patch to address the last round of comments and suggestions, most notably to: [...] with the currently committed version, the tic6x-uclinux tar

Re: Change license of filenames.h to LGPL

2016-09-27 Thread DJ Delorie
Most of the files in include/ are GPL, not LGPL. Why is this one different?

[gomp4] loop abstraction fns

2016-09-27 Thread Nathan Sidwell
In implementing support for tile, the loop structure becomes a little more complex, such that oacc_loop_xform_loop's simple scanning approach fails. I realized, that wasn't necessary, if rather than count the abstraction functions when discovering the loops, we record the gimple calls themselve

Re: [gomp4] Fix tile parsing

2016-09-27 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 07:14:00AM -0400, Nathan Sidwell wrote: > --- c/c-parser.c (revision 240420) > +++ c/c-parser.c (working copy) > @@ -10882,6 +10882,7 @@ c_parser_omp_clause_collapse (c_parser * >location_t loc; > >check_no_duplicate_clause (list, OMP_CLAUSE_COLLAPSE, "co

Re: [C++ PATCH] Fix -fsanitize=return on small functions (PR c++/77722)

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 10:56:51AM -0400, Jason Merrill wrote: > On Tue, Sep 27, 2016 at 3:57 AM, Jakub Jelinek wrote: > > @@ -1570,14 +1570,22 @@ cp_ubsan_maybe_instrument_return (tree f > > + if (TREE_CODE (*p) == STATEMENT_LIST) > > { > > + tree_stmt_iterator i = tsi_last (*p); > >

Re: [gomp4] Fix tile parsing

2016-09-27 Thread Nathan Sidwell
On 09/27/16 14:07, Jakub Jelinek wrote: + case OMP_CLAUSE_TILE: + /* These clauses really need a positive integral constant +expression, but we don't have a predicate for that +(yet). */ + needs_ice = true; + /* FALLTHRU */ But why do you

Re: [ARM] Fix invalid instructions generated for data movement.

2016-09-27 Thread Christophe Lyon
Hi, On 27 September 2016 at 15:55, Kyrill Tkachov wrote: > Hi Matthew, > > > On 27/09/16 14:21, Matthew Wahab wrote: >> >> Recently added support for ARMv8.2-A >> (https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01240.html) included a >> number of changes to improve data movement, particularly for

[C++ PATCH] P0018R3, C++17 lambda capture of *this by value as [=,*this]

2016-09-27 Thread Jakub Jelinek
Hi! This patch implements P0018R3. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? BTW, not sure if/what we should do about say [this...] {} or [*this...] {}, the grammar seems to allow it (the former already in earlier standards), but this or *this is never a parameter pack

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Jeff Law
On 09/27/2016 11:52 AM, DJ Delorie wrote: Most of the files in include/ are GPL, not LGPL. Why is this one different? Right. ANd it's not like this file inserts anything of significance into the resulting object code. I'd really like to see more rationale behind the request for a license ch

Re: [gomp4] Fix tile parsing

2016-09-27 Thread Nathan Sidwell
On 09/27/16 14:17, Nathan Sidwell wrote: On 09/27/16 14:07, Jakub Jelinek wrote: +case OMP_CLAUSE_TILE: + /* These clauses really need a positive integral constant + expression, but we don't have a predicate for that + (yet). */ + needs_ice = true; + /* FALLT

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Jeff Law
On 09/27/2016 10:39 AM, James Greenhalgh wrote: On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: Hi, This patch requires int32plus for gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of failures for a 16 bit int target like the avr. The "%u" format

[PATCH] PR fortran/58991 and fortran/58992

2016-09-27 Thread Steve Kargl
The attached patch fixes both PR fortran/58991 and fortran/58992. The issue was that for a CHARACTER expression or variable as a selector in an ASSOCIATE statement, the type-spec was incomplete. That is, the actual length of the string was not set. The patch rectifies the problem (at least in my s

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
> From: DJ Delorie > Cc: gcc-patches@gcc.gnu.org, seze...@gmail.com > Date: Tue, 27 Sep 2016 13:52:10 -0400 > > > Most of the files in include/ are GPL, not LGPL. Why is this one > different? Because Ozkan wants to use it in an otherwise LGPL package.

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Florian Weimer
* Eli Zaretskii: >> From: DJ Delorie >> Cc: gcc-patches@gcc.gnu.org, seze...@gmail.com >> Date: Tue, 27 Sep 2016 13:52:10 -0400 >> >> >> Most of the files in include/ are GPL, not LGPL. Why is this one >> different? > > Because Ozkan wants to use it in an otherwise LGPL package. But then the

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
> Cc: gcc-patches@gcc.gnu.org, seze...@gmail.com > From: Jeff Law > Date: Tue, 27 Sep 2016 12:36:11 -0600 > > On 09/27/2016 11:52 AM, DJ Delorie wrote: > > > > Most of the files in include/ are GPL, not LGPL. Why is this one > > different? > Right. ANd it's not like this file inserts anything o

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Richard Sandiford
Marek Polacek writes: > Currently Makefile.in contains -Wno-error for several of the insn-* files, but > after further investigation I think with this patch we won't need them > anymore. > I'm not removing it until I bootstrap gcc on more arches, though. Meanwhile, > this patch at least makes th

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Florian Weimer
* Marek Polacek: > @@ -11498,21 +11508,23 @@ > case V64QImode: > case V32HImode: >if (TARGET_AVX512F) > - { > -tmp = "p"; > -ssesuffix = "q"; > -break; > - } > + { > + tmp = "p"; > + sse

Re: Change license of filenames.h to LGPL

2016-09-27 Thread DJ Delorie
Eli Zaretskii writes: > Because Ozkan wants to use it in an otherwise LGPL package. Ok, but that doesn't say why it's different. That reason could apply to any header in there. Do we need to convert all headers there to LGPL? Is this "otherwise LGPL package" in one of our repos, or elsewhere?

Re: [C++ PATCH] P0018R3, C++17 lambda capture of *this by value as [=,*this]

2016-09-27 Thread Jason Merrill
On Tue, Sep 27, 2016 at 2:27 PM, Jakub Jelinek wrote: > This patch implements P0018R3. Bootstrapped/regtested on x86_64-linux and > i686-linux, ok for trunk? OK, thanks. > BTW, not sure if/what we should do about say [this...] {} or [*this...] {}, > the grammar seems to allow it (the former alr

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Ozkan Sezer
On 9/27/16, DJ Delorie wrote: > > Eli Zaretskii writes: >> Because Ozkan wants to use it in an otherwise LGPL package. > > Ok, but that doesn't say why it's different. That reason could apply to > any header in there. Do we need to convert all headers there to LGPL? > Is this "otherwise LGPL pa

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: > * Marek Polacek: > > > @@ -11498,21 +11508,23 @@ > > case V64QImode: > > case V32HImode: > >if (TARGET_AVX512F) > > - { > > -tmp = "p"; > > -ssesuffix = "q"; > > -

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
> From: Florian Weimer > Cc: DJ Delorie , gcc-patches@gcc.gnu.org, seze...@gmail.com > Date: Tue, 27 Sep 2016 20:54:59 +0200 > > >> Most of the files in include/ are GPL, not LGPL. Why is this one > >> different? > > > > Because Ozkan wants to use it in an otherwise LGPL package. > > But then

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
> From: DJ Delorie > Cc: gcc-patches@gcc.gnu.org, seze...@gmail.com > Date: Tue, 27 Sep 2016 15:00:46 -0400 > > > Eli Zaretskii writes: > > Because Ozkan wants to use it in an otherwise LGPL package. > > Ok, but that doesn't say why it's different. That reason could apply to > any header in t

Re: [C++ PATCH] P0018R3, C++17 lambda capture of *this by value as [=,*this]

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 03:08:07PM -0400, Jason Merrill wrote: > On Tue, Sep 27, 2016 at 2:27 PM, Jakub Jelinek wrote: > > This patch implements P0018R3. Bootstrapped/regtested on x86_64-linux and > > i686-linux, ok for trunk? > > OK, thanks. Apparently I forgot to add feature macro for this. T

Re: Change license of filenames.h to LGPL

2016-09-27 Thread DJ Delorie
Eli Zaretskii writes: >> But then the implementation would need relicensing as well, wouldn't >> it? > > Which implementation? of Ozkan's library? libiberty's filename_cmp.c is GPL and implements two of the functions in filenames.h; if those are why he's using it, then it's still GPL unless filen

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Florian Weimer
* Marek Polacek: > On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: >> * Marek Polacek: >> >> > @@ -11498,21 +11508,23 @@ >> > case V64QImode: >> > case V32HImode: >> >if (TARGET_AVX512F) >> > - { >> > -tmp = "p"; >> > -

[PATCH] fix profiledbootstrap with -Werror=format-length (77753)

2016-09-27 Thread Martin Sebor
The attached one line patch increases a local buffer size to avoid an apparently justified (though in reality likely a false positive) -Wformat-length warning in varasm.c. The warning has been reported to break profiledbootstrap on powerp64le (though not ordinary bootstrap). An arguably better s

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Marek Polacek
On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > * Marek Polacek: > > > On Tue, Sep 27, 2016 at 08:58:59PM +0200, Florian Weimer wrote: > >> * Marek Polacek: > >> > >> > @@ -11498,21 +11508,23 @@ > >> > case V64QImode: > >> > case V32HImode: > >> >if

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Eli Zaretskii
> From: DJ Delorie > Cc: f...@deneb.enyo.de, gcc-patches@gcc.gnu.org, seze...@gmail.com > Date: Tue, 27 Sep 2016 15:23:46 -0400 > > Eli Zaretskii writes: > >> But then the implementation would need relicensing as well, wouldn't > >> it? > > > > Which implementation? of Ozkan's library? > > libi

Re: Change license of filenames.h to LGPL

2016-09-27 Thread Ozkan Sezer
On 9/27/16, Eli Zaretskii wrote: >> From: DJ Delorie >> Cc: f...@deneb.enyo.de, gcc-patches@gcc.gnu.org, seze...@gmail.com >> Date: Tue, 27 Sep 2016 15:23:46 -0400 >> >> Eli Zaretskii writes: >> >> But then the implementation would need relicensing as well, wouldn't >> >> it? >> > >> > Which imp

Re: [C++ PATCH] P0018R3, C++17 lambda capture of *this by value as [=,*this]

2016-09-27 Thread Jason Merrill
OK, thanks. On Tue, Sep 27, 2016 at 3:22 PM, Jakub Jelinek wrote: > On Tue, Sep 27, 2016 at 03:08:07PM -0400, Jason Merrill wrote: >> On Tue, Sep 27, 2016 at 2:27 PM, Jakub Jelinek wrote: >> > This patch implements P0018R3. Bootstrapped/regtested on x86_64-linux and >> > i686-linux, ok for trun

Re: Change license of filenames.h to LGPL

2016-09-27 Thread DJ Delorie
Ozkan Sezer writes: > I am not using filename_cmp.c, nor do I include hashtab.h. The version > I took was an old one with macros only and I added some more macros and > inlines to it. (I replied to these, but I forgot including the CC list, > here: http://gcc.gnu.org/ml/gcc-patches/2016-09/msg02

Re: PATCH to add more FALLTHRU markers

2016-09-27 Thread Jakub Jelinek
On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > Not sure if I read this code correctly, but if we fall through from > V32HImode, and we have TARGET_SSE2 set, we execute this code: > > tmp = "p"; > ssesuffix = TARGET_AVX512VL ? "q" : ""; > > And not gcc_unreachable ()

Re: [PATCH RESEND 2/2] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

2016-09-27 Thread Denys Vlasenko
On 09/27/2016 01:53 PM, Bernd Schmidt wrote: On 09/26/2016 09:08 PM, Denys Vlasenko wrote: +@gccoptlist{-faggressive-loop-optimizations @gol +-falign-functions[=@var{n}[,@var{m},[@var{n}[,@var{m} @gol +-falign-jumps[=@var{n}[,@var{m}]] @gol +-falign-labels[=@var{n}[,@var{m}]] -falign-loops[=

Re: debug container mutex association

2016-09-27 Thread François Dumont
On 27/09/2016 17:29, Jonathan Wakely wrote: On 20/09/16 09:53 +0100, Jonathan Wakely wrote: On 19/09/16 21:56 +0200, François Dumont wrote: Hi Following our conversation here is a much simpler patch. I just consider that all debug containers will have the same alignment. Even if I submi

Go patch committed: add src information to AST dumps

2016-09-27 Thread Ian Lance Taylor
This patch by Than McIntosh adds some file/line information to the AST dumps generated by the Go frontend. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 2016-09-27 Than McIntosh * go-linemap.cc (Gcc_linemap::to_string): New method. Index: gcc/go/Change

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Christophe Lyon
On 27 September 2016 at 20:38, Jeff Law wrote: > On 09/27/2016 10:39 AM, James Greenhalgh wrote: >> >> On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: >>> >>> Hi, >>> >>> This patch requires int32plus for >>> gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bun

Re: [PATCH 4/5] shrink-wrap: Shrink-wrapping for separate components

2016-09-27 Thread Jeff Law
On 09/23/2016 02:21 AM, Segher Boessenkool wrote: Deciding what blocks should run with a certain component active so that the total cost of executing the prologues (and epilogues) is optimal, is not a computationally feasible problem. Instead, for each basic block, we estimate the cost of puttin

Patch ping

2016-09-27 Thread Jakub Jelinek
Hi! On Tue, Sep 20, 2016 at 06:12:26PM +0200, Jakub Jelinek wrote: > 2016-09-20 Jakub Jelinek > > PR c++/77467 > * constexpr.c (enum constexpr_switch_state): New. > (struct constexpr_ctx): Add css_state field. > (label_matches): Add CTX and STMT arguments, remove I and

Go patch committed: Don't duplicate calls with multiple results

2016-09-27 Thread Ian Lance Taylor
While moving expressions around to preserve the specified order of evaluation, the Go frontend was duplicating call expressions with multiple results. This had no bad effect as the second instance generated no code for the backend. But, it's pointless and wasteful. This patch by Than McIntosh fix

libgo patch committed: Separate mksysinfo inputs into separate Makefile targets

2016-09-27 Thread Ian Lance Taylor
This patch to libgo separates the inputs to mksysinfo.sh into separate Makefile targets. This is a step toward a smaller version of mksysinfo.sh that will generate system-specific information for the runtime package. The runtime package can not import the syscall package, as the syscall package i

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Mike Stump
On Sep 27, 2016, at 11:38 AM, Jeff Law wrote: > > On 09/27/2016 10:39 AM, James Greenhalgh wrote: >> On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: >>> Hi, >>> >>> This patch requires int32plus for >>> gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-27 Thread Marc Glisse
On Tue, 27 Sep 2016, Jonathan Wakely wrote: This adds the new 3D std::hypot() functions. This implementation seems to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or hypot(hypot(x, y), z), and should be a bit more accurate at very large or very small values due to reducing the

Re: Split c-common.c?

2016-09-27 Thread Joseph Myers
On Mon, 26 Sep 2016, Marek Polacek wrote: > Before I spend time on this, I wanted to check if you consider this a good > idea. Since c-common.c has grown a lot and is quite large now, I think we > might split it into c-warn.c, where various warning routines would go. What > do > you think? If

[PATCH] fix typos behind incorrect destination buffer length in -Wformat-length warning (77762)

2016-09-27 Thread Martin Sebor
The attached patch corrects a couple of typos in argument numbers in the handling of __builtin__vsnprintf_chk calls in the gimple- ssa-sprintf pass, and another couple of typos in the test for this that were masking this failure. As an aside, the patch also fixes the off-by-one line test failures

Re: [PATCH, Fortran] Extension: COTAN and degree-valued trig intrinsics with -fdec-math

2016-09-27 Thread Joseph Myers
On Mon, 26 Sep 2016, Tobias Burnus wrote: > Regarding the decimal trigonometric functions, the internet suggests to > use >sin (fmod ((x), 360) * M_PI / 180) > instead of >sin (x * M_PI / 180) > to yield better results for angles which are larger than +/-360 degrees. Actually for good res

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-27 Thread Joseph Myers
On Tue, 27 Sep 2016, Jonathan Wakely wrote: > This adds the new 3D std::hypot() functions. This implementation seems > to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or > hypot(hypot(x, y), z), and should be a bit more accurate at very large > or very small values due to reducin

[PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-27 Thread Alan Modra
Extend this attribute to cover long double ABIs, for 64-bit too. The idea is that the linker should warn if you are linking object files with incompatible ABIs, for example IEEE128 long double with IBM long double. It's only a warning, and doesn't catch everything. In particular, global data mis

[PATCH 2/2] Disable .gnu_attribute tags in compatibility-ldbl.o

2016-09-27 Thread Alan Modra
compatibility-ldbl.o is compiled with -mlong-double-64. When long double .gnu_attribute tags are checked by the linker, it complains about the mismatch between this file and others in libstdc++. Bootstrapped and regression tested powerpc64le-linux and powerpc64-linux biarch. OK to apply?

Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-27 Thread Joseph Myers
On Wed, 28 Sep 2016, Alan Modra wrote: > I've also added a new option, default on, that disables output of > .gnu_attribute tags. That's needed because this patch alone > introduces libstdc++ testsuite regressions, fixed by the next patch. This option is missing documentation in invoke.texi. >

Re: [PATCH 2/2] Disable .gnu_attribute tags in compatibility-ldbl.o

2016-09-27 Thread Joseph Myers
On Wed, 28 Sep 2016, Alan Modra wrote: > compatibility-ldbl.o is compiled with -mlong-double-64. When > long double .gnu_attribute tags are checked by the linker, it > complains about the mismatch between this file and others in > libstdc++. Is that the only file in libstdc++ that involves long

Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-27 Thread Alan Modra
On Wed, Sep 28, 2016 at 01:20:22AM +, Joseph Myers wrote: > On Wed, 28 Sep 2016, Alan Modra wrote: > > > I've also added a new option, default on, that disables output of > > .gnu_attribute tags. That's needed because this patch alone > > introduces libstdc++ testsuite regressions, fixed by t

Re: [PATCH 2/2] Disable .gnu_attribute tags in compatibility-ldbl.o

2016-09-27 Thread Alan Modra
On Wed, Sep 28, 2016 at 01:26:12AM +, Joseph Myers wrote: > On Wed, 28 Sep 2016, Alan Modra wrote: > > > compatibility-ldbl.o is compiled with -mlong-double-64. When > > long double .gnu_attribute tags are checked by the linker, it > > complains about the mismatch between this file and others

Re: [PATCH] fix profiledbootstrap with -Werror=format-length (77753)

2016-09-27 Thread Jeff Law
On 09/27/2016 01:30 PM, Martin Sebor wrote: The attached one line patch increases a local buffer size to avoid an apparently justified (though in reality likely a false positive) -Wformat-length warning in varasm.c. The warning has been reported to break profiledbootstrap on powerp64le (though n

Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues

2016-09-27 Thread Jeff Law
On 09/27/2016 11:29 AM, Martin Sebor wrote: On 09/26/2016 02:30 AM, Gerald Pfeifer wrote: Hi Martin, I'm afraid there may be further fallout from your patch. GCC now bootstraps fine on my tester, but building Wine I started to see internal compiler error: in format_floating, at gimple-ssa-s

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Jeff Law
On 09/27/2016 03:41 PM, Mike Stump wrote: On Sep 27, 2016, at 11:38 AM, Jeff Law wrote: On 09/27/2016 10:39 AM, James Greenhalgh wrote: On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: Hi, This patch requires int32plus for gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, a

Re: [PATCH] fix typos behind incorrect destination buffer length in -Wformat-length warning (77762)

2016-09-27 Thread Jeff Law
On 09/27/2016 04:50 PM, Martin Sebor wrote: The attached patch corrects a couple of typos in argument numbers in the handling of __builtin__vsnprintf_chk calls in the gimple- ssa-sprintf pass, and another couple of typos in the test for this that were masking this failure. As an aside, the patch

[PATCH] Fix gcc.dg/tree-ssa/pr68198.c

2016-09-27 Thread Bernd Edlinger
Hi, this test does fail because a non-existent dump file is referenced in the dg-final. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. OK for trunk? Thanks Bernd. 2016-09-28 Bernd Edlinger * gcc.dg/tree-ssa/pr68198.c: Fix dg-final. Index: gcc/testsuite/gcc.dg/tree-ssa/pr68198.c ===

Re: [PATCH] Fixed up missing semicolons.

2016-09-27 Thread Jeff Law
On 09/26/2016 07:20 PM, lhmouse wrote: My name is Liu Hao. :> Thanks. I've updated the ChangeLog entry. Thanks for your work. And thanks for the mingw patch -- we're always grateful for any help we can get on the lesser used platforms. Jeff ps. Yes, I am law on IRC, but I was away when y

Re: [PATCH] Fix gcc.dg/tree-ssa/pr68198.c

2016-09-27 Thread Jeff Law
On 09/27/2016 10:47 PM, Bernd Edlinger wrote: Hi, this test does fail because a non-existent dump file is referenced in the dg-final. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. OK for trunk? OK. FWIW, the key here is that the dg-options explicitly disable early jump threading, so l

[patch, libgfortran] PR77707 formatted direct access: nextrec off by one

2016-09-27 Thread Jerry DeLisle
I plan to commit the attached patch in the next few days. Fairly simple. Regression tested on x86-64. Regards, Jerry 2016-09-27 Jerry DeLisle PR libgfortran/77707 io/transfer.c (next_record): Flush before calculating next_record. Correctly calculate. diff --git a/li

Re: [PATCH GCC][v2]Simplify alias check code generation in vectorizer

2016-09-27 Thread Markus Trippelsdorf
On 2016.09.27 at 15:22 +0200, Richard Biener wrote: > On Tue, 27 Sep 2016, Robin Dapp wrote: > > > > Also the '=' in the split line goes to the next line according to > > > coding conventions. > > > > fixed, I had only looked at an instance one function above which had it > > wrong as well. Also

Re: [Patch, testsuite] Require int32plus for builtin-sprintf-warn-1.c

2016-09-27 Thread Senthil Kumar Selvaraj
James Greenhalgh writes: > On Tue, Sep 27, 2016 at 04:40:22PM +0530, Senthil Kumar Selvaraj wrote: >> Hi, >> >> This patch requires int32plus for >> gcc.dg/tree-ssa/builtin-sprintf-warn-1.c, as it reports a bunch of >> failures for a 16 bit int target like the avr. The "%u" format >> spe

<    1   2