On 09/27/16 14:17, Nathan Sidwell wrote:
On 09/27/16 14:07, Jakub Jelinek wrote:
+ case OMP_CLAUSE_TILE:
+ /* These clauses really need a positive integral constant
+ expression, but we don't have a predicate for that
+ (yet). */
+ needs_ice = true;
+ /* FALLTHRU */
But why do you need this (at least for OMP_CLAUSE_COLLAPSE)?
The OMP_CLAUSE_COLLAPSE (and OMP_CLAUSE_ORDERED if not NULL) argument
is required to be INTEGER_CST already during parsing, it can't be even
template argument etc. (because we need that number already during parsing
to find out how many nested loops to parse specially).
So I don't see how would the last argument to tsubst_expr make any
difference there.
Oh, I'd not realized it couldn't be a template argument. (the same is not true
of tile parameters).
Er, why is tsubst_expr even trying to feed them to tsubst_expr in that case?
(it's harmless, but extra work)
nathan
