Re: [gomp4] expunge shared_size from launch API

2015-09-02 Thread Tom de Vries
On 01-09-15 12:15, Tom de Vries wrote: On 31/08/15 19:39, Nathan Sidwell wrote: * builtin-types.def (DEF_FUNCTION_TYPE_VAR_6): Define. Committed attached follow-up patch to fix the ada build. Thanks, - Tom 0001-Fix-gomp-4_0-branch-ada-build.patch Fix gomp-4_0-branch ada build 2015-0

[Patch, avr] Fix PR65210

2015-09-02 Thread Senthil Kumar Selvaraj
Hi, This (rather trivial) patch fixes PR65210. The ICE happens because code wasn't handling io_low attribute where it is supposed to. If this is ok, could someone commit please? I don't have commit access. Regards Senthil gcc/ChangeLog 2015-09-02 Senthil Kumar Selvaraj PR t

Re: [Patch, libfortran] PR 67414 Improve error handling

2015-09-02 Thread FX
> Hmm, in that case errnum must be set to 0. What about the attached > patch, which prints the existing message if errnum == 0, and the new > and improved only for errnum > 0? OK. Thanks for the patch. FX

Re: [PATCH v2] [libstdc++] Run tests on RTEMS

2015-09-02 Thread Sebastian Huber
On 01/09/15 23:07, Jeff Law wrote: On 09/01/2015 05:02 AM, Sebastian Huber wrote: v2: Include all options and not only "dg-do run ...". libstdc++-v3/ChangeLog 2015-09-01 Sebastian Huber testsuite/*: Use 's/\*-\*-cygwin\* /&*-*-rtems* /' to add RTEMS target selector to all tests that

Re: [PATCH][wwwdocs][AArch64] Add entry for target attributes and pragmas

2015-09-02 Thread Kyrill Tkachov
Hi Gerald, On 01/09/15 18:29, Gerald Pfeifer wrote: On Tue, 1 Sep 2015, Kyrill Tkachov wrote: This wwwdocs patch adds an entry to the GCC 6 changes page about the aarch64 target attributes and pragmas support. Thanks for thinking of this, Kyrill. Thanks for the feedback. Index: htdocs/gcc

Re: [gomp4] declare directive

2015-09-02 Thread Tom de Vries
On 12-08-15 20:31, James Norris wrote: diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c index bc54067..eee5340 100644 --- a/gcc/fortran/trans-decl.c +++ b/gcc/fortran/trans-decl.c @@ -5864,8 +5864,7 @@ void finish_oacc_declare (gfc_namespace *ns, enum sym_flavor flavor) {

Re: [Fortran, committed] XFAIL read_dir.f90 on FreeBSD

2015-09-02 Thread Janne Blomqvist
On Wed, Sep 2, 2015 at 1:28 AM, Jerry DeLisle wrote: > On 09/01/2015 11:18 AM, Steve Kargl wrote: >> On Tue, Sep 01, 2015 at 11:16:27AM -0700, Steve Kargl wrote: >>> open(unit=10, file='junko.dir',iostat=ios,action='read',access='stream') >>> if (ios.ne.0) call abort >>> read(10, iosta

[gomp4.1] Fix up ordered threads handling and initial step towards ordered simd

2015-09-02 Thread Jakub Jelinek
Hi! This fixes ICE with ordered simd (broken with the doacross changes; the second chunk) and allows ordered simd inside of simd regions. As it is still unclear whether ordered simd is required to be only closely nested inside of simd construct or declare simd functions (i.e. lexically nested), or

[patch] libstdc++/67408 Handle distinct __gthread_recursive_mutex_t type.

2015-09-02 Thread Jonathan Wakely
This makes recursive_timed_mutex work for non-pthreads targets where __gthread_mutex_t and __gthread_recursive_mutex_t are not the same type. Thanks to Sebastian for the bug report and patch. Tested powerpc64le-linux, committed to trunk. commit 852d09122561d301b2980b6f9c97e88c5499006c Author: J

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Marc Glisse
On Tue, 1 Sep 2015, Dmitry Vyukov wrote: The refcounted basic_string implementation contains several data races on _M_refcount: There are several bug reports about races in basic_string in bugzilla (some might even have been closed as wontfix because of the new implementation). Does this als

Re: [Patch] PR67351 Implement << N & >> N optimizers

2015-09-02 Thread Marc Glisse
+/* Optimize (x >> c) << c into x & (-1

Re: [gomp4.1] Structure element mapping support

2015-09-02 Thread Ilya Verbin
On Mon, Aug 31, 2015 at 17:07:53 +0200, Jakub Jelinek wrote: > * gimplify.c (gimplify_scan_omp_clauses): Handle > struct element GOMP_MAP_FIRSTPRIVATE_POINTER. Have you seen this? gcc/gimplify.c: In function ‘void gimplify_scan_omp_clauses(tree_node**, gimple_statement_base**, omp_re

Re: Fix 61441

2015-09-02 Thread Sujoy Saraswati
Hi Richard, > Note that I'm curious what > the actual bug is - is it that (double) sNaN creates a sNaN? Then the fix > should be elsewhere, in constant folding itself > (fold_convert_const_real_from_real > or real_convert). > > If that isn't the bug you have very many other passes to fix for the

Re: Fix 61441

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 1:36 PM, Sujoy Saraswati wrote: > Hi Richard, > >> Note that I'm curious what >> the actual bug is - is it that (double) sNaN creates a sNaN? Then the fix >> should be elsewhere, in constant folding itself >> (fold_convert_const_real_from_real >> or real_convert). >> >> If

Re: [PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

2015-09-02 Thread Jan Hubicka
> >This patch is an attempt to fix > >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67280. I have written up > >an analysis of the bug there. > > > >When cgraph_node::create_wrapper() updates the callgraph for the new > >function, it sets the can_throw_external flag to false, even when > >wrapping a

Re: Fix 61441

2015-09-02 Thread Sujoy Saraswati
> CCP and other passes ultimatively end up using fold-const.c:const_{unop,binop} > for constant folding so that is where the fix should go to (or to real.c). > That > will automatically handle other passes doing similar transforms. Thanks for the tip. I will modify my fix and post it. Regards,

Re: [PATCH GCC]Try to fold (long)(A-B) into (long)A - (long)B for canonicalization in tree affine

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 5:48 AM, Bin Cheng wrote: > Hi, > Generally we don't try to fold (long)(A-B) into (long)A - (long)B because it > results in more operations. On the other hand, this fold is wanted when we > want to explore as many canonical opportunities as possible. Tree affine is > defin

Re: [PATCH GCC]Look into unnecessary conversion when checking mult_op in get_shiftadd_cost

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 5:50 AM, Bin Cheng wrote: > Hi, > When calling get_shiftadd_cost, the mult_op is stripped at caller places. > We should look into unnecessary conversion in op1 before checking equality, > otherwise it computes wrong shiftadd cost. This patch picks this small > issue up. > >

[PATCH][AArch64][0/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
This is a set of patches to reduce the compile-time overhead of immediate generation on AArch64. There have been discussions and investigations into reducing the overhead of immediate generation using various caching strategies. However the statistics showed some of the expensive immediate loops

[PATCH][AArch64][1/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
This patch reimplements aarch64_bitmask_imm using bitwise arithmetic rather than a slow binary search. The algorithm searches for a sequence of set bits. If there are no more set bits and not all bits are set, it is a valid mask. Otherwise it determines the distance to the next set bit and check

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Richard Biener
On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: > Hi, > > This fixes an ICE by adding a NULL check. Bootstrapped and regtested for > x86_64-unknown-linux-gnu. Applied to trunk. Does this need to be ported to > gcc-5-branch? > > Thanks, > Ilya > -- > gcc/ > > 2015-09-01 Ilya Enkovich >

[PATCH][AArch64][2/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
aarch64_internal_mov_immediate uses loops iterating over all legal bitmask immediates to find 2-instruction immediate combinations. One loop is quadratic and despite being extremely expensive very rarely finds a matching immediate (43 matches in all of SPEC2006 but none are emitted in final code

[PATCH][AArch64][3/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
Remove aarch64_bitmasks, aarch64_build_bitmask_table and aarch64_bitmasks_cmp as they are no longer used by the immediate generation code. No change in generated code, passes GCC regression tests/bootstrap. ChangeLog: 2015-09-02 Wilco Dijkstra * gcc/config/aarch64/aarch64.c (aarch64_

[PATCH][AArch64][4/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
The code that emits a movw with an add/sub is hardly ever used, and all cases in actual code are already covered by mov+movk, so it is redundant (an example of such an immediate is 0x00000abcul). Passes GCC regression tests/bootstrap. Minor changes in generated code due to movk being us

[PATCH][AArch64][5/5] Improve immediate generation

2015-09-02 Thread Wilco Dijkstra
Cleanup the remainder of aarch64_internal_mov_immediate. Compute the number of 16-bit aligned 16-bit masks that are all-zeroes or all-ones, and emit the smallest sequence using a single loop skipping either all-ones or all-zeroes. Passes GCC regression tests/bootstrap. Minor changes in generated

Re: [PATCH] Fix ICE when generating a vector shift by scalar

2015-09-02 Thread Richard Biener
On Tue, Sep 1, 2015 at 5:53 PM, Bill Schmidt wrote: > On Tue, 2015-09-01 at 11:01 +0200, Richard Biener wrote: >> On Mon, Aug 31, 2015 at 10:28 PM, Bill Schmidt >> wrote: >> > Hi, >> > >> > The following simple test fails when attempting to convert a vector >> > shift-by-scalar into a vector shif

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Ilya Enkovich
2015-09-02 15:35 GMT+03:00 Richard Biener : > On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: >> Hi, >> >> This fixes an ICE by adding a NULL check. Bootstrapped and regtested for >> x86_64-unknown-linux-gnu. Applied to trunk. Does this need to be ported to >> gcc-5-branch? >> >> Thanks,

[PATCH] Fix PR66705

2015-09-02 Thread Richard Biener
I was naiively using ->get_constructor in IPA PTA without proper checking on wheter that succeeds. Now I tried to use ctor_for_folding but that isn't good as we want to analyze non-const globals in IPA PTA and we need to analyze their initialiers as well. Thus I'm trying below with ctor_for_anal

Re: [PATCH][AArch64][1/3] Expand signed mod by power of 2 using CSNEG

2015-09-02 Thread Kyrill Tkachov
On 01/09/15 11:40, Kyrill Tkachov wrote: Hi James, On 01/09/15 10:25, James Greenhalgh wrote: On Thu, Aug 13, 2015 at 01:36:50PM +0100, Kyrill Tkachov wrote: Some comments below. Thanks, I'll incorporate them, with one clarification inline. And here's the updated patch. Thanks, Kyrill 20

Re: [PATCH] Fix PR66705

2015-09-02 Thread Jan Hubicka
> > I was naiively using ->get_constructor in IPA PTA without proper > checking on wheter that succeeds. Now I tried to use ctor_for_folding > but that isn't good as we want to analyze non-const globals in IPA > PTA and we need to analyze their initialiers as well. > > Thus I'm trying below with

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Jonathan Wakely
On 01/09/15 17:42 +0200, Dmitry Vyukov wrote: On Tue, Sep 1, 2015 at 5:08 PM, Jonathan Wakely wrote: On 01/09/15 16:56 +0200, Dmitry Vyukov wrote: I don't understand how a new gcc may not support __atomic builtins on ints. How it is even possible? That's a portable API provided by recent gcc'

[AArch64_be] Fix vldX/vstX AdvSIMD intrinsics

2015-09-02 Thread Christophe Lyon
Hi, The aarch64_vldX/aarch64_vstX expanders used for the vldX/vstX AdvSIMD intrisics in Q mode called vec_load_lanes, witch shuffles the vectors to match the layout expected by the vectorizer. We do not want this to happen when the intrinsics are called directly by the end-user code. This patch

Re: Location of "dg-final" directives? (was Re: [PATCH][GCC] Algorithmic optimization in match and simplify)

2015-09-02 Thread Andre Vieira
On 01/09/15 17:54, Marek Polacek wrote: On Tue, Sep 01, 2015 at 12:50:27PM -0400, David Malcolm wrote: I can't comment on the patch itself, but I noticed that in the testsuite addition, you've gathered all the "dg-final" clauses at the end. I think that this is consistent with existing practi

Re: [PATCH, PR67405, committed] Avoid NULL pointer dereference

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 2:51 PM, Ilya Enkovich wrote: > 2015-09-02 15:35 GMT+03:00 Richard Biener : >> On Tue, Sep 1, 2015 at 5:03 PM, Ilya Enkovich wrote: >>> Hi, >>> >>> This fixes an ICE by adding a NULL check. Bootstrapped and regtested for >>> x86_64-unknown-linux-gnu. Applied to trunk. D

Re: [PATCH] Fix PR66705

2015-09-02 Thread Richard Biener
On Wed, 2 Sep 2015, Jan Hubicka wrote: > > > > I was naiively using ->get_constructor in IPA PTA without proper > > checking on wheter that succeeds. Now I tried to use ctor_for_folding > > but that isn't good as we want to analyze non-const globals in IPA > > PTA and we need to analyze their in

Re: [PATCH] Import liboffloadmic from upstream

2015-09-02 Thread Dodji Seketeli
Ilya Verbin writes: > On Tue, Sep 01, 2015 at 09:58:22 +0200, Dodji Seketeli wrote: >> Woops. can you send me the exact two libraries so that I can see what's >> going wrong? You can quickly file an issue to >> https://sourceware.org/bugzilla/enter_bug.cgi?product=libabigail or just >> send me

Re: [PATCH] Fix PR66705

2015-09-02 Thread Richard Biener
On Wed, 2 Sep 2015, Richard Biener wrote: > On Wed, 2 Sep 2015, Jan Hubicka wrote: > > > > > > > I was naiively using ->get_constructor in IPA PTA without proper > > > checking on wheter that succeeds. Now I tried to use ctor_for_folding > > > but that isn't good as we want to analyze non-const

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2015-09-02 Thread Jiong Wang
Jeff Law writes: > On 05/21/2015 02:46 PM, Jiong Wang wrote: >> >> Thanks for these thoughts. >> >> I tried but still can't prove this transformation will not introduce >> extra pointer overflow even given it's reassociation with vfp, although >> my first impression is it do will not introduce ex

Re: [PATCH][optabs][ifcvt][1/3] Define negcc, notcc optabs

2015-09-02 Thread Kyrill Tkachov
Hi Jeff, On 01/09/15 23:13, Jeff Law wrote: On 09/01/2015 09:04 AM, Kyrill Tkachov wrote: Hi all, This first patch introduces the negcc and notcc optabs that should expand to a conditional negate or a conditional bitwise complement operation. These are used in ifcvt.c to transform code of the

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Dmitry Vyukov
On Wed, Sep 2, 2015 at 12:58 PM, Marc Glisse wrote: > On Tue, 1 Sep 2015, Dmitry Vyukov wrote: > >> The refcounted basic_string implementation contains several data races >> on _M_refcount: > > > There are several bug reports about races in basic_string in bugzilla (some > might even have been clo

Re: [AArch64_be] Fix vldX/vstX AdvSIMD intrinsics

2015-09-02 Thread James Greenhalgh
On Wed, Sep 02, 2015 at 02:18:03PM +0100, Christophe Lyon wrote: > Hi, > > The aarch64_vldX/aarch64_vstX expanders used for the vldX/vstX AdvSIMD > intrisics in Q mode called vec_load_lanes, witch shuffles the vectors > to match the layout expected by the vectorizer. > > We do not want this to ha

RE: [PATCH] MIPS: Prevent the p5600-bonding.c test from being run for the n32 and 64 ABIs

2015-09-02 Thread Andrew Bennett
> > diff --git a/gcc/testsuite/gcc.target/mips/p5600-bonding.c > > b/gcc/testsuite/gcc.target/mips/p5600-bonding.c > > index 0890ffa..20c26ca 100644 > > --- a/gcc/testsuite/gcc.target/mips/p5600-bonding.c > > +++ b/gcc/testsuite/gcc.target/mips/p5600-bonding.c > > @@ -1,6 +1,7 @@ > > /* { dg-do co

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Dmitry Vyukov
Added comment to _M_dispose and restored ChangeLog entry. Please take another look. On Wed, Sep 2, 2015 at 3:17 PM, Jonathan Wakely wrote: > On 01/09/15 17:42 +0200, Dmitry Vyukov wrote: >> >> On Tue, Sep 1, 2015 at 5:08 PM, Jonathan Wakely >> wrote: >>> >>> On 01/09/15 16:56 +0200, Dmitry Vyuk

Re: [testsuite] Clean up effective_target cache

2015-09-02 Thread Christophe Lyon
On 1 September 2015 at 16:04, Christophe Lyon wrote: > On 25 August 2015 at 17:31, Mike Stump wrote: >> On Aug 25, 2015, at 1:14 AM, Christophe Lyon >> wrote: >>> Some subsets of the tests override ALWAYS_CXXFLAGS or >>> TEST_ALWAYS_FLAGS and perform effective_target support tests using >>> the

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Jonathan Wakely
On 02/09/15 15:49 +0200, Dmitry Vyukov wrote: On Wed, Sep 2, 2015 at 12:58 PM, Marc Glisse wrote: On Tue, 1 Sep 2015, Dmitry Vyukov wrote: The refcounted basic_string implementation contains several data races on _M_refcount: There are several bug reports about races in basic_string in bug

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Jonathan Wakely
On 02/09/15 16:01 +0200, Dmitry Vyukov wrote: Added comment to _M_dispose and restored ChangeLog entry. Please take another look. Thanks, this is OK for trunk. I assume you are covered by the Google company-wide copyright assignment, so someone just needs to commit it, which I can do if you li

Re: [PATCH PR66388]Add sizetype cand for BIV of smaller type if it's used as index of memory ref

2015-09-02 Thread Richard Biener
On Wed, Sep 2, 2015 at 5:26 AM, Bin Cheng wrote: > Hi, > This patch is a new approach to fix PR66388. IVO today computes iv_use with > iv_cand which has at least same type precision as the use. On 64bit > platforms like AArch64, this results in different iv_cand created for each > address type i

Re: [PATCH] Fix PR66705

2015-09-02 Thread Jan Hubicka
> > Hmm, no, ipa-ref list should be enough (unless we start field-sensitive > analysis or need NULL inits for correctness). Still have to figure out > how to walk the list and how the reference would look like (what > is ref->use? IPA_REF_ADDR? can those be speculative?) Yep, it should be IPA_

Re: [PATCH] Fix PR66705

2015-09-02 Thread Jan Hubicka
> On Wed, 2 Sep 2015, Richard Biener wrote: > > > On Wed, 2 Sep 2015, Jan Hubicka wrote: > > > > > > > > > > I was naiively using ->get_constructor in IPA PTA without proper > > > > checking on wheter that succeeds. Now I tried to use ctor_for_folding > > > > but that isn't good as we want to a

Re: [PATCH] Fix PR66705

2015-09-02 Thread Richard Biener
On Wed, 2 Sep 2015, Jan Hubicka wrote: > > On Wed, 2 Sep 2015, Richard Biener wrote: > > > > > On Wed, 2 Sep 2015, Jan Hubicka wrote: > > > > > > > > > > > > > I was naiively using ->get_constructor in IPA PTA without proper > > > > > checking on wheter that succeeds. Now I tried to use ctor_f

Re: [Patch, libstdc++] Fix data races in basic_string implementation

2015-09-02 Thread Dmitry Vyukov
Thank you. Yes, I am covered by the Google copyright assignment, and I have commit access. I don't commit frequently, hope I didn't mess up things fundamentally :) https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227403 On Wed, Sep 2, 2015 at 4:08 PM, Jonathan Wakely wrote: > On 02/09/15

Re: [Fortran, committed] XFAIL read_dir.f90 on FreeBSD

2015-09-02 Thread Steve Kargl
On Wed, Sep 02, 2015 at 11:30:07AM +0300, Janne Blomqvist wrote: > On Wed, Sep 2, 2015 at 1:28 AM, Jerry DeLisle wrote: > > On 09/01/2015 11:18 AM, Steve Kargl wrote: > >> On Tue, Sep 01, 2015 at 11:16:27AM -0700, Steve Kargl wrote: > >>> open(unit=10, > >>> file='junko.dir',iostat=ios,action

Re: [PATCH] add initial support for J2 core to sh target

2015-09-02 Thread Oleg Endo
On 02 Sep 2015, at 02:08, Rich Felker wrote: > On Wed, Sep 02, 2015 at 01:24:55AM +0900, Oleg Endo wrote: >>> I'm not sure what the best way to achieve multiple goals is, but the >>> current behavior makes it so you need --isa=any (and a final binary >>> with weird ABI tag) to have a binary that

RE: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-09-02 Thread Zamyatin, Igor
> > > On 19/08/15 17:57, Jeff Law wrote: > > On 08/12/2015 08:31 AM, Kyrill Tkachov wrote: > >> 2015-08-10 Kyrylo Tkachov > >> > >> * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, > >> then_cost, else_cost fields. Change branch_cost field to > >> unsigned int. > >>

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

2015-09-02 Thread Jason Merrill
On 09/01/2015 06:25 PM, Martin Sebor wrote: Having now made this change, I don't think the added complexity of three declarations and two trivial definitions of the new c_decl_implicit function across five files is an improvement, Three declarations? Isn't declaring it in c-common.h enough?

Re: patch for PR61578

2015-09-02 Thread Christophe Lyon
Hi Vladimir, On 1 September 2015 at 21:39, Vladimir Makarov wrote: > The following patch is for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61578 > > The patch was bootstrapped and tested on x86 and x86-64. > > Committed as rev. 227382. > Since this patch, I can see: gcc.dg/vect/s

[gomp4.1] Depend clause support for offloading

2015-09-02 Thread Jakub Jelinek
Hi! On Wed, Sep 02, 2015 at 02:21:14PM +0300, Ilya Verbin wrote: > On Mon, Aug 31, 2015 at 17:07:53 +0200, Jakub Jelinek wrote: > > * gimplify.c (gimplify_scan_omp_clauses): Handle > > struct element GOMP_MAP_FIRSTPRIVATE_POINTER. > > Have you seen this? > > gcc/gimplify.c: In function ‘

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-09-02 Thread Kyrill Tkachov
On 02/09/15 16:18, Zamyatin, Igor wrote: On 19/08/15 17:57, Jeff Law wrote: On 08/12/2015 08:31 AM, Kyrill Tkachov wrote: 2015-08-10 Kyrylo Tkachov * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, then_cost, else_cost fields. Change branch_cost field to unsigne

Patch GCC for profile-func-internal-id=0 coverage-callback=1

2015-09-02 Thread Matt Deeds
Hello, Honza. David Li said you might be able to help me get this patch into GCC trunk. I sent mail for this on August 27, but didn't get a reply. It's a small change to make these two options work together: profile-func-internal-id=0 coverage-callback=1 Let me know what I can do to get this s

RFC: Combine of compare & and oddity

2015-09-02 Thread Wilco Dijkstra
Hi, Combine canonicalizes certain AND masks in a comparison with zero into extracts of the widest register type. During matching these are expanded into a very inefficient sequence that fails to match. For example (x & 2) == 0 is matched in combine like this: Failed to match this instruction: (

Re: [PR64164] drop copyrename, integrate into expand

2015-09-02 Thread Alan Lawrence
On 14/08/15 19:57, Alexandre Oliva wrote: I'm glad it appears to be working to everyone's satisfaction now. I've just committed it as r226901, with only a context adjustment to account for a change in use_register_for_decl in function.c. /me crosses fingers :-) Here's the patch as checked in:

[C PATCH] Better diagnostic for empty enum (PR c/67432)

2015-09-02 Thread Marek Polacek
This PR asks for a better error wrt empty enums. So I've handled empty enum specially. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-09-02 Marek Polacek PR c/67432 * c-parser.c (c_parser_enum_specifier): Give a better error for an empty enum. * g

Reviving SH FDPIC target

2015-09-02 Thread Rich Felker
I've started work on reviving the FDPIC support patch for the SH target, which was proposed upstream in 2010 then abandoned: https://gcc.gnu.org/ml/gcc-patches/2010-08/msg01464.html Right now I'm in the process of determining what parts can be applied as-is to current gcc, and what parts need to

[hsa] Stricter target_follows_kernelizable_pattern

2015-09-02 Thread Martin Jambor
Hi, the patch below makes target_follows_kernelizable_pattern stricter by adding a few checks for clauses that have to preclude kernelization. Committed to the branch. Thanks, Martin 2015-09-02 Martin Jambor * omp-low.c (target_follows_kernelizable_pattern): Parallel num_th

Re: RFC: Combine of compare & and oddity

2015-09-02 Thread Segher Boessenkool
Hi Wilco, On Wed, Sep 02, 2015 at 06:09:24PM +0100, Wilco Dijkstra wrote: > Combine canonicalizes certain AND masks in a comparison with zero into > extracts of the widest > register type. During matching these are expanded into a very inefficient > sequence that fails to > match. For example (x

Re: [C PATCH] Better diagnostic for empty enum (PR c/67432)

2015-09-02 Thread Joseph Myers
On Wed, 2 Sep 2015, Marek Polacek wrote: > This PR asks for a better error wrt empty enums. So I've handled > empty enum specially. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? OK. -- Joseph S. Myers jos...@codesourcery.com

Re: RFC: Combine of compare & and oddity

2015-09-02 Thread Jeff Law
On 09/02/2015 11:09 AM, Wilco Dijkstra wrote: Hi, Combine canonicalizes certain AND masks in a comparison with zero into extracts of the widest register type. During matching these are expanded into a very inefficient sequence that fails to match. For example (x & 2) == 0 is matched in combine

Re: Reviving SH FDPIC target

2015-09-02 Thread Joseph Myers
On Wed, 2 Sep 2015, Rich Felker wrote: > Also, according to Joseph Myers, there was some unresolved > disagreement that stalled (and eventually sunk) the old patch, so if > anyone's still around who has objections to it, could you speak up and > let me know what's wrong? Kaz Kojima seems to have a

[gomp4] remove xfails in the libgomp reduction tests

2015-09-02 Thread Cesar Philippidis
A couple of reduction tests inside libgomp had xfails because Julian added those tests before my reduction patches were ready. Most of them should pass unmodified, but I had to found a bug in loop-reduction-wv-p-3.c, where a private variable was used without being initialized. This patch fixes that

Re: Patch GCC for profile-func-internal-id=0 coverage-callback=1

2015-09-02 Thread Xinliang David Li
Sorry for the wrong advice. I thought the feature was in trunk. Rong, can you submit the callback support to trunk? David On Wed, Sep 2, 2015 at 1:41 PM, Rong Xu wrote: > Matt, > > It seems this patch is for google branch, rather the trunk. The code for > coverage callback function is not in tr

Re: [PATCH] PR 62173, re-shuffle insns for RTL loop invariant hoisting

2015-09-02 Thread Jeff Law
On 09/02/2015 07:36 AM, Jiong Wang wrote: For the record, after Bin's recent tree-ssa-ivopt improvement originated from PR62173, this patch is not benefitial anymore. It happens sometimes. I have stopped working on this patch. Thanks for those time spent on reviewing and discussing on this.

Go patch committed: mark erroneous constants as invalid

2015-09-02 Thread Ian Lance Taylor
This patch by Chris Manghane avoids a compiler crash by marking erroneous constants as invalid and turning them into error expressions when seen. This fixes https://golang.org/issue/11541 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/g

Re: [PATCH] PR 60586

2015-09-02 Thread Jeff Law
On 09/01/2015 10:30 PM, Iyer, Balaji V wrote: Hi Jeff, I thought about this for a minute and I don't think I need to use the lang_hooks. I could do this change right before calling gimplify_cilk_spawn. I have attached the fixed patch and have answered your questions below. Here are the

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-09-02 Thread Jeff Law
On 09/02/2015 09:18 AM, Zamyatin, Igor wrote: On 19/08/15 17:57, Jeff Law wrote: On 08/12/2015 08:31 AM, Kyrill Tkachov wrote: 2015-08-10 Kyrylo Tkachov * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, then_cost, else_cost fields. Change branch_cost field to un

Re: RFC: Combine of compare & and oddity

2015-09-02 Thread Segher Boessenkool
On Wed, Sep 02, 2015 at 01:59:58PM -0600, Jeff Law wrote: > >(set (reg:CC 66 cc) > > (compare:CC (and:DI (lshiftrt:DI (subreg:DI (reg/v:SI 76 [ xD.2641 ]) > > 0) > > (const_int 1 [0x1])) > > (const_int 1 [0x1])) > > (const_int 0 [0]))) > Yea, this is an

Re: Reviving SH FDPIC target

2015-09-02 Thread Rich Felker
On Wed, Sep 02, 2015 at 07:59:45PM +, Joseph Myers wrote: > On Wed, 2 Sep 2015, Rich Felker wrote: > > > Also, according to Joseph Myers, there was some unresolved > > disagreement that stalled (and eventually sunk) the old patch, so if > > anyone's still around who has objections to it, could

Re: [PATCH] Fix ICE when generating a vector shift by scalar

2015-09-02 Thread Bill Schmidt
On Wed, 2015-09-02 at 14:44 +0200, Richard Biener wrote: > On Tue, Sep 1, 2015 at 5:53 PM, Bill Schmidt > wrote: > > On Tue, 2015-09-01 at 11:01 +0200, Richard Biener wrote: > >> On Mon, Aug 31, 2015 at 10:28 PM, Bill Schmidt > >> wrote: > >> > Hi, > >> > > >> > The following simple test fails w

Re: [PING] Re: [PATCH] c/66516 - missing diagnostic on taking the address of a builtin function

2015-09-02 Thread Martin Sebor
On 09/02/2015 09:29 AM, Jason Merrill wrote: On 09/01/2015 06:25 PM, Martin Sebor wrote: Having now made this change, I don't think the added complexity of three declarations and two trivial definitions of the new c_decl_implicit function across five files is an improvement, Three declarations

Re: [PR64164] drop copyrename, integrate into expand

2015-09-02 Thread Alexandre Oliva
On Sep 2, 2015, Alan Lawrence wrote: > One more failure to report, I'm afraid. On AArch64 Bigendian, > aapcs64/func-ret-4.c ICEs in simplify_subreg (line refs here are from > r227348): Thanks. The failure mode was different in the current, revamped git branch aoliva/pr64164, but I've just fixe

[PATCH] fix PR53852: stop ISL after a given number of operations

2015-09-02 Thread Sebastian Pop
2015-09-02 Sebastian Pop * config.in: Regenerate. * configure: Regenerate. * configure.ac (HAVE_ISL_CTX_MAX_OPERATIONS): Detect. * graphite-optimize-isl.c (optimize_isl): Stop computation when PARAM_MAX_ISL_OPERATIONS is reached.

Re: [PATCH] fix PR53852: stop ISL after a given number of operations

2015-09-02 Thread Tobias Grosser
On 09/03/2015 12:34 AM, Sebastian Pop wrote: 2015-09-02 Sebastian Pop * config.in: Regenerate. * configure: Regenerate. * configure.ac (HAVE_ISL_CTX_MAX_OPERATIONS): Detect. * graphite-optimize-isl.c (optimize_isl): Stop computation when

Re: Remove redundant test for global_regs

2015-09-02 Thread Georg-Johann Lay
Anatoliy Sokolov schrieb: Hi. The fixed_reg_set contain all fixed and global registers. This patch change code "fixed_regs[r] || global_regs[r]" with "TEST_HARD_REG_BIT (fixed_reg_set, r)". Even though technically a no-op change TEST_HARD_REG_BIT (fixed_reg_set, r) appears to be a test f

Re: [PATCH] fix PR53852: stop ISL after a given number of operations

2015-09-02 Thread Jeff Law
On 09/02/2015 04:52 PM, Tobias Grosser wrote: On 09/03/2015 12:34 AM, Sebastian Pop wrote: 2015-09-02 Sebastian Pop * config.in: Regenerate. * configure: Regenerate. * configure.ac (HAVE_ISL_CTX_MAX_OPERATIONS): Detect. * graphite-optimize-

Re: [RFC] COMDAT Safe Module Level Multi versioning

2015-09-02 Thread Sriraman Tallam
On Tue, Aug 18, 2015 at 9:46 PM, Cary Coutant wrote: >> Thanks, will make those changes. Do you recommend a different name >> for this flag like -fmake-comdat-functions-static? > > Well, the C++ ABI refers to this as "vague linkage." It may be a bit > too long or too ABI-specific, but maybe somet

Re: Reviving SH FDPIC target

2015-09-02 Thread Rich Felker
On Wed, Sep 02, 2015 at 05:05:35PM -0400, Rich Felker wrote: > On Wed, Sep 02, 2015 at 07:59:45PM +, Joseph Myers wrote: > > On Wed, 2 Sep 2015, Rich Felker wrote: > > > > > Also, according to Joseph Myers, there was some unresolved > > > disagreement that stalled (and eventually sunk) the old

Go patch committed: report invalid receiver types

2015-09-02 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go frontend to report invalid function receiver types as an error rather than crashing. This fixes https://golang.org/issue/12324 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

[PATCH 00/10] removal of typedefs that hide pointerness episode 1

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders Hi, Personally I think hiding that variables are pointers is confusing, and I believe consensus is we should move away from this style. So this series starts to do that. patches individually bootstrapped + regtested on x86_64-linux-gnu, ok? Trev Trevor Saunders (10):

[PATCH 02/10] dse.c: remove some typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-02 Trevor Saunders * dse.c (store_info_t): Remove typedef. (group_info_t): Likewise. (const_group_info_t): Likewise. (deferred_change_t): Likewise. (get_group_info): Adjust. (free_store_info): Likewi

[PATCH 01/10] don't typedef alias_set_entry and unhide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-02 Trevor Saunders * alias.c (alias_set_entry_d): Rename to alias_set_entry. (alias_set_entry): Remove typedef. (alias_set_subset_of): Adjust. (alias_sets_conflict_p): Likewise. (init_alias_set_entry): Likew

[PATCH 06/10] tree-ssa-ter.c: remove typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * tree-ssa-ter.c (temp_expr_table_d): Rename to temp_expr_table and remove typedef. (new_temp_expr_table): Adjust. (free_temp_expr_table): Likewise. (version_to_be_replaced_p): Likewise.

[PATCH 05/10] bt-load.c: remove typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * bt-load.c (struct btr_def_group): Rename from btr_def_group_s. (struct btr_user): Rename from btr_user_s. (struct btr_def): Rename from btr_def_s. (find_btr_def_group): Adjust. (add_btr_

[PATCH 03/10] var-tracking.c: remove typedef of location_chain

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * var-tracking.c (struct location_chain): Rename from location_chain_def. (struct variable_part): Adjust. (variable_htab_free): Likewise. (unshare_variable): Likewise. (get_init_va

[PATCH 04/10] var-tracking.c: remove typedef of shared_hash

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * var-tracking.c (shared_hash_def): Rename to shared_hash. (shared_hash): Remove typedef. (struct dataflow_set): Adjust. (shared_hash_unshare): Likewise. (dataflow_set_merge): Likewise.

[PATCH 07/10] tree-vrp.c: remove typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * tree-vrp.c (struct assert_locus_d): Rename to assert_locus. (dump_asserts_for): Adjust. (register_new_assert_for): Likewise. (process_assert_insertions): Likewise. (insert_range_assertio

[PATCH 10/10] tree-ssa-loop-im.c: remove typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * tree-ssa-loop-im.c (mem_ref_loc_p): Remove typedef. (mem_ref_p): Likewise. (outermost_indep_loop): Adjust. (mem_ref_in_stmt): Likewise. (determine_max_movement): Likewise. (mem_r

[PATCH 09/10] dwarf2out.c: remove typedefs that hide pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * dwarf2out.c (dw_attr_ref): Remove typedef. (dw_line_info_ref): Likewise. (pubname_ref): Likewise. (dw_ranges_ref): Likewise. (dw_ranges_by_label_ref): Likewise. (comdat_type_node

Re: [PATCH] [RTEMS] Update RTEMS thread model

2015-09-02 Thread Sebastian Huber
Committed: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227428 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key avai

[PATCH 08/10] dwarf2cfi.c: remove typedef that hides pointerness

2015-09-02 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2015-09-03 Trevor Saunders * dwarf2cfi.c (dw_trace_info_ref): Remove typedef. --- gcc/dwarf2cfi.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index ab18062..1cfa6a7 100644 --- a/gcc/dw

Re: [PATCH v2] [libstdc++] Run tests on RTEMS

2015-09-02 Thread Sebastian Huber
On 01/09/15 23:07, Jeff Law wrote: On 09/01/2015 05:02 AM, Sebastian Huber wrote: v2: Include all options and not only "dg-do run ...". libstdc++-v3/ChangeLog 2015-09-01 Sebastian Huber testsuite/*: Use 's/\*-\*-cygwin\* /&*-*-rtems* /' to add RTEMS target selector to all tests tha