Re: [PATCH][ARM] Use %wd format for lane printing in bounds_check

2015-08-19 Thread Ramana Radhakrishnan
On 14/08/15 10:56, Kyrill Tkachov wrote: > Hi all, > > I'm seeing these warnings when building arm.c: > warning: format ‘%lld’ expects argument of type ‘long long int’, but argument > 5 has type ‘long int’ [-Wformat=] > > These appear in the bounds_check function when it tries to print out >

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Paolo Carlini
Hi, On 08/19/2015 08:50 AM, FX wrote: .. I think this improvement means that in principle we could revert what we committed for libstdc++/58625, thus increasing a little the consistency wrt the other classification facilities in c_global/cmath (and c_std/cmath). Not sure it's worth it. Can’t

RE: [Patch, MIPS] MIPS specific optimization for o32 ABI

2015-08-19 Thread Matthew Fortune
Steve Ellcey writes: > On Thu, 2015-08-13 at 02:14 -0700, Matthew Fortune wrote: > > Hi Steve, > > > > Overall, I don't think these optimizations are ready to include. In > > principle > > the idea looks good but it is done at the wrong point in the compiler in my > > opinion. > > > > The biggest

Re: [PATCH] ivopts costs debug

2015-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2015 at 10:45:42AM +0800, Bin.Cheng wrote: > I ran into back-end address cost issue before and this should be > useful in such cases. Though there are a lot of dumps, it would be > better to classify it into existing dump option (TDF_DETAILS?) and > discard the use of macro. But T

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Andreas Schwab
FX writes: > @@ -80,6 +80,24 @@ foo_1 (float f, double d, long double ld >if (__builtin_finitel (ld) != res_isfin) > __builtin_abort (); > > + /* Sign bit of zeros and nans is not preserved in unsafe math mode. */ > +#ifdef UNSAFE > + if (!res_isnan && d != 0) > +#endif Why only in

Re: [PATCH][1/n] dwarf2out refactoring for early (LTO) debug

2015-08-19 Thread Yao Qi
On 18/08/15 20:32, Aldy Hernandez wrote: Aldyh, what other testing did you usually do for changes? Run the gdb testsuite against the new compiler? Anything else? gdb testsuite, and make sure you test GCC with --enable-languages=all,go,ada, though the latter is mostly useful while you iron out

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Biener
On Tue, Aug 18, 2015 at 4:15 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Tue, Aug 18, 2015 at 1:07 PM, David Sherwood >> wrote: On Mon, Aug 17, 2015 at 11:29 AM, David Sherwood wrote: > Hi Richard, > > Thanks for the reply. I'd chosen to add new express

Re: [PATCH] Fix middle-end/67133, part 1

2015-08-19 Thread Richard Biener
On Tue, Aug 18, 2015 at 9:49 PM, Marek Polacek wrote: > On Tue, Aug 18, 2015 at 10:45:21AM +0200, Richard Biener wrote: >> On Mon, Aug 17, 2015 at 7:31 PM, Jeff Law wrote: >> > But in walking through all that, I think I've stumbled on a simpler >> > solution. Specifically do as a little as possi

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Sandiford
Richard Biener writes: > On Tue, Aug 18, 2015 at 4:15 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Tue, Aug 18, 2015 at 1:07 PM, David Sherwood >>> wrote: > On Mon, Aug 17, 2015 at 11:29 AM, David Sherwood > wrote: > > Hi Richard, > > > > Thanks for the r

Re: Move some flag_unsafe_math_optimizations using simplify and match

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 6:53 AM, Hurugalawadi, Naveen wrote: > Hi Richard, > > Thanks very much for your review and comments. > >>> Can you point me to which patterns exhibit this behavior? > > root(x)*root(y) as root(x*y) > expN(x)*expN(y) as expN(x+y) > pow(x,y)*pow(x,z) as pow(x,y+z) > x/expN(y

Re: [PR64164] drop copyrename, integrate into expand

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 8:45 AM, Alexandre Oliva wrote: > On Aug 18, 2015, Alexandre Oliva wrote: > On Aug 17, 2015, Christophe Lyon wrote: > Since this was committed (r226901), I can see that the compiler build > fails for armeb targets, when building libgcc: > >> This patch fixes

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 11:54 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Tue, Aug 18, 2015 at 4:15 PM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Tue, Aug 18, 2015 at 1:07 PM, David Sherwood wrote: >> On Mon, Aug 17, 2015 at 11:29 AM, David Sherwoo

Re: [PATCH] Fix middle-end/67133, part 1

2015-08-19 Thread Marek Polacek
On Wed, Aug 19, 2015 at 11:48:12AM +0200, Richard Biener wrote: > Looks good to me. Thanks! I'll wait for Jeff if he has any comments. Marek

Re: [PATCH] Missing Skylake -march=/-mtune= option

2015-08-19 Thread Richard Biener
On Thu, Aug 13, 2015 at 9:57 PM, Uros Bizjak wrote: > On Thu, Aug 13, 2015 at 11:31 AM, Yuri Rumyantsev wrote: >> Hi All, >> >> Here is patch for adding march/mtune options for Skylake. >> >> Bootstrap and regression testing did not show any new failures. >> >> Is it OK for trunk? > > OK. I thin

Re: [PATCH] Missing Skylake -march=/-mtune= option

2015-08-19 Thread Uros Bizjak
On Wed, Aug 19, 2015 at 12:39 PM, Richard Biener wrote: > On Thu, Aug 13, 2015 at 9:57 PM, Uros Bizjak wrote: >> On Thu, Aug 13, 2015 at 11:31 AM, Yuri Rumyantsev wrote: >>> Hi All, >>> >>> Here is patch for adding march/mtune options for Skylake. >>> >>> Bootstrap and regression testing did not

[PATCH/AARCH64] Remove index from AARCH64_EXTRA_TUNING_OPTION

2015-08-19 Thread Andrew Pinski
Just like the patch for AARCH64_FUSION_PAIR, this is a patch for AARCH64_EXTRA_TUNING_OPTION. Note I tested this patch on top of the patch for AARCH64_EXTRA_TUNING_OPTION. Remove index from AARCH64_FUSION_PAIR Instead of doing an explict index in aarch64-fusion-pairs.def, we should

Re: [PATCH] Missing Skylake -march=/-mtune= option

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 12:47 PM, Uros Bizjak wrote: > On Wed, Aug 19, 2015 at 12:39 PM, Richard Biener > wrote: >> On Thu, Aug 13, 2015 at 9:57 PM, Uros Bizjak wrote: >>> On Thu, Aug 13, 2015 at 11:31 AM, Yuri Rumyantsev >>> wrote: Hi All, Here is patch for adding march/mtune o

[PATCH/AARCH64] Remove index from AARCH64_FUSION_PAIR

2015-08-19 Thread Andrew Pinski
Instead of doing an explicit index in aarch64-fusion-pairs.def, we should have an enum which does the index instead. This allows you to add/remove them without worrying about the order being correct and having holes or worry about merge conflicts. OK? Bootstrapped and tested o

Re: [PATCH/AARCH64] Remove index from AARCH64_FUSION_PAIR

2015-08-19 Thread James Greenhalgh
On Wed, Aug 19, 2015 at 12:11:04PM +0100, Andrew Pinski wrote: > Instead of doing an explicit index in aarch64-fusion-pairs.def, we > should have an enum which does the index instead. This allows > you to add/remove them without worrying about the order being > correct and having h

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Sandiford
Richard Biener writes: > On Wed, Aug 19, 2015 at 11:54 AM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Tue, Aug 18, 2015 at 4:15 PM, Richard Sandiford >>> wrote: Richard Biener writes: > On Tue, Aug 18, 2015 at 1:07 PM, David Sherwood > wrote: >>> On Mon, Aug

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Tue, Aug 4, 2015 at 1:50 PM, H.J. Lu wrote: > On Tue, Aug 4, 2015 at 1:45 PM, Segher Boessenkool > wrote: >> On Tue, Aug 04, 2015 at 01:00:32PM -0700, H.J. Lu wrote: >>> There is another issue with x86, maybe other targets. You >>> can't get the real stack top when stack is realigned and >>>

RE: [PATCH][4/N] Introduce new inline functions for GET_MODE_UNIT_SIZE and GET_MODE_UNIT_PRECISION

2015-08-19 Thread David Sherwood
> I asked Richard S. to give this a once-over which he did. However, he > technically can't approve due to the way his maintainership position was > worded. > > The one request would be a function comment for emit_mode_unit_size and > emit_mode_unit_precision. OK with that change. Thanks. Here's

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 2:11 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Aug 19, 2015 at 11:54 AM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Tue, Aug 18, 2015 at 4:15 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Tue, Aug 18

Re: [gomp4] OpenACC first private

2015-08-19 Thread Nathan Sidwell
On 08/18/15 17:43, Thomas Schwinge wrote: ..., but the following ones remain to be addressed -- could somebody look into this, please? Especially the timeouts are very annoying. Tests that now reproducibly XPASS instead of XFAIL should be verified, and the XFAIL marker removed. [-PASS:-

Re: [PATCH], PowerPC IEEE 128-bit patch #5

2015-08-19 Thread Segher Boessenkool
On Fri, Aug 14, 2015 at 11:46:03AM -0400, Michael Meissner wrote: > +;; Like int_reg_operand, but don't return true for pseudo registers > +(define_predicate "int_reg_operand_not_pseudo" > + (match_operand 0 "register_operand") > +{ > + if ((TARGET_E500_DOUBLE || TARGET_SPE) && invalid_e500_subre

RE: [PATCH][ARM]Tighten the conditions for arm_movw, arm_movt

2015-08-19 Thread Kyrill Tkachov
Hi Renlin, Please send patches to gcc-patches for review. Redirecting there now... On 19/08/15 12:49, Renlin Li wrote: > Hi all, > > This simple patch will tighten the conditions when matching movw and > arm_movt rtx pattern. > Those two patterns will generate the following assembly: > > movw w1

Re: RFC: [PATCH] PR target/67215: -fno-plt needs improvements for x86

2015-08-19 Thread H.J. Lu
On Mon, Aug 17, 2015 at 10:17:00AM -0700, H.J. Lu wrote: > On Mon, Aug 17, 2015 at 10:08 AM, Alexander Monakov > wrote: > >> >> Perhaps add a comment that GOT slots are 64-bit on x32? > >> >> > >> > > >> > Good idea. I will update my patch. > >> > > >> > >> How about this? > >> > >> > >> diff --

RE: [PATCH][ARM][3/3] Expand mod by power of 2

2015-08-19 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00448.html Thanks, Kyrill > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Kyrill Tkachov > Sent: 10 August 2015 12:14 > To: GCC Patches > Cc: Ramana Radhakrishnan; Richard

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2015 at 05:23:41AM -0700, H.J. Lu wrote: > >>> >> > You might have a reason why you want the entry stack address instead > >>> >> > of the > >>> >> > frame address, but you didn't really explain I think? Or I missed > >>> >> > it. > >> > >> What would a C program do with this, th

RE: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-08-19 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00609.html Thanks, Kyrill > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Kyrill Tkachov > Sent: 12 August 2015 15:32 > To: Jeff Law; Steven Bosscher > Cc: Bernhard Reutne

Re: [PATCH/AARCH64] Remove index from AARCH64_FUSION_PAIR

2015-08-19 Thread Andrew Pinski
On Wed, Aug 19, 2015 at 7:39 PM, James Greenhalgh wrote: > On Wed, Aug 19, 2015 at 12:11:04PM +0100, Andrew Pinski wrote: >> Instead of doing an explicit index in aarch64-fusion-pairs.def, we >> should have an enum which does the index instead. This allows >> you to add/remove them wi

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 5:51 AM, Segher Boessenkool wrote: > On Wed, Aug 19, 2015 at 05:23:41AM -0700, H.J. Lu wrote: >> >>> >> > You might have a reason why you want the entry stack address >> >>> >> > instead of the >> >>> >> > frame address, but you didn't really explain I think? Or I missed

[COMMITTED][AArch64] Cleanup whitespace in aarch64.c

2015-08-19 Thread Jiong Wang
These whitespaces are introduced by my commit r225017. Those whitespaces should be replaced with tab according to GNU coding style. Commited as obvisous (r227005), after cross build aarch64-elf OK. 2015-08-19 Jiong Wang gcc/ * config/aarch64/aarch64.c (aarch64_load_symref_appropriately):

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Sandiford
Richard Biener writes: > As an additional point for many math functions we have to support errno > which means, like, BUILT_IN_SQRT can be rewritten to SQRT_EXPR > only if -fno-math-errno is in effect. But then code has to handle > both variants for things like constant folding and expression com

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Paolo Carlini
... I'm committing the below. Tested x86_64-linux. Thanks, Paolo. / 2015-08-19 Paolo Carlini * include/c_global/cmath: Revert fix for libstdc++/58625, no longer necessary (__builtin_signbit is now type-generic). Index: include/c_global/cmath ==

Re: [PR64164] drop copyrename, integrate into expand

2015-08-19 Thread Andreas Schwab
Alexandre Oliva writes: > [PR64164] fix regressions reported on m68k and armeb > > From: Alexandre Oliva > > Defer stack slot address assignment for all parms that can't live in > pseudos, and accept pseudos assignments in assign_param_setup_block. That doesn't fix the ia64 Ada miscompilation t

Re: [PATCH][4/N] Introduce new inline functions for GET_MODE_UNIT_SIZE and GET_MODE_UNIT_PRECISION

2015-08-19 Thread Jeff Law
On 08/19/2015 06:29 AM, David Sherwood wrote: I asked Richard S. to give this a once-over which he did. However, he technically can't approve due to the way his maintainership position was worded. The one request would be a function comment for emit_mode_unit_size and emit_mode_unit_precision.

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Biener
On Wed, Aug 19, 2015 at 3:06 PM, Richard Sandiford wrote: > Richard Biener writes: >> As an additional point for many math functions we have to support errno >> which means, like, BUILT_IN_SQRT can be rewritten to SQRT_EXPR >> only if -fno-math-errno is in effect. But then code has to handle >>

[PATCH][AArch64] Fix FAIL: gcc.target/aarch64/target_attr_crypto_ice_1.c (internal compiler error)

2015-08-19 Thread Kyrill Tkachov
Hi all, This fixes the ICE exposed by Alexandre's patch (https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00873.html) The solution I came up with is to re-layout the parameter decls not during expansion time (when RTL has already been allocated to SSA names) but in TARGET_SET_CURRENT_FUNCTION whic

Re: [PR64164] drop copyrename, integrate into expand

2015-08-19 Thread Andreas Schwab
Andreas Schwab writes: > Alexandre Oliva writes: > >> [PR64164] fix regressions reported on m68k and armeb >> >> From: Alexandre Oliva >> >> Defer stack slot address assignment for all parms that can't live in >> pseudos, and accept pseudos assignments in assign_param_setup_block. > > That does

Re: [PATCH][1/n] dwarf2out refactoring for early (LTO) debug

2015-08-19 Thread Richard Biener
On Tue, 18 Aug 2015, Aldy Hernandez wrote: > On 08/18/2015 07:20 AM, Richard Biener wrote: > > > > This starts a series of patches (still in development) to refactor > > dwarf2out.c to better cope with early debug (and LTO debug). > > Awesome! Thanks. > > > Aldyh, what other testing did you us

Re: [PATCH][1/n] dwarf2out refactoring for early (LTO) debug

2015-08-19 Thread Aldy Hernandez
On 08/19/2015 06:45 AM, Richard Biener wrote: [copying gdb folks] On Tue, 18 Aug 2015, Aldy Hernandez wrote: On 08/18/2015 07:20 AM, Richard Biener wrote: [snip] The patch below has passed bootstrap & regtest on x86_64-unknown-linux-gnu as well as gdb testing. Twice unpatched, twice patc

Re: [PATCH] Fix middle-end/67133, part 1

2015-08-19 Thread Jeff Law
On 08/18/2015 01:49 PM, Marek Polacek wrote: On Tue, Aug 18, 2015 at 10:45:21AM +0200, Richard Biener wrote: On Mon, Aug 17, 2015 at 7:31 PM, Jeff Law wrote: But in walking through all that, I think I've stumbled on a simpler solution. Specifically do as a little as possible and let the stand

[PATCH][2/n] Change dw2_asm_output_offset to allow assembling extra offset

2015-08-19 Thread Richard Biener
This is needed so that we can output references to $early-debug-symbol + constant offset where $early-debug-symbol is the beginning of a .debug_info section containing early debug info from the compile-stage. Constant offsets are always fine for any object formats I know, I tested ia64-linux apa

[AArch64][TLSLE][1/3] Add the option "-mtls-size" for AArch64

2015-08-19 Thread Jiong Wang
Marcus Shawcroft writes: > On 21 May 2015 at 17:44, Jiong Wang wrote: >> >> This patch add -mtls-size option for AArch64. This option let user to do >> finer control on code generation for various TLS model on AArch64. >> >> For example, for TLS LE, user can specify smaller tls-size, for example

[AArch64][TLSLE][2/3] Add the option "-mtls-size" for AArch64

2015-08-19 Thread Jiong Wang
As we have added -mtls-size support, there should be four types TLSLE symbols: SYMBOL_TLSLE12 SYMBOL_TLSLE24 SYMBOL_TLSLE32 SYMBOL_TLSLE48 which reflect the maximum address bits needed to address this symbol. This patch rename SYMBOL_TLSLE to SYMBOL_TLSLE24. Patch [3/3] will add support

Re: [PATCH][ARM]Tighten the conditions for arm_movw, arm_movt

2015-08-19 Thread Renlin Li
Hi Kyrylo, On 19/08/15 13:46, Kyrylo Tkachov wrote: Hi Renlin, Please send patches to gcc-patches for review. Redirecting there now... Thank you! I should really double check after Thunderbird auto complete the address for me. On 19/08/15 12:49, Renlin Li wrote: Hi all, This simple patch

[AArch64][TLSLE][3/3] Implement local executable mode for all memory model

2015-08-19 Thread Jiong Wang
Marcus Shawcroft writes: > On 21 May 2015 at 17:49, Jiong Wang wrote: > >> 2015-05-14 Jiong Wang >> gcc/ >> * config/aarch64/aarch64.c (aarch64_print_operand): Support tls_size. >> * config/aarch64/aarch64.md (tlsle): Choose proper instruction >> sequences. >> (tlsle_): New define_ins

Re: [PATCH][1/n] dwarf2out refactoring for early (LTO) debug

2015-08-19 Thread Pedro Alves
On 08/19/2015 02:55 PM, Aldy Hernandez wrote: > On 08/19/2015 06:45 AM, Richard Biener wrote: > > [copying gdb folks] Thanks. > >> On Tue, 18 Aug 2015, Aldy Hernandez wrote: >> >>> On 08/18/2015 07:20 AM, Richard Biener wrote: > > [snip] > >> The patch below has passed bootstrap & regtest on

[fortran, committed] Forward port test generic_31.f90 from the 5 branch

2015-08-19 Thread Mikael Morin
Hello, I have forward-ported the test that justified backport of the pr66929 patch on the 5 branch: https://gcc.gnu.org/r227010 Mikael Index: gcc/testsuite/gfortran.dg/generic_31.f90 === --- gcc/testsuite/gfortran.dg/generic_31

[PATCH][AArch64][obvious] Remove obsolete comment in aarch64-option-extensions.def

2015-08-19 Thread Kyrill Tkachov
Hi all, This comment in aarch64-option-extensions.def seems obsolete and to me is more confusing than helpful. The entries in that file are not "example" extensions, they have a real meaning, and they are not templates for adding new CPUs anyway (not sure that ever made sense). This patch remo

[PATCH][AArch64] Use popcount_hwi instead of homebrew version

2015-08-19 Thread Kyrill Tkachov
Hi all, I noticed we have a hand-crafted "bit_count" function in the aarch64 backend that implements the popcount operation. We already have a midend popcount_hwi function operating on HOST_WIDE_INTs which seems to be exactly what we need. This patch removes the aarch64-specific version and up

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Michael Matz
Hi, On Wed, 19 Aug 2015, Richard Biener wrote: > I think tree_code is 64bits now. Huh? No; it's 16 bit since 8 bit run out. Ciao, Michael.

Re: [PATCH][AArch64] Use popcount_hwi instead of homebrew version

2015-08-19 Thread James Greenhalgh
On Wed, Aug 19, 2015 at 04:02:41PM +0100, Kyrill Tkachov wrote: > Hi all, > > I noticed we have a hand-crafted "bit_count" function in the aarch64 backend > that implements the popcount operation. > We already have a midend popcount_hwi function operating on HOST_WIDE_INTs > which seems to be ex

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Joseph Myers
On Wed, 19 Aug 2015, Andreas Schwab wrote: > FX writes: > > > @@ -80,6 +80,24 @@ foo_1 (float f, double d, long double ld > >if (__builtin_finitel (ld) != res_isfin) > > __builtin_abort (); > > > > + /* Sign bit of zeros and nans is not preserved in unsafe math mode. */ > > +#ifdef

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Biener
On August 19, 2015 5:05:01 PM GMT+02:00, Michael Matz wrote: >Hi, > >On Wed, 19 Aug 2015, Richard Biener wrote: > >> I think tree_code is 64bits now. > >Huh? No; it's 16 bit since 8 bit run out. Err, that's what I was trying to say... 16bits, obviously. BTW, in addition to errno math there is r

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Joseph Myers
On Wed, 19 Aug 2015, Richard Biener wrote: > As an additional point for many math functions we have to support errno > which means, like, BUILT_IN_SQRT can be rewritten to SQRT_EXPR > only if -fno-math-errno is in effect. But then code has to handle I'd say that for functions like that (which ca

Re: [PING][Patch] Add support for IEEE-conformant versions of scalar fmin* and fmax*

2015-08-19 Thread Richard Sandiford
Richard Biener writes: > BTW, in addition to errno math there is rounding math where we rely on > virtual operands to not mess with ordering. But you know what I'm going to say to that. Rounding affects arithmetic just as much as things like pow(). (And also doesn't affect min/max.) Richard

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 6:00 AM, H.J. Lu wrote: > On Wed, Aug 19, 2015 at 5:51 AM, Segher Boessenkool > wrote: >> On Wed, Aug 19, 2015 at 05:23:41AM -0700, H.J. Lu wrote: >>> >>> >> > You might have a reason why you want the entry stack address >>> >>> >> > instead of the >>> >>> >> > frame addr

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Andreas Schwab
Joseph Myers writes: > On Wed, 19 Aug 2015, Andreas Schwab wrote: > >> FX writes: >> >> > @@ -80,6 +80,24 @@ foo_1 (float f, double d, long double ld >> >if (__builtin_finitel (ld) != res_isfin) >> > __builtin_abort (); >> > >> > + /* Sign bit of zeros and nans is not preserved in u

[AArch64] Break -mcpu tie between the compiler and assembler

2015-08-19 Thread James Greenhalgh
Hi, This patch has been sitting in my tree for a while - it comes in handy when trying out bootstrap or test with -mcpu values like -mcpu=cortex-a72 with a system assmebler which trails trunk binutils. Essentially, we rewrite -mcpu=foo to a -march flag providing the same architecture revision an

Re: [AArch64] Break -mcpu tie between the compiler and assembler

2015-08-19 Thread Andrew Pinski
On Wed, Aug 19, 2015 at 11:39 PM, James Greenhalgh wrote: > > Hi, > > This patch has been sitting in my tree for a while - it comes in handy > when trying out bootstrap or test with -mcpu values like -mcpu=cortex-a72 > with a system assmebler which trails trunk binutils. > > Essentially, we rewrit

Re: [AArch64] Break -mcpu tie between the compiler and assembler

2015-08-19 Thread Andrew Pinski
On Wed, Aug 19, 2015 at 11:39 PM, James Greenhalgh wrote: > > Hi, > > This patch has been sitting in my tree for a while - it comes in handy > when trying out bootstrap or test with -mcpu values like -mcpu=cortex-a72 > with a system assmebler which trails trunk binutils. > > Essentially, we rewrit

[PATCH] remove more useless typedefs

2015-08-19 Thread tbsaunde+gcc
From: tbsaunde Hi, more typedef cleanup. bootstrapped + regtested on x86_64-linux-gnu, commited since preapproved by richi. Trev gcc/c-family/ChangeLog: 2015-08-18 Trevor Saunders * c-ada-spec.h, c-common.c, c-common.h, c-format.c, c-format.h, c-objc.h, c-ppoutput.c, c-p

[PATCHv2/AARCH64] Remove index from AARCH64_FUSION_PAIR

2015-08-19 Thread Andrew Pinski
Changes from v1: Also remove the hack AARCH64_FUSE_ALL. Instead of doing an explict index in aarch64-fusion-pairs.def, we should have an enum which does the index instead. This allows you to add/remove them without worrying about the order being correct and having holes or worry a

[PATCHv2/AARCH64] Remove index from AARCH64_EXTRA_TUNING_OPTION

2015-08-19 Thread Andrew Pinski
Just like the patch for AARCH64_FUSION_PAIR, this is a patch for AARCH64_EXTRA_TUNING_OPTION. Note I tested this patch on top of the patch for AARCH64_EXTRA_TUNING_OPTION. Changes in v2: Remove the hack for AARCH64_EXTRA_TUNE_ALL. Remove index from AARCH64_EXTRA_TUNING_OPTION Instead of

Re: [PATCHv2/AARCH64] Remove index from AARCH64_FUSION_PAIR

2015-08-19 Thread James Greenhalgh
On Wed, Aug 19, 2015 at 04:58:22PM +0100, Andrew Pinski wrote: > Changes from v1: > Also remove the hack AARCH64_FUSE_ALL. > > Instead of doing an explict index in aarch64-fusion-pairs.def, we > should have an enum which does the index instead. This allows > you to add/remove them wit

Re: [PATCHv2/AARCH64] Remove index from AARCH64_EXTRA_TUNING_OPTION

2015-08-19 Thread James Greenhalgh
On Wed, Aug 19, 2015 at 05:00:14PM +0100, Andrew Pinski wrote: > Just like the patch for AARCH64_FUSION_PAIR, this is a patch for > AARCH64_EXTRA_TUNING_OPTION. Note I tested this patch on top of the > patch for AARCH64_EXTRA_TUNING_OPTION. > > Changes in v2: > Remove the hack for AARCH64_EXTRA_T

[AArch64][TLSLE][2/3] Rename SYMBOL_TLSLE to SYMBOL_TLSLE24

2015-08-19 Thread Jiong Wang
Jiong Wang writes: > As we have added -mtls-size support, there should be four types TLSLE > symbols: > > SYMBOL_TLSLE12 > SYMBOL_TLSLE24 > SYMBOL_TLSLE32 > SYMBOL_TLSLE48 > > which reflect the maximum address bits needed to address this symbol. > > This patch rename SYMBOL_TLSLE to SYMBO

Re: [middle-end,patch] Making __builtin_signbit type-generic

2015-08-19 Thread Joseph Myers
On Wed, 19 Aug 2015, Andreas Schwab wrote: > >> Why only in usafe mode? Isn't the sign bit of NaN always unreliable? > > > > NaN sign bits are meaningful for a limited set of operations. > > And what are those? Assignment to the same type, negation, absolute value, copysign, signbit. (In part

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-08-19 Thread Jeff Law
On 08/12/2015 08:31 AM, Kyrill Tkachov wrote: 2015-08-10 Kyrylo Tkachov * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, then_cost, else_cost fields. Change branch_cost field to unsigned int. (end_ifcvt_sequence): Call set_used_flags on each insn in the sequ

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2015 at 08:25:49AM -0700, H.J. Lu wrote: > Here is a patch to add __builtin_argument_pointer. I only have Sorry to be a pain but... all the other builtins use _address instead of _pointer, it's probably best to follow that. > -- Built-in Function: void * __builtin_argument_poin

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 9:58 AM, Segher Boessenkool wrote: > On Wed, Aug 19, 2015 at 08:25:49AM -0700, H.J. Lu wrote: >> Here is a patch to add __builtin_argument_pointer. I only have > > Sorry to be a pain but... all the other builtins use _address > instead of _pointer, it's probably best to f

Re: [PATCH] remove more useless typedefs

2015-08-19 Thread David Malcolm
On Wed, 2015-08-19 at 11:50 -0400, tbsaunde+...@tbsaunde.org wrote: > From: tbsaunde > > Hi, > > more typedef cleanup. > > bootstrapped + regtested on x86_64-linux-gnu, commited since preapproved > by richi. [...] > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index db23a0f..32421c5 100644 >

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-08-19 Thread Kyrill Tkachov
On 19/08/15 17:57, Jeff Law wrote: On 08/12/2015 08:31 AM, Kyrill Tkachov wrote: 2015-08-10 Kyrylo Tkachov * ifcvt.c (struct noce_if_info): Add then_simple, else_simple, then_cost, else_cost fields. Change branch_cost field to unsigned int. (end_ifcvt_sequence): Call set_u

Re: [PATCH 1/3] tree-ssa-tail-merge: add IPA ICF infrastructure.

2015-08-19 Thread Jeff Law
On 08/05/2015 09:16 AM, Martin Liška wrote: 2015-07-09 Martin Liska * dbgcnt.def: Add new debug counter. * ipa-icf-gimple.c (func_checker::compare_ssa_name): Use newly added state flag. (func_checker::compare_memory_operand): Likewise. (func_checker::com

Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

2015-08-19 Thread Jeff Law
On 08/19/2015 11:20 AM, Kyrill Tkachov wrote: Hmmm... The function bb_valid_for_noce_process_p that we call early on in noce_process_if_block makes sure that the only live reg out of each basic block is the final common destination ('x' in the noce_if_info struct definition). Since both basic bl

[gomp4] Fixacc_on_device xform

2015-08-19 Thread Nathan Sidwell
I've committed this fix for a typo I introduced yesterday (and not testing what I thought I was testing). Sadly passing a gimple_seq to gsi_replace doesn't lead to a compile error, but to bad runtime behaviour. nathan 2015-08-19 Nathan Sidwell * omp-low.c (oacc_xform_on_device): Fix think

Re: [PR64164] drop copyrename, integrate into expand

2015-08-19 Thread Alexandre Oliva
On Aug 19, 2015, Andreas Schwab wrote: > Andreas Schwab writes: >> Alexandre Oliva writes: >> >>> [PR64164] fix regressions reported on m68k and armeb >>> >>> From: Alexandre Oliva >>> >>> Defer stack slot address assignment for all parms that can't live in >>> pseudos, and accept pseudos a

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2015 at 10:08:01AM -0700, H.J. Lu wrote: > > Maybe something like (heavily cut'n'pasted): > > > > > > @deftypefn {Built-in Function} {void *} __builtin_argument_address (void) > > This function is similar to @code{__builtin_frame_address} with an > > argument of 0, but it returns th

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 10:48 AM, Segher Boessenkool wrote: > On Wed, Aug 19, 2015 at 10:08:01AM -0700, H.J. Lu wrote: >> > Maybe something like (heavily cut'n'pasted): >> > >> > >> > @deftypefn {Built-in Function} {void *} __builtin_argument_address (void) >> > This function is similar to @code{_

Re: [PATCH] remove more useless typedefs

2015-08-19 Thread Trevor Saunders
On Wed, Aug 19, 2015 at 01:11:04PM -0400, David Malcolm wrote: > On Wed, 2015-08-19 at 11:50 -0400, tbsaunde+...@tbsaunde.org wrote: > > From: tbsaunde > > > > Hi, > > > > more typedef cleanup. > > > > bootstrapped + regtested on x86_64-linux-gnu, commited since preapproved > > by richi. > >

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-08-19 Thread Matthias Klose
On 08/18/2015 10:36 PM, Lynn A. Boger wrote: > As discussed in PR 66870, for ppc64le and ppc64le it is preferred to > use the gold linker with gccgo or gcc if the split stack option is enabled. > Use of the gold linker with the split stack option results in less storage > allocated for goroutine s

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-08-19 Thread David Edelsohn
On Wed, Aug 19, 2015 at 3:33 PM, Matthias Klose wrote: > why keep the old behaviour for other archs that have split stack support? Is > it > really necessary to make this dependent on the target? I'm still using an > unreviewed/unpinged patch to enable gold for gccgo (attached). I much prefer y

[gomp4] New reduction infrastructure for OpenACC

2015-08-19 Thread Cesar Philippidis
This patch introduces a infrastructure for reductions in OpenACC. This infrastructure consists of four internal functions, GOACC_REDUCTION_SETUP, GOACC_REDUCTION_INIT, GOACC_REDUCTION_FINI, and GOACC_REDUCTION_TEARDOWN, along with a new target hook goacc.reduction. Each internal function shares a c

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-08-19 Thread Jeff Law
On 08/15/2015 11:01 AM, Ajit Kumar Agarwal wrote: All: Please find the updated patch with suggestion and feedback incorporated. Thanks Jeff and Richard for the review comments. Following changes were done based on the feedback on RFC comments. and the review for the previous patch. 1. Both tr

[C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Paolo Carlini
Hi, submitter noticed that, in violation of [basic.start.main], we don't reject as ill-formed the declaration of a 'main' variable in the global namespace. Not a big deal IMHO, but the below simple check works well for me on x86_64-linux. Thanks, Paolo. // /cp 20

Re: [PATCH][2/n] Change dw2_asm_output_offset to allow assembling extra offset

2015-08-19 Thread Mike Stump
On Aug 19, 2015, at 7:25 AM, Richard Biener wrote: > > This is needed so that we can output references to $early-debug-symbol + > constant offset where $early-debug-symbol is the beginning of a > .debug_info section containing early debug info from the compile-stage. > Constant offsets are alwa

[C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Ville Voutilainen
>submitter noticed that, in violation of [basic.start.main], we don't reject >as ill-formed the declaration of a 'main' variable in the global namespace. >Not a big deal IMHO, but the below simple check works well for me on >x86_64-linux. Just fyi, gcc accepts decltype(main) x; decltype(sizeof(

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Paolo Carlini
Hi Ville, On 08/19/2015 10:12 PM, Ville Voutilainen wrote: submitter noticed that, in violation of [basic.start.main], we don't reject as ill-formed the declaration of a 'main' variable in the global namespace. Not a big deal IMHO, but the below simple check works well for me on x86_64-linux.

[nvptx] testsuite cleanups

2015-08-19 Thread Nathan Sidwell
This patch cleans up a bunch of c testsuite fails, (by skipping them) 1) make nvptx-*-* a freestanding environment. While there is a newlib port, it's not a full c library, and in particular doesn't have all the IO that's generally presumed. 2) added effective_target_global_constructor. nvp

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Ville Voutilainen
On 19 August 2015 at 23:26, Paolo Carlini wrote: > Hi Ville, > > > On 08/19/2015 10:12 PM, Ville Voutilainen wrote: >>> >>> submitter noticed that, in violation of [basic.start.main], we don't >>> reject >>> as ill-formed the declaration of a 'main' variable in the global >>> namespace. >>> Not a

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Paolo Carlini
Hi, On 08/19/2015 10:33 PM, Ville Voutilainen wrote: On 19 August 2015 at 23:26, Paolo Carlini wrote: Hi Ville, On 08/19/2015 10:12 PM, Ville Voutilainen wrote: submitter noticed that, in violation of [basic.start.main], we don't reject as ill-formed the declaration of a 'main' variable in

Re: [C++ Patch] PR 67065 ("Missing diagnostics for ill-formed program with main variable instead of function")

2015-08-19 Thread Ville Voutilainen
On 19 August 2015 at 23:37, Paolo Carlini wrote: > Ah, Ok, I didn't actually try to compile your snippet. Then I suspect you > mean c++/66606?!? Please double check if something is missing in Martin's > bug! That looks fairly comprehensive to me, I don't think I have cases to add to it. I did co

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-08-19 Thread Jeff Law
On 08/15/2015 11:01 AM, Ajit Kumar Agarwal wrote: From cf2b64cc1d6623424d770f2a9ea257eb7e58e887 Mon Sep 17 00:00:00 2001 From: Ajit Kumar Agarwal Date: Sat, 15 Aug 2015 18:19:14 +0200 Subject: [PATCH] [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation. Added a

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 10:53 AM, H.J. Lu wrote: > On Wed, Aug 19, 2015 at 10:48 AM, Segher Boessenkool > wrote: >> On Wed, Aug 19, 2015 at 10:08:01AM -0700, H.J. Lu wrote: >>> > Maybe something like (heavily cut'n'pasted): >>> > >>> > >>> > @deftypefn {Built-in Function} {void *} __builtin_argum

Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack

2015-08-19 Thread Lynn A. Boger
The split stack support only recently went into the gold linker for Power so the configure needs to detect if the gold linker version contains that support. If the build tries to use a gold linker without that support the build will fail on Power. My understanding was that the gold linker suppo

Re: [PING] Re: [PATCH] New configure option to default enable Smart Stack Protection

2015-08-19 Thread Jeff Law
On 07/13/2015 07:20 AM, Magnus Granberg wrote: Patch updated and tested on x86_64-unknown-linux-gnu (Gentoo) Changlogs /gcc 2015-07-05 Magnus Granberg * common.opt (fstack-protector): Initialize to -1. (fstack-protector-all): Likewise. (fstack-protector-strong): Like

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread Segher Boessenkool
On Wed, Aug 19, 2015 at 02:53:47PM -0700, H.J. Lu wrote: > How about this > > @deftypefn {Built-in Function} {void *} __builtin_argument_pointer (void) > This function is similar to @code{__builtin_frame_address} with an > argument of 0, but it returns the address of the incoming arguments to > th

Re: [PATCH] Add __builtin_stack_top

2015-08-19 Thread H.J. Lu
On Wed, Aug 19, 2015 at 3:10 PM, Segher Boessenkool wrote: > On Wed, Aug 19, 2015 at 02:53:47PM -0700, H.J. Lu wrote: >> How about this >> >> @deftypefn {Built-in Function} {void *} __builtin_argument_pointer (void) >> This function is similar to @code{__builtin_frame_address} with an >> argument

  1   2   >