On Wed, Aug 19, 2015 at 3:06 PM, Richard Sandiford <richard.sandif...@arm.com> wrote: > Richard Biener <richard.guent...@gmail.com> writes: >> As an additional point for many math functions we have to support errno >> which means, like, BUILT_IN_SQRT can be rewritten to SQRT_EXPR >> only if -fno-math-errno is in effect. But then code has to handle >> both variants for things like constant folding and expression combining. >> That's very unfortunate and something we want to avoid (one reason >> the POW_EXPR thing didn't fly when I tried). STRICT_FMIN/MAX_EXPR >> is an example where this doesn't apply, of course (but I detest the name, >> just use FMIN/FMAX_EXPR?). Still you'd need to handle both, >> FMIN_EXPR and BUILT_IN_FMIN, in code doing analysis/transform. > > Yeah, but match.pd makes that easy, right? ;-)
Sure, but that only addresses stmt combining, not other passes. And of course it causes {gimple,generic}-match.c to become even bigger ;) Richard.