Re: [PATCH] Fix a typo in range_entry_cmp (PR tree-optimization/61686)

2014-12-10 Thread Marek Polacek
On Wed, Dec 10, 2014 at 08:59:09AM +0100, Jakub Jelinek wrote: > On Wed, Dec 10, 2014 at 07:57:46AM +0100, Marek Polacek wrote: > > I don't really know this code, but this typo looks obvious enough. > > Using if (p->high != NULL_TREE) ... else if (p->high != NULL_TREE) > > couldn't be possibly desi

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-10 Thread Jakub Jelinek
On Tue, Dec 09, 2014 at 03:32:33PM +0300, Ilya Verbin wrote: > On 04 Dec 20:52, Jakub Jelinek wrote: > > On Thu, Dec 04, 2014 at 10:35:19PM +0300, Ilya Verbin wrote: > > > This issue can be resolved by forcing output of such variables. > > > Is this fix ok? Should I add a testcase? > > > > Yes, w

Re: [PING ^ 3][PATCH, AArch64] Add doloop_end pattern for -fmodulo-sched

2014-12-10 Thread Yangfei (Felix)
> > --- gcc/config/aarch64/aarch64.c(revision 217394) > > +++ gcc/config/aarch64/aarch64.c(working copy) > > @@ -10224,6 +10224,9 @@ aarch64_use_by_pieces_infrastructure_p > (unsigned i > > #define TARGET_USE_BY_PIECES_INFRASTRUCTURE_P \ > > aarch64_use_by_pieces_infrastructure_p > >

Re: [SH][committed] Document FPSCR built-in functions

2014-12-10 Thread Oleg Endo
On Wed, 2014-12-10 at 01:24 +0100, Oleg Endo wrote: > Hi, > > This documents the new SH FPSCR built-in functions. > Tested with 'make info dvi pdf', committed as r218551. > > Cheers, > Oleg > > gcc/ChangeLog: > PR target/53513 > * doc/extend.texi (__builtin_sh_get_fpscr, __builtin_sh

Re: [PATCH] TYPE_OVERFLOW_* cleanup

2014-12-10 Thread Richard Biener
On Tue, 9 Dec 2014, Marek Polacek wrote: > The issue here is that TYPE_OVERFLOW_TRAPS, TYPE_OVERFLOW_UNDEFINED, > and TYPE_OVERFLOW_WRAPS macros work on integral types only, yet we > pass e.g. pointer_type/real_type to them. This patch adds proper > checking for these macros and adds missing guar

Re: [PATCH 2/4] vldN_lane error message enhancements (D registers)

2014-12-10 Thread Christophe Lyon
On 9 December 2014 at 16:27, wrote: > From: Charles Baylis > > gcc/ChangeLog > > Charles Baylis > > * config/aarch64/arm_neon.h (__LD2_LANE_FUNC): Add explicit lane > bounds check. > (__LD3_LANE_FUNC): Likewise. > (__LD4_LANE_FUNC): Likewise > > gcc/testsuite/

[PATCH] Fix PR64191, 2nd part

2014-12-10 Thread Richard Biener
This fixes DCE to remove pointless clobbers which then enables to DCE empty loops (with just clobbers). This is IMHO important to get rid of empty constructor calling loops which are not uncommon. The way this now works is to treat clobbers as not necessary - but avoid removing them if required

Re: [PATCH] Fix PR42108

2014-12-10 Thread Richard Biener
On Tue, 9 Dec 2014, Richard Biener wrote: > > The following finally fixes PR42108 (well, hopefully...) by using > range-information on SSA names to allow the integer divisions introduced > by Fortran array lowering being hoisted out of loops, thus detecting > them as not trapping. > > I chose to

Re: [PATCH, REPOST] Fix PR fortran/60718

2014-12-10 Thread Tobias Burnus
Hi Bernd, On Tue, 2 Dec 2014 11:25:42, Bernd Edlinger wrote: > a long time ago, I posted this patch, but it got forgotten. Sorry, but persistent pinging helps... > However the described problem is still unsolved, > so I thought my patch should be re-posted now. > > > Boot-strapped and regressi

Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1

2014-12-10 Thread Alan Hayward
On 02/12/2014 12:36, "Alan Hayward" wrote: > >On 21/11/2014 14:08, "Alan Hayward" wrote: > >> >>On 14/11/2014 16:48, "Alan Hayward" wrote: >> >>>This is a new version of my BE patch from a few weeks ago. >>>This is part 1 and covers rtlanal.c. The second part will be aarch64 >>>specific. >>> >

Re: [gomp4] acc enter/exit data

2014-12-10 Thread Thomas Schwinge
Hi! On Thu, 30 Oct 2014 17:11:04 -0700, Cesar Philippidis wrote: > This patch add support for OpenACC's enter/exit data directive. [...] > gcc/ > * gimple.h (enum gf_mask): Add GF_OMP_TARGET_KIND_OACC_ENTER_EXIT_DATA. In r218567, I committed the following to gomp-4_0-branch: commi

Re: OpenACC GIMPLE_OACC_* -- or not?

2014-12-10 Thread Thomas Schwinge
Hi! On Wed, 12 Nov 2014 14:45:02 +0100, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 02:33:43PM +0100, Thomas Schwinge wrote: > > Months later, with months' worth of GCC internals experience, I now came > > to realize that maybe this has not actually been a useful thing to do > > (and likewise

Re: [gomp4] acc enter/exit data

2014-12-10 Thread Jakub Jelinek
On Wed, Dec 10, 2014 at 10:54:13AM +0100, Thomas Schwinge wrote: > --- gcc/omp-low.c > +++ gcc/omp-low.c > @@ -9404,7 +9404,9 @@ build_omp_regions_1 (basic_block bb, struct omp_region > *parent, >else if (code == GIMPLE_OMP_TARGET > && (gimple_omp_target_kind (stmt) == GF_OMP_

Nested OpenACC/OpenMP constructs (was: OpenACC GIMPLE_OACC_* -- or not?)

2014-12-10 Thread Thomas Schwinge
Hi! On Wed, 12 Nov 2014 14:45:02 +0100, Jakub Jelinek wrote: > please make sure we'll have > some tests on mixing OpenMP and OpenACC directives in the same functions > (it is fine if we error out on combinations that don't make sense or are > too hard to support). > E.g. supporting OpenACC #pragm

Re: OpenACC GIMPLE_OACC_* -- or not?

2014-12-10 Thread Thomas Schwinge
Hi Jakub! On Wed, 10 Dec 2014 10:57:58 +0100, I wrote: > In r218568, I applied the following to gomp-4_0-branch: > > commit 28629d718a63a782170cfb06a4d0278de0779039 > Author: tschwinge > Date: Wed Dec 10 09:52:28 2014 + > > Merge GIMPLE_OACC_KERNELS and GIMPLE_OACC_PARALLEL into GIMPL

Re: OpenACC GIMPLE_OACC_* -- or not?

2014-12-10 Thread Jakub Jelinek
On Wed, Dec 10, 2014 at 11:07:37AM +0100, Thomas Schwinge wrote: > ..., I noticed that GIMPLE_OMP_TARGET doesn't walk the child_fn and > data_arg. Is that intentional, or should that be done? If the latter > (but this doesn't seem to cause any ill effects -- why?), OK to commit > the following to

Re: Nested OpenACC/OpenMP constructs (was: OpenACC GIMPLE_OACC_* -- or not?)

2014-12-10 Thread Thomas Schwinge
Hi Jakub! On Wed, 10 Dec 2014 11:02:24 +0100, I wrote: > OpenACC: Rework nested constructs checking. > > gcc/ > * omp-low.c (scan_omp_target): Remove taskreg_nesting_level and > target_nesting_level assertions. > (check_omp_nesting_restrictions): Rework OpenACC con

Re: Nested OpenACC/OpenMP constructs (was: OpenACC GIMPLE_OACC_* -- or not?)

2014-12-10 Thread Jakub Jelinek
On Wed, Dec 10, 2014 at 11:10:19AM +0100, Thomas Schwinge wrote: > --- /dev/null > +++ gcc/testsuite/c-c++-common/gomp/nesting-1.c > @@ -0,0 +1,77 @@ > +void > +f_omp_parallel (void) > +{ > +#pragma omp parallel > + { > +int i; Can you please use a global variable declared outside of f_omp_pa

Re: [COMMITTED] [PING] [PATCH] [AArch64, NEON] More NEON intrinsics improvement

2014-12-10 Thread Yangfei (Felix)
> >> >>> +__extension__ static __inline float32x2_t __attribute__ > >> >>> +((__always_inline__)) > >> >>> +vfms_f32 (float32x2_t __a, float32x2_t __b, float32x2_t __c) { > >> >>> + return __builtin_aarch64_fmav2sf (-__b, __c, __a); } > >> >>> + > >> >>> +__extension__ static __inline float32x4_t

Re: [PATCH][rtlanal.c][BE][1/2] Fix vector load/stores to not use ld1/st1

2014-12-10 Thread Marcus Shawcroft
On 10 December 2014 at 09:51, Alan Hayward wrote: This is a new version of my BE patch from a few weeks ago. This is part 1 and covers rtlanal.c. The second part will be aarch64 specific. When combined with the second patch, It fixes up movoi/ci/xi for Big Endian, so that

Re: [PATCH 2/4] vldN_lane error message enhancements (D registers)

2014-12-10 Thread Alan Lawrence
Hmmm. Yes I think I may have switched that in the patch introducing __AARCH64_LANE_CHECK, and it was correct at time of Charles' writing. However, maybe we could (now) use __AARCH64_LANE_CHECK directly? (Referencing one of the component vectors in the blahLxMxN_t struct?) --Alan Christophe Ly

Re: [PATCH 0/4] [AARCH64,SIMD] PR63870 Improve error messages for single lane load/store

2014-12-10 Thread Alan Lawrence
Thanks, Charles. A couple of thoughts. I think the approach in patches 2+3+4 of using __builtin_aarch64_im_lane_boundsi is justified and works quite neatly. Modulo the question of argument ordering and __AARCH64_LANE_CHECK, those patches look good. However, the SIMD_ARG_STRUCT_LOAD_STORE_LANE

Re: [PATCH 2/3] Extended if-conversion

2014-12-10 Thread Yuri Rumyantsev
Richard, Sorry that I forgot to delete debug dump from my fix. I have few questions about your comments. 1. You wrote : > You also still have two functions for PHI predication. And the > new extended variant doesn't commonize the 2-args and general > path Did you mean that I must combine predic

Re: [PATCH, x86] Fix pblendv expand.

2014-12-10 Thread Jakub Jelinek
On Wed, Dec 10, 2014 at 02:37:13AM +0300, Evgeny Stupachenko wrote: > 2014-12-10 Evgeny Stupachenko I went ahead and filed a PR, so we have something to refer to in the ChangeLog and name the testcases. > --- a/gcc/config/i386/i386.c > +++ b/gcc/config/i386/i386.c > @@ -47546,6 +47546,7 @@ exp

Re: [RFC] diagnostics.c: For terminals, restrict messages to terminal width?

2014-12-10 Thread Dodji Seketeli
Hello Tobias, Thank you for this patch. I have a few comments about it below. Just as a heads-up, I am asking questions to Manuel in there, as well as referring to comments from FX's. Please read below. Tobias Burnus writes: > This patch fixes a Fortran diagnostic "regression". > > With the

Re: [PATCH][ARM] Fix names of some rounding intrinsics, impement vrndx_f32 and vrndxq_f32

2014-12-10 Thread Kyrill Tkachov
Ping. Kyrill On 01/12/14 11:43, Kyrill Tkachov wrote: Ping. Kyrill On 21/11/14 11:30, Kyrill Tkachov wrote: Ping again. Thanks, Kyrill On 13/11/14 14:45, Kyrill Tkachov wrote: Ping. Kyrill On 04/11/14 10:56, Kyrill Tkachov wrote: Phew, This one slipped through the cracks. Ping? https:/

Re: [PATCH] TYPE_OVERFLOW_* cleanup

2014-12-10 Thread Marek Polacek
On Tue, Dec 09, 2014 at 08:26:56PM +0100, Marc Glisse wrote: > >@@ -426,7 +426,8 @@ negate_expr_p (tree t) > > > >case VECTOR_CST: > > { > >-if (FLOAT_TYPE_P (TREE_TYPE (type)) || TYPE_OVERFLOW_WRAPS (type)) > >+if (FLOAT_TYPE_P (TREE_TYPE (type)) > >+|| (INTEGRAL_TYPE_P (t

Re: [patch] Fix ICE on unaligned record field

2014-12-10 Thread Eric Botcazou
> I suppose that could be done by something like the following, which I > have tested only very mildly so far, in particular I have not double > checked that get_inner_reference is cfun-agnostic. Thanks, this works fine on the testcase and I believe that get_inner_reference is indeed cfun-agnosti

[PATCH] IPA ICF: refactoring + fix for PR ipa/63569

2014-12-10 Thread Martin Liška
Hello. As suggested by Richard, I split compare_operand functions to various functions related to a specific comparison. Apart from that I added fast check for volatility flag that caused miscompilation mentioned in PR63569. Patch can bootstrap on x86_64-linux-pc without any regression seen and

Re: [RFC] diagnostics.c: For terminals, restrict messages to terminal width?

2014-12-10 Thread Manuel López-Ibáñez
On 10 December 2014 at 12:10, Dodji Seketeli wrote: >> >> Note that -fmessage-length= applies to the error message (wraps) _and_ >> the caret diagnostic (truncates) while the COLUMNS variable _only_ >> applies to the caret diagnostic. (BTW: The documentation currently >> does not mention COLUMNS.)

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-12-10 Thread Martin Liška
On 12/09/2014 03:15 PM, Richard Biener wrote: On Mon, Dec 8, 2014 at 5:52 PM, Martin Liška wrote: On 11/28/2014 10:32 AM, Richard Biener wrote: On Thu, Nov 27, 2014 at 6:08 PM, Martin Liška wrote: On 11/21/2014 04:21 PM, Martin Liška wrote: On 11/21/2014 04:02 PM, Richard Biener wrote:

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-10 Thread Dodji Seketeli
Hello Manuel, Manuel López-Ibáñez writes: > New version of the patch. Tobias noticed several problems with the > previous version: > > * Due to the use of placement-new for the buffered output_buffers > pp_warning_buffer and pp_error_buffer, the pretty-printer destructor > may end up trying to f

[PATCH][AARCH64]Fix AArch64 CLZ_DEFINED_AT_ZERO and CTZ_DEFINED_AT_ZERO definition.

2014-12-10 Thread Renlin Li
Hi all, This patch update the CTZ_DEFINED_VALUE_AT_ZERO definition to support more modes. In addition, those two macros should both return 2 in aarch64 back-end. Here are the explanations from GCC documentation: CLZ_DEFINED_VALUE_AT_ZERO (mode, value) CTZ_DEFINED_VALUE_AT_ZERO (mode, value)

Re: [PATCH fortran/diagnostics] Move gfc_error (buffered) to common diagnostics

2014-12-10 Thread Manuel López-Ibáñez
On 10 December 2014 at 13:54, Dodji Seketeli wrote: >> /* Report the number of warnings and errors that occurred to the caller. */ >> >> @@ -1525,11 +1625,14 @@ gfc_diagnostics_init (void) >> { >>diagnostic_starter (global_dc) = gfc_diagnostic_starter; >>diagnostic_finalizer (global_dc)

Re: [PATCH] PR ipa/63909 ICE: SIGSEGV in ipa_icf_gimple::func_checker::compare_bb()

2014-12-10 Thread Richard Biener
On Tue, Dec 9, 2014 at 4:52 PM, Martin Liška wrote: > On 11/21/2014 01:23 PM, Richard Biener wrote: >> >> On Fri, Nov 21, 2014 at 12:52 PM, Martin Liška wrote: >>> >>> On 11/20/2014 05:41 PM, Richard Biener wrote: On Thu, Nov 20, 2014 at 5:30 PM, Martin Liška wrote: > > >>

RE: [PATCH] Fix IRA register preferencing

2014-12-10 Thread Wilco Dijkstra
> Jeff Law wrote: > On 12/09/14 12:21, Wilco Dijkstra wrote: > > With the fix it uses a floating point register as expected. Given a similar > > issue in > > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02253.html, would it not be > > better to change > the > > initialization values of reg_pref

Re: [RFC] diagnostics.c: For terminals, restrict messages to terminal width?

2014-12-10 Thread Dodji Seketeli
Manuel López-Ibáñez writes: [...] > On 10 December 2014 at 12:10, Dodji Seketeli wrote: [...] >> Manuel, was there a particular reason to avoid mentioning the COLUMNS >> environment variable in the documentation? > > Not that I remember. Perhaps the documentation should say something > like:

Re: [PATCH] Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites

2014-12-10 Thread Richard Biener
On Wed, Dec 10, 2014 at 6:16 AM, Chung-Ju Wu wrote: > 2014-12-09 21:16 GMT+08:00 Richard Biener : >> On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu wrote: >>> Hi, all, >>> >>> In the discussion thread last year: >>> https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html >>> >>> I extended the sc

Re: [PATCH] Fix PR 61225

2014-12-10 Thread Segher Boessenkool
On Tue, Dec 09, 2014 at 12:15:30PM -0700, Jeff Law wrote: > >>@@ -3323,7 +3396,11 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn > >>*i1, rtx_insn *i0, > >> rtx old = newpat; > >> total_sets = 1 + extra_sets; > >> newpat = gen_rtx_PARALLEL (VOIDmode, rtvec_alloc (total_sets));

Re: [PATCH PR62178]Improve candidate selecting in IVOPT, 2nd try.

2014-12-10 Thread Richard Biener
On Fri, Dec 5, 2014 at 1:15 PM, Bin Cheng wrote: > Hi, > Though PR62178 is hidden by recent cost change in aarch64 backend, the ivopt > issue still exists. > > Current candidate selecting algorithm tends to select fewer candidates given > below reasons: > 1) to better handle loops with many indu

Re: [RFC] diagnostics.c: For terminals, restrict messages to terminal width?

2014-12-10 Thread FX
> So the patch you (Manual) are proposing looks fine to me, with the > environment variable taking precedence, *if* that is fine for Fortran, > of course. That seems fine to me, from the Fortran standpoint. COLUMNS is a bit of a special environment variable, which the shell (when it provides it)

Re: [PATCH] PR ipa/63909 ICE: SIGSEGV in ipa_icf_gimple::func_checker::compare_bb()

2014-12-10 Thread Martin Liška
On 12/10/2014 02:26 PM, Richard Biener wrote: On Tue, Dec 9, 2014 at 4:52 PM, Martin Liška wrote: On 11/21/2014 01:23 PM, Richard Biener wrote: On Fri, Nov 21, 2014 at 12:52 PM, Martin Liška wrote: On 11/20/2014 05:41 PM, Richard Biener wrote: On Thu, Nov 20, 2014 at 5:30 PM, Martin Liš

[PATCH][AARCH64][4.9]Backport "Use selected cpu's tuning when no tuning parameter is specified."

2014-12-10 Thread Renlin Li
On 04/12/14 10:27, Marcus Shawcroft wrote: On 27 November 2014 at 11:27, Renlin Li wrote: gcc/ChangeLog: 2014-11-27 Renlin Li * config/aarch64/aarch64.c (aarch64_parse_cpu): Don't define selected_tune. (aarch64_override_options): Use selected_cpu's tuning. OK and this is also

Re: [PATCH 06/10] rs6000: New add/subf carry insns

2014-12-10 Thread Segher Boessenkool
On Mon, Dec 08, 2014 at 10:53:21AM -0500, David Edelsohn wrote: > As we both noticed, there are a few problems with this patch, so I'll > wait for a revised version. Here it is. It took a bit longer because of a latent problem in combine (ugh!) that caused mysterious failures in guality (double u

Re: locales fixes

2014-12-10 Thread Jonathan Wakely
On 09/12/14 23:24 +, Jonathan Wakely wrote: On 09/12/14 20:34 +0100, Marc Glisse wrote: On Tue, 9 Dec 2014, Jonathan Wakely wrote: On 08/12/14 23:53 +0100, François Dumont wrote: After having installed all necessary locales on my system I end up with 4 failures. Here is a patch to fix th

Re: [patch] Fix ICE on unaligned record field

2014-12-10 Thread Richard Biener
On Wed, Dec 3, 2014 at 3:02 PM, Martin Jambor wrote: > Hi, > > On Mon, Dec 01, 2014 at 12:00:14PM +0100, Richard Biener wrote: >> On Fri, Nov 28, 2014 at 5:20 PM, Eric Botcazou wrote: >> > Hi, >> > >> > the attached Ada testcase triggers an assertion in the RTL expander for the >> > address opera

Reducing the amount of builtins by merging named patterns

2014-12-10 Thread Blumental Maxim
Hello everyone. I'm working on reducing the amount of builtin's in i386. My approach is to merge similar patterns into one with a fake argument which determines which instruction to print. We have ~30 groups of similar (i.e.having similar sets of attributes) named patterns. These groups together

Reducing the amount of builtins by merging named patterns

2014-12-10 Thread Blumental Maxim
Hello everyone. I'm working on reducing the amount of builtin's in i386. My approach is to merge similar patterns into one with a fake argument which determines which instruction to print. We have ~30 groups of similar (i.e.having similar sets of attributes) named patterns. These groups together

[PATCH] Fix LIM not clearing range-info

2014-12-10 Thread Richard Biener
While working on PR42108 I noticed that LIM fails to clear range-info on SSA names whose defining statements it moves, possibly causing wrong code generation later on. The following fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2014-12-10 Richard

Re: [patch] gdb python pretty printer for DIEs

2014-12-10 Thread David Malcolm
On Tue, 2014-12-09 at 13:10 -0800, Aldy Hernandez wrote: > From: > Aldy Hernandez >To: > jason merrill >Cc: > David Malcolm > , gcc-patches > > Subject: > [patch] gdb python

Re: [PATCH 2/3] Extended if-conversion

2014-12-10 Thread Richard Biener
On Wed, Dec 10, 2014 at 11:54 AM, Yuri Rumyantsev wrote: > Richard, > > Sorry that I forgot to delete debug dump from my fix. > I have few questions about your comments. > > 1. You wrote : >> You also still have two functions for PHI predication. And the >> new extended variant doesn't commonize

Re: [PATCH 06/10] rs6000: New add/subf carry insns

2014-12-10 Thread David Edelsohn
On Wed, Dec 10, 2014 at 9:00 AM, Segher Boessenkool wrote: > On Mon, Dec 08, 2014 at 10:53:21AM -0500, David Edelsohn wrote: >> As we both noticed, there are a few problems with this patch, so I'll >> wait for a revised version. > > Here it is. It took a bit longer because of a latent problem in

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Andreas Schwab
Ilya Enkovich writes: > * gcc.dg/lto/lto.exp: Load mpx-dg.exp. > * gcc.dg/lto/chkp-privatize_0.c: New. > * gcc.dg/lto/chkp-privatize_1.c: New. xgcc: error: unrecognized command line option '-mmpx' FAIL: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o assemble, -fPIC -flto

Re: [PATCH] TYPE_OVERFLOW_* cleanup

2014-12-10 Thread Marek Polacek
On Wed, Dec 10, 2014 at 09:42:58AM +0100, Richard Biener wrote: > On Tue, 9 Dec 2014, Marek Polacek wrote: > > > The issue here is that TYPE_OVERFLOW_TRAPS, TYPE_OVERFLOW_UNDEFINED, > > and TYPE_OVERFLOW_WRAPS macros work on integral types only, yet we > > pass e.g. pointer_type/real_type to them.

Merge from trunk to gccgo branch

2014-12-10 Thread Ian Lance Taylor
I merged trunk revision 218558 to the gccgo branch. Ian

[PATCH] Fix forwprop-29.c testcase

2014-12-10 Thread Richard Biener
The testcase relies on inlining two functions but if ICF unifies them (they are equal) then for some reason that doesn't happen. Even more weird on x86_64 ICF doesn't unify them. Well, the testcase isn't about ICF so simply disable it. Richard. 2014-12-10 Richard Biener * gcc.dg/tre

Re: [PATCH 2/3] Extended if-conversion

2014-12-10 Thread Yuri Rumyantsev
Richard, Thanks for your reply! I didn't understand your point: Well, I don't mind splitting all critical edges unconditionally but you do it unconditionally in proposed patch. Also I assume that call of split_critical_edges() can break ssa. For example, we can split headers of loops, loop exit

[PATCH][AArch64] Fix usage of +no in error message for aarch64_parse_extension

2014-12-10 Thread Kyrill Tkachov
Hi all, The error message when parsing feature modifiers can be improved. Currently, if the user gives something like -march=armv8-a+ the error message will read: error: missing feature modifier after '+no' even though '+no' was not given. With this patch we will now say: error: missing featur

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 17:49 GMT+03:00 Andreas Schwab : > Ilya Enkovich writes: > >> * gcc.dg/lto/lto.exp: Load mpx-dg.exp. >> * gcc.dg/lto/chkp-privatize_0.c: New. >> * gcc.dg/lto/chkp-privatize_1.c: New. > > xgcc: error: unrecognized command line option '-mmpx' > > FAIL: gcc.dg/lto/chkp-pr

[PATCH] Fix PR64048

2014-12-10 Thread Richard Biener
Committed. Richard. 2014-12-10 Richard Biener PR testsuite/64048 * gcc.dg/tree-prof/peel-1.c: Update dump scanning. Index: gcc/testsuite/gcc.dg/tree-prof/peel-1.c === --- gcc/testsuite/gcc.dg/tree-prof/peel-1.c

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Andreas Schwab
Ilya Enkovich writes: > 2014-12-10 17:49 GMT+03:00 Andreas Schwab : >> Ilya Enkovich writes: >> >>> * gcc.dg/lto/lto.exp: Load mpx-dg.exp. >>> * gcc.dg/lto/chkp-privatize_0.c: New. >>> * gcc.dg/lto/chkp-privatize_1.c: New. >> >> xgcc: error: unrecognized command line option '-m

Re: Reducing the amount of builtins by merging named patterns

2014-12-10 Thread Richard Henderson
On 12/10/2014 06:08 AM, Blumental Maxim wrote: > We have ~30 groups of similar (i.e.having similar sets of attributes) > named patterns. These groups together include ~230 template (i.e. > having substitution attributes in their names) named patterns in > total. So, we can reduce the amount of tem

[PATCH x86] Add march/mtune=knl

2014-12-10 Thread Ilya Tocar
Hi, Patch bellow adds march/mtune/attribute=knl. For now this is just silvermont tuning and avx/avx2/avx512 support. Ok for trunk? gcc/ * config.gcc: Support "knl". * config/i386/driver-i386.c (host_detect_local_cpu): Detect "knl". * config/i386/i386-c.c (ix86_target_macro

Re: [PATCH, x86] Fix pblendv expand.

2014-12-10 Thread Uros Bizjak
On Wed, Dec 10, 2014 at 12:03 PM, Jakub Jelinek wrote: > On Wed, Dec 10, 2014 at 02:37:13AM +0300, Evgeny Stupachenko wrote: >> 2014-12-10 Evgeny Stupachenko > > I went ahead and filed a PR, so we have something to refer to in the > ChangeLog and name the testcases. Thanks! >> --- a/gcc/confi

[PATCH][AARCH64]Use AARCH64_FL_FPSIMD flags for all cores in aarch64-cores.def

2014-12-10 Thread Renlin Li
Hi all, This patch will change AARCH64_FL_FPSIMD flags in aarch64-cores.def to AARCH64_FL_FOR_ARCH8 for all cores. In addition, duplicated flags from AARCH64_CORE expansion macro is removed. After the change, flags for a core should only be defined in aarch64-cores.def file. aarch64-none-

Re: [Ping] Port of VTV for Cygwin and MinGW

2014-12-10 Thread Patrick Wollgast
Ping. https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html On 27.11.2014 10:42, Patrick Wollgast wrote: > On 12.11.2014 19:40, Kai Tietz wrote: >> TerminateProcess is actually bad, as it doesn't call any of the atexit >> handlers. You simply nuke the process off. For cygwin this behavior >>

Re: [PATCH x86] Add march/mtune=knl

2014-12-10 Thread Uros Bizjak
On Wed, Dec 10, 2014 at 5:20 PM, Ilya Tocar wrote: > Hi, > > Patch bellow adds march/mtune/attribute=knl. > For now this is just silvermont tuning and avx/avx2/avx512 support. > Ok for trunk? > > gcc/ > * config.gcc: Support "knl". > * config/i386/driver-i386.c (host_detect_local_c

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
ax -fcheck-pointer-bounds -mmpx >> >> What is the target? > > Pick any. Here it is. >./gcc/xgcc -v Using built-in specs. COLLECT_GCC=./gcc/xgcc Target: x86_64-unknown-linux-gnu Configured with: ../gcc/configure --enable-languages=c,c++,fortran --disable-bootstrap Thr

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Andreas Schwab
Ilya Enkovich writes: > 2014-12-10 18:53 GMT+03:00 Andreas Schwab : >> Ilya Enkovich writes: >> >>> 2014-12-10 17:49 GMT+03:00 Andreas Schwab : Ilya Enkovich writes: > * gcc.dg/lto/lto.exp: Load mpx-dg.exp. > * gcc.dg/lto/chkp-privatize_0.c: New. > * gcc.

Re: [PATCH x86] Enable v64qi permutations.

2014-12-10 Thread Richard Henderson
On 12/04/2014 01:49 AM, Ilya Tocar wrote: > + if (!TARGET_AVX512BW || !(d->vmode == V64QImode)) Please don't over-complicate the expression. Use x != y instead of !(x == y). r~

[PATCH][ARM][doc] Remove mention of Advanced RISC Machines

2014-12-10 Thread Kyrill Tkachov
Hi all, The company ARM is not Advanced RISC Machines anymore and anyway the ARM architecture is distinct from the company. This patch adjusts the documentation accordingly. Ok? Thanks, Kyrill 2014-12-10 Kyrylo Tkachov * doc/invoke.texi (ARM options): Remove mention of Advanced RISC

Re: [PATCH x86] Enable v64qi permutations.

2014-12-10 Thread Robert Dewar
On 12/10/2014 11:49 AM, Richard Henderson wrote: On 12/04/2014 01:49 AM, Ilya Tocar wrote: + if (!TARGET_AVX512BW || !(d->vmode == V64QImode)) Please don't over-complicate the expression. Use x != y instead of !(x == y). To me the original reads more clearly, since it is of the parallel for

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 19:49 GMT+03:00 Andreas Schwab : > Ilya Enkovich writes: > >> 2014-12-10 18:53 GMT+03:00 Andreas Schwab : >>> Ilya Enkovich writes: >>> 2014-12-10 17:49 GMT+03:00 Andreas Schwab : > Ilya Enkovich writes: > >> * gcc.dg/lto/lto.exp: Load mpx-dg.exp. >> *

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Andreas Schwab
Ilya Enkovich writes: > 2014-12-10 19:49 GMT+03:00 Andreas Schwab : >> Ilya Enkovich writes: >> >>> 2014-12-10 18:53 GMT+03:00 Andreas Schwab : Ilya Enkovich writes: > 2014-12-10 17:49 GMT+03:00 Andreas Schwab : >> Ilya Enkovich writes: >> >>> * gcc.dg/lto/lto.e

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

2014-12-10 Thread Paolo Carlini
Hi, On 12/04/2014 07:17 PM, Kai Tietz wrote: So added testcase for this pr (its c++98 only) So: ChangeLog testsuite 2014-12-04 Kai Tietz PR c++/64127 * g++.dg/cpp/pr64127.C: New file. Tested on x86_64-unknown-linux-gnu. Ok to apply prior posted patch plus this new testcase

[PATCH][libstdc++][testsuite][2/2] Mark tests that don't fit into memory as UNSUPPORTED

2014-12-10 Thread Kyrill Tkachov
Hi all, Here is the second part that includes the new target-utils.exp in the libstdc++ testsuite and uses the check_unsupported_p procedure to mark tests that are too large for memory as unsupported. Ok? Thanks, Kyrill 2014-12-10 Kyrylo Tkachov * testsuite/lib/libstdc++.exp: Includ

Re: [PATCH][libstdc++][testsuite] Mark as UNSUPPORTED tests that don't fit into tiny memory model

2014-12-10 Thread Kyrill Tkachov
On 09/12/14 20:14, Mike Stump wrote: On Dec 9, 2014, at 3:17 AM, Kyrill Tkachov wrote: In the gcc and g++ testsuite we already catch such cases and mark them as UNSUPPORTED. In libstdc++.exp there is no such functionality. I'm not very happy that it had to be copied, but I couldn't find a way

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread James Greenhalgh
On Wed, Dec 10, 2014 at 05:13:22PM +, Andreas Schwab wrote: > Ilya Enkovich writes: > > > 2014-12-10 19:49 GMT+03:00 Andreas Schwab : > >> Ilya Enkovich writes: > >> > >>> 2014-12-10 18:53 GMT+03:00 Andreas Schwab : > Ilya Enkovich writes: > > > 2014-12-10 17:49 GMT+03:00 Andr

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 21:07 GMT+03:00 James Greenhalgh : > On Wed, Dec 10, 2014 at 05:13:22PM +, Andreas Schwab wrote: >> Ilya Enkovich writes: >> >> > 2014-12-10 19:49 GMT+03:00 Andreas Schwab : >> >> Ilya Enkovich writes: >> >> >> >>> 2014-12-10 18:53 GMT+03:00 Andreas Schwab : >> Ilya Enkovich

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread James Greenhalgh
On Wed, Dec 10, 2014 at 06:19:08PM +, Ilya Enkovich wrote: > 2014-12-10 21:07 GMT+03:00 James Greenhalgh : > > In the interests of breaking us out of this loop... > > > > At least: {arm-none-linux-gnueabihf, arm-none-eabi, > > aarch64-none-linux-gnueabi, aarch64-none-elf, > > aarch

[PATCH, committed] Document the JIT C++ bindings (libgccjit++.h)

2014-12-10 Thread David Malcolm
The JIT documentation only covered libgccjit.h, not libgccjit++.h. The following patch expands the JIT docs to cover these C++ bindings. These docs began as a copy of the C documentation, but have numerous changes and additional material to reflect the differences between the APIs (e.g. overload

Re: locales fixes

2014-12-10 Thread François Dumont
On 10/12/2014 00:24, Jonathan Wakely wrote: I still say the change to "if __GLIBC__ > 2 || __GLIBC_MINOR__ >= 20" is simply wrong. It works for me with 2.18, but if it doesn't work with 2.19 on Debian then why should it work any better with 2.20? Yes, it was indeed a wild guess because I di

Re: [PATCH] TYPE_OVERFLOW_* cleanup

2014-12-10 Thread Marc Glisse
On Wed, 10 Dec 2014, Marek Polacek wrote: @@ -482,6 +487,15 @@ extern void omp_clause_range_check_failed (const_tree, const char *, int, || TREE_CODE (TYPE) == BOOLEAN_TYPE \ || TREE_CODE (TYPE) == INTEGER_TYPE) +/* Nonzero if TYPE represents an integral type, including complex + and v

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 21:29 GMT+03:00 James Greenhalgh : > On Wed, Dec 10, 2014 at 06:19:08PM +, Ilya Enkovich wrote: >> 2014-12-10 21:07 GMT+03:00 James Greenhalgh : >> > In the interests of breaking us out of this loop... >> > >> > At least: {arm-none-linux-gnueabihf, arm-none-eabi, >> > aar

[C++ Patch] PR 60955

2014-12-10 Thread Paolo Carlini
Hi, this regression, a spurious warning about taking the address of a register parameter, happens in C++14 mode due to the use of force_paren_expr, called by finish_parenthesized_expr, which ends up calling build_static_cast. Manuel mentioned in the audit trail that TREE_NO_WARNING can be use

[PATCH] jit.exp: support C++ testcases

2014-12-10 Thread David Malcolm
There is an ugly kludge here in jit.exp, but it works. Is there a better way to do this? (see "Kludge alert" at top of jit.exp) gcc/jit/ChangeLog: * TODO.rst (Test suite): Remove item about running C++ testcases. * docs/internals/index.rst (Working on the JIT library): Add

[PATCH] combine: Do not allow asm as I2 in a special case

2014-12-10 Thread Segher Boessenkool
My rs6000 patch putting a clobber of the carry in every asm regressed guality/pr41353-1.c. This is because the asm (in f3 in that testcase, for example) now is a PARALLEL, and the special case for I2 a parallel and I3 a register move now triggers. Before, when the asm was not a parallel, can_comb

[PATCH, libiberty, libcpp]: Introduce xvasprintf to libiberty and use it in libcpp

2014-12-10 Thread Uros Bizjak
On Tue, Dec 9, 2014 at 11:24 PM, Joseph Myers wrote: >> Attached patch checks the return value and sets ptr to NULL in this case. >> >> 2014-12-09 Uros Bizjak >> >> * directives.c (cpp_define_formatted): Check return value of >> vasprintf and in case of error set ptr to NULL. >> >> Boo

Go patch committed: Don't lower multi-valued arguments into temporaries

2014-12-10 Thread Ian Lance Taylor
This patch from Chris Manghane fixes a compiler crash when lowering a multi-valued temporary (as in f(g()) when g returns multiple values). This is GCC PR 61316. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r fc51bd51a948 go/expressions.cc --- a

Re: [PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-12-10 Thread Ilya Verbin
On 10 Dec 09:22, Jakub Jelinek wrote: > On Tue, Dec 09, 2014 at 03:32:33PM +0300, Ilya Verbin wrote: > > However, I don't see -flto option in the build log. It seems that > > check_effective_target_lto isn't working inside libgomp/ directory. > > Maybe because ENABLE_LTO is defined only in gcc/con

Re: [PATCH] Fix IRA register preferencing

2014-12-10 Thread Jeff Law
On 12/10/14 06:26, Wilco Dijkstra wrote: If recomputing is best does that mean that record_reg_classes should not give a boost to the preferred class in the 2nd pass? Perhaps. I haven't looked deeply at this part of IRA. I was relaying my experiences with (ab)using the ira-reload callbacks to

Re: [PATCH, libiberty, libcpp]: Introduce xvasprintf to libiberty and use it in libcpp

2014-12-10 Thread Joseph Myers
On Wed, 10 Dec 2014, Uros Bizjak wrote: > libcpp/ChangeLog: > > 2014-12-10 Uros Bizjak > > * directives.c (cpp_define_formatted): Use xvasprintf. The libcpp patch is OK once the libiberty patch is in. -- Joseph S. Myers jos...@codesourcery.com

Re: [RFC] diagnostics.c: For terminals, restrict messages to terminal width?

2014-12-10 Thread Tobias Burnus
Hi all, I have now updated the patch, based on all comments and Manuel's patch. And bootstrapped it on x86-64-gnu-linux. If there are no more comments, I intent to commit it tomorrow. If it gets approved earlier, I will commit it earlier ;-) Some comments from me are below. FX wrote: So th

Re: [PATCH][libstdc++][testsuite] Mark as UNSUPPORTED tests that don't fit into tiny memory model

2014-12-10 Thread Mike Stump
On Dec 10, 2014, at 10:05 AM, Kyrill Tkachov wrote: > Thanks for the guidance. I've moved the definitions into a separate file and > included that in the places that use it (more than 2 places in my count). > This is the patch attached. > The second patch (will send shortly after this) adds the

Re: [PATCH] combine: Do not allow asm as I2 in a special case

2014-12-10 Thread Jeff Law
On 12/10/14 13:12, Segher Boessenkool wrote: My rs6000 patch putting a clobber of the carry in every asm regressed guality/pr41353-1.c. This is because the asm (in f3 in that testcase, for example) now is a PARALLEL, and the special case for I2 a parallel and I3 a register move now triggers. Be

Re: [patch] gdb python pretty printer for DIEs

2014-12-10 Thread Aldy Hernandez
On 12/10/14 06:21, David Malcolm wrote: On Tue, 2014-12-09 at 13:10 -0800, Aldy Hernandez wrote: From: Aldy Hernandez To: jason merrill Cc: David Malcolm , gcc-patches Subj

Re: Reducing the amount of builtins by merging named patterns

2014-12-10 Thread Andi Kleen
Richard Henderson writes: > On 12/10/2014 06:08 AM, Blumental Maxim wrote: >> We have ~30 groups of similar (i.e.having similar sets of attributes) >> named patterns. These groups together include ~230 template (i.e. >> having substitution attributes in their names) named patterns in >> total. S

Re: [PATCH, libiberty, libcpp]: Introduce xvasprintf to libiberty and use it in libcpp

2014-12-10 Thread Ian Lance Taylor
On Wed, Dec 10, 2014 at 12:17 PM, Uros Bizjak wrote: > > libiberty/ChangeLog: > > 2014-12-10 Uros Bizjak > Ben Elliston > Manuel Lopez-Ibanez > > * xvasprintf.c: New file. > * vprintf-support.h: Likewise. > * vprintf-support.c: Likewise. > * Makefile.

Re: [AArch64, NEON] Improve vmulX intrinsics

2014-12-10 Thread Jiangjiji
Hi, Christophe Lyon These testcases are not covered by the glorious testsuite. If these cases are in your todo list , I will exclude them. Thanks. -邮件原件- 发件人: Christophe Lyon [mailto:christophe.l...@linaro.org] 发送时间: 2014年12月9日 21:43 收件人: Jiangjiji 抄送: gcc-patches@gcc.gnu.org; Richard Ea

Merge from trunk@218484 to debug-early branch

2014-12-10 Thread Aldy Hernandez
It's been a while since the last merge, so I encountered more pain than usual in this merge. I noticed quite a few target library failures, but those seem to have been there already, thanks to my less than stellar testing on my last big set of patches in October :(. I will be fixing the targ

  1   2   >