Re: [PATCH] Fix fold making valid VEC_PERMs invalid

On November 3, 2014 8:34:11 AM CET, Jakub Jelinek wrote: >On Mon, Nov 03, 2014 at 08:15:32AM +0100, Marc Glisse wrote: >> Should I commit the following version, which passed testing as well? > >Yes, thanks. Thanks for fixing this! Richard. > Jakub

Re: [PATCH] x86: allow to suppress default clobbers added to asm()s

>>> On 31.10.14 at 20:02, wrote: > On 10/31/14 02:07, Jan Beulich wrote: >> While it always seemed wrong to me that there's no way to avoid the >> default "flags" and "fpsr" clobbers, the regression the fix for >> PR/60663 introduced (see PR/63637) makes it even more desirable to have >> such a me

[PATCH, testsuite, ARM] Check lr other than r3

Hi, pr45701-1.c FAIL for all tests. The patch updates it to check lr other than r3, based on the comments in arm_compute_save_reg_mask, /* ... Otherwise if we do not use the link register we do not need to save it. If we are pushing other registers onto the stack however, we can

Re: [PATCH, PR61605, 2/2] Use fuse-caller-save info in pass_cprop_hardreg

Tom, This patch broke arm thumb1 bootstrap. Please check details at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63718 Best Regards Joey On Fri, Oct 17, 2014 at 5:57 AM, Jeff Law wrote: > On 10/16/14 03:14, Tom de Vries wrote: >> >> Eric, >> >> this patch is the second half of the fix for PR61

[PATCH, testsuite, ARM] Skip combine-cmp-shift.c and unsined-extend-1.c for Thumb1

Hi, For combine-cmp-shift.c, Thumb1 does not have cmp and shift instruction. For unsigned-extend-1.c, it bases on conditional execution to optimize uxtb. But this is not for Thumb1. The patch skips the final check when arm_thumb1_ok. OK for trunk? Thanks! -Zhenqiang testsuite/ChangeLog: 2014-1

Re: [PATCH, i386]: Add target x86_64-*-* to many tests

On Sun, Nov 2, 2014 at 10:35 PM, Uros Bizjak wrote: >> Attached (mechanical) patch adds i?86-*-* target to many tests, where >> only x86_64-*-* is listed. Please note that x86_64-*-* already >> included && lp64 for 64bit specific tests due to -m32 multilib >> testing. > > Following patch adds mis

Re: [PATCH] FreeBSD arm support, EABI.

On Mon, Nov 3, 2014 at 6:11 AM, Andreas Tobler wrote: > Hello all, > > this is a patch which brings support for arm*-*-freebsd* to trunk. > The architectures supported are arm-*-*freebsd*, armv6-*-freebsd* and > armv6hf-*-freebsd*. > armv6 stands for ARM_ARCH == 6, arm stands for ARM_ARCH < 6. Jus

Re: update address taken: don't drop clobbers

On Sun, Nov 2, 2014 at 11:34 AM, Marc Glisse wrote: > On Fri, 31 Oct 2014, Richard Biener wrote: > >> On Sat, Oct 25, 2014 at 6:29 PM, Marc Glisse wrote: >>> >>> On Fri, 24 Oct 2014, Jeff Law wrote: >>> I'm starting to agree -- a later message indicated you wanted to drop the unlin

Re: [PATCH] FreeBSD arm support, EABI.

- Original Message From: Bin.Cheng To: Andreas Tobler Cc: GCC Patches Subject: Re: [PATCH] FreeBSD arm support, EABI. Date: 03/11/14 10:04 > On Mon, Nov 3, 2014 at 6:11 AM, Andreas Tobler wrote: > > Hello all, > > > > this is a patch which brings suppo

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

On Tue, Oct 28, 2014 at 10:30:47PM +0300, Ilya Verbin wrote: > --- a/gcc/cgraph.c > +++ b/gcc/cgraph.c > @@ -70,6 +70,7 @@ along with GCC; see the file COPYING3. If not see > #include "tree-dfa.h" > #include "profile.h" > #include "params.h" > +#include "context.h" > > /* FIXME: Only for PRO

[PATCH] [BUILDROBOT] RX: Mark unused argument

Hi! I noticed that rx_handle_func_attribute() doesn't use it's `args' argument any longer since DJ removed it's a gcc_assert() using it. See eg. this build: http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=372376 [...] g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exce

[BUILDROBOT] s390x-linux: Breaking in ifcvt.c (was: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4)

On Wed, 2014-10-29 18:27:57 +0800, Zhenqiang Chen wrote: > Hi, > > The patch enhances ifcvt to allow_cc_mode if HAVE_cbranchcc4. > > Bootstrap and no make check regression on X86-64. > Will add new test cases after ccmp is enabled. > > Ok for trunk? This seems to uncover something for s390x-l

Re: [BUILDROBOT] s390x-linux: Breaking in ifcvt.c (was: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4)

On Mon, Nov 03, 2014 at 11:06:06AM +0100, Jan-Benedict Glaw wrote: > On Wed, 2014-10-29 18:27:57 +0800, Zhenqiang Chen > wrote: > > Hi, > > > > The patch enhances ifcvt to allow_cc_mode if HAVE_cbranchcc4. > > > > Bootstrap and no make check regression on X86-64. > > Will add new test cases aft

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4

"Zhenqiang Chen" writes: > diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c > index a28f5c1..5cd0ac0 100644 > --- a/gcc/ifcvt.c > +++ b/gcc/ifcvt.c > @@ -1441,10 +1441,17 @@ noce_emit_cmove (struct noce_if_info *if_info, rtx > x, enum rtx_code code, >end_sequence (); > } > > - /* Don't even

Re: [BUILDROBOT] s390x-linux: Breaking in ifcvt.c (was: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4)

On Mon, 2014-11-03 11:06:06 +0100, Jan-Benedict Glaw wrote: > On Wed, 2014-10-29 18:27:57 +0800, Zhenqiang Chen > wrote: > > Hi, > > > > The patch enhances ifcvt to allow_cc_mode if HAVE_cbranchcc4. > > > > Bootstrap and no make check regression on X86-64. > > Will add new test cases after ccm

Re: [PATCH AVX512] Fix dg.torture tests with avx512

On Fri, Oct 31, 2014 at 11:17:07AM +0100, Uros Bizjak wrote: > I'd like to ask Jakub for a review of the above two parts, other parts > are OK with a rename (as mentioned above). Looks ok to me. Where the ICEs discovered just by normal make check or only with GCC_TEST_RUN_EXPENSIVE ? If the latt

[PATCH v3] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

On 2014.11.02 at 21:12 -0500, Jason Merrill wrote: > On 11/02/2014 09:15 AM, Markus Trippelsdorf wrote: > > + if (cxx_dialect < cxx11) > > + { > > + permerror (input_location, "specialization of %qD in different " > > +"namespace", tmpl); > > + permerror (input_locati

Re: [PATCH] FreeBSD arm support, EABI.

Hi Andreas, CC'ing arm maintainers and a couple of comments inline. On 02/11/14 22:11, Andreas Tobler wrote: Hello all, this is a patch which brings support for arm*-*-freebsd* to trunk. The architectures supported are arm-*-*freebsd*, armv6-*-freebsd* and armv6hf-*-freebsd*. armv6 stands for

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

On 29/10/14 00:22, Joseph S. Myers wrote: On Tue, 28 Oct 2014, Tejas Belagod wrote: Hi, Here is patch that consolidates AArch64 and ARM Intrinsics sections in extend.texi into one ACLE section to avoid information repetition and adds reference to the ARM C Language Extension spec on infocenter

Re: [PATCH] Use CONVERT_EXPR_P and friends in the middle-end

On Fri, Oct 31, 2014 at 6:59 PM, Joseph S. Myers wrote: > On Fri, 31 Oct 2014, Richard Biener wrote: > >> This fixes the few places where explicit checks for NOP_EXPR >> or CONVERT_EXPRs crept in. > > The goal really should be to eliminate anything that distinguishes the > two, and then combine th

Re: [PATCH] [BUILDROBOT] RX: Mark unused argument

Hi Jan-Benedict, 2014-11-03 Jan-Benedict Glaw * config/rx/rx.c (rx_handle_func_attribute): Mark unused argument. Approved - please apply. Cheers Nick

[match-and-simplify] support operator list

(had sent it earlier by private mail). The attached patch supports operator-list and it's use in for. For now, operator-list is rejected in expression. This patch also allows user-defined operator to be used as operator-list (user-defined ops are really temporary or "scoped" operator-lists). (for

Re: [PATCH] Merge from match-and-simplify, remove fold_unary dispatch from fold_stmt

On Fri, Oct 31, 2014 at 2:07 PM, Richard Biener wrote: > This implements the last pattern from fold_unary that covers > inputs that can come from a GIMPLE_UNARY_RHS assignment > and thus allows removal of the fold_unary dispatch from fold_stmt > and gimple_fold_stmt_to_constant_1. Remember that t

SRA: don't drop clobbers

Hello, now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C (attached) has a use of an undefined variable at the time of the uninit pass. Sadly, while this warned with earlier versions of the other patch (when I was inserting def

Re: [match-and-simplify] support operator list

On Mon, Nov 03, 2014 at 06:26:12PM +0530, Prathamesh Kulkarni wrote: > --- gcc/match-comparison.pd (revision 216916) > +++ gcc/match-comparison.pd (working copy) > @@ -1,5 +1,8 @@ > /* From fold_binary. */ > > +(define_operator_list eq_ops eq ne) > +(define_operator_list cc eq_ops lt le gt

[PATCH] Optimize UBSAN_NULL checks, add sanopt.c

Another shot at optimizing redundant UBSAN_NULL statements. This time we walk the dominator tree - that should result in more effective optimization - and keep a list of UBSAN_NULL statements that dominate the current block, see the comment before sanopt_optimize_walker. Statements coming from bl

[patch,avr] correct incorrect spec string for device specs

Hi, Unrecognized option error is issued by avr-gcc for devices with AVR_ISA_RMW. This is because of an incorrect spec string device spec generation. Below patch corrects the incorrect spec string in gen-avr-mmcu-specs.c. If OK, could someone commit please? diff --git a/gcc/config/avr/gen-avr-mmc

Re: [PATCH v3] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

On 11/03/2014 05:27 AM, Markus Trippelsdorf wrote: BTW both EDG and clang reject g++.dg/template/spec17.C: namespace io { template int foo(); } using namespace io; template<> int foo(); But I think it is a reasonable extension to accept it. We should reject it, too. We can only leave out

Re: [C++ PING^2] Re: [PATCH 5/5] Add illegal cilk checks to C++ front.

Andi Kleen writes: Ping!^2 > Andi Kleen writes: > > Ping! > > Can someone from the C++ side please approve this patch? > That's the only patch not approved in this patch kit, but blocking > the commit. > > -Andi > >> From: Andi Kleen >> >> Add calls for several illegal Cilk cases to the C++ fr

Re: [COMMITTED][PATCH PR63173] [AARCH64, NEON] Improve vld[234](q?)_dup intrinsics

So we've been seeing FAIL: gcc.target/aarch64/vldN_dup_1.c on aarch64_be-none-elf, since this patch went in. Felix, did you test for bigendian? However, this failure is fixed if I apply David Sherwood's patch set: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00942.html https://gcc.gnu.org/ml

Re: [PATCH]Partially fix PR61529, bound basic block frequency

On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. Not really, it's just a little bigger than the limit.

Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c

On Mon, Nov 03, 2014 at 03:27:57PM +0100, Marek Polacek wrote: > I moved all of this into new sanopt.c file. > (I guess that file includes some headers that we in fact don't > need, but the header flattening doesn't make it easy to check, > there are too many of them.) Well, in theory you could ju

Re: SRA: don't drop clobbers

Hi, On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: > Hello, > > now that the update_address_taken patch is in, let me re-post the > SRA follow-up. With this patch, testcase pr60517.C (attached) has a > use of an undefined variable at the time of the uninit pass. Sadly, > while this

Re: [match-and-simplify] support operator list

On Mon, Nov 3, 2014 at 2:01 PM, Jakub Jelinek wrote: > On Mon, Nov 03, 2014 at 06:26:12PM +0530, Prathamesh Kulkarni wrote: >> --- gcc/match-comparison.pd (revision 216916) >> +++ gcc/match-comparison.pd (working copy) >> @@ -1,5 +1,8 @@ >> /* From fold_binary. */ >> >> +(define_operator_lis

[PATCH] Adjust conversion handling in operation_could_trap_helper_p, gimplify CONVERT_EXPR as NOP_EXPR

$subject, as suggested by Joseph and Jakub Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-03 Richard Biener * tree-eh.c (operation_could_trap_helper_p): Handle conversions like ordinary operations. * gimplify.c (gimplify_conversion): G

Re: [match-and-simplify] support operator list

On Mon, Nov 03, 2014 at 04:46:43PM +0100, Richard Biener wrote: > On Mon, Nov 3, 2014 at 2:01 PM, Jakub Jelinek wrote: > > On Mon, Nov 03, 2014 at 06:26:12PM +0530, Prathamesh Kulkarni wrote: > >> --- gcc/match-comparison.pd (revision 216916) > >> +++ gcc/match-comparison.pd (working copy) > >

Re: SRA: don't drop clobbers

On Mon, 3 Nov 2014, Martin Jambor wrote: On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: Hello, now that the update_address_taken patch is in, let me re-post the SRA follow-up. With this patch, testcase pr60517.C (attached) has a use of an undefined variable at the time of the uni

Re: [PATCH 23/27] Documentation: the "intro" subdirectory

On 10/31/14 15:44, David Malcolm wrote: I don't see #26 or #27 in the series? Were they particularly large? Yes: I deliberately didn't send 19, 26, 27 as they were large (170k and up), and are essentially already approved: OK. No worries then. Jeff

Re: [PATCH] FreeBSD arm support, EABI.

Hi Kyrill, On 03.11.14 12:44, Kyrill Tkachov wrote: CC'ing arm maintainers and a couple of comments inline. Thank you! On 02/11/14 22:11, Andreas Tobler wrote: Hello all, this is a patch which brings support for arm*-*-freebsd* to trunk. The architectures supported are arm-*-*freebsd*, ar

Re: [libgomp, libiberty, libobjc] Fix gnu11 fallout on Solaris 10+

Richard Henderson writes: > On 10/24/2014 01:56 AM, Rainer Orth wrote: >> And even with the _XOPEN_SOURCE business out of the way, there's still >> the question what to do about _POSIX_SOURCE in libiberty/sigsetmask.c. >> Given that it was introduced almost 20 years ago, it may well be >> unneces

libgo patch committed: Use -dumpversion rather than looking at BASE-VER

This patch from Peter Collingbourne changes the libgo install to get the version number from gccgo -dumpversion rather than looking at the BASE-VER file in the gcc source directory. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 21b8b46b67f2 libgo/Makefile.am --- a/

Re: [patch,avr] correct incorrect spec string for device specs

On 3 November 2014 14:33, Sivanupandi, Pitchumani wrote: > Hi, > > Unrecognized option error is issued by avr-gcc for devices with AVR_ISA_RMW. > This is because of an incorrect spec string device spec generation. > > Below patch corrects the incorrect spec string in gen-avr-mmcu-specs.c. > If OK,

Re: [AArch64, Patch] Restructure arm_neon.h vector types's implementation(Take 2).

On 1 October 2014 09:26, Tejas Belagod wrote: > Hi, > > Returning to this old thread, > > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02285.html > > here is a patch after a few rounds of review comments, specifically: > > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02248.html > https://gcc.gnu

[libcc1, build] Enable libcc1 on Solaris

I noticed that the new libcc1 wasn't built on Solaris. This happens because socketpair doesn't live in libc, but in libsocket instead. To deal with this, I've copied the libgo (and libjava) code to detect the need for libsocket and libnsl. Once the build was attempted, two failures had to be dea

[libgo] Remove Solaris 11.1+ zone_net_addr_t treatment

The recent godump changes broke Solaris 11.1+ bootstrap in libgo: before, gen-sysinfo.so had type _zone_net_addr_t struct { zna_family uint16; zna_plen uint16; zna_addru struct { znau_addr6 _in6_addr; }; } which was filtered out by mksysinfo.sh due to the use of _in6_addr. After the change, the

Re: SRA: don't drop clobbers

Hi, On Mon, Nov 03, 2014 at 05:17:22PM +0100, Marc Glisse wrote: > On Mon, 3 Nov 2014, Martin Jambor wrote: > >On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: > >> > >>now that the update_address_taken patch is in, let me re-post the > >>SRA follow-up. With this patch, testcase pr6051

[RTL, Patch] Int div by constant compilation enhancement

Hi, This patch adds a mid-end check to catch division by constant case and optimize it to generate one shift, instead of two. A testacase to check the correct codegeneration for aarch64 is added. This check is not made generic, because the optimisation implemented is not used by all targets. Is

Re: Recent go changes broke alpha bootstrap

On Thu, Oct 30, 2014 at 08:05:14AM -0700, Ian Taylor wrote: > On Thu, Oct 30, 2014 at 5:46 AM, Dominik Vogt wrote: > > I'm not quite sure about the best approach. The attempt to > > represent C unions in the "right" way is ultimately futile as Go > > does not have the types necessary for it. For

Re: [PATCH 7/11][ARM] Migrate to new reduc_plus_scal_optab

On Fri, Oct 24, 2014 at 12:57 PM, Alan Lawrence wrote: > This migrates ARM from reduc_splus_optab and reduc_uplus optab to a single > reduc_plus_optab. > > Tested, in combination with next patch: > bootstrap on arm-none-linux-gnueabihf > cross-tested check-gcc on arm-none-eabi. > Ok. Ramana > gc

[gomp4] Mark fopenacc as LTO option

Thomas, This patch marks fopenacc as LTO option. This allows fopenacc to be passed to lto, which means the openacc builtins are recognized when reading in the LTO stream. This fixes a number of testcases in the libgomp testsuite. ok for gomp-4_0-branch? Thanks, - Tom 2014-11-03 Tom de Vrie

Re: [PATCH 10/11][RS6000] Migrate reduction optabs to reduc_..._scal

On Fri, 2014-10-24 at 19:49 -0400, David Edelsohn wrote: > On Fri, Oct 24, 2014 at 8:06 AM, Alan Lawrence wrote: > > This migrates the reduction patterns in altivec.md and vector.md to the new > > names. I've not touched paired.md as I wasn't really sure how to fix that > > (how do I vec_extractv2

Re: [PATCH] FreeBSD arm support, EABI.

On Sun, 2 Nov 2014, Andreas Tobler wrote: > * config/arm/arm.c (arm_init_libfuncs): FreeBSD does not support 8 > byte > atomics for __ARM_ARCH__ < 6 yet. > (arm_option_override): FreeBSD has not yet implemented unaligned > access. The __FreeBSD__ conditionals in arm.c are incorr

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

On Mon, 3 Nov 2014, Tejas Belagod wrote: > If I mention in a couple of sentences the level of ACLE support there is in > GCC currently, this section will need to be updated every time there is an > improvement in ACLE support - I guess we'll just have to remember to remove > parts of this section

Re: [PATCH v3] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

On 2014.11.03 at 08:47 -0600, Jason Merrill wrote: > On 11/03/2014 05:27 AM, Markus Trippelsdorf wrote: > > BTW both EDG and clang reject g++.dg/template/spec17.C: > > > > namespace io { > >template int foo(); > > } > > using namespace io; > > template<> int foo(); > > > > But I think it is a

Re: [PATCH][PPC] Skip gcc.target tests with conflicting -mcpu

On Oct 30, 2014, at 10:25 AM, Andrew Stubbs wrote: > Many of the tests in gcc.target/powerpc specify an explicit -mcpu option with > dg-options. This is a problem for multilib configurations that use -mcpu in > their definition > OK to commit? Given the discussion, I think the patch as is is f

Re: SRA: don't drop clobbers

On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah, that explains it, thanks. This patch is a follow-up to r217034. Still, I didn't expect the ICE you are seeing by applying this patch to older trunk, I'll try to reproduce that. -- M

Re: [patch,avr] correct incorrect spec string for device specs

Committed.

Re: [PATCH] FreeBSD arm support, EABI.

On 03.11.14 18:53, Joseph Myers wrote: On Sun, 2 Nov 2014, Andreas Tobler wrote: * config/arm/arm.c (arm_init_libfuncs): FreeBSD does not support 8 byte atomics for __ARM_ARCH__ < 6 yet. (arm_option_override): FreeBSD has not yet implemented unaligned access. The __Fre

Re: [PATCH] FreeBSD arm support, EABI.

On Mon, 3 Nov 2014, Andreas Tobler wrote: > > The __FreeBSD__ conditionals in arm.c are incorrect. Those would test for > > FreeBSD *host*, but you need a conditional for FreeBSD *target* here. > > > > Ouch, yes. > > This I'd have to define via config/arm/freebsd.h, right? > > #define ARM_FRE

Re: [PATCH 07/27] New file: gcc/jit/dummy-frontend.c

On 10/31/14 11:02, David Malcolm wrote: gcc/jit/ * dummy-frontend.c: New. OK. jeff

Re: [PATCH 11/27] New file: gcc/jit/jit-common.h

On 10/31/14 11:02, David Malcolm wrote: This header has forward declarations of both the jit::recording and jit::playback internal APIs. gcc/jit/ * jit-common.h: New. OK jeff

Re: [Patch, Fortran] Add CO_REDUCE

Andreas Schwab wrote: Tobias Burnus writes: diff --git a/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 b/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 new file mode 100644 index 000..f0ab932 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 FAIL: gfor

Re: C++ Patch for c++/60894

2014-10-09 15:34 GMT+02:00 Jason Merrill : [...] >> If the USING_DECL is returned, the code below will be rejected as >> expected, but the error message will not mention the line where the >> USING_DECL appears as the previous definition, but at the target >> declaration of the USING_DECL instead.

Re: [PATCH 08/27] New file: gcc/jit/libgccjit.h

On 10/31/14 11:02, David Malcolm wrote: This header is the public API for the library. gcc/jit/ * libgccjit.h: New. Given this is inside the JIT subdirectory, I'm not doing a depth review. + +/* A gcc_jit_block encapsulates a "basic block" of statements within a + function (i.e. wi

Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c

On 10/31/14 11:02, David Malcolm wrote: This file implements the entrypoints of the library's public API. It performs error-checking at this boundary, before calling into the jit-recording.h internal API. gcc/jit/ * libgccjit.c: New. --- gcc/jit/libgccjit.c | 1506

[PATCH] Optimize BIT_AND_EXPRs for UBSAN_OBJECT_SIZE

We don't emit UBSAN_BOUNDS checks in case we can at compile-time prove that the array access is fine. Also if we have [i & CST], where CST is <= bound_of_the_array, we know we're fine as well. But we don't have similar BIT_AND_EXPR check for UBSAN_OBJECT_SIZE which is what this patch attempts to

[RFC PATCH, i386]: Fix PR 63538, With -mcmodel=medium .lrodata accesses do not use 64-bit addresses

Hello! Following patch fixes PR 63538, where the data in the large data section was accessed through 32bit address. The patch unifies places where large data sections are determined and passes all declarations to ix86_in_large_data_p only. The patch fixes the testcase form the PR. Also, the code

Re: [PATCH 14/27] New files: gcc/jit/jit-builtins.{c|h}

On 10/31/14 11:02, David Malcolm wrote: These files implement support for builtins, for the gcc_jit_context_get_builtin_function API entrypoint. Only a subset of builtins are currently supported, based on those that I needed when porting GNU Octave's JIT. Attempts to use other builtins may l

Re: [PATCH 15/27] New file: gcc/jit/jit-playback.h

On 10/31/14 11:02, David Malcolm wrote: This files declares the gcc::jit::playback internal API, called by the dummy "frontend" to replay the public API calls made to the library. A thin wrapper around trees. gcc/jit/ * jit-playback.h: New. OK. jeff

Re: [PATCH 17/27] New file: gcc/jit/libgccjit++.h

On 10/31/14 11:02, David Malcolm wrote: This adds a C++ wrapper API, with syntactic sugar for reducing the verbosity compared to the C API. gcc/jit/ * libgccjit++.h: New. OK. Jeff

Re: [PATCH 20/27] Documentation: Makefile and conf.py

On 10/31/14 11:02, David Malcolm wrote: When I previously submitted the jit for review, I posted all of the documentation as one big patch, as: "[PATCH 08/10] Documentation for the JIT library (Re: Patches 5-10 of jit merger)" https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01392.html Sin

Re: [PATCH 12/27] New file: gcc/jit/jit-recording.h

On 10/31/14 11:02, David Malcolm wrote: This file declares the gcc::jit::recording internal API, so that libgccjit.c can record the calls that are made to the public API, for later playback by the dummy frontend. gcc/jit/ * jit-recording.h: New. --- gcc/jit/jit-recording.h | 1593 +

Re: [PATCH 06/27] New file: gcc/jit/Make-lang.in

On 10/31/14 11:02, David Malcolm wrote: gcc/jit/ * Make-lang.in: New. OK. jeff

Re: [PATCH 01/27] gcc: configure and Makefile changes needed by jit

On 10/31/14 11:02, David Malcolm wrote: An earlier version of this was posted as: "[PATCH 2/5] gcc: configure and Makefile changes needed by jit" https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01169.html Since then, I've eliminated the gcc_version, bindir, and pkgconfigdir additions, and

Re: SRA: don't drop clobbers

On Mon, 3 Nov 2014, Marc Glisse wrote: On Mon, 3 Nov 2014, Martin Jambor wrote: I just applied your patch on top of trunk revision 217032 on my Ah, that explains it, thanks. This patch is a follow-up to r217034. Still, I didn't expect the ICE you are seeing by applying this patch to older t

Re: The nvptx port [11/11] More tools.

On 10/31/14 17:50, Bernd Schmidt wrote: On 10/31/2014 09:56 PM, Jeff Law wrote: Pondering this a bit more, I think this is fine in concept. As you note, removing the GNU extensions or at least making them conditional would be good since these are going to be built with the host tools. I'm not

Re: [PATCH 13/27] New file: gcc/jit/jit-recording.c

On 10/31/14 11:02, David Malcolm wrote: Implementation of the gcc::jit::recording internal API, so that libgccjit.c can record the calls that are made to the public API, for later playback by the dummy frontend. gcc/jit/ * jit-recording.c: New. Cursory review since it's the JIT implement

Re: [PATCH] Optimize BIT_AND_EXPRs for UBSAN_OBJECT_SIZE

On 11/03/14 13:47, Marek Polacek wrote: We don't emit UBSAN_BOUNDS checks in case we can at compile-time prove that the array access is fine. Also if we have [i & CST], where CST is <= bound_of_the_array, we know we're fine as well. But we don't have similar BIT_AND_EXPR check for UBSAN_OBJECT_

Re: nvptx offloading patches [1/n]

On 11/01/14 05:47, Bernd Schmidt wrote: This is one of the patches required to make offloading via the LTO path work when the machines involved differ. x86 requires bigger alignments for some types than nvptx does, which becomes an issue when reading LTO produced by the host compiler. The proble

Re: nvptx offloading patches [2/n]

On 11/01/14 05:51, Bernd Schmidt wrote: LTO has a mechanism not to stream out common nodes that are expected to be identical on each run. When using LTO to communicate between compilers for different targets, the va_list_type_node and related ones must be excluded from this. Richard B mentioned

Re: nvptx offloading patches [3/n], RFD

On 11/01/14 05:57, Bernd Schmidt wrote: This is not against current trunk; it applies to gomp-4_0-branch where it is one of the necessary parts to make offloading x86->nvptx work. The issue is that the LTO file format depends on the machine_modes enum, it needs to match between host and offload t

Re: [PATCH] Optimize BIT_AND_EXPRs for UBSAN_OBJECT_SIZE

On Mon, Nov 03, 2014 at 09:47:05PM +0100, Marek Polacek wrote: > @@ -1456,6 +1457,8 @@ instrument_object_size (gimple_stmt_iterator *gsi, bool > is_lhs) > } >break; > case ARRAY_REF: > + index = TREE_OPERAND (t, 1); > + break; > case INDIRECT_REF: > case MEM_

Re: [PARCH 1/2, x86, PR63534] Fix darwin bootstrap

On 11/01/14 06:39, Evgeny Stupachenko wrote: When PIC register is pseudo there is nothing special about it's value that setjmp can hurt. So if the pseudo register lives across setjmp_receiver RA should care about correct allocation (in case it is not saved/restored, it should go on stack). gcc.dg

fix obvious typos in input.c

Committed as r217057. Index: gcc/input.c === --- gcc/input.c (revision 217056) +++ gcc/input.c (revision 217057) @@ -749,19 +749,20 @@ expanded_location expand_location_to_spelling_point (source_location loc) { - return expand_loc

Re: nvptx offloading patches [1/n]

On 11/03/2014 11:22 PM, Jeff Law wrote: On 11/01/14 05:47, Bernd Schmidt wrote: This is one of the patches required to make offloading via the LTO path work when the machines involved differ. x86 requires bigger alignments for some types than nvptx does, which becomes an issue when reading LTO

Re: Recent go changes broke alpha bootstrap

On Mon, Nov 3, 2014 at 9:02 AM, Dominik Vogt wrote: > On Thu, Oct 30, 2014 at 08:05:14AM -0700, Ian Taylor wrote: >> On Thu, Oct 30, 2014 at 5:46 AM, Dominik Vogt >> wrote: >> > I'm not quite sure about the best approach. The attempt to >> > represent C unions in the "right" way is ultimately f

Re: [COMMITTED][PATCH PR63173] [AARCH64, NEON] Improve vld[234](q?)_dup intrinsics

> So we've been seeing > > FAIL: gcc.target/aarch64/vldN_dup_1.c > > on aarch64_be-none-elf, since this patch went in. Felix, did you test for > bigendian? > > However, this failure is fixed if I apply David Sherwood's patch set: > > https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00942.html > ht

Re: [PATCH 08/27] New file: gcc/jit/libgccjit.h

On Mon, 2014-11-03 at 13:22 -0700, Jeff Law wrote: > On 10/31/14 11:02, David Malcolm wrote: > > This header is the public API for the library. > > > > gcc/jit/ > > * libgccjit.h: New. > Given this is inside the JIT subdirectory, I'm not doing a depth review. > > + > > +/* A gcc_jit_block en

RE: [BUILDROBOT] s390x-linux: Breaking in ifcvt.c (was: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4)

> -Original Message- > From: Jan-Benedict Glaw [mailto:jbg...@lug-owl.de] > Sent: Monday, November 03, 2014 6:16 PM > To: Zhenqiang Chen; Hartmut Penner; Ulrich Weigand; Andreas Krebbel > Cc: 'Richard Henderson'; gcc-patches@gcc.gnu.org > Subject: Re: [BUILDROBOT] s390x-linux: Breaking in

RE: [BUILDROBOT] s390x-linux: Breaking in ifcvt.c (was: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4)

Sorry for breaking the build. The patch was reverted. I will rework on it. Thanks! -Zhenqiang > -Original Message- > From: Jan-Benedict Glaw [mailto:jbg...@lug-owl.de] > Sent: Monday, November 03, 2014 6:16 PM > To: Zhenqiang Chen; Hartmut Penner; Ulrich Weigand; Andreas Krebbel > Cc: 'R

[patch] Use aliases for type traits in C++14 mode.

For C++14-only components we can use the aliases for type traits. Tested x86_64-linux, committed to trunk. commit cdb81d65750569f86a526856c99c2ef3c5266d11 Author: Jonathan Wakely Date: Tue Nov 5 23:21:01 2013 + Use aliases for type traits in C++14 mode. * include/bits/uniq

[patch] Simplify construction of _Bind_simple in

With the arity-checking I added recently we don't need the SFINAE constraints on the number of arguments to _Bind_simple's constructors. Tested x86_64-linux, committed to trunk. commit d78bba658af1677b873d391649ee237150b3c916 Author: Jonathan Wakely Date: Mon Nov 3 14:52:15 2014 +

Re: [patch] LWG 2019 - std::isblank

On 21/10/14 13:26 +0100, Jonathan Wakely wrote: On 20/10/14 23:08 +0100, Jonathan Wakely wrote: On 20 October 2014 18:40, Tim Shen wrote: On Mon, Oct 20, 2014 at 5:34 AM, Jonathan Wakely wrote: Committed to trunk. Yay, I think it's the time to remove regex_traits::_RegexMask? Yes, I want

[patch] Make std::reference_wrapper trivially copyable.

This might be required for C++17, and is beneficial anyway, so let's change it now. Tested x86_64-linux, committed to trunk. commit 3b1cfc115060eb85f2a43c4bef80d25c4aefaa95 Author: Jonathan Wakely Date: Tue Nov 4 01:51:48 2014 + Make reference_wrapper trivially copyable.

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

On 03/11/14 17:19 +0100, Paolo Carlini wrote: Hi, On 11/03/2014 03:55 PM, Rainer Emrich wrote: Since the recent changes to the testsuites the folowing make targets in the libstdc++ testsuite directory don't work anymore: check-parallel check-performance check-performance-parallel Any comments

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

On 03/11/14 22:07 +, Jonathan Wakely wrote: On 3 November 2014 17:51, Paolo Carlini wrote: .. other than the above issue, I see a segmentation fault for: performance/ext/pb_ds/multimap_text_insert_mem_large.cc and a compile error for: performance/ext/pb_ds/priority_queue_text_pop

Re: [patch] Use aliases for type traits in C++14 mode.

Hmm, not sure how I managed to swap the content-type of the two parts of that message. The body was meant to read: On 04/11/14 02:51 +, Jonathan Wakely wrote: For C++14-only components we can use the aliases for type traits. Tested x86_64-linux, committed to trunk.

Re: [patch] Make std::reference_wrapper trivially copyable.

Messed up the content-types here too, the body was meant to be: On 04/11/14 02:53 +, Jonathan Wakely wrote: This might be required for C++17, and is beneficial anyway, so let's change it now. Tested x86_64-linux, committed to trunk.

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

On 04/11/14 03:41 +, Jonathan Wakely wrote: On 03/11/14 22:07 +, Jonathan Wakely wrote: On 3 November 2014 17:51, Paolo Carlini wrote: .. other than the above issue, I see a segmentation fault for: performance/ext/pb_ds/multimap_text_insert_mem_large.cc Fixed like so. commit 75