Re: avoid alignment of static variables affecting stack's

2014-10-23 Thread Jan Beulich
>>> On 23.10.14 at 08:50, wrote: > On Thu, Oct 23, 2014 at 07:30:27AM +0100, Jan Beulich wrote: >> Function (or more narrow) scope static variables (as well as others not >> placed on the stack) should also not have any effect on the stack >> alignment. I noticed the issue first with Linux'es dyna

[PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Yury Gribov
Hi all, On 09/29/2014 09:21 PM, Yury Gribov wrote: This patch enables -fsanitize-recover for KASan by default. This causes KASan to continue execution after error in case of inline instrumentation. This feature is needed because - reports during early bootstrap won't even be printed - needed to

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 11:11:29AM +0400, Yury Gribov wrote: > Hi all, > > On 09/29/2014 09:21 PM, Yury Gribov wrote: > >>>This patch enables -fsanitize-recover for KASan by default. This causes > >>>KASan to continue execution after error in case of inline > >>>instrumentation. This feature is ne

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-23 Thread Richard Sandiford
Maxim Kuvyrkov writes: > @@ -6701,6 +6753,24 @@ alloc_global_sched_pressure_data (void) > saved_reg_live = BITMAP_ALLOC (NULL); > region_ref_regs = BITMAP_ALLOC (NULL); > } > + > + /* Calculate number of CALL_USED_REGS in register classes that > + we calculate regis

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-23 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 8:20 PM, Richard Sandiford wrote: > Maxim Kuvyrkov writes: >> @@ -6701,6 +6753,24 @@ alloc_global_sched_pressure_data (void) >>saved_reg_live = BITMAP_ALLOC (NULL); >>region_ref_regs = BITMAP_ALLOC (NULL); >> } >> + >> + /* Calculate number of CALL_

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Yury Gribov
On 10/23/2014 11:13 AM, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 11:11:29AM +0400, Yury Gribov wrote: Hi all, On 09/29/2014 09:21 PM, Yury Gribov wrote: This patch enables -fsanitize-recover for KASan by default. This causes KASan to continue execution after error in case of inline instrum

[PATCH] Var-tracking initialization fix (PR debug/63623)

2014-10-23 Thread Jakub Jelinek
Hi! As I wrote in the PR, vt_stack_adjustments can often compute wrong offsets, because it never considers pops with autoinc addressing, which can lead either to wrong debug info, or turning off -fvar-tracking altogether for a function on which that issue resulted in stack depth inconsistencies on

Re: [patch,gomp-4_0-branch] openacc parallel reduction part 1

2014-10-23 Thread Thomas Schwinge
Hi! On Mon, 28 Jul 2014 10:36:03 -0700, Cesar Philippidis wrote: > On 07/28/2014 10:02 AM, Thomas Schwinge wrote: > > On Sun, 6 Jul 2014 16:10:56 -0700, Cesar Philippidis > > wrote: > >> This patch is the first step to enabling parallel reductions in openacc. > > > > I think I have found one

Re: [PATCHv2] Don't expand string/memory builtins if ASan is enabled.

2014-10-23 Thread Yury Gribov
On 10/21/2014 05:26 PM, Maxim Ostapenko wrote: Hi, this is the second version of the patch. Here the major changes from the previous one: [snip] case BUILT_IN_BCMP: + *intercepted_p = false; The code which identifies interceptors seems to be duplicated in expand_builtin. What

[PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
This adds a libcpp host module without NLS and ICONV support and properly links genmatch against the build libcpp instead of the host one. Bootstrap running on x86_64-unknown-linux-gnu (stage1 all-gcc finished fine). Ok for trunk? Thanks, Richard. 2014-10-23 Richard Biener * Makefi

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 10:47:43AM +0200, Richard Biener wrote: > > This adds a libcpp host module without NLS and ICONV support > and properly links genmatch against the build libcpp instead of > the host one. > > Bootstrap running on x86_64-unknown-linux-gnu (stage1 all-gcc > finished fine). >

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Rainer Orth
Rainer Orth writes: > Two of the new gcc.dg/ipa/ipa-icf-*.c tests were FAILing on Solaris: > > FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) > UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Equal symbols: 1" > UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Semantic equali

[match-and-simplify] add new lower function

2014-10-23 Thread Prathamesh Kulkarni
Instead of iterating each time for calling lowering function (lower_opt_convert, etc.), add new lower function and pass lower_opt_convert, lower_for etc. to it as callback. * genmatch.c (lower): New overloaded function. (lower): Adjust to call overloaded lower. Thanks, Prathamesh Index: gcc/g

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 11:16:39AM +0200, Rainer Orth wrote: > Rainer Orth writes: > > > Two of the new gcc.dg/ipa/ipa-icf-*.c tests were FAILing on Solaris: > > > > FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) > > UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Equal symbols: 1"

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Rainer Orth
Jakub Jelinek writes: > On Thu, Oct 23, 2014 at 11:16:39AM +0200, Rainer Orth wrote: >> Rainer Orth writes: >> >> > Two of the new gcc.dg/ipa/ipa-icf-*.c tests were FAILing on Solaris: >> > >> > FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) >> > UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote: > > The testcase is clearly i?86/x86_64 specific, so it must be guarded with > > { target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need > > Right, that's what my patch already does. > > > for assembler support, so jus

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Andrey Ryabinin
On 10/23/2014 11:28 AM, Yury Gribov wrote: > On 10/23/2014 11:13 AM, Jakub Jelinek wrote: >> On Thu, Oct 23, 2014 at 11:11:29AM +0400, Yury Gribov wrote: >>> Hi all, >>> >>> On 09/29/2014 09:21 PM, Yury Gribov wrote: >> This patch enables -fsanitize-recover for KASan by default. This causes >>>

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: > IMO we don't need different versions of __asan_load* and > __asan_load*_noabort, because > -fno-sanitize-recover=kernel-address will never work with the linux kernel. > > I already said this before, and repeat this once again: > T

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 11:55:32AM +0200, Jakub Jelinek wrote: > On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: > > IMO we don't need different versions of __asan_load* and > > __asan_load*_noabort, because > > -fno-sanitize-recover=kernel-address will never work with the linux k

Re: [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV

2014-10-23 Thread Ramana Radhakrishnan
On Wed, Oct 22, 2014 at 11:02 AM, Jiong Wang wrote: > > On 21/10/14 15:30, Ramana Radhakrishnan wrote: >> >> On Mon, Oct 13, 2014 at 3:15 PM, Renlin Li wrote: >>> >>> Hi all, >>> >>> This is a simple patch to add missing __ARM_FEATURE_IDIV__ predefined >>> marco(ACLE 2.0) into TARGET_CPU_CPP_BUIL

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Andrey Ryabinin
On 10/23/2014 01:55 PM, Jakub Jelinek wrote: > On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: >> IMO we don't need different versions of __asan_load* and >> __asan_load*_noabort, because >> -fno-sanitize-recover=kernel-address will never work with the linux kernel. >> >> I alread

[Ada] Undefined symbol when using -gnatVa

2014-10-23 Thread Arnaud Charlet
This patch modifies the generation of validity checks for the bounds of a range to propagate the related subtype. This ensures the the same range will produce the same temporaries to capture the bounds with and without validity checks enabled. No small reproducer available. Tested on x86_64-pc-lin

Re: [PATCH 2/2] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*

2014-10-23 Thread Marcus Shawcroft
On 8 October 2014 18:27, wrote: > +#define __LD2_LANE_FUNC(intype, vectype, largetype, ptrtype, \ Just above the insertion point in arm-neon.h is the comment: /* Start of temporary inline asm for vldn, vstn and friends. */ This patch removes the "temporary inline asm vldn" imple

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 02:09:47PM +0400, Andrey Ryabinin wrote: > On 10/23/2014 01:55 PM, Jakub Jelinek wrote: > > On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: > >> IMO we don't need different versions of __asan_load* and > >> __asan_load*_noabort, because > >> -fno-sanitize-r

[Ada] Freezing issues with expression functions

2014-10-23 Thread Arnaud Charlet
An expression function does not freeze the corresponding expression. The function and the expression are frozen by a call, or by the end of the enclosing declarative part. If the expression includes attribute references to outer types, these must be frozen at that point. This patch ensures that fre

[Ada] Illegal declarations of deferred constants

2014-10-23 Thread Arnaud Charlet
A deferred constant whose type is an anonymous array is always illegal (unless it is imported). This patch makes the error message more detailed, to help future Ada beginners. Compiling array_constant.ads must yield: array_constant.ads:2:17: a deferred constant must have a named type array

[Ada] Ignore pragmas Inline/Inline_Always in GNATprove mode

2014-10-23 Thread Arnaud Charlet
Frontend inlining is applied independently of pragmas Inline or Inline_Always in GNATprove mode, to benefit from contextual analysis whenever possible. Hence, ignore such pragmas in GNATprove mode, to avoid getting useless errors on these when the corresponding subprogram is inlined by the frontend

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Andrey Ryabinin
On 10/23/2014 02:00 PM, Jakub Jelinek wrote: > On Thu, Oct 23, 2014 at 11:55:32AM +0200, Jakub Jelinek wrote: >> On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: >>> IMO we don't need different versions of __asan_load* and >>> __asan_load*_noabort, because >>> -fno-sanitize-recover

[Ada] Use of SPARK_Mode with front end inlining (-gnatN)

2014-10-23 Thread Arnaud Charlet
This patch modifies the front end inlining mechanism to ensure that a package body is always analyzed with the SPARK_Mode of the enclosing context. -- Source -- -- front_end_inlining.adc pragma SPARK_Mode (On); -- front_end_inlining.ads package Front_End_Inlining is

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Yury Gribov
On 10/23/2014 02:20 PM, Andrey Ryabinin wrote: On 10/23/2014 02:00 PM, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 11:55:32AM +0200, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: IMO we don't need different versions of __asan_load* and __asan_load*_noab

[Ada] Bug with interfaces and limited views

2014-10-23 Thread Arnaud Charlet
A type that implements interfaces generates internal procedures ("thunks") that access the dispatch table to retrieve the proper operation on a dispatching call. This patch fixes a bug in the handling of these thunks, when one of its formals has a limited view of a type. Usually the presence of suc

[Ada] Local renaming should not be externally visible

2014-10-23 Thread Arnaud Charlet
This patch modifies the analysis of a package body to hide object and subprogram renamings from external visibility. -- Source -- -- externals.ads package Externals is procedure Force_Body; end Externals; -- externals.adb package body Externals is Obj : consta

[Ada] Infinite loop on nested instantiations with dynamic elaboration checks

2014-10-23 Thread Arnaud Charlet
This patch fixes an infinite loop in GNAT when dynamic elaboration checks are generated for an instantiation of a generic function whose type is obtained from a formal package. The following must compile quietly: gcc -c -gnatE main.adb --- with Ada.Text_IO; use Ada.Text_IO; with Optional_Valu

Re: [COMMITTED][PATCH][ARM]Add ACLE 2.0 predefined marco __ARM_FEATURE_IDIV

2014-10-23 Thread Renlin Li
Are you sure that the ACLE documents this with trailing underscores ? The copy that I have doesn't. You are right, it's my incaution. I have double checked, the macro should be __ARM_FEATURE_IDIV. Could you please do a obvious fix? Thank you so much! Kind regards, Renlin

Re: [PATCH diagnostics] PR 53061 cleanup initialization

2014-10-23 Thread Dodji Seketeli
Hello Manuel, Manuel López-Ibáñez writes: > This is an old patch of mine that never got finished. I updated it following > the suggestions of Gabriel here > https://gcc.gnu.org/ml/gcc-patches/2012-04/msg00443.html Thanks for looking at this again. > Bootstrapped and tested on x86_64-linux-gnu.

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Yury Gribov
On 10/23/2014 02:16 PM, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 02:09:47PM +0400, Andrey Ryabinin wrote: On 10/23/2014 01:55 PM, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 01:51:12PM +0400, Andrey Ryabinin wrote: IMO we don't need different versions of __asan_load* and __asan_load*_noab

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 02:33:42PM +0400, Yury Gribov wrote: > Actually this is a historical artifact. If inlining proves to be > significantly faster, they may want to switch. Ok. > >So, at that point you can include your ugly hacks in __asan_load* logic in > >the kernel, the difference between

Re: C/C++ diagnostics guidelines

2014-10-23 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > On 17 October 2014 19:33, Joseph S. Myers wrote: >> On Fri, 17 Oct 2014, Manuel López-Ibáñez wrote: >> >>> Thus, I drafted some guidelines >>> at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines >>> >>> Please, could you take a look and comment whether I got i

[Ada] Spurious warnings about unused units

2014-10-23 Thread Arnaud Charlet
A prefixed call is resolved by examining the dispatch table of the controlling object, not by visibility. The operation may be defined in another unit, and no reference to it, or to its scope, might be created for it through the usual Generate_Reference machinery. To prevent spurious warnings about

[Ada] Introduce new message kind "Check"

2014-10-23 Thread Arnaud Charlet
This patch introduces a kind of message which is not an error (i.e. is non-fatal), but is not a warning either (cannot be suppressed with pragma Warnings). This new kind is called a check, and is recognized by a severity prefix "low: ", "medium: " or "high: ". This new message kind is to be used by

[Ada] Spurious conformance error with instance and child unit

2014-10-23 Thread Arnaud Charlet
This patch fixes a spurious subtype conformance error in a child unit when the actual is a private type declared in a package instantiation, whose full view is a constrained discriminated type. The following must compile quietly: gcc -c new_bounded_strings-child.adb --- with G_Instance; package

[Ada] Spurious warnings about unreferenced entities of a packed type

2014-10-23 Thread Arnaud Charlet
A reference to an element of a packed array is rewritten through conversions and masks and shifts. If the prefix of the reference is a source entity we must generate a reference to it for cross-reference purposes, and to prevent spurious warnings about unused entities. Compiling gcc -c -gnatw

Re: C/C++ diagnostics guidelines

2014-10-23 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > On 17 October 2014 20:04, Manuel López-Ibáñez wrote: >> On 17 October 2014 19:33, Joseph S. Myers wrote: >>> On Fri, 17 Oct 2014, Manuel López-Ibáñez wrote: >>> Thus, I drafted some guidelines at:https://gcc.gnu.org/wiki/Better_Diagnostics#guidelines

Re: [PATCH AVX512] [81.1/n] Extend `function_code' field in `tree_var_decl' structure.

2014-10-23 Thread Jakub Jelinek
On Wed, Oct 22, 2014 at 11:51:32AM +0400, Kirill Yukhin wrote: > gcc/ > * tree-core.h (tree_var_decl): Extend `function_code' field > by one bit, move `regdecl_flag' field to ... > (tree_decl_with_vis): Here. > * tree.h (DECL_STATIC_CHAIN): Update struct name. > > >

Re: [PATCHv4] Enable -fsanitize-recover for KASan

2014-10-23 Thread Andrey Ryabinin
On 10/23/2014 02:38 PM, Jakub Jelinek wrote: > On Thu, Oct 23, 2014 at 02:33:42PM +0400, Yury Gribov wrote: >> Actually this is a historical artifact. If inlining proves to be >> significantly faster, they may want to switch. > > Ok. > >>> So, at that point you can include your ugly hacks in __a

Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C

2014-10-23 Thread Dodji Seketeli
Hello Manuel, Manuel López-Ibáñez writes: > Dodji, are the linemap_asserts() appropriate? Yes they are. I have some additional comments though. > libcpp/ChangeLog: > > 2014-10-16 Manuel López-Ibáñez > > PR fortran/44054 > * include/line-map.h (linemap_position_for_loc_and_offset):

Re: [PATCH] Var-tracking initialization fix (PR debug/63623)

2014-10-23 Thread Richard Biener
On Thu, Oct 23, 2014 at 9:30 AM, Jakub Jelinek wrote: > Hi! > > As I wrote in the PR, vt_stack_adjustments can often compute wrong offsets, > because it never considers pops with autoinc addressing, which can lead > either to wrong debug info, or turning off -fvar-tracking altogether for > a funct

[C PATCH] Don't output warning twice (PR c/63626)

2014-10-23 Thread Marek Polacek
At present, we print the "inline function ... declared but never defined" warning twice. The reason for that is that this warning is being printed in pop_scope, which is called when popping file scope (c_common_parse_file->pop_file_scope), and when popping external scope (c_write_global_declaratio

Re: [patch] Excessive alignment in ix86_data_alignment

2014-10-23 Thread Petr Murzin
On 09 Oct 08:25, H.J. Lu wrote: > On Thu, Oct 9, 2014 at 1:37 AM, Uros Bizjak wrote: > > On Thu, Oct 9, 2014 at 10:25 AM, Kirill Yukhin > > wrote: > >> On 08 Oct 23:02, Petr Murzin wrote: > >>> Hi, > >>> I have measured performance impact on Haswell platform according to this > >>> input: > >>>

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Martin Liška
On 10/23/2014 11:38 AM, Jakub Jelinek wrote: On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote: The testcase is clearly i?86/x86_64 specific, so it must be guarded with { target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need Right, that's what my patch already does.

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 01:31:53PM +0200, Martin Liška wrote: > On 10/23/2014 11:38 AM, Jakub Jelinek wrote: > >On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote: > >>>The testcase is clearly i?86/x86_64 specific, so it must be guarded with > >>>{ target i?86-*-* x86_64-*-* }, and as it i

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Rainer Orth
Jakub Jelinek writes: >> The former can be cured by adding -Wno-psabi to dg-options, but I've no >> idea what to do about the latter, especially since it doesn't occur on >> i386-pc-solaris2.11. > > The testcase is clearly i?86/x86_64 specific, so it must be guarded with > { target i?86-*-* x86_6

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Rainer Orth
Jakub Jelinek writes: > On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote: >> > The testcase is clearly i?86/x86_64 specific, so it must be guarded with >> > { target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need >> >> Right, that's what my patch already does. >> >>

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 01:33:18PM +0200, Jakub Jelinek wrote: > > I combined both patches and run regression tests on x86_64-linux-pc. > > Ready for trunk? > > With proper ChangeLog entry yes. Actually, Rainer seems to have committed everything already. Jakub

Re: [PATCH 5/5] New tests introduction

2014-10-23 Thread Martin Liška
On 10/19/2014 09:50 AM, Andreas Schwab wrote: Martin Liška writes: diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c b/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c new file mode 100644 index 000..7358e43 --- /dev/null +++ b/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c @@ -0,0 +1,27 @@ +/* { dg-do comp

[PATCH] Fix ubsan shift instrumentation

2014-10-23 Thread Marek Polacek
The issue here was that we were diagnosing an artificial check that we created within the scope of shift instrumentation. In other words, for shifts we create something like (unsigned) A >> (B - C) and signed-integer-overflow triggered on that subtraction. Fixed by making the subtraction work on

[patch,avr,committed]: Fix coding rules.

2014-10-23 Thread Georg-Johann Lay
This no-op change fixed typos and restored coding rules as obvious like: spaces around operators, space before opening parentheses, wrapping long lines, indentation rules, trailing blanks, etc... http://gcc.gnu.org/r216592 Johann gcc/ * config/avr/avr.c: Fix GNU coding rules and typo

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Rainer Orth
Richard Biener writes: > This adds a libcpp host module without NLS and ICONV support > and properly links genmatch against the build libcpp instead of > the host one. > > Bootstrap running on x86_64-unknown-linux-gnu (stage1 all-gcc > finished fine). Unfortunately, this doesn't work on i386-pc-

Re: [PATCH] Fix ubsan shift instrumentation

2014-10-23 Thread Marek Polacek
On Thu, Oct 23, 2014 at 02:46:52PM +0200, Jakub Jelinek wrote: > Ok. Can you please queue it for 4.9 branch too, after 4.9.2 is released? > There is no -f*sanitize-recover* support, but it can be supposedly left out > from dg-options for the branch. Sure. Marek

Re: [PATCH] Fix and improve avx2 broadcasts (PR target/63594)

2014-10-23 Thread Rainer Orth
Hi Jakub, > This patch fixes a bunch of recent regressions: > FAIL: gcc.target/i386/avx-1.c (internal compiler error) > FAIL: gcc.target/i386/avx-1.c (test for excess errors) > FAIL: gcc.target/i386/avx-2.c (internal compiler error) > FAIL: gcc.target/i386/avx-2.c (test for excess errors) > FAIL:

Re: [PATCH] Fix ubsan shift instrumentation

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 02:34:04PM +0200, Marek Polacek wrote: > The issue here was that we were diagnosing an artificial check > that we created within the scope of shift instrumentation. In > other words, for shifts we create something like > (unsigned) A >> (B - C) and signed-integer-overflow t

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
On Thu, 23 Oct 2014, Rainer Orth wrote: > Richard Biener writes: > > > This adds a libcpp host module without NLS and ICONV support > > and properly links genmatch against the build libcpp instead of > > the host one. > > > > Bootstrap running on x86_64-unknown-linux-gnu (stage1 all-gcc > > fini

Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-10-23 Thread Rainer Orth
Andreas Schwab writes: > Alan Lawrence writes: > >> diff --git a/gcc/testsuite/gcc.dg/combine_ashiftrt_1.c >> b/gcc/testsuite/gcc.dg/combine_ashiftrt_1.c >> new file mode 100644 >> index >> ..90e64fd10dc358f10ad03a90041605bc3ccb7011 >> --- /dev/null >> +++

Re: [PATCH] Fix and improve avx2 broadcasts (PR target/63594)

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 02:58:06PM +0200, Rainer Orth wrote: > Unfortunately, I see some problems with those tests on Solaris: > > * On Solaris/x86, I get > > FAIL: gcc.dg/pr63594-2.c execution test > > for 32-bit. Any particular reason to restrict -mno-mmx to Linux/x86? > Manually building

[PATCH] Avoid recursion in fold

2014-10-23 Thread Richard Biener
On match-and-simplify branch I run into a recursion folding (bool_var & 1) == 0 via !(bool_var & 1) to (bool_var & 1) == 0 The appearant recursion prevention (well, not documented as such) in fold_truth_not_expr doesn't work because we still fold its result via the various fold_convert calls

[PATCH][match-and-simplify] 2nd try handling TREE_SIDE_EFFECTS

2014-10-23 Thread Richard Biener
This is a second attempt - it fixes the bugs in the previous one and handles falling back or not separately for the incoming arguments. What we handle too conservatively right now is non-captured leafs and captured expressions that are substituted into the result. Both result in the incoming argu

Re: [PATCH 1/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code

2014-10-23 Thread Rainer Orth
Evgeny Stupachenko writes: > Reattached. > > On Mon, Oct 13, 2014 at 8:22 PM, Uros Bizjak wrote: >> On Mon, Oct 13, 2014 at 4:53 PM, Evgeny Stupachenko >> wrote: >> >>> ChangeLog for testsuite: >>> >>> 2014-10-13 Evgeny Stupachenko >>> >>> PR target/8340 >>> PR middle-end/476

Re: [PATCH] Fix and improve avx2 broadcasts (PR target/63594)

2014-10-23 Thread Rainer Orth
Jakub Jelinek writes: > On Thu, Oct 23, 2014 at 02:58:06PM +0200, Rainer Orth wrote: >> Unfortunately, I see some problems with those tests on Solaris: >> >> * On Solaris/x86, I get >> >> FAIL: gcc.dg/pr63594-2.c execution test >> >> for 32-bit. Any particular reason to restrict -mno-mmx to

Re: [PATCH i386 AVX512] [81.2/n] Add new built-ins.

2014-10-23 Thread Uros Bizjak
On Thu, Oct 23, 2014 at 2:50 PM, Kirill Yukhin wrote: > Hello Uroš, > On 20 Oct 17:41, Kirill Yukhin wrote: >> This patch adds (almost) all built-ins > This is second, target dependent, part of the initial patch. > > ChangeLog is the same as in intial mail - tree* changes. > > Is it ok for trunk?

[PATCH] Fix copy&paste error in fold

2014-10-23 Thread Richard Biener
The following makes sure to convert the correct argument, not the one we already converted. Currently we end up folding ptr-type - integer-type. Oops. Fails spectacularly on match-and-simplify where this is the first strip-nops missed-optimization (on bogus input, that is). I'm considering th

[patch,avr] tweak sign extensions

2014-10-23 Thread Georg-Johann Lay
This optimization makes most sign-extensions one instruction shorter in the case when the source register may be clobbered and the register numbers are different. Source and destination may overlap. Ok for trunk? Johann gcc/ * config/avr/avr.md (extendqihi2, extendqipsi2, extendqisi

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Uros Bizjak
Hello! >> Ok, will try that. Still no idea why Linux/x86 and Solaris/x86 are >> different here. > > Why do you think so? I certainly have: > FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) > UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Equal symbols: 1" > UNRESOLVED: gcc.dg/ipa/

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Uros Bizjak
On Thu, Oct 23, 2014 at 3:54 PM, Uros Bizjak wrote: >>> Ok, will try that. Still no idea why Linux/x86 and Solaris/x86 are >>> different here. >> >> Why do you think so? I certainly have: >> FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) >> UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-d

Re: [PATCH PR63173] [AARCH64, NEON] Improve vld[234](q?)_dup intrinsics

2014-10-23 Thread Tejas Belagod
Index: gcc/config/aarch64/arm_neon.h === --- gcc/config/aarch64/arm_neon.h (revision 216558) +++ gcc/config/aarch64/arm_neon.h (working copy) @@ -11765,46 +11765,271 @@ __STRUCTN (poly, 8, 4) __STRUCTN (float, 64, 4) #

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
On Thu, 23 Oct 2014, Richard Biener wrote: > On Thu, 23 Oct 2014, Rainer Orth wrote: > > > Richard Biener writes: > > > > > This adds a libcpp host module without NLS and ICONV support > > > and properly links genmatch against the build libcpp instead of > > > the host one. > > > > > > Bootstra

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
On Thu, 23 Oct 2014, Richard Biener wrote: > On Thu, 23 Oct 2014, Richard Biener wrote: > > > On Thu, 23 Oct 2014, Rainer Orth wrote: > > > > > Richard Biener writes: > > > > > > > This adds a libcpp host module without NLS and ICONV support > > > > and properly links genmatch against the buil

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2014-10-23 Thread jb999
"Jeff Law" : > On 10/21/14 12:21, jb...@gmx.de wrote: > > "Jeff Law" : > >> On 10/21/14 16:13, Haswell wrote: > >>> The additional source must have the same requirement > >>> crossmodule-indircall-1.c has. > >>> > >>> * crossmodule-indircall-1a.c: Add missing requirement. > >> Why? When used b

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
Final try for today. Richard. Index: gcc/Makefile.in === --- gcc/Makefile.in (revision 216590) +++ gcc/Makefile.in (working copy) @@ -981,7 +981,15 @@ else LIBIBERTY = ../libiberty/libiberty.a BUILD_LIBIBERTY = $(build_lib

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Richard Biener
On Thu, 23 Oct 2014, Richard Biener wrote: > > Final try for today. And this may work as well and is slightly simpler. Index: gcc/Makefile.in === --- gcc/Makefile.in (revision 216590) +++ gcc/Makefile.in (working copy) @@ -

Re: [PATCH] Fix genmatch linking

2014-10-23 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 04:31:36PM +0200, Richard Biener wrote: > > Final try for today. > > Richard. > > Index: gcc/Makefile.in > === > --- gcc/Makefile.in (revision 216590) > +++ gcc/Makefile.in (working copy) > @@ -981,7 +981

Re: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work

2014-10-23 Thread Pedro Alves
On 10/23/2014 04:36 AM, Ian Taylor wrote: > This patch to the top level GCC configure script disables the go > languages on some systems where it is known to not work. Bootstrapped > on x86_64-unknown-gnu-linux. > > OK for mainline? > > Ian > > 2014-10-22 Ian Lance Taylor > > * configure.ac

Re: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work

2014-10-23 Thread Ian Taylor
On Thu, Oct 23, 2014 at 8:27 AM, Pedro Alves wrote: > > I think it'd be better if knowledge specific to subdirs was pushed down to > the subdirs, rather than being kept in the top level, in the direction > of how we disable libatomic, libsanitizer, etc. That is, by sourcing > something in the sub

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Jan Hubicka
> Jakub Jelinek writes: > > > On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote: > >> > The testcase is clearly i?86/x86_64 specific, so it must be guarded with > >> > { target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need > >> > >> Right, that's what my patch alread

Re: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work

2014-10-23 Thread Pedro Alves
On 10/23/2014 04:31 PM, Ian Taylor wrote: > On Thu, Oct 23, 2014 at 8:27 AM, Pedro Alves wrote: >> >> I think it'd be better if knowledge specific to subdirs was pushed down to >> the subdirs, rather than being kept in the top level, in the direction >> of how we disable libatomic, libsanitizer, e

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2014-10-23 Thread Ilya Verbin
On 22 Oct 11:22, Jakub Jelinek wrote: > On Tue, Oct 21, 2014 at 09:24:13PM +0400, Ilya Verbin wrote: > > + mic_lib_path_new = (char *) malloc ((mic_lib_path ? strlen > > (mic_lib_path) : 0) > > + + strlen (ld_lib_path) + 2); > > malloc can fail, SIGSEGV in respons

[patch] Define std::promise::set_value_at_thread_exit() etc.

2014-10-23 Thread Jonathan Wakely
This adds: std::notify_all_at_thread_exit() std::promise<>::set_value_at_thread_exit() std::promise<>::set_exception_at_thread_exit() std::packaged_task<>::make_ready_at_thread_exit() There's a linked list of callbacks that run after TLS destructors (called by a pthread_key_create destructor)

Re: PR lto/63603: Fix -fno-lto handling in driver (gcc/gcc.c)

2014-10-23 Thread Markus Trippelsdorf
On 2014.10.22 at 13:57 +0200, Tobias Burnus wrote: > I intent to commit the following patch this evening, which was > pre-proved for 4.9/trunk by Richard in the PR. > However, I still need to do the bootstrapping and regtesting. This breaks bootstrap-lto: ... configure: error: Link tests are not a

Re: [C PATCH] Don't output warning twice (PR c/63626)

2014-10-23 Thread Joseph S. Myers
On Thu, 23 Oct 2014, Marek Polacek wrote: > At present, we print the "inline function ... declared but never > defined" warning twice. The reason for that is that this warning > is being printed in pop_scope, which is called when popping file > scope (c_common_parse_file->pop_file_scope), and whe

RE: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-10-23 Thread Alan Lawrence
Mmmm, I've made a few attempts at filtering according to LP64 and ILP32, but not managed to get anything working so far (that is, I've ended up with the test not being executed on platforms where it should)ah, I see now where I've been going wrong, patch attached. The original intent was p

[patch] Update libstdc++ status docs

2014-10-23 Thread Jonathan Wakely
Committed to trunk. commit 65b21ceb68ef845874f79555cd51d7e54e69340f Author: Jonathan Wakely Date: Thu Oct 23 17:54:34 2014 +0100 * doc/xml/manual/status_cxx2011.xml: Update status. * doc/xml/manual/status_cxx2014.xml: Update TS status. diff --git a/libstdc++-v3/doc/xml/manual/status

Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-10-23 Thread Rainer Orth
Alan Lawrence writes: > Mmmm, I've made a few attempts at filtering according to LP64 and ILP32, > but not managed to get anything working so far (that is, I've ended up with > the test not being executed on platforms where it should)ah, I see now > where I've been going wrong, patch attached

Re: [testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

2014-10-23 Thread Martin Liška
On 10/23/2014 04:03 PM, Uros Bizjak wrote: On Thu, Oct 23, 2014 at 3:54 PM, Uros Bizjak wrote: Ok, will try that. Still no idea why Linux/x86 and Solaris/x86 are different here. Why do you think so? I certainly have: FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors) UNRESOLVED: gcc.dg

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-10-23 Thread augustine.sterl...@gmail.com
On Tue, Oct 21, 2014 at 7:20 PM, Yangfei (Felix) wrote: > If the tripcount spill issue is not handled in the pattern, ICE may happen > then. > Here reload is trying to spill pseudo 173, but a memory operand is not > allowed in zero_cost_loop_end pattern. > And this is what I am trying to solve.

Re: [PATCH i386 AVX512] [82/n] Add gather built-ins.

2014-10-23 Thread Uros Bizjak
On Wed, Oct 22, 2014 at 2:17 PM, Kirill Yukhin wrote: > Hello, > This patch introduces built-ins for gather insns. > > Bootstrapped. > AVX-512* tests on top of patch-set all pass > under simulator. > > Is it ok for trunk? > > gcc/ > * config/i386/i386.c (ix86_builtins): Add > IX86_BUILTIN

Re: [PATCH 2/2] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*

2014-10-23 Thread Charles Baylis
On 23 October 2014 11:14, Marcus Shawcroft wrote: > On 8 October 2014 18:27, wrote: > >> +#define __LD2_LANE_FUNC(intype, vectype, largetype, ptrtype, \ > > Just above the insertion point in arm-neon.h is the comment: > > /* Start of temporary inline asm for vldn, vstn and friends.

Re: [PATCH i386 AVX512] [83/n] Add scatter built-ins.

2014-10-23 Thread Uros Bizjak
On Wed, Oct 22, 2014 at 2:19 PM, Kirill Yukhin wrote: > Hello, > This patch adds built-ins for scatter insns. > > Bootstrapped. > AVX-512* tests on top of patch-set all pass > under simulator. > > Is it ok for trunk? > > gcc/ > * config/i386/i386.c > (ix86_init_mmx_sse_builtins): >

Re: [PATCH i386 AVX512] [84/n] Add missing immediate checks.

2014-10-23 Thread Uros Bizjak
On Wed, Oct 22, 2014 at 2:28 PM, Kirill Yukhin wrote: > Hello, > This tiny patch adds couple of missing immediate checks. > > Bootstrapped. > AVX-512* tests on top of patch-set all pass > under simulator. > > Is it ok for trunk? > > gcc/ > * config/i386/i386.c (ix86_expand_args_builtin): H

Re: [PATCH i386 AVX512] [89/n] Improve mask move insn generation.

2014-10-23 Thread Uros Bizjak
On Wed, Oct 22, 2014 at 2:58 PM, Kirill Yukhin wrote: > Hello, > This patch fixes kmov* insn generation > and adds memory alternative to `movqi_internal' > pattern > Reg-test included. > > Bootstrapped. > AVX-512* tests on top of patch-set all pass > under simulator. > > Is it ok for trunk? > > gc

Re: avoid alignment of static variables affecting stack's

2014-10-23 Thread Jeff Law
On 10/23/14 01:09, Jan Beulich wrote: On 23.10.14 at 08:50, wrote: On Thu, Oct 23, 2014 at 07:30:27AM +0100, Jan Beulich wrote: Function (or more narrow) scope static variables (as well as others not placed on the stack) should also not have any effect on the stack alignment. I noticed the iss

Re: [PATCH i386 AVX512] [85/n] Add intrinsics headers.

2014-10-23 Thread Uros Bizjak
On Wed, Oct 22, 2014 at 2:43 PM, Kirill Yukhin wrote: > Hello, > This patch introduces necessary AVX-512* intrinsics headers. > > Bootstrapped. > AVX-512* tests on top of patch-set all pass > under simulator. > > Is it ok for trunk? > > gcc/ > * config/i386/avx512bwintrin.h: New. >

  1   2   >