Re: sort_heap complexity guarantee

2014-10-22 Thread François Dumont
Then I think we need this patch which also fix other issues. 2014-10-22 François Dumont * testsuite/25_algorithms/make_heap/complexity.cc: Add missing test variable. * testsuite/25_algorithms/sort_heap/complexity.cc: Likewise and use log2. * testsuite/25_algorithms/pop_hea

Re: The nvptx port [11/11] More tools.

2014-10-22 Thread Bernd Schmidt
On 10/22/2014 10:31 PM, Jeff Law wrote: These tools currently require GNU extensions - something I probably ought to fix if we decide to add them to the gcc build itself. Would these be more appropriate in binutils? I don't think so, given that we don't need any piece of regular binutils. The

Re: [Patch, testsuite] clear wrap_compile_flags before setting it

2014-10-22 Thread Jeff Law
On 10/17/14 15:05, Christophe Lyon wrote: Hi, In testsuite/lib/wrapper.exp's ${tool}_maybe_build_wrapper, we call set_currtarget_info wrap_compile_flags to override wrap_compile_flags with additional flags when compiling testglue.c. However, dejagnu's set_currtarget_info {entry value} will writ

Re: [PATCH 3/5] IPA ICF pass

2014-10-22 Thread Jiong Wang
PR 63574 ICE building libjava (segfault) on arm-linux-gnueabihf is caused by this commit. from the backtrace, the ICF pass is trying to compare two label tree node without type info. while looks like "compare_operand" expect the type info always be not empty before invoking "func_checker::compati

Re: [PATCH] Add missing requirement to crossmodule-indircall-1a.c

2014-10-22 Thread Jeff Law
On 10/21/14 12:21, jb...@gmx.de wrote: "Jeff Law" : On 10/21/14 16:13, Haswell wrote: The additional source must have the same requirement crossmodule-indircall-1.c has. * crossmodule-indircall-1a.c: Add missing requirement. Why? When used by crossmodule-indircall-1.c we'll have alr

Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap

2014-10-22 Thread Jeff Law
On 10/17/14 08:16, Evgeny Stupachenko wrote: Hi, Some instructions (like one in PR63534) could have hidden use of PIC register. Therefore we need to leave SET_GOT not deleted till reload completed. The patch prevents SET_GOT from deleting while PIC register is pseudo. Is it ok? ChangeLog: 201

Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap

2014-10-22 Thread Jakub Jelinek
On Wed, Oct 22, 2014 at 03:34:38PM -0600, Jeff Law wrote: > >--- a/gcc/cse.c > >+++ b/gcc/cse.c > >@@ -6953,6 +6953,11 @@ delete_trivially_dead_insns (rtx_insn *insns, int > >nreg) > >/* If no debug insns can be present, COUNTS is just an array > > which counts how many times each

Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes

2014-10-22 Thread Michael Collison
Patch that removes extraneous comment attached. The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the vector intrinsic vclz this is incorrect and should return the value eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. Tested on arm-linux-gnueabihf, arm-linux-gnueabi.

Re: [Patch, libstdc++/63497] Avoid dereferencing invalid iterator in regex_executor

2014-10-22 Thread Tim Shen
On Wed, Oct 22, 2014 at 7:34 AM, Jonathan Wakely wrote: > Only if it's likely to catch problems in future. If you'd be putting > it in only to make a testcase fail then it's not worth it. No, since I think with this patch _M_current is clearly valid when being dereferenced. > You could even simp

Re: [PATCH 2/2, x86, PR63534] Fix darwin bootstrap

2014-10-22 Thread Evgeny Stupachenko
>What is ia32 specific on the test? Just the fact the test fails on ia32 now, for 64 bit the test is very simple, however we can test it as well. Full patch with testcase: 2014-10-22 Evgeny Stupachenko PR target/63534 PR target/63618 * cse.c (delete_trivially_dead_insns

Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap

2014-10-22 Thread Evgeny Stupachenko
>But here, after reload completes, there shouldn't be pseudos in the IL, so >the condition should not trigger anymore. At that point we'll just exit the condition earlier with !reload_completed. On Thu, Oct 23, 2014 at 1:40 AM, Jakub Jelinek wrote: > On Wed, Oct 22, 2014 at 03:34:38PM -0600, Jef

Re: [PATCH 5/8] Enable max_issue for AArch32 and AArch64

2014-10-22 Thread Sebastian Pop
Sebastian Pop wrote: > Maxim Kuvyrkov wrote: > > This change requires benchmarking, which I can't easily do at the moment. I > > would appreciate any benchmarking results that you can share. > > I will run my testsuite on aarch64. > Do you need the perf for all the previous patches 1 to 5 togethe

Re: [PATCH 5/8] Enable max_issue for AArch32 and AArch64

2014-10-22 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 11:42 AM, Sebastian Pop wrote: > Sebastian Pop wrote: >> Maxim Kuvyrkov wrote: >>> This change requires benchmarking, which I can't easily do at the moment. I >>> would appreciate any benchmarking results that you can share. >> >> I will run my testsuite on aarch64. >> Do yo

Re: [PATCH 6/8] Handle SCRATCH in decompose_address

2014-10-22 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 9:02 AM, Jeff Law wrote: > On 10/20/14 21:35, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch is a simple fix to allow decompose_address to handle >> SCRATCH'es during 2nd scheduler pass. This patch is a prerequisite >> for a scheduler improvement that relies on decompose_addre

Re: [Patch, libstdc++/63497] Avoid dereferencing invalid iterator in regex_executor

2014-10-22 Thread Jonathan Wakely
On 22/10/14 14:53 -0700, Tim Shen wrote: On Wed, Oct 22, 2014 at 7:34 AM, Jonathan Wakely wrote: Only if it's likely to catch problems in future. If you'd be putting it in only to make a testcase fail then it's not worth it. No, since I think with this patch _M_current is clearly valid when b

Re: sort_heap complexity guarantee

2014-10-22 Thread Jonathan Wakely
On 22/10/14 23:05 +0200, François Dumont wrote: Then I think we need this patch which also fix other issues. 2014-10-22 François Dumont * testsuite/25_algorithms/make_heap/complexity.cc: Add missing test variable. * testsuite/25_algorithms/sort_heap/complexity.cc: Likewise and use

Re: sort_heap complexity guarantee

2014-10-22 Thread Paolo Carlini
Hi, On 10/22/2014 11:05 PM, François Dumont wrote: + VERIFY( counter_type::less_compare_count <= 2.0 * std::log2(nb_values) ); Nit: log2 isn't in C89, thus we shouldn't use it unconditionally, ie, if the test isn't guarded by { dg-require-cmath "" }. Thus, either the latter, or just express l

Re: [PATCH 6/8] Handle SCRATCH in decompose_address

2014-10-22 Thread Jeff Law
On 10/22/14 17:01, Maxim Kuvyrkov wrote: On Oct 23, 2014, at 9:02 AM, Jeff Law wrote: On 10/20/14 21:35, Maxim Kuvyrkov wrote: Hi, This patch is a simple fix to allow decompose_address to handle SCRATCH'es during 2nd scheduler pass. This patch is a prerequisite for a scheduler improvement th

Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap

2014-10-22 Thread Jeff Law
On 10/22/14 15:40, Jakub Jelinek wrote: diff --git a/gcc/dce.c b/gcc/dce.c index 5b7d36e..a52a59c 100644 --- a/gcc/dce.c +++ b/gcc/dce.c @@ -127,6 +127,10 @@ deletable_insn_p (rtx_insn *insn, bool fast, bitmap arg_stores) if (HARD_REGISTER_NUM_P (DF_REF_REGNO (def)) && global_reg

Optimize powerpc*-*-linux* 32-bit classic hard/soft float hardfp/soft-fp use

2014-10-22 Thread Joseph S. Myers
Continuing the cleanups of libgcc soft-fp configuration for powerpc*-*-linux* in preparation for implementing TARGET_ATOMIC_ASSIGN_EXPAND_FENV for soft-float and e500, this patch optimizes the choice of which functions to build for the 32-bit classic hard-float and soft-float cases. (e500 will be

Re: [PATCH] Account for prologue spills in reg_pressure scheduling

2014-10-22 Thread Maxim Kuvyrkov
On Oct 23, 2014, at 3:45 AM, Vladimir Makarov wrote: ... > Richard proposed 2-loops solution instead of 3. So I'd definitely prefer his. > > The patch is ok with Richard's 2-loops proposal. Thanks, Maxim. As I wrote > the heuristic is an interesting one. This is the patch I'm going to commi

Re: [Patch, libstdc++/63497] Avoid dereferencing invalid iterator in regex_executor

2014-10-22 Thread Tim Shen
On Wed, Oct 22, 2014 at 4:04 PM, Jonathan Wakely wrote: > OK to commit, thanks! Committed. Thank you too! -- Regards, Tim Shen

Re: [PATCH 3/8] Remove cached_first_cycle_multipass_dfa_lookahead and cached_issue_rate

2014-10-22 Thread Maxim Kuvyrkov
On Oct 22, 2014, at 4:53 AM, Vladimir Makarov wrote: > On 10/20/2014 11:16 PM, Maxim Kuvyrkov wrote: >> Hi, >> >> This patch cleans up (removes) cached_first_cycle_multipass_dfa_lookahead >> and cached_issue_rate. >> >> These seem to be an artifact from the scheduler refactoring 10+ years ago.

Patch committed: Add missing ChangeLog entry

2014-10-22 Thread Ian Taylor
I committed this patch to the top-level ChangeLog to add a missing entry. I forgot to commit the ChangeLog patch with the real change over a year ago, and just came across it. Ian Index: ChangeLog === --- ChangeLog (revision 216522

[PATCH] New debug parameter sched-pressure-factor

2014-10-22 Thread Maxim Kuvyrkov
Hi, For benchmarking and tuning of register-pressure scheduling I've made the following simple patch to adjust effective number of registers that scheduler has at its disposal. Do you think this would be valuable for others to investigate performance problems or tune register-pressure scheduli

Patch RFA: Top-level configure patch: disable go on systems where it doesn't work

2014-10-22 Thread Ian Taylor
This patch to the top level GCC configure script disables the go languages on some systems where it is known to not work. Bootstrapped on x86_64-unknown-gnu-linux. OK for mainline? Ian 2014-10-22 Ian Lance Taylor * configure.ac: Disable the Go frontend on systems where it is known to not wo

avoid alignment of static variables affecting stack's

2014-10-22 Thread Jan Beulich
Function (or more narrow) scope static variables (as well as others not placed on the stack) should also not have any effect on the stack alignment. I noticed the issue first with Linux'es dynamic_pr_debug() construct using an 8-byte aligned sub-file-scope local variable. According to my checking

Re: avoid alignment of static variables affecting stack's

2014-10-22 Thread Jakub Jelinek
On Thu, Oct 23, 2014 at 07:30:27AM +0100, Jan Beulich wrote: > Function (or more narrow) scope static variables (as well as others not > placed on the stack) should also not have any effect on the stack > alignment. I noticed the issue first with Linux'es dynamic_pr_debug() > construct using an 8-b

[PATCH PR63173] [AARCH64, NEON] Improve vld[234](q?)_dup intrinsics

2014-10-22 Thread Yangfei (Felix)
Hi, This patch converts the vld[234](q?)_dup intrinsics to use builtin functions instead of the previous inline assembly syntax. It can fix the performance issue on PR63173. Reg-tested with aarch64-linux-gnu-gcc on qemu. OK for the trunk? Thanks Index: gcc/ChangeLog ===

Fix 63615 - FAIL: gcc.target/i386/addr-sel-1.c

2014-10-22 Thread Alan Modra
PR 63615 was caused by r21642 fixing the accounting of "n_constants" in simplify_plus_minus. Previously, any expression handled by simplify_plus_minus that expanded to more than two elements and contained at least one constant would have resulted in "n_constants" being larger than one, even if it

<    1   2