[arm-embedded] enable multilib for embedded-4_9-branch

2014-05-12 Thread Terry Guo
Hi there, I just committed attached patch to enable build multilib for ARM embedded-4_9-branch. BR, Terry 2014-05-12 Terry Guo * config.gcc (--with-multilib-list): Accept arm embedded cores. * configure.ac (with_multilib_list): Export for being used in arm embedded mu

Re: genattrtab error reporting

2014-05-12 Thread Mike Stump
Ping? On May 7, 2014, at 2:21 PM, Mike Stump wrote: > getattrtab looses track of which file the given rtl came from during error > reporting. A port that uses multiple .md files for the port will tend to > list the last .md file processed instead of the correct md file. We preserve > the fil

RE: [Patch: RL78] Add support for 64-bit doubles

2014-05-12 Thread Kaushik Phatak
Hi DJ, Thanks for your review earlier. >> It looks OK, it's just the timing is bad. Please remind us after GCC is >> back in stage1. I am reposting this patch with GCC in stage 1. >> I would also like to see an explicit initialization for the variable to >> guarantee that the >> defau

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Dimitris Papavasiliou
Ping! On 05/05/2014 10:35 AM, Dimitris Papavasiliou wrote: Ping! On 04/28/2014 01:35 PM, Dimitris Papavasiliou wrote: On 04/25/2014 07:50 PM, Mike Stump wrote: On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou wrote: --Wreturn-type -Wsequence-point -Wshadow @gol +-Wreturn-type -Wsequence-p

Re: [PATCH, libgfortran] Use -std=gnu11

2014-05-12 Thread Tobias Burnus
Janne Blomqvist wrote: > the attached patch switches libgfortran C sources to be compiled in > gnu11 mode instead of gnu99. > Since libgfortran is compiled by the stage 3 compiler, there shouldn't > be any bootstrapping issues wrt. older (stage 1) compilers. > > Ok for trunk? OK. I do not see a r

Re: [PATCH, libgfortran] PR 61035 Stack overflow in GETCWD

2014-05-12 Thread Tobias Burnus
Janne Blomqvist wrote: > the attached patch avoids a stack overflow crash due to not trying to > create a null-terminated duplicate of the argument char array on the > stack. Also, for the common case it avoids an extra allocation and an > extra memcpy. > > Regtested on x86_64-unknown-linux-gnu, Ok

Re: [Patch, Fortran] Reject OpenMP parallelization for DO CONCURRENT

2014-05-12 Thread Jakub Jelinek
On Sun, May 11, 2014 at 08:28:12PM +0200, Tobias Burnus wrote: > While it would be nice to support "!$OMP do" for "do concurrent" > loops, the OpenMP spec does not support it, yet. (Syntactically, it > is a not a that simple feature as do concurrent can optionally have > a MASK=, which has to be ev

Re: [patch, Fortran] Fix PR 60834

2014-05-12 Thread Tobias Burnus
Thomas Koenig wrote: > this contains a straightforward fix for the regression by > not trying to do combine array constructors inside > association lists. > > Regression-tested. OK for all affected open branches? OK. Thanks for the patch. (I think only 4.9 and 4.10 are affected - and not 4.8.) T

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
Hello, I'd still wish to ping for the following set of patches. Those changes does not impact other targets than SH4 but, as suggested by Joern, I have hooked the macros and moved the SH4A specific support to the target parts (so a different target can eventually implement other models than dual m

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers remains the target maintainers. Joern, Kaz ? Many thanks. Christian On 05/12/2014 10:44 AM, Christian Bruel wrote: > Hello, > > I'd still wish to ping for the following set of patches. Those changes > does not impact

Re: [PATCH, Pointer Bounds Checker 1/x] Pointer bounds type and mode

2014-05-12 Thread Ilya Enkovich
2014-05-08 23:28 GMT+04:00 Jeff Law : > On 05/08/14 02:17, Ilya Enkovich wrote: >>> >>> >>> Right. Richi explicitly wanted the entire set approved before staging in >>> any of the bits. >> >> >> I thought it would be useful to have approved codes in the trunk to >> reveal some possible problems on

Re: [PATCH, Pointer Bounds Checker 1/x] Pointer bounds type and mode

2014-05-12 Thread Ilya Enkovich
2014-05-09 17:42 GMT+04:00 Jeff Law : > On 05/09/14 04:36, Richard Biener wrote: >> >> On Thu, May 8, 2014 at 9:45 PM, H.J. Lu wrote: >>> >>> On Thu, May 8, 2014 at 12:28 PM, Jeff Law wrote: On 05/08/14 02:17, Ilya Enkovich wrote: >> >> >> >> Right. Richi explicitly wan

[PING] [PATCH, ARM] Enable shrink-wrap for apcs frame

2014-05-12 Thread Zhenqiang Chen
Ping? OK for trunk? Thanks! -Zhenqiang On 25 March 2014 16:13, Zhenqiang Chen wrote: > Hi > > The patch enables shrink-wrap for apcs frame. > > Bootstrap and no make check regression in ARM, THUMB1 and THUMB2 modes. > No make check regression with "-g/-mapcs/-marm". > Build linux-3.14-rc7 withou

Ping3: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-12 Thread Mark Wielaard
On Mon, 2014-04-28 at 13:17 +0200, Mark Wielaard wrote: > On Tue, 2014-04-22 at 12:31 +0200, Mark Wielaard wrote: > > On Mon, 2014-04-14 at 23:19 +0200, Mark Wielaard wrote: > > > On Fri, 2014-04-11 at 11:03 -0700, Cary Coutant wrote: > > > > >> The DWARF bits are fine with me. > > > > > > > > > >

[Patch, avr] Fix PR60991

2014-05-12 Thread Senthil Kumar Selvaraj
This trivial patch fixes PR60991 by correcting the constant used to restore Y in one of the assembler template variants used in avr_out_store_psi. I've also added a testcase (modified from the original poster's code). If ok, could someone commit please? I don't have commit access. It would be grea

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Michael Matz
Hi, On Sat, 10 May 2014, Mike Stump wrote: > > The rtx u2 field currently uses a desc/tag pair for GTY. This seems > > unnecessary though, > > > OK to install? > > Ick. I don’t favor skip. The change feels like a premature > optimization that doesn’t net any code gen benefit. I’ll defer to

Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler

2014-05-12 Thread Senthil Kumar Selvaraj
Ping! Regards Senthil On Fri, Apr 18, 2014 at 03:22:46PM +0530, Senthil Kumar Selvaraj wrote: > > On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote: > > Senthil Kumar Selvaraj schrieb: > > >This patch modifies AVR target's ASM spec to pass -mlink-relax to the > > >assembler if -mr

Re: [patch,arm] Add GCC runtime library exceptions to files that go into libgcc

2014-05-12 Thread Georg-Johann Lay
Am 05/10/2014 02:51 AM, schrieb Ian Lance Taylor: Georg-Johann Lay writes: This patch adds GCC Runtime Library Exception to files that go into libgcc because libgcc2.c includes tm.h and libgcc_tm.h. Most of these files contain much code, some used by libgcc, some not. Some potential users of

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Michael Matz
Hi, On Sat, 10 May 2014, Richard Sandiford wrote: > @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" > /* The INSN_UID of an RTX_INSN-class code. */ > int insn_uid; > > +/* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */ > +unsigned int symbol_ref_flags; > + In [3/7] y

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Kaz Kojima
[I'd like to add Oleg to CC list.] Christian Bruel wrote: > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > remains the target maintainers. Joern, Kaz ? SH specific part looks OK to me. Oleg, could you comment on the patch? Regards, kaz

[C++ Patch] Couple of minor fixes

2014-05-12 Thread Paolo Carlini
Hi, almost obvious, I would say. Tested x86_64-linux. Thanks, Paolo. 2014-05-12 Paolo Carlini * cvt.c (cp_convert_to_pointer): Don't call error_at if complain & tf_error is false. * decl.c (make_unbound_class_template): Prefer inform for "de

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Richard Sandiford
Michael Matz writes: > Hi, > > On Sat, 10 May 2014, Mike Stump wrote: > >> > The rtx u2 field currently uses a desc/tag pair for GTY. This seems >> > unnecessary though, >> >> > OK to install? >> >> Ick. I don’t favor skip. The change feels like a premature >> optimization that doesn’t net a

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Richard Sandiford
Michael Matz writes: > Hi, > > On Sat, 10 May 2014, Richard Sandiford wrote: > >> @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" >> /* The INSN_UID of an RTX_INSN-class code. */ >> int insn_uid; >> >> +/* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */ >> +unsigned int

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Michael Matz
Hi, On Mon, 12 May 2014, Richard Sandiford wrote: > > Also I'm idly wondering if the explicit sizing of > > the fields via a bit-field as originally would be better here or just > > confusing. I guess unsigned and enums are 32bit for all hosts we care > > about, but if we ever have one where

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 10:06, Christian Bruel wrote: > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > remains the target maintainers. Joern, Kaz ? > > Many thanks. > > Christian > > On 05/12/2014 10:44 AM, Christian Bruel wrote: >> Hello, >> >> I'd still wish to ping for

Re: [Patch, avr] Propagate -mrelax gcc driver flag to assembler

2014-05-12 Thread Georg-Johann Lay
Am 04/18/2014 11:52 AM, schrieb Senthil Kumar Selvaraj: On Sat, Apr 12, 2014 at 06:36:01PM +0200, Georg-Johann Lay wrote: Senthil Kumar Selvaraj schrieb: This patch modifies AVR target's ASM spec to pass -mlink-relax to the assembler if -mrelax is passed to the compiler driver. This was alread

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Christian Bruel
On 04/28/2014 10:08 AM, Christian Bruel wrote: Hello, I'd like to ping the following patches [Hookize mode-switching] http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html [Add new hooks to support toggle and SH4A fpchg instruction] http://gcc.gnu.org/

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 13:16, Christian Bruel wrote: > Just for my curiosity, which other targets have multi-way toggling > support ? The epiphany has, sort of: you read a control register, AND and/or OR some mask(s) to the value, and write it back. If we knew the previous mode, we might elide and AND o

Re: [patch] gcc fstack-protector-explicit

2014-05-12 Thread Marcos Díaz
On Wed, Mar 19, 2014 at 11:09 AM, Jeff Law wrote: > On 03/19/14 08:06, Marcos Díaz wrote: >> >> Well, finally I have the assignment, could you please review this patch? > > Thanks. I'll take a look once we open up stage1 development again (should > be soon as 4.9 is getting close to being ready).

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Joern Rennecke
On 12 May 2014 13:51, Joern Rennecke wrote: > On 12 May 2014 13:16, Christian Bruel wrote: > >> Just for my curiosity, which other targets have multi-way toggling >> support ? > > The epiphany has, sort of: you read a control register, AND and/or OR > some mask(s) to the value, > and write it bac

[PATCH][x86] Support clflushopt, xsaves, xsavec.

2014-05-12 Thread Ilya Tocar
Hi, This patch add support for xsavec, xsaves ISA extensions, introduced in [1], and clflushopt introduced in [2]. [1]http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html [2]http://software.intel.com/en-us/file/319433-018pdf Bootstraps, passes make-chec

[PING] -fuse-caller-save - Collect register usage information

2014-05-12 Thread Tom de Vries
On 26-04-14 14:51, Tom de Vries wrote: Eric, Honza, This patch adds analysis in pass_final to track which hard registers are set or clobbered by the function body, and stores that information in a struct cgraph_node, to be used in the fuse-caller-save optmization. This is the updated version of

Re: [PATCH][x86] Support clflushopt, xsaves, xsavec.

2014-05-12 Thread Uros Bizjak
On Mon, May 12, 2014 at 3:25 PM, Ilya Tocar wrote: > This patch add support for xsavec, xsaves ISA extensions, introduced in > [1], and clflushopt introduced in [2]. > > [1]http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html > [2]http://software.intel.c

Re: [C++ Patch] Couple of minor fixes

2014-05-12 Thread Jason Merrill
Yes, those seem obvious. Jason

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Mike Stump
On May 12, 2014, at 3:53 AM, Richard Sandiford wrote: > Yeah, but the reason I'm removing the desc/tag pair isn't so much to get > rid of that (the compiler should do it for us) but because marking it > anything other than "skip" gives the impression that we want to allow > GC pointers in the uni

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-12 Thread Rainer Orth
Marek Polacek writes: > On Sun, May 11, 2014 at 09:18:47PM +0200, Rainer Orth wrote: >> No, that's wrong: avoid hardcoding target lists if at all possible. >> Besides, it's wrong since it doesn't cover the Solaris (and other >> non-gld linker) case. Use the init_priority effective-target keyword

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call

2014-05-12 Thread Rainer Orth
Hi Wei, please teach your mailer not to break/mangle long lines. Thanks. > Here is a patch for the test. It contains two changes: > 1. For emutls, there will be an explicit call generated at expand > pass, and no stack adjustment is needed. So add /* { > dg-require-effective-target tls_native }

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-05-12 Thread Rainer Orth
Evgeny Stupachenko writes: > Patch with fixes attached. > Currently if-structure is as following: > + if (count == 3) > ... > + else > + { > + /* If length is not equal to 3 then only power of 2 is supported. > */ > + gcc_assert (exact_log2 (count) != -1); > > Fo

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Maxim Ostapenko
Hi, I see a couple of errors when building for arm-linux-gnueabi (host is x86_64 Ubuntu 12.04 LTS, host compiler is gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)): 1) In file included from /home/max/workspace/downloads/gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc

Re: [PATCH 1/7] Fix GTY markup of u2

2014-05-12 Thread Jeff Law
On 05/10/14 13:58, Richard Sandiford wrote: The rtx u2 field currently uses a desc/tag pair for GTY. This seems unnecessary though, since the field is specifically supposed to be 32 bits wide on 64-bit hosts and so cannot hold a pointer. Tested on x86_64-linux-gnu. OK to install? Thanks, Rich

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Yury Gribov
On 05/12/2014 03:20 PM, Konstantin Serebryany wrote: This is the first libsanitizer merge in 4.10 Thanks, Kostya. I see that ASAN_DYNAMIC is not fully supported in libsanitizer Makefiles, I'll work on this once your patch goes in. I also have pending patch for asan-instrumentation-with-call-

Re: [PATCH 2/7] Reduce GENERATOR_FILE ifndefs in print-rtl.c

2014-05-12 Thread Jeff Law
On 05/10/14 14:00, Richard Sandiford wrote: The print-rtl.c code for '0' fields has a complicated sequence of ifndef GENERATOR_FILEs. None of the '0' data makes sense for generators though, so it seems simpler to wrap the whole case instead. Tested on x86_64-linux-gnu. OK to install? Thanks,

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-12 Thread Joseph S. Myers
On Sun, 11 May 2014, Marek Polacek wrote: > > FAIL: c-c++-common/pr50459.c -std=gnu++1y (test for excess errors) > > FAIL: c-c++-common/pr50459.c -Wc++-compat (test for excess errors) > > > > The errors are > > > > /opt/gcc/work/gcc/testsuite/c-c++-common/pr50459.c:8:1: error: constructor > >

Re: [PATCH 3/7] Move ORIGINAL_REGNO to rtx header

2014-05-12 Thread Jeff Law
On 05/10/14 14:08, Richard Sandiford wrote: ...and reduce the size of REGs by one field. This is still OK for REG->MEM conversion since MEMs only have 2 fields. In some ways it would have been nicer to move REGNO to the header, since we wouldn't then need to fetch the second word of the rtx whe

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Jeff Law
On 05/12/14 05:00, Richard Sandiford wrote: Michael Matz writes: Hi, On Sat, 10 May 2014, Richard Sandiford wrote: @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)" /* The INSN_UID of an RTX_INSN-class code. */ int insn_uid; +/* The SYMBOL_REF_FLAGS of a SYMBOL_R

Re: [PATCH 4/7] Move INSN_UID to the rtx header

2014-05-12 Thread Jeff Law
On 05/10/14 14:12, Richard Sandiford wrote: This is a bit more complicated than REG because INSN_UID is an "i" field and so is a parameter to the respective gen_rtx_FOOs. However, in all but one case these uids were dummy values; the one exception can simply set the INSN_UID after the call inste

Re: [PATCH 5/7] Shrink SCRATCH

2014-05-12 Thread Jeff Law
On 05/10/14 14:16, Richard Sandiford wrote: SCRATCH has a single "0" field because reload used to turn it directly into a REG. It no longer does (or could do) that since REG has three fields rather than one. This patch therefore updates the comment and removes the field. Tested on x86_64-linux

Re: [PATCH 6/7] Move PAT_VAR_LOCATION_STATUS to rtx header

2014-05-12 Thread Jeff Law
On 05/10/14 14:22, Richard Sandiford wrote: This is the other case (apart from INSN_UID) in which the field being moved is an "i". I kept the gen_rtx_VAR_LOCATION interface the same by writing it in C code. As with INSN_UID, removing an "i" is safe because genrecog and the equality routines don

Re: [PATCH] Enable Java on Cygwin-64

2014-05-12 Thread Kai Tietz
Hi, I have the following comment. boehm-gc/ChangeLog: 2014-05-11 Bernd Edlinger Fix current cygwin-64 build problems. * include/gc_config_macros.h (GC_PTHREADS): Use __CYGWIN__ instead of __CYGWIN32__ here. * win32_threads.c (GC_push_all_stacks): Push all X86_64 registers. (GC_get_thread_sta

Re: [Patch, avr] Fix PR60991

2014-05-12 Thread Denis Chertykov
2014-05-12 14:17 GMT+04:00 Senthil Kumar Selvaraj : > This trivial patch fixes PR60991 by correcting the constant used to > restore Y in one of the assembler template variants used in avr_out_store_psi. > I've also added a testcase (modified from the original poster's code). > > If ok, could someon

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-12 Thread Dominique Dhumieres
Joseph, > I don't think the whole test should be skipped for that issue; I think the > part requiring this feature should be split out into a separate testcase, > so that as much as possible is still tested on Darwin. Is the following patch --- ../_clean/gcc/testsuite/c-c++-common/pr50459.c

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-12 Thread Jeff Law
On 05/12/14 02:02, Zhenqiang Chen wrote: Hi, According to Steven and Jeff's comments, the patch cleans up most shrink-wrapping codes from function.c to new added shrink-wrap.c. Changes include: (1) Move functions requires_stack_frame_p, next_block_for_reg, move_insn_for_shrink_wrap, prepare_shr

Re: [C PATCH] Make attributes accept enum values (PR c/50459)

2014-05-12 Thread Marek Polacek
On Mon, May 12, 2014 at 06:11:16PM +0200, Dominique Dhumieres wrote: > Joseph, > > > I don't think the whole test should be skipped for that issue; I think the > > part requiring this feature should be split out into a separate testcase, > > so that as much as possible is still tested on Darwin. >

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Matthias Klose
Am 08.05.2014 23:36, schrieb Joseph S. Myers: > On Thu, 8 May 2014, Matthias Klose wrote: > >> This fixes a regression introduced with 4.8, where the option ordering >> of -Wextra and -Wunused-parameter emits a warning, which is not emitted >> with 4.7. No regressions with the trunk, the 4.9 and

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Konstantin Serebryany
Thanks! May I ask you to contribute the patch upstream? https://code.google.com/p/address-sanitizer/wiki/HowToContribute On Mon, May 12, 2014 at 7:19 PM, Maxim Ostapenko wrote: > Hi, > > I see a couple of errors when building for arm-linux-gnueabi (host is x86_64 > Ubuntu 12.04 LTS, host compiler

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Konstantin Serebryany
On Mon, May 12, 2014 at 7:36 PM, Yury Gribov wrote: > On 05/12/2014 03:20 PM, Konstantin Serebryany wrote: >> >> This is the first libsanitizer merge in 4.10 > > > Thanks, Kostya. > > I see that ASAN_DYNAMIC is not fully supported in libsanitizer Makefiles, Generally, I prefer to minimize the chan

Re: genattrtab error reporting

2014-05-12 Thread Jeff Law
On 05/12/14 01:15, Mike Stump wrote: 2014-05-07 Mike Stump * genattrtab.c (struct insn_def): Add filename. (convert_set_attr_alternative): Improve error message. (check_defs): Ensure read_md_filename is set appropriately. (gen_insn): Save read_md_filename. OK fo

Re: [DOC Patch] Remove reference to deleted macro

2014-05-12 Thread Jeff Law
On 05/11/14 18:40, David Wohlferd wrote: I don't have permissions to commit this patch, but I do have a release on file with the FSF. Problem description: The existing docs make reference to a macro which "is described below." However, this is the final sentence in the section; there is no "belo

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Mike Stump
On Apr 28, 2014, at 3:35 AM, Dimitris Papavasiliou wrote: >>> + a = private;/* { dg-warning "hides instance variable" "" { xfail >>> *-*-* } } */ >>> + a = protected; /* { dg-warning "hides instance variable" "" { xfail >>> *-*-* } } */ >>> + a = public; /* { dg-warning "hides instan

Re: PR61140: check the phi is unique in value_replacement

2014-05-12 Thread Jeff Law
On 05/11/14 04:03, Marc Glisse wrote: On Sat, 10 May 2014, Andrew Pinski wrote: On Sat, May 10, 2014 at 3:53 PM, Marc Glisse wrote: Hello, in my recent phiopt patch enhancing value_replacement to optimize x!=0?x+y:y, I forgot to check that there is no other PHI (not sure how I managed to mis

Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header

2014-05-12 Thread Jeff Law
On 05/10/14 14:24, Richard Sandiford wrote: Very much like the code to move ORIGINAL_REGNO, but with a few more knock-on changes. I handled the printing by dumping the flags immediately before the SYMBOL_REF_DATA. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * rtl

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Yury Gribov
On 05/12/2014 08:16 PM, Konstantin Serebryany wrote: Thanks! May I ask you to contribute the patch upstream? https://code.google.com/p/address-sanitizer/wiki/HowToContribute Note that we wouldn't be able to repro in upstream because * ARM isn't supported * LLVM won't build with gcc 4.6 anyway

[PATCH, AArch64] Implement HARD_REGNO_CALLER_SAVE_MODE

2014-05-12 Thread Ian Bolton
Currently, on AArch64, when a caller-save register is saved/restored, GCC is accessing the maximum size of the hard register. So an SImode integer (4 bytes) value is being stored as DImode (8 bytes) because the int registers are 8 bytes wide, and an SFmode float (4 bytes) and DFmode double (8 byte

Re: [PATCH 5/7] Shrink SCRATCH

2014-05-12 Thread Richard Sandiford
Jeff Law writes: > On 05/10/14 14:16, Richard Sandiford wrote: >> SCRATCH has a single "0" field because reload used to turn it directly >> into a REG. It no longer does (or could do) that since REG has three >> fields rather than one. This patch therefore updates the comment and >> removes the

Re: [patch] Remove shadow variable

2014-05-12 Thread Thomas Schwinge
Hi! On Fri, 9 May 2014 18:07:52 +0200, Jakub Jelinek wrote: > On Fri, May 09, 2014 at 11:03:35AM -0500, James Norris wrote: > > Removed three occurrences of a shadow variable. > > > > Bootstrapped and tested on x86-64-unknown-linux-gnu. > > > > 2014-05-09 James Norris Jim, note that once yo

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Yury Gribov
* ARM isn't supported I meant ARM-Linux. -Y

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread Yury Gribov
On 05/12/2014 08:18 PM, Konstantin Serebryany wrote: Didn'thttp://llvm.org/viewvc/llvm-project?view=revision&revision=208530 help? Ah true, I missed the fact that you define PIC in libsanitizer/configure. -Y

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-12 Thread Jeff Law
On 05/09/14 01:14, John Marino wrote: On 5/9/2014 07:26, Jeff Law wrote: On 05/03/14 01:11, John Marino wrote: In config.gcc: +no | gnat | single) + # Let these non-posix thread selections fall through if requested Support for "gnat" as a thread model was removed in 2011. So I think

Re: [PATCH 5/7] Shrink SCRATCH

2014-05-12 Thread Jeff Law
On 05/12/14 10:37, Richard Sandiford wrote: The rtl.def SCRATCH entry predates the repository (1991) and I couldn't see anything in the initial versions of reload.c or reload1.c that set the code to a REG. local-alloc.c had: if (qty_scratch_rtx[q]) { if (GET_CODE (qty_scratch_rtx

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-12 Thread John Marino
On 5/12/2014 18:59, Jeff Law wrote: > On 05/09/14 01:14, John Marino wrote: >> >> 1) Patch updated online as requested >> 2) At this exact point in time, we probably can share the files >> 3) I might debate that we should share the files - that would imply >> reviewing the existing counterpart file

Re: [PATCH 33/89] Use more concrete types for various gimple statements

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * cgraphunit.c (thunk_adjust): Strengthen local "stmt" from gimple to gimple_assign. * gimple-ssa-isolate-paths.c (insert_trap_and_remove_trailing_statements): Strengthen local "new_stmt" from gimple to gimple_c

Re: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly

2014-05-12 Thread Jeff Law
On 05/12/14 11:10, John Marino wrote: On 5/12/2014 18:59, Jeff Law wrote: On 05/09/14 01:14, John Marino wrote: 1) Patch updated online as requested 2) At this exact point in time, we probably can share the files 3) I might debate that we should share the files - that would imply reviewing the

Re: [PATCH 35/89] Introduce gimple_omp_atomic_store

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_atomic_store): New typedef. (const_gimple_omp_atomic_store): New typedef. * gimple-pretty-print.c (dump_gimple_omp_atomic_store): Require a gimple_omp_atomic_store rather than a plain gimple.

Re: [PATCH 40/89] tree-cfg.c: Make verify_gimple_call require a gimple_call

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * tree-cfg.c (verify_gimple_call): Require a gimple_call rather than a plain gimple. (verify_gimple_stmt): Add checked cast to gimple_call within GIMPLE_CALL case of switch statement. OK when prerequisites have gone in.

Re: [PATCH 41/89] Introduce gimple_omp_task

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_task): New typedef. (const_gimple_omp_task): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_task): New. (gimple_build_omp_task): Return a gimple_omp_task rather than a

Re: [PATCH 42/89] Introduce gimple_omp_single

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_single): New typedef. (const_gimple_omp_single): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_single): New. (gimple_build_omp_single): Return a gimple_omp_single rather than

Re: [PATCH 44/89] Introduce gimple_omp_teams

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_teams): New typedef. (const_gimple_omp_teams): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_teams): New. (gimple_build_omp_teams): Return a gimple_omp_teams rather than a

Re: [PATCH 37/89] Introduce gimple_omp_critical

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_critical): New typedef. (const_gimple_omp_critical): New typedef. * gimple-pretty-print.c (dump_gimple_omp_critical): Require a gimple_omp_critical rather than a plain gimple. (pp_gimpl

Re: [PATCH 34/89] Introduce gimple_omp_atomic_load

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_atomic_load): New typedef. (const_gimple_omp_atomic_load): New typedef. * gimple-pretty-print.c (dump_gimple_omp_atomic_load): Require a gimple_omp_atomic_load rather than a plain gimple.

Re: [PATCH 50/89] Make gimple_phi_arg_set_location require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_set_location): Require a gimple_phi rather than a plain gimple. OK once prerequisites have gone in. jeff

Re: [PATCH 47/89] omp-low.c: Use more concrete types of gimple statement for various locals

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * omp-low.c (finalize_task_copyfn): Strengthen local "bind" from plain gimple to gimple_bind. (lower_rec_input_clauses): Strengthen local "g" from plain gimple to gimple_assign. (lower_lastprivate_clauses): Likew

Re: [PATCH 53/89] More gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_set_result): Require a gimple_phi rather than a plain gimple. (gimple_phi_set_arg): Likewise. * tree-outof-ssa.c (remove_gimple_phi_args): Likewise; add a checked cast to gimple_phi.

Re: [PATCH 57/89] Concretize parameter to gimple_call_copy_skip_args

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.c (gimple_call_copy_skip_args): Require a gimple_call. * gimple.h (gimple_call_copy_skip_args): Likewise. OK once prerequisites have gone in. Jeff

Re: [PATCH 58/89] Make gimple_label_set_label require a gimple_label

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_label_set_label): Require a gimple_label. OK once prerequisites have gone in. jeff \

Re: [PATCH 60/89] Concretize gimple_catch_types

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_catch_types): Require a const_gimple_catch rather than a const_gimple. --- OK once prerequisites have gone in. jeff

Re: [PATCH 59/89] Make gimple_goto_set_dest require a gimple_goto

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_goto_set_dest): Require a gimple_goto. * tree-cfg.c (factor_computed_gotos): Add checked cast to gimple_goto. (cleanup_dead_labels): Likewise. OK once prerequisites have gone in. jeff

Re: [PATCH 61/89] Concretize gimple_call_use_set and gimple_call_clobber_set

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_use_set): Require a gimple_call. (gimple_call_clobber_set): Likewise. OK once prerequisites have gone in. jeff

Re: [PATCH 64/89] Concretize gimple_try_set_catch_is_cleanup

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_try_set_catch_is_cleanup): Require a gimple_try. * gimplify.c (gimplify_expr): Convert local "try_" from a gimple to a gimple_try. OK after prerequisites have gone in. jeff

Re: [PATCH 46/89] tree-parloops.c: Use gimple_phi in various places

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * tree-parloops.c (reduction_info::keep_res): Strengthen field from plain gimple to gimple_phi. (transform_to_exit_first_loop): Strengthen locals "phi", "nphi" to gimple_phi. Eliminate early decl of gimple_stmt_iterator

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Joseph S. Myers
On Mon, 12 May 2014, Matthias Klose wrote: > I didn't look close enough to the gfortran test results. PR driver/61126 is a > fix for the regression introduced with the fix for the above issue. With this > patch proposed by Manuel, gfortran.dg/wextra_1.f now passes, and no new > regressions seen

Re: [PATCH 45/89] Introduce gimple_omp_sections

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_sections): New typedef. (const_gimple_omp_sections): New typedef. * gimple-pretty-print.c (dump_gimple_omp_sections): Require a gimple_omp_sections rather than a plain gimple. (pp_gimpl

Re: [PATCH 54/89] Make gimple_call_return_slot_opt_p require a gimple_call.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_return_slot_opt_p): Require a gimple_call rather than a plain gimple. * gimple-walk.c (walk_stmt_load_store_addr_ops): Convert usage of is_gimple_call to dyn_cast_gimple_call, introducing a new l

Re: [PATCH 43/89] Introduce gimple_omp_target

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_target): New typedef. (const_gimple_omp_target): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_target): New. (gimple_build_omp_target): Return a gimple_omp_target rath

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call

2014-05-12 Thread Wei Mi
>> Here is a patch for the test. It contains two changes: >> 1. For emutls, there will be an explicit call generated at expand >> pass, and no stack adjustment is needed. So add /* { >> dg-require-effective-target tls_native } */ in the test. >> 2. Replace cfi_def_cfa_offset with insn sequence chec

Re: [PATCH 38/89] Introduce gimple_omp_for

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_for): New. (const_gimple_omp_for): New. * gimple.h (gimple_statement_base::as_a_gimple_omp_for): New. (gimple_statement_base::dyn_cast_gimple_omp_for): New. (gimple_build_omp_for): Retu

Re: [PATCH 36/89] Introduce gimple_omp_continue

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_continue): New typedef. (const_gimple_omp_continue): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_continue): New. (gimple_build_omp_continue): Return a gimple_omp_continue ra

Re: [PATCH 39/89] Introduce gimple_omp_parallel

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_parallel): New typedef. (const_gimple_omp_parallel): New typedef. * cgraphbuild.c (build_cgraph_edges): Convert check of code against GIMPLE_OMP_PARALLEL to a dyn_cast_gimple_omp_parallel and

Re: [PATCH 48/89] Make gimple_phi_arg_def_ptr and gimple_phi_arg_has_location require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_def_ptr): Require a gimple_phi rather than a plain gimple. (gimple_phi_arg_has_location): Likewise. * gimple-streamer-in.c (input_phi): Return a gimple_phi rather than a plain gimple.

Re: [PATCH 54/89] Make gimple_call_return_slot_opt_p require a gimple_call.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_return_slot_opt_p): Require a gimple_call rather than a plain gimple. * gimple-walk.c (walk_stmt_load_store_addr_ops): Convert usage of is_gimple_call to dyn_cast_gimple_call, introducing a new l

Re: [PATCH 63/89] Concretize gimple_eh_filter_set_types and gimple_eh_filter_set_failure

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_eh_filter_set_types): Require a gimple_eh_filter. (gimple_eh_filter_set_failure): Likewise. * gimple.c (gimple_copy): Add checked casts to gimple_eh_filter within GIMPLE_EH_FILTER case. --- OK once pr

  1   2   >