Hi,

On Sat, 10 May 2014, Mike Stump wrote:

> > The rtx u2 field currently uses a desc/tag pair for GTY.  This seems
> > unnecessary though,
> 
> > OK to install?
> 
> Ick.  I don’t favor skip.  The change feels like a premature 
> optimization that doesn’t net any code gen benefit.  I’ll defer to a gty 
> person if they prefer skip.

The skip is necessary, otherwise union members of GTY structs are required 
to have a 'desc' (and their members in turn are required to have a 'tag').  
So it's either the skip or the desc/tag pair.  The code-gen difference is 
one empty (but two-cased) switch statement less.


Ciao,
Michael.

Reply via email to