Hi,
Regtested on x86_64-unknown-linux-gnu. Ok for trunk?
>>> This looks good to me
>>> but I let Tobias have the final word as he
>>> expressed some concerns in the PR audit trail.
>
> Sorry for the very belated replay. I played with the patch and it looks
> okay.
thanks. Committed as r
On Thu, Sep 19, 2013 at 2:48 PM, Jeff Law wrote:
>
> I find it amazing to look at code I wrote in the past, the occasional WTF
> always makes it worth it.
>
> The code to manage the temporary expression & const/copies tables in
> tree-ssa-dom.c around jump threading looks overly convoluted. In pa
On Thu, Sep 19, 2013 at 3:20 PM, Andrew MacLeod wrote:
> I'm looking at pulling ssa specific bits out of gimple.c so that it doesn't
> require the ssa headers, and can concentrate on basic gimple support. I
> stumbled across the "new" build interface in gimple.c consisting of these
> routines:
>
On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod wrote:
> On 09/19/2013 09:24 AM, Andrew MacLeod wrote:
>>
>>
>> I think this is of most use to ssa passes that need to construct code
>> snippets, so I propose we make this ssa specific and put it in tree-ssa.c
>> (renaming it ssa_build_assign), *OR
On Thu, Sep 19, 2013 at 7:24 PM, Trevor Saunders wrote:
> On Thu, Sep 19, 2013 at 03:23:21PM +0200, Michael Matz wrote:
>> > I don't see anything in Trevor's work that requires jumping through
>> > hoops.
>>
>> Me neither, from that perspective it's okay. It's merely that I doubt the
>> value of
On Fri, Sep 20, 2013 at 10:08:20AM +0200, Richard Biener wrote:
> Can you move the builders to asan.c please? From a quick glance it seems
> to have various issues so it shouldn't be used (I wonder who approved them
> in the end ... maybe it was even me).
Moving them to asan.c looks wrong. If we
On Thu, Sep 19, 2013 at 8:11 PM, Richard Sandiford
wrote:
> Michael Matz writes:
>> What's the benefit of reading and writing such noisy lines? :
>>
>> *out_mode = mode_;
>> mode_ = GET_MODE_WIDER_MODE (mode_);
>> count_++;
>>
>> The uglification merely makes code harder to writ
On Mon, Sep 16, 2013 at 06:18:11PM +0200, Marek Polacek wrote:
> On Mon, Sep 16, 2013 at 06:04:23PM +0200, Jakub Jelinek wrote:
> > On Mon, Sep 16, 2013 at 05:59:28PM +0200, Marek Polacek wrote:
> > > Regtested/ran bootstrap-ubsan on x86_64-linux.
> >
> > That looks wrong. ubsan_type_descriptor s
On Thu, 19 Sep 2013, David Edelsohn wrote:
> This patch has caused 6 new libstdc++ failures on AIX. All look like:
>
> /home/dje/src/src/libstdc++-v3/testsuite/ext/random/normal_mv_distribution/cons/default.cc:49:1:
> internal compiler error: in build_polynomial_chrec, at
> tree-chrec.h:148
> }
On Fri, Sep 20, 2013 at 10:22:43AM +0200, Marek Polacek wrote:
> > --- gcc/ubsan.c.mp 2013-09-16 18:13:01.075903156 +0200
> > +++ gcc/ubsan.c 2013-09-16 18:13:20.514974154 +0200
> > @@ -233,7 +233,13 @@ ubsan_source_location (location_t loc)
> > static unsigned short
> > get_ubsan_type_info_
Hi,
For now IVOPT constructs scaled address expression in the form of
"scaled*index" and checks whether backend supports it. The problem is the
address expression is invalid on ARM, causing scaled expression disabled in
IVOPT on ARM. This patch fixes the IVOPT part by constructing rtl address
expr
This fixes a fallout of the fix for PR58417 - the assert in
build_polynomial_chrec is too strict and I wonder why we haven't
been running into this before.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.
Richard.
2013-09-20 Richard Biener
PR middle-end/58473
*
Hi!
When testing gcc with GCC_COLORS=' ' in the environment,
gcc/testsuite/lib/*.exp makes sure -fdiagnostics-color=never is added
and thus doesn't confuse the regexps checking for gcc output (which
in dejagnu goes to a pseudo tty and thus can be colorized even with
-fdiagnostics-color=auto), but
The following "fixes" the bogus loop distribution that breaks
434.zeusmp by applying the cost model for -ftree-loop-distribute-patterns
as well (with -O3 -ftree-loop-distribution the bug doesn't reproduce).
This papers over the real issue only but it is part of the real
fix I am developing (a miss
On Fri, Sep 20, 2013 at 10:13:27AM +0200, Richard Biener wrote:
> On Thu, Sep 19, 2013 at 8:11 PM, Richard Sandiford
> wrote:
> > Michael Matz writes:
> >> What's the benefit of reading and writing such noisy lines? :
> >>
> >> *out_mode = mode_;
> >> mode_ = GET_MODE_WIDER_MODE (mode
On 09/20/2013 09:46 AM, Marc Glisse wrote:
Hello,
for basic_string, I tried not to add lies about exceptions, but I didn't
remove existing ones.
Of course we should not have lies, I thought we didn't, besides maybe
special cases having to do with the FULLY_DYNAMIC string thing, really a
C++98
Hi,
On Fri, 20 Sep 2013, Trevor Saunders wrote:
> > > very ugly FWIW. I only added the underscores because that's what
> > > the conventions said.
> > >
> > > But we're never going to get consensus on this kind of thing. E.g.
> > > I know some people really hate the GNU formatting style (alth
On Fri, Sep 20, 2013 at 10:37:57AM +0200, Jakub Jelinek wrote:
> On Fri, Sep 20, 2013 at 10:22:43AM +0200, Marek Polacek wrote:
> > > --- gcc/ubsan.c.mp2013-09-16 18:13:01.075903156 +0200
> > > +++ gcc/ubsan.c 2013-09-16 18:13:20.514974154 +0200
> > > @@ -233,7 +233,13 @@ ubsan_source_loc
On Fri, Sep 20, 2013 at 02:33:25PM +0200, Marek Polacek wrote:
> Agreed. Added that assert in there. How does it look now?
Ok.
> 2013-09-20 Marek Polacek
>
> PR sanitizer/58413
> * ubsan.c (get_ubsan_type_info_for_type): Use TYPE_SIZE instead of
> TYPE_PRECISION. Add asse
.. first blush, I think we have to remove the noexcept from the
non-const forms of begin and end and from clear. Because the string can
be shared...
Thanks,
Paolo.
Great indeed!
More comments later. First nit: please review the various regex_replace
overloads vs inline: if I'm not misreading the diff I see large ones
inline and small ones out of line!?! Should we have a regex.tcc?
Also, old story about ChangeLogs ;) This is not ok:
* include/bi
On Thu, Sep 19, 2013 at 9:20 AM, Andrew MacLeod wrote:
> I see the benefit in the streamlined asan.c code, but I detest that
> ssa_mode flag. And as long as it supports SSA, I don't think it should be
> in gimple.c.
Yeah, at the time that I introduced it, I had a hard time with the
normal/ssa
On Fri, Sep 20, 2013 at 4:08 AM, Richard Biener
wrote:
> On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod wrote:
>> On 09/19/2013 09:24 AM, Andrew MacLeod wrote:
>>>
>>>
>>> I think this is of most use to ssa passes that need to construct code
>>> snippets, so I propose we make this ssa specific a
I am testing the following patch which fixes PR58484, the ICE
compiling 416.gamess after my PR58417 fix.
The issue is that now the chrec cache during instantiation is
again dependent on the block we instantiate below due to the
possible recursion through analyze_scalar_evolution. Thus the
patch
On Fri, Sep 20, 2013 at 3:07 PM, Diego Novillo wrote:
> On Fri, Sep 20, 2013 at 4:08 AM, Richard Biener
> wrote:
>> On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod wrote:
>>> On 09/19/2013 09:24 AM, Andrew MacLeod wrote:
I think this is of most use to ssa passes that need to const
On Mon, Sep 16, 2013 at 4:23 AM, Basile Starynkevitch
wrote:
> Hello All,
>
> I'm pinging again my small patch to accept = inside plugin arguments
> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00382.html
OK.
Diego.
On 2013-09-16 04:19 , Basile Starynkevitch wrote:
Hello all,
I'm pinging the patch (of september 2nd) on
http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00036.html
gcc/ChangeLog entry
2013-09-16 Basile Starynkevitch
* gengtype.c (file_rules): Added rule for *.cc files.
(
On Fri, Sep 20, 2013 at 6:00 AM, Zamyatin, Igor wrote:
>
> For x86 32-bit is still important due to mobile market so we would like to
> make some measurements first to see how this new generic model works on 32
> bits
I would expect people compiling code for the mobile market to use an
appropri
Treat GTY structs that have a "desc" as being the root of an inheritance
hierarchy. Generate a switch on desc within the marking function with
cases for each subclass, visiting all fields of the type (including
inherited ones).
Don't create marking functions for subclasses, instead using the base
This patch is the handwritten part of the conversion of these types
to C++; it requires the followup patch, which is autogenerated.
It converts:
struct symtab_node_base
to:
class symtab_node_base
and converts:
struct cgraph_node
to:
struct cgraph_node : public symtab_node_base
and:
stru
Extend gengtype (and gtype.state reading/writing) so that it is able to
parse base classes in simple cases, and only attempt to do it for
GTY-marked types.
* gengtype-parse.c (require_without_advance): New.
(type): For GTY-marked types, parse any base classes, requiring
the
There have been various discussions about how to handle inheritance
within ggc and PCH: whether to extend gengtype to support C++ syntax
such as templates, or to require people to use GTY((user)) and manually
write field-traversal.
I've attempted to introduce class hierarchies in a few places rece
On Fri, 20 Sep 2013, Paolo Carlini wrote:
On 09/20/2013 09:46 AM, Marc Glisse wrote:
Hello,
for basic_string, I tried not to add lies about exceptions, but I didn't
remove existing ones.
Of course we should not have lies, I thought we didn't, besides maybe special
cases having to do with the
On 09/20/2013 04:09 PM, Marc Glisse wrote:
On Fri, 20 Sep 2013, Paolo Carlini wrote:
On 09/20/2013 09:46 AM, Marc Glisse wrote:
Hello,
for basic_string, I tried not to add lies about exceptions, but I
didn't
remove existing ones.
Of course we should not have lies, I thought we didn't, besid
Hello all,
This patch will replace all explicit calls to gen_rtx_PLUS and GEN_INT
with plus_constant.
This has been tested for aarch64-none-elf on the model.
OK for trunk?
Kind regards,
Renlin Li
gcc/ChangeLog:
2013-09-20 Renlin Li
* config/aarch64/aarch64.c (aarch64_expand_prologue
Hello all,
This patch will replace all explicit calls to gen_rtx_PLUS and GEN_INT
with plus_constant.
This has been tested for arm-none-linux-gnueabi on the model.
OK for trunk?
Kind regards,
Renlin Li
gcc/ChangeLog:
2013-09-20 Renlin Li
* config/arm/arm.c (arm_legitimize_reload_add
On Fri, 20 Sep 2013, Paolo Carlini wrote:
By the way, I would be curious at some point to actually see with my eyes the
effect of those optimizations in the assembly: is it easy to produce
examples? Even at say -O2?
If you use "if(noexcept(container.shrink_to_fit()))", you can easily cause
d
Thank you, can you please commit it for me?
Kind regards,
Renlin Li
On 09/20/13 15:26, Marcus Shawcroft wrote:
On 20 September 2013 15:18, Renlin Li wrote:
2013-09-20 Renlin Li
* config/aarch64/aarch64.c (aarch64_expand_prologue): Use plus_constant.
(aarch64_expand_epilogue): L
On 20 September 2013 15:18, Renlin Li wrote:
> 2013-09-20 Renlin Li
>
> * config/aarch64/aarch64.c (aarch64_expand_prologue): Use plus_constant.
> (aarch64_expand_epilogue): Likewise.
> (aarch64_legitimize_reload_address): Likewise.
OK
/Marcus
Hi,
On Fri, 20 Sep 2013, David Malcolm wrote:
> Treat GTY structs that have a "desc" as being the root of an inheritance
> hierarchy. Generate a switch on desc within the marking function with
> cases for each subclass, visiting all fields of the type (including
> inherited ones).
Yay! Thanks
Can we please backport this to 4.8 (it will fix PR58463)?
I attach Richard's patch to master, let me know if instead I should create one
specific for 4.8.1. I tested this against 4.8 branch and everything looks fine.
2013-03-27 Richard Biener
PR tree-optimization/56716
* tre
> This patch is the handwritten part of the conversion of these types
> to C++; it requires the followup patch, which is autogenerated.
>
> It converts:
> struct symtab_node_base
> to:
> class symtab_node_base
>
> and converts:
> struct cgraph_node
> to:
> struct cgraph_node : public symt
Please find the patch attached.
I have added the test to gcc.c-torture, please let me know if this is not the
right place.
2013-09-20 Paulo Matos
* gcc.c-torture/pr58463.c: New testcase.
Paulo Matos
pr58463-testcase.patch
Description: pr58463-test
On 10 September 2013 18:12, Yufeng Zhang wrote:
> gcc/
>
> * config/aarch64/aarch64-builtins.c (aarch64_simd_expand_args):
> Call aarch64_simd_expand_args to update op[argc].
OK
/Marcus
> On Fri, Sep 20, 2013 at 6:00 AM, Zamyatin, Igor
> wrote:
> >
> > For x86 32-bit is still important due to mobile market so we would like to
> > make some measurements first to see how this new generic model works on 32
> > bits
I assume by mobile market you mean atom CPU these days (not Pent
On Fri, Sep 20, 2013 at 09:53:10AM -0400, Diego Novillo wrote:
> On 2013-09-16 04:19 , Basile Starynkevitch wrote:
> >Hello all,
> >
> >I'm pinging the patch (of september 2nd) on
> >http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00036.html
> >
> >
> > gcc/ChangeLog entry
> >
> >2013-09-16 Basil
On Fri, Sep 20, 2013 at 09:49:34AM -0400, Diego Novillo wrote:
> On Mon, Sep 16, 2013 at 4:23 AM, Basile Starynkevitch
> wrote:
> > Hello All,
> >
> > I'm pinging again my small patch to accept = inside plugin arguments
> > http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00382.html
>
> OK.
Thanks f
On Fri, Sep 20, 2013 at 05:52:38PM +0200, Basile Starynkevitch wrote:
> On Fri, Sep 20, 2013 at 09:53:10AM -0400, Diego Novillo wrote:
> > On 2013-09-16 04:19 , Basile Starynkevitch wrote:
> > >Hello all,
> > >
> > >I'm pinging the patch (of september 2nd) on
> > >http://gcc.gnu.org/ml/gcc-patches/
On 09/12/2013 04:55 AM, Jakub Jelinek wrote:
- if (t1 != t2)
+ if (t1 != t2 && !DECL_OMP_DECLARE_REDUCTION_P (newdecl))
return 0;
What's the theory here? Why should decls_match return true for
reductions with mismatching templates?
+ && ! (DECL_OMP_DECLARE_REDUCTI
On Fri, Sep 20, 2013 at 03:45:17PM +, Paulo Matos wrote:
> Please find the patch attached.
>
> I have added the test to gcc.c-torture, please let me know if this is not the
> right place.
>
> 2013-09-20 Paulo Matos
>
> * gcc.c-torture/pr58463.c: New testc
Any comment or more suggestions on this patch?
thanks,
Cong
On Mon, Sep 9, 2013 at 7:28 PM, Cong Hou wrote:
> On Mon, Sep 9, 2013 at 6:26 PM, Xinliang David Li wrote:
>> On Fri, Sep 6, 2013 at 3:24 PM, Cong Hou wrote:
>>> First, thank you for your detailed comments again! Then I deeply
>>> ap
Hi!
On Fri, Sep 20, 2013 at 12:00:41PM -0400, Jason Merrill wrote:
Thanks for the review, I'll try to get to most of that next week.
> On 09/12/2013 04:55 AM, Jakub Jelinek wrote:
> >- if (t1 != t2)
> >+ if (t1 != t2 && !DECL_OMP_DECLARE_REDUCTION_P (newdecl))
> > return 0;
>
> Wh
ssa-dom-thread-3.c was missing its dg-final clause to clean up the log
files. Installed onto the trunk.
Jeff
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 0d6438b..a9a1513 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2013-09-17 J
On 09/20/2013 02:13 AM, Richard Biener wrote:
On Thu, Sep 19, 2013 at 8:11 PM, Richard Sandiford
wrote:
Michael Matz writes:
What's the benefit of reading and writing such noisy lines? :
*out_mode = mode_;
mode_ = GET_MODE_WIDER_MODE (mode_);
count_++;
The uglification
On 09/20/2013 02:00 AM, Richard Biener wrote:
diff --git a/gcc/tree-ssa-dom.c b/gcc/tree-ssa-dom.c
index aac7aa4..f561386 100644
--- a/gcc/tree-ssa-dom.c
+++ b/gcc/tree-ssa-dom.c
@@ -1070,6 +1070,31 @@ simplify_stmt_for_jump_threading (gimple stmt,
return lookup_avail_expr (stmt, false);
}
Richi noticed I'd added a function without a block comment. This patch
fixes that oversight.
Installed onto the trunk after a stage1 build to ensure I didn't do
something stupid like forget to close a comment :-)
Jeff
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 6d93bab..e2fff6c 100644
On 09/19/2013 02:37 PM, Adam Butcher wrote:
+ static int i = 0;
I think this needs to be global and GTY so that it works properly with PCH.
Jason
Why is canonical_type_parameter not doing the right thing here? I don't
see a reason we should need to treat these differently from normal
template parms.
Jason
On Sep 20, 2013, at 9:58 AM, Jan-Benedict Glaw wrote:
> Hi!
>
> VAX GAS has a glitch when generating a 64bit value from a small
> negative integer, which isn't properly sign-extended. (I'll see if
> this can be fixed without breaking other cases.)
>
> However, GCC should work around this by si
OK.
Jason
On Sep 20, 2013, at 7:05 AM, David Malcolm wrote:
> Extend gengtype (and gtype.state reading/writing) so that it is able to
> parse base classes in simple cases, and only attempt to do it for
> GTY-marked types.
I endorse this, and look forward to using it in the wide-int branch. I expect
it sh
Hi!
VAX GAS has a glitch when generating a 64bit value from a small
negative integer, which isn't properly sign-extended. (I'll see if
this can be fixed without breaking other cases.)
However, GCC should work around this by simply using the already
prepared formatting operand code 'D'. The patch
On Fri, 2013-09-20 18:58:23 +0200, Jan-Benedict Glaw wrote:
> VAX GAS has a glitch when generating a 64bit value from a small
> negative integer, which isn't properly sign-extended. (I'll see if
> this can be fixed without breaking other cases.)
>
> However, GCC should work around this by simply
OK.
Jason
Hi!
With the VAX target, I see this warning:
g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength
On Sep 20, 2013, at 3:28 AM, Jakub Jelinek wrote:
> When testing gcc with GCC_COLORS=' ' in the environment,
> gcc/testsuite/lib/*.exp makes sure -fdiagnostics-color=never is added
> and thus doesn't confuse the regexps checking for gcc output (which
> in dejagnu goes to a pseudo tty and thus can
OK.
Jason
Diego -
In http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00174.html I proposed
a patch to fix PR58312, which is that libssp when cross-compiled
assumes that vnsprintf is broken [1]. This is causing our libssp.so
to be missing some symbols that are referenced by some pre-existing
binaries.
The pro
Hi,
this bug looks superficially similar to the already fixed c++/50089: an
ICE on valid in build_base_path for a qualified-id call in a lambda,
which can be worked around by qualifying with this->. It seems to me
that in this case too a fix may boil down to simply using
current_nonlambda_cla
Ping.
> -Original Message-
> From: Wei Mi [mailto:w...@google.com]
> Sent: Thursday, September 12, 2013 2:51 AM
> To: GCC Patches
> Cc: David Li; Zamyatin, Igor
> Subject: [PATCH] disable use_vector_fp_converts for m_CORE_ALL
>
> For the following testcase 1.c, on westmere and sandybridge,
Now that both statement fixup and cfg cleanup are moved after
annotation. So setting of cgraph node's count is still needed, right?
Thanks,
Dehao
On Thu, Sep 19, 2013 at 9:28 PM, Xinliang David Li wrote:
> I did not catch this in the last review. The cleanup CFG should be
> done before afdo_anno
The attached change fixes a regression in my last change. Detected on
4.8 branch. Tested on
hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
Dave
--
John David Anglin dave.ang...@bell.net
2013-09-20 John David Anglin
* config/pa/pa.md: In "scc" insn patterns, change output t
Yes -- in current form, it is still needed. As you explained, the
linking & stmt fixup will need to be done after profile annotation as
autofdo uses assembler name for icall target matching.
David
On Fri, Sep 20, 2013 at 3:29 PM, Dehao Chen wrote:
> Now that both statement fixup and cfg cleanup
Mostly whitespace and comment tweaks, with a few random bug fixes.
Committed.
Note: the net result of our recent batch of patches is an
approximately 50% speed improvement :-)
* config/rl78/rl78.c: Various whitespace and comment tweaks.
(need_to_save): Save bank 0 on interrupts.
I am now breaking the patches down to be more bite size. Ultimately, I hope
these patches will provide support to allow scalar floating point to occupy the
Altivec (upper) registers if the ISA allows it (ISA 2.06 for DFmode, ISA 2.07
for SFmode). One effect of later patches will be to go back to
I noticed recently in looking at the configure output of glib2.0 that
the __GCC_HAVE_SYNC_COMPARE_AND_SWAP_[1,2,4]
defines are not defined on hppa-linux because the corresponding
builtins are implemented as library functions.
Tested on hppa-linux. Committed to trunk.
Dave
--
John David Angl
The attached change works around a problem that results in wrong code
on hppa1.1-*-hpux*. The wrong
code causes a bootstrap error. The problem does not occur when
generating PA2.0 code, or on linux because
the generation of auto increment/decrement instructions is disabled.
The comment in
77 matches
Mail list logo
