Re: C++ PATCH for c++/53650 (memory-hog with large array)

2013-01-23 Thread Eric Botcazou
> Tested x86_64-pc-linux-gnu, applying to trunk for now. This was put yesterday on the 4.7 branch and broke the build: ../../src/gcc/cp/call.c: In function 'type_has_extended_temps': ../../src/gcc/cp/call.c:8866: error: 'for' loop initial declaration used outside C99 mode make[3]: *** [cp/call.o

Re: [PATCH] Fix up one OpenMP Fortran OOP ICE (PR fortran/56052)

2013-01-23 Thread Janus Weil
Hi Jakub, > Fortran OOP is still to be considered completely unsupported in OpenMP, > but this patch just attempts to fix this because it was easy to do so. > The select_type_temporary vars are artificial (created by the compiler, > not user vars), we shouldn't emit them into debug info, nor they

Re: [PATCH] Fix up ARM ICE (PR target/49069)

2013-01-23 Thread Jakub Jelinek
On Tue, Jan 22, 2013 at 10:38:24AM +, Ramana Radhakrishnan wrote: > Instead I'd just use s_register_operand for operand1 and continue to > use cmpdi_operand for operand2 and fix it so. > > And likewise . > > Ok with those changes and if no regressions. Managed to bootstrap/regtest this (via

Re: RFA - Remove GC zone allocator

2013-01-23 Thread Richard Earnshaw
On 22/01/13 14:33, Diego Novillo wrote: This patch removes the GC zone allocator. It is not used and it produces several regressions in the testsuite. Furthermore, it complicates things for the plan to implement manual GC markers (http://gcc.gnu.org/wiki/cxx-conversion/gc-alternatives#Do_GC_mar

Re: C++ PATCH for c++/53650 (memory-hog with large array)

2013-01-23 Thread Eric Botcazou
> Tested x86_64-pc-linux-gnu, applying to trunk for now. This was put yesterday on the 4.7 branch and broke the build: ../../src/gcc/cp/call.c: In function 'type_has_extended_temps': ../../src/gcc/cp/call.c:8866: error: 'for' loop initial declaration used outside C99 mode make[3]: *** [cp/call.o

Re: [Patch, AARCH64] Remove REGISTER_PREFIX

2013-01-23 Thread Marcus Shawcroft
On 08/01/13 08:21, Hurugalawadi, Naveen wrote: Hi, AARCH64 back-end defines REGISTER_PREFIX to empty string. Hence, it can be removed as the default value of REGISTER_PREFIX is "". Please find attached the patch that removes REGISTER_PREFIX and all its occurrence in aarch64 back-end. Please rev

Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components

2013-01-23 Thread Tobias Burnus
Paul Richard Thomas wrote: *** gfc_alloc_allocatable_for_assignment (gf *** 8224,8229 --- 8250,8262 desc, tmp); tmp = gfc_conv_descriptor_dtype (desc); gfc_add_modify (&alloc_block, tmp, gfc_get_dtype (TREE_TYPE (desc))); + if ((ex

Disable iteration in early inliner

2013-01-23 Thread Jan Hubicka
Hi, this patch disables iteration of early inliner. I added the code in early days of indirect inlining mostly to catch things that are not well handled by IPA inliner. We got better on devirtualization and indirect inlining and I think we now handle pretty much all interesting cases there. Disab

Re: Disable iteration in early inliner

2013-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2013 at 11:18:31AM +0100, Jan Hubicka wrote: > Bootstrapped/regtested x86_64-linux, compensated the 3 testcases in tesuite > testing > the feature to both test the feature with parameter increased and thest that > the > optimization happens anyway at IPA level by default. Not obj

Re: PR libgomp/56073: benchmark regression due to PR libgomp/51376 fix

2013-01-23 Thread Torvald Riegel
On Wed, 2013-01-23 at 11:41 +1030, Alan Modra wrote: > On Tue, Jan 22, 2013 at 02:20:23PM +0100, Torvald Riegel wrote: > > > @@ -116,11 +116,10 @@ GOMP_task (void (*fn) (void *), void *data, void ( > > > } > > >else > > > fn (data); > > > - if (team != NULL) > > > + if (task.c

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Dmitry Vyukov
Rubber stamp LGTM On Wed, Jan 23, 2013 at 2:31 PM, Konstantin Serebryany wrote: > Hi, > > The attached patch is the libsanitizer merge from upstream r173241. > > Lots of changes. Among other things: > - slow CFI-based unwinder is on by default for fatal errors > (fast_unwind_on_fatal=0, Linux-o

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote: > The attached patch is the libsanitizer merge from upstream r173241. > > Lots of changes. Among other things: > - slow CFI-based unwinder is on by default for fatal errors > (fast_unwind_on_fatal=0, Linux-only) > - more in

[PATCH, regression?] Support --static-libstdc++ with native AIX ld

2013-01-23 Thread Michael Haubenwallner
Hi, attached patch actually makes gcc-4.8 useable after removing builddir when using native AIX ld, as libstdc++ now really is statically linked into xgcc/xg++, like with other platforms or with GNU binutils on AIX. This also renders those tries/patches needless that drop the RPATH_ENVVAR=LD_L

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Konstantin Serebryany
On Wed, Jan 23, 2013 at 3:13 PM, Jakub Jelinek wrote: > On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote: >> The attached patch is the libsanitizer merge from upstream r173241. >> >> Lots of changes. Among other things: >> - slow CFI-based unwinder is on by default for fatal

Re: RFA - Remove GC zone allocator

2013-01-23 Thread Laurynas Biveinis
Diego - > I will need a global reviewer to approve the patch. Laurynas, > could you take a look to make sure I'm not forgetting to remove > anything? Cannot find anything. > * gengtype.c (write_enum_defn): Remove. Update all users. > (write_Types_process_field): Remove generati

Re: RFA - Remove GC zone allocator

2013-01-23 Thread Diego Novillo
On Wed, Jan 23, 2013 at 4:19 AM, Richard Earnshaw wrote: > Won't this mean that use of the configure option is now silently ignored, > rather than generating an error? Existing users of the option might be > slightly confused by that. That's true. Perhaps a warning message stating that --with-

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Evgeniy Stepanov
On Wed, Jan 23, 2013 at 3:28 PM, Konstantin Serebryany wrote: > > On Wed, Jan 23, 2013 at 3:13 PM, Jakub Jelinek wrote: > > On Wed, Jan 23, 2013 at 02:31:57PM +0400, Konstantin Serebryany wrote: > >> The attached patch is the libsanitizer merge from upstream r173241. > >> > >> Lots of changes. Am

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote: > > So, e.g. whenever match_spec > > > returns 0, it should break out of the loop, rather than continue. > > > And for %hh it doesn't check following letters, no match_spec at all. > > That's cause they don't change the write size.

Re: [PATCH] configure: don't echo $CFLAGS (issue 7103062)

2013-01-23 Thread Richard Biener
On Sun, Jan 20, 2013 at 12:02 PM, wrote: > Reviewers: bonzini_gnu.org, dj_redhat.com, neroden_gcc.gnu.org, > aoliva_redhat.com, ralf.wildenhues_gmx.de, jakub_redhat.com, > mikestump_comcast.net, Ok. Thanks Richard. > Description: > 2013-01-20 Shenghou Ma > > * config/isl.m4: don't e

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Evgeniy Stepanov
On Wed, Jan 23, 2013 at 4:39 PM, Jakub Jelinek wrote: > On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote: >> > So, e.g. whenever match_spec >> > > returns 0, it should break out of the loop, rather than continue. >> > > And for %hh it doesn't check following letters, no match_spec

Re: Disable iteration in early inliner

2013-01-23 Thread Jan Hubicka
> On Wed, Jan 23, 2013 at 11:18:31AM +0100, Jan Hubicka wrote: > > Bootstrapped/regtested x86_64-linux, compensated the 3 testcases in tesuite > > testing > > the feature to both test the feature with parameter increased and thest > > that the > > optimization happens anyway at IPA level by defau

Re: libsanitizer merge from upstream r173241

2013-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2013 at 04:49:04PM +0400, Evgeniy Stepanov wrote: > On Wed, Jan 23, 2013 at 4:39 PM, Jakub Jelinek wrote: > > On Wed, Jan 23, 2013 at 04:24:01PM +0400, Evgeniy Stepanov wrote: > >> > So, e.g. whenever match_spec > >> > > returns 0, it should break out of the loop, rather than cont

Re: [Patch] Ignore Invalid Memory operands in constraint 'X'

2013-01-23 Thread Ulrich Weigand
Naveen Hurugalawadi wrote: > The definition of constraint 'X' allows all operands. > `X' - Any operand whatsoever is allowed. > However, invalid memory operands should not be valid input for 'X'. > > Please find attached the patch "X_constraint.patch" which ignores=20 > invalid memory operands in

Re: C++ PATCH for c++/53650 (memory-hog with large array)

2013-01-23 Thread Jason Merrill
Thanks; I've already fixed it. Jason

Re: RFA - Remove GC zone allocator

2013-01-23 Thread Richard Biener
Diego Novillo wrote: >On Wed, Jan 23, 2013 at 4:19 AM, Richard Earnshaw >wrote: > >> Won't this mean that use of the configure option is now silently >ignored, >> rather than generating an error? Existing users of the option might >be >> slightly confused by that. > >That's true. Perhaps a war

Re: RFA - Remove GC zone allocator

2013-01-23 Thread Jakub Jelinek
On Wed, Jan 23, 2013 at 03:31:16PM +0100, Richard Biener wrote: > >That's true. Perhaps a warning message stating that --with-gc is now > >ignored? Or would you prefer a straight out error? > > I don't think we ever cared for this. > > Thus, the patch is ok if no other rm objects within a day.

Re: [Patch, microblaze]: Add microblaze*-*-elf target

2013-01-23 Thread Michael Eager
On 01/20/2013 09:42 PM, David Holsgrove wrote: gcc/Changelog 2013-01-21 Edgar E. Iglesias * config.gcc (microblaze*-*-elf): Add new target libgcc/Changelog 2013-01-21 Edgar E. Iglesias * config.host (microblaze*-*-elf): Add new target Hi David -- This appears to be

Re: [Patch, microblaze]: PR54662 - microblaze-linux target makefile

2013-01-23 Thread Michael Eager
On 01/20/2013 09:46 PM, David Holsgrove wrote: gcc/Changelog 2013-01-21 David Holsgrove * config.gcc (microblaze*-linux*): Add tmake_file to allow building of microblaze-c.o libgcc/Changelog 2013-01-21 David Holsgrove * libgcc/config/microblaze/t-microblaze:

Re: [Patch, microblaze, testsuite] Remove check for target_config_cflags

2013-01-23 Thread Michael Eager
On 01/20/2013 09:46 PM, David Holsgrove wrote: Remove test for target_config_cflags for microblaze - not set anywhere, and causes error while running testsuite; ERROR: tcl error sourcing [SNIP]/gcc/gcc/testsuite/gcc.target/microblaze/microblaze.exp. ERROR: can't read "target_config_cflags": no s

Re: [patch,avr] Ad PR54222: Add bitsfx and fxbits to stdint.h

2013-01-23 Thread Georg-Johann Lay
Denis Chertykov wrote: > 2013/1/21 Georg-Johann Lay: >> This adds the "Embedded C" bitsfx and fxbits functions to stdfix.h. >> >> The original stdfix.h is installed as stdfix-gcc.h and included by the new, >> avr-specific stdfix.h. >> >> The implementation uses __builtin_memcpy to get a no-op imple

Re: [Patch, microblaze]: Add TARGET_OS_CPP_BUILTINS for microblaze*-linux

2013-01-23 Thread Michael Eager
On 01/20/2013 09:46 PM, David Holsgrove wrote: gcc/Changelog 2013-01-21 Edgar E. Iglesias * gcc/config/microblaze/linux.h: Add TARGET_OS_CPP_BUILTINS Committed revision 195408. -- Michael Eagerea...@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077

Re: [RFC] Fix for PR driver/47785

2013-01-23 Thread Richard Biener
On Tue, Jan 22, 2013 at 5:00 PM, Ramana Radhakrishnan wrote: > Hi, > > I ran into PR driver/47785 when doing some testing with an option passed to > the testsuite and I chose to fix this by putting out COLLECT_AS_OPTIONS as > though these are options for the driver by prepending them with a "'-Wa"

Re: [RFC] Fix for PR driver/47785

2013-01-23 Thread Ramana Radhakrishnan
On 01/23/13 15:36, Richard Biener wrote: On Tue, Jan 22, 2013 at 5:00 PM, Ramana Radhakrishnan wrote: Hi, I ran into PR driver/47785 when doing some testing with an option passed to the testsuite and I chose to fix this by putting out COLLECT_AS_OPTIONS as though these are options for the driv

Re: [RFC] Fix for PR driver/47785

2013-01-23 Thread Richard Biener
On Wed, Jan 23, 2013 at 4:50 PM, Ramana Radhakrishnan wrote: > On 01/23/13 15:36, Richard Biener wrote: >> >> On Tue, Jan 22, 2013 at 5:00 PM, Ramana Radhakrishnan >> wrote: >>> >>> Hi, >>> >>> I ran into PR driver/47785 when doing some testing with an option passed >>> to >>> the testsuite and I

Re: [RFC] Fix for PR driver/47785

2013-01-23 Thread Ramana Radhakrishnan
Well, if you look at the testcase you added with your patch you see -Wa,--defsym=x=42, so the answer is yes. Bah I must be blind. Ramana Richard. cheers, Ramana

[PATCH] rs6000_delegitimize_address fix

2013-01-23 Thread David Edelsohn
While debugging the selective scheduler problem, Jakub pointed out that not all AIX TOC references are in the constant pool, causing an ICE for him. This patch checks that the TOC operand is a symbol ref in the constant pool before trying to check its value. * config/rs6000/rs6000.c (rs6000_deleg

Re: [patch] PR inline-asm/55934

2013-01-23 Thread Vladimir Makarov
On 13-01-22 4:41 AM, Steven Bosscher wrote: On Mon, Jan 21, 2013 at 5:22 PM, Vladimir Makarov wrote: I'd prefer the above change than just keeping lra_invalidate_insn_data call. I think it is more safe solution for other parts of LRA code. I agree, but unfortunately the compiler does not... W

[PATCH, i386]: Slightly disparage DFmode moves involving stack registers on x86_64

2013-01-23 Thread Uros Bizjak
Hello! All things equal, we would like to avoid x87 registers to move DFmode immediates to a memory. Following testcase: --cut here-- volatile double y; void test () { int z; for (z = 0; z < 1000; z++) { y = 1.33; } } -- cut here-- compiled with -O3 to: movl$100

Re: [PATCH, regression?] Support --static-libstdc++ with native AIX ld

2013-01-23 Thread David Edelsohn
This patch looks okay, although it needs a ChangeLog entry. Also, is this really sufficient? I guess you are linking the shared libstdc++ library statically, which is bulky but will work. In the past there have been problems linking libstdc++ statically without explicitly linking libsupc++ as well

Re: FW: [PATCH] [MIPS] microMIPS gcc support

2013-01-23 Thread Richard Sandiford
Hi Catherine, Thanks for the update. Despite the length of this reply, there isn't anything major. Please don't change all NOMIPS16 to NOCOMPRESSION in the testsuite. Most NOMIPSs are there because of the drastically reduced MIPS16 instruction set. I would have expected most of them to pass wit

[Patch, Fortran] PR 56081: [4.7/4.8 Regression] Seg fault ICE on select with bad case

2013-01-23 Thread Janus Weil
Hi all, here is a regression fix for an ICE-on-invalid bug with SELECT CASE. The check to reject non-scalar selectors had been present in 4.6, but was apparently removed when CLASS arrays were implemented. The patch re-inserts the check and makes sure it is not applied to SELECT TYPE (where class

Re: [Patch, Fortran] PR 56081: [4.7/4.8 Regression] Seg fault ICE on select with bad case

2013-01-23 Thread Steve Kargl
On Wed, Jan 23, 2013 at 09:18:45PM +0100, Janus Weil wrote: > > here is a regression fix for an ICE-on-invalid bug with SELECT CASE. > The check to reject non-scalar selectors had been present in 4.6, but > was apparently removed when CLASS arrays were implemented. > > The patch re-inserts the ch

small bug fix for atomic compare and swap

2013-01-23 Thread Mike Stump
The problem is that expansion can use const0_rtx as an indicator that we are not interested in the value. This is an invalid as a target of a move, so, we must always have a valid target. This dummies up a target, just like in the NULL_RTX case. Ok? diff --git a/gcc/optabs.c b/gcc/optabs.c i

Re: [Patch, microblaze]: PR54662 - microblaze-linux target makefile

2013-01-23 Thread David Holsgrove
Hi Michael, On 24 January 2013 01:07, Michael Eager wrote: > On 01/20/2013 09:46 PM, David Holsgrove wrote: >> >> gcc/Changelog >> >> 2013-01-21 David Holsgrove >> >> * config.gcc (microblaze*-linux*): Add tmake_file to allow >> building >>of microblaze-c.o >> >> libgcc/Cha

Re: [Patch, Fortran] PR 56081: [4.7/4.8 Regression] Seg fault ICE on select with bad case

2013-01-23 Thread Janus Weil
2013/1/23 Steve Kargl : > On Wed, Jan 23, 2013 at 09:18:45PM +0100, Janus Weil wrote: >> >> here is a regression fix for an ICE-on-invalid bug with SELECT CASE. >> The check to reject non-scalar selectors had been present in 4.6, but >> was apparently removed when CLASS arrays were implemented. >>

Re: [Patch, libfortran] Improve performance of byte swapped IO

2013-01-23 Thread Janne Blomqvist
On Wed, Jan 23, 2013 at 12:32 AM, Thomas Koenig wrote: > Hi Janne, > >> PING**2 > > > this is OK. Thanks a lot for the work you put into this! Thanks for the review; committed as r195413. -- Janne Blomqvist

Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c

2013-01-23 Thread Eric Botcazou
> Test gcc.dg/vect/vect-multitypes uses Tcl conditions within a dg-final > directive, which is something that DejaGnu handles but we strive not to > do. It's now possible to use supported constructs to get the same > result, so I've cleaned up the test and checked it in as obvious. I'm > fixing t

Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c

2013-01-23 Thread Janis Johnson
On 01/23/2013 02:52 PM, Eric Botcazou wrote: >> Test gcc.dg/vect/vect-multitypes uses Tcl conditions within a dg-final >> directive, which is something that DejaGnu handles but we strive not to >> do. It's now possible to use supported constructs to get the same >> result, so I've cleaned up the t

Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c

2013-01-23 Thread Eric Botcazou
> Would you mind playing around with it a bit, like removing the xfail from > /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target > sparc*-*-* xfail ilp32 } } } */ and removing/disabling the directives with > sparc*-*-*? I already played a bit when I wrote the original dire

Re: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c

2013-01-23 Thread Janis Johnson
On 01/23/2013 04:57 PM, Eric Botcazou wrote: >> Would you mind playing around with it a bit, like removing the xfail from >> /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target >> sparc*-*-* xfail ilp32 } } } */ and removing/disabling the directives with >> sparc*-*-*? > >

Re: [Patch, microblaze]: Add microblaze*-*-elf target

2013-01-23 Thread David Holsgrove
Hi Michael, On 24 January 2013 00:58, Michael Eager wrote: > On 01/20/2013 09:42 PM, David Holsgrove wrote: >> >> gcc/Changelog >> >> 2013-01-21 Edgar E. Iglesias >> >> * config.gcc (microblaze*-*-elf): Add new target >> >> libgcc/Changelog >> >> 2013-01-21 Edgar E. Iglesias >> >>

[google gcc-4_7, integration] Scribble on destructed strings to catch invalid accesses.

2013-01-23 Thread Paul Pluzhnikov
This patch allows us to catch use of destructed strings. Google ref: b/5430313 Ok for google/gcc-4_7 and google/integration? -- Paul Pluzhnikov Index: libstdc++-v3/include/ext/sso_string_base.h === --- libstdc++-v3/include/ext/ss