Re: [PATCH] build: add -Wl,-rpath=path to $gmplibs (issue 7124057)

2013-01-18 Thread Paolo Bonzini
Il 17/01/2013 21:05, minux ha scritto: >> > >> > I think gcc should try and build and run a gmp program and fail to >> > configure if the binary can't also run. This prevents configuring and >> > building on such a system. The gcc directions for building gmp and >> > friends should say that th

Re: PR 52573

2013-01-18 Thread Uros Bizjak
Hello! > @@ -1,3 +1,7 @@ > +2013-01-17 Jeff Law > + > + PR rtl-optimization/52573 > + * gcc.dg/pr52573.c: New test. > 2013-01-17 Jack Howarth > > PR sanitizer/55679 > diff --git a/gcc/testsuite/gcc.dg/pr52573.c b/gcc/testsuite/gcc.dg/pr52573.c > new file mode 100644 > index

[PATCH] Fix ICE in vectorization dump (PR tree-optimization/55995)

2013-01-18 Thread Sharad Singhai
This patch fixes an ICE in vectorization dump when section anchors are present. Bootstrapped/tested on x86_64 and PPC 64 and found no new failures. OK for trunk? Thanks, Sharad 2013-01-18 Sharad Singhai PR tree-optimization/55995 * dumpfile.c (dump_loc): Print location only if available. * t

Re: [PATCH] gcc/doc: fix two typos (issue 7159043)

2013-01-18 Thread Richard Biener
On Thu, Jan 17, 2013 at 7:54 PM, wrote: > Reviewers: gerald_pfeifer.com, joseph_codesourcery.com, > > Message: > two trivial typo fixes. Ok. Thanks, Richard. > Description: > 2013-01-16 Shenghou Ma > > * doc/invoke.texi: fix typo. > * doc/objc.texi: fix typo. > > > PS: my co

Re: [patch] Update "Downloading the source" docs (Was: Components no longer exist)

2013-01-18 Thread Richard Biener
On Fri, Jan 18, 2013 at 12:01 AM, Jonathan Wakely wrote: > On 17 January 2013 15:48, Michael Witten wrote: >> The documentation here: >> >> http://gcc.gnu.org/install/download.html >> >> says: >> >> It is possible to download a full distribution or >> specific components... If you choose to

Re: [PATCH] Fix ICE in vectorization dump (PR tree-optimization/55995)

2013-01-18 Thread Richard Biener
On Fri, Jan 18, 2013 at 9:51 AM, Sharad Singhai wrote: > This patch fixes an ICE in vectorization dump when section anchors are > present. > > Bootstrapped/tested on x86_64 and PPC 64 and found no new failures. OK > for trunk? Ok. Thanks, Richard. > Thanks, > Sharad > > 2013-01-18 Sharad Sing

[patch libbacktrace]: Fix undeclared-symbols warning for SjLj-targets

2013-01-18 Thread Kai Tietz
Hi, this patch cleans up a undeclared-symbol issue in libbacktrace. ChangeLog 2013-01-18 Kai Tietz * backtrace.c (_Unwind_GetIPInfo): Add prototype. * simple.c (_Unwind_GetIPInfo): Likewise. Tested for x86_64-w64-mingw32, and i686-w64-mingw32. Ok for apply? Kai Index: back

Re: [PATCH] Fix ICE in vectorization dump (PR tree-optimization/55995)

2013-01-18 Thread Jakub Jelinek
On Fri, Jan 18, 2013 at 11:04:32AM +0100, Richard Biener wrote: > > 2013-01-18 Sharad Singhai > > > > PR tree-optimization/55995 > > * dumpfile.c (dump_loc): Print location only if available. > > * testsuite/gcc.dg/vect/vect.exp: Use "details" flags for dump info. > > * tree-vectorizer.c (increa

[patch libstdc++]: Fix tests trying to override symbols in shared-library for mingw targets

2013-01-18 Thread Kai Tietz
Hi, this patch addresses some of libstdc++'s testsuite regressions on pe-coff targets due none-overridable symbols in DLL files. ChangeLog * 18_support/50594.cc: Force use of static libstdc++ for mingw targets. * 19_diagnostics/error_category/operators/equal.cc: Likewise.

Re: [patch libbacktrace]: Fix undeclared-symbols warning for SjLj-targets

2013-01-18 Thread Jakub Jelinek
On Fri, Jan 18, 2013 at 11:05:11AM +0100, Kai Tietz wrote: > this patch cleans up a undeclared-symbol issue in libbacktrace. It is prototyped in unwind.h, at least should be. > 2013-01-18 Kai Tietz > > * backtrace.c (_Unwind_GetIPInfo): Add prototype. > * simple.c (_Unwind_GetIPIn

[Patch, AArch64, AArch64-4.7] Map scalar types in arm_neon.h to standard types.

2013-01-18 Thread Tejas Belagod
Hi, The attached patch fixes one of arm_neon.h's issues with C++. All scalar types x1_t are mapped to internal __builtin_aarch64_simd_ types. This creates duplicate function name symbols when one attempts overloading a standard type and one of these builtin types that are of the same size. Fo

Re: [Patch, AArch64, AArch64-4.7] Map scalar types in arm_neon.h to standard types.

2013-01-18 Thread Marcus Shawcroft
On 18/01/13 10:25, Tejas Belagod wrote: Hi, The attached patch fixes one of arm_neon.h's issues with C++. All scalar types x1_t are mapped to internal __builtin_aarch64_simd_ types. This creates duplicate function name symbols when one attempts overloading a standard type and one of these built

Re: [patch libbacktrace]: Fix undeclared-symbols warning for SjLj-targets

2013-01-18 Thread Kai Tietz
Sure, it is. But the point is that system's unwind.h header is used over the local one. So if you have an older gcc to build, you might get the wrong unwind.h header. I admit that this patch is a kludge but fixes issue I have with bootstrap cross on cygwin by using a gcc 3.4.4 compiler. 2013/1/

Re: [patch libbacktrace]: Fix undeclared-symbols warning for SjLj-targets

2013-01-18 Thread Jakub Jelinek
On Fri, Jan 18, 2013 at 11:39:41AM +0100, Kai Tietz wrote: > Sure, it is. But the point is that system's unwind.h header is used > over the local one. So if you have an older gcc to build, you might > get the wrong unwind.h header. I admit that this patch is a kludge > but fixes issue I have wit

Re: fix for PR49888 var-tracking compile-time regression

2013-01-18 Thread Jakub Jelinek
On Thu, Jan 17, 2013 at 06:56:40PM -0200, Alexandre Oliva wrote: > From: Alexandre Oliva > > for gcc/ChangeLog > > PR debug/54114 > PR debug/54402 > PR debug/49888 > * var-tracking.c (negative_power_of_two_p): New. > (global_get_addr_cache, local_get_addr_cache): N

Re: [PATCH] Fix COMPLEX_EXPR expansion (PR middle-end/56015)

2013-01-18 Thread Richard Biener
On Thu, Jan 17, 2013 at 7:22 PM, Jakub Jelinek wrote: > Hi! > > If target (the real part thereof) overlap op1 (i.e. the imag part of > COMPLEX_EXPR > to be stored), we end up with first overwriting the real part and then > using wrong value in op1. > Fixed by testing for overlap, and either, if p

Re: [PR55547] fix alias regression on alpha on misaligned symbols

2013-01-18 Thread Alexandre Oliva
On Jan 16, 2013, Uros Bizjak wrote: >> Thanks, I started a bootstrap/regtest run. If everything goes as >> expected, the results will be available in ~10h from now... > The results looks good [1], no regressions with patch. > [1] http://gcc.gnu.org/ml/gcc-testresults/2013-01/msg01706.html Than

Re: [patch libstdc++]: Fix tests trying to override symbols in shared-library for mingw targets

2013-01-18 Thread Jonathan Wakely
On 18 January 2013 10:17, Kai Tietz wrote: > Hi, > > this patch addresses some of libstdc++'s testsuite regressions on > pe-coff targets due none-overridable symbols in DLL files. > ChangeLog > > * 18_support/50594.cc: Force use of static libstdc++ for > mingw targets. > * 1

[PATCH,ARM] remove incscc and decscc patterns

2013-01-18 Thread Greta Yorsh
Remove incscc and decscc expanders that appear to be dead, along with the related patterns. This patch is a follow up on: http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01128.html No regression qemu for arm-none-eabi. Bootstrap successful. Ok for trunk? Thanks, Greta 2013-01-17 Greta Yorsh

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-18 Thread Alexandre Oliva
On Jan 16, 2013, Jan Hubicka wrote: > For 2) the symtab_get_node test seems resonable to me. It is what > dwarf2out does, too. We keep nodes for external vars that are > refereed but we remove all optimized out nodes. Since you agreed this was the right approach and richi said he didn't care m

[AArch64] Fix unordered comparisons to floating-point vcond.

2013-01-18 Thread James Greenhalgh
Hi, When I added support for floating-point vcond on aarch64, I didn't consider the various UNORDERED cases gcc required support for. This could in some circumstances lead to an ICE. This patch fixes that oversight, adding support for the UNLT, UNLE, UNEQ, UNGE, UNGT, ORDERED and UNORDERED case

Re: [patch libstdc++]: Fix tests trying to override symbols in shared-library for mingw targets

2013-01-18 Thread Kai Tietz
2013/1/18 Jonathan Wakely : > On 18 January 2013 10:17, Kai Tietz wrote: >> Hi, >> >> this patch addresses some of libstdc++'s testsuite regressions on >> pe-coff targets due none-overridable symbols in DLL files. >> ChangeLog >> >> * 18_support/50594.cc: Force use of static libstdc++ for >

RE: [Patch i386]: btver2 pipeline descriptions.

2013-01-18 Thread Kumar, Venkataramanan
Hi Steven, The output of "genautomata -stats btver2.md" is given below: Automaton `btver2' 4 NDFA states, 8 NDFA arcs 4 DFA states, 8 DFA arcs 3 minimal DFA states, 7 minimal DFA arcs 176 all insns 3 insn equivalence classes

[PATCH] Unset M4 environment variable for flex

2013-01-18 Thread Michael Haubenwallner
Hi, not sure if that is intentional though, but gcc-4.8-20130113 snapshot does /not/ ship with gcc/gengtype-lex.c. I've expected the FLEX=/path/to/flex environment variable to be enough, as it is not in PATH here on AIX. But alas, this creates an empty gcc/gengtype-lex.c, resulting in: ld:

Re: [patch libstdc++]: Fix tests trying to override symbols in shared-library for mingw targets

2013-01-18 Thread Jonathan Wakely
On 18 January 2013 12:09, Kai Tietz wrote: >>> + >>> +if { [llength $args] >= 3 } { >> >> Is this condition right or should it check for exactly three? > > Well, I copied stuff from gcc's testsuite. As we check some lines > about for args > 3 and error out, a test for == 3 makes sense, but > w

Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores

2013-01-18 Thread Ramana Radhakrishnan
On 06/20/12 03:53, Yi-Hsiu Hsu wrote: marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated

Re: PR 52573

2013-01-18 Thread Jeff Law
On 01/18/2013 01:21 AM, Uros Bizjak wrote: Hello! @@ -1,3 +1,7 @@ +2013-01-17 Jeff Law + + PR rtl-optimization/52573 + * gcc.dg/pr52573.c: New test. 2013-01-17 Jack Howarth PR sanitizer/55679 diff --git a/gcc/testsuite/gcc.dg/pr52573.c b/gcc/testsuite/gcc.dg/pr5257

Re: [AArch64] Fix unordered comparisons to floating-point vcond.

2013-01-18 Thread Marcus Shawcroft
OK /Marcus On 18 January 2013 11:55, James Greenhalgh wrote: > > Hi, > > When I added support for floating-point vcond on aarch64, > I didn't consider the various UNORDERED cases gcc required > support for. This could in some circumstances lead to > an ICE. > > This patch fixes that oversight, a

Re: PR 52573

2013-01-18 Thread Jeff Law
On 01/18/2013 01:21 AM, Uros Bizjak wrote: This test should really go into gcc.target/m68k, without target selector at "dg-do compile" directive. Done. Jeff

testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c

2013-01-18 Thread Janis Johnson
Test gcc.dg/vect/vect-multitypes uses Tcl conditions within a dg-final directive, which is something that DejaGnu handles but we strive not to do. It's now possible to use supported constructs to get the same result, so I've cleaned up the test and checked it in as obvious. I'm fixing this partic

Re: [PATCH] Fix COMPLEX_EXPR expansion (PR middle-end/56015)

2013-01-18 Thread Jakub Jelinek
On Fri, Jan 18, 2013 at 12:11:33PM +0100, Richard Biener wrote: > On Thu, Jan 17, 2013 at 7:22 PM, Jakub Jelinek wrote: > (I wonder if it's worth doing the work to eventually swap instead of simply > forcing it to a reg always for overlaps) It is just a couple of lines, and we might get better co

[PATCH] add inc to list of suffix in libsanitizer/merge.sh

2013-01-18 Thread Jack Howarth
Upstream llvm compiler-rts asan subdirectory now includes files with the *.inc suffix. The attached patch adds this new suffix to the list of merged files. Okay for gcc trunk? Jack libsanitizer/ 2013-01-18 Jack Howarth merge.sh: Add inc suffix for merged file listing.

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-18 Thread Martin Jambor
Hi, On Wed, Jan 16, 2013 at 10:24:10PM +0100, Jan Hubicka wrote: > > On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > > > Perhaps could you first change cgraph_non_local_node_p_1 and try to > > > > check some code > > > > if codegen differs significantly? It should not at all. > >

Re: [PATCH, PR 55264] Do not remove as unreachable any virtual methods before inlining

2013-01-18 Thread Martin Jambor
Hi, On Wed, Jan 16, 2013 at 10:24:10PM +0100, Jan Hubicka wrote: > > On Wed, Jan 16, 2013 at 01:44:20PM +0100, Jan Hubicka wrote: > > > > Perhaps could you first change cgraph_non_local_node_p_1 and try to > > > > check some code > > > > if codegen differs significantly? It should not at all. > >

Re: [PATCH] build: add -Wl,-rpath=path to $gmplibs (issue 7124057)

2013-01-18 Thread Mike Stump
On Jan 17, 2013, at 12:05 PM, minux wrote: > On Fri, Jan 18, 2013 at 3:39 AM, Mike Stump wrote: >> On Jan 17, 2013, at 11:11 AM, minux...@gmail.com wrote: >>> some systems (notably NetBSD), doesn't place the path where libgmp, >> >> I think gcc should try and build and run a gmp program and fail

Re: [PATCH] add inc to list of suffix in libsanitizer/merge.sh

2013-01-18 Thread Konstantin Serebryany
ok, thanks! (that was quick!) --kcc On Fri, Jan 18, 2013 at 9:39 PM, Jack Howarth wrote: >Upstream llvm compiler-rts asan subdirectory now includes files with the > *.inc suffix. > The attached patch adds this new suffix to the list of merged files. Okay for > gcc trunk? > Jack >

patch to fix PR55433

2013-01-18 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55433 LRA went into infinite reload loop when secondary memory was needed. To fix the problem, two changes are done: o a typo was fixed in inheritance which prevented rejecting inheritances requiring secondary memory relo

Re: patch to fix PR55433

2013-01-18 Thread Steven Bosscher
On Fri, Jan 18, 2013 at 7:25 PM, Vladimir Makarov wrote: > > PR target/55433 > * lra-constraints.c (curr_insn_transform): Reuse original insn for > secondary memory move. > (inherit_reload_reg): Use rclass instead of cl for > check_secondary_memory_needed_p.

[Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)

2013-01-18 Thread Sterling Augustine
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c Author: Sterling Augustine Date: Fri Jan 18 10:38:30 2013 -0800 Fix for Google Ref: b/8028506 Calling find_AT_string can resize the debug_str hash table, even if the string is already present in the hash table--go figure. So afte

Re: [Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)

2013-01-18 Thread Cary Coutant
> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c > Author: Sterling Augustine > Date: Fri Jan 18 10:38:30 2013 -0800 > > Fix for Google Ref: b/8028506 > > Calling find_AT_string can resize the debug_str hash table, even if the > string is already present in the hash table--go figure

Re: [google 4.7] Fix for PR 8013197 (issue7140044)

2013-01-18 Thread Cary Coutant
>> 2013-01-16 Sterling Augustine >> >> * gcc/dwarf2out.c (resolve_addr): Delete call to >> remove_addr_table_entry. > > OK for google/gcc-4_7. The commit log entry should say "Google ref: > b/8013197" instead of "PR ...". I'll file an upstream bug for this as well (as soon as I

Re: [patch] PR inline-asm/55934

2013-01-18 Thread Steven Bosscher
On Fri, Jan 18, 2013 at 12:59 AM, Jakub Jelinek wrote: > On Fri, Jan 18, 2013 at 12:45:06AM +0100, Steven Bosscher wrote: >> --- testsuite/gcc.target/i386/pr55934.c (revision 0) >> +++ testsuite/gcc.target/i386/pr55934.c (revision 0) >> @@ -0,0 +1,10 @@ >> +/* PR inline-asm/55934 */ >> +/* { dg-do

[PATCH] Fix phi arg location handling (PR tree-optimization/56029)

2013-01-18 Thread Jakub Jelinek
Hi! The following testcase ICEs, because we have a n argument PHI node referencing some BLOCK in its last gimple_phi_arg_location, then for the containing bb the number of predecessors decreases and thus the PHI has fewer arguments (but, nothing clears the argument location at that point), then tr

Re: [PING^5] PR 54805: __gthread_tsd* in vxlib-tls.c

2013-01-18 Thread rbmj
On 17-Jan-13 20:18, Mike Stump wrote: You are now entered into the most ignored and most trivial gcc patch contest. You presently are behind the leader, but, if you can get another 10 pings in before approval, you can win! Good luck. Thanks. I know it's trivial, but 1. it's not hard to pin

Re: [PATCH] Fix phi arg location handling (PR tree-optimization/56029)

2013-01-18 Thread Jeff Law
On 01/18/2013 01:14 PM, Jakub Jelinek wrote: Hi! The following testcase ICEs, because we have a n argument PHI node referencing some BLOCK in its last gimple_phi_arg_location, then for the containing bb the number of predecessors decreases and thus the PHI has fewer arguments (but, nothing clear

[PATCH] Multiversioning fixes (PR c++/55742)

2013-01-18 Thread Jakub Jelinek
Hi! As discussed in the PR, this patch attempts to change multiversioning so that backwards compatibility with the previous target attribute behavior is preserved. In particular, e.g. for void foo () __attribute__((target ("avx"))); void foo () { } the foo definition was just merged with the pre

backporting testsuite fixes to 4.7 branch

2013-01-18 Thread Janis Johnson
For primarily selfish reasons I'd like to backport several testsuite fixes from mainline to the 4.7 branch. Should I request permission for specific groups of changes, or just do it? Janis

Re: backporting testsuite fixes to 4.7 branch

2013-01-18 Thread Mike Stump
On Jan 18, 2013, at 12:35 PM, Janis Johnson wrote: > For primarily selfish reasons I'd like to backport several testsuite > fixes from mainline to the 4.7 branch. Should I request permission for > specific groups of changes, or just do it? For changes that have withstood the test of time in late

LRA branch was merged with trunk

2013-01-18 Thread Vladimir Makarov
LRA branch was merged with trunk @ 195303. Committed as rev. 195305.

Re: [Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)

2013-01-18 Thread Sterling Augustine
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant wrote: >> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c >> Author: Sterling Augustine >> Date: Fri Jan 18 10:38:30 2013 -0800 >> >> Fix for Google Ref: b/8028506 >> >> Calling find_AT_string can resize the debug_str hash table, even if th

Re: C++ PATCH for target/54908 (thread_local vs emutls)

2013-01-18 Thread Jason Merrill
I've been thinking about how to deal with the problems with calling initialization functions in another translation unit; namely, that it's significant overhead even for cases where it isn't useful, and that it requires alias and weak reference support. This patch introduces a new flag -fno-ex

Re: [Patch, libfortran] Improve performance of byte swapped IO

2013-01-18 Thread Janne Blomqvist
PING**2 On Mon, Jan 14, 2013 at 12:44 AM, Janne Blomqvist wrote: > PING**1.2 > > Yet another slightly updated patch attached. Compared to the previous > version, now with specializations for size 12 and 16 as well. For the > real(10) benchmark, with the previous v3 patch (please disregard the > a

[Patch, Fortran, OOP] PR 46952: [OOP] Spurious "recursive call" error with type bound procedure

2013-01-18 Thread Janus Weil
Hi all, here is a simple patch for a rejects-valid problem with deferred type-bound procedures. This is the patch from comment 5 in the PR. A simpler (but equivalent) patch can be found in comment 4. Both fix the problem and are free of testsuite regressions. Is any of the two versions still ok f

Re: patch to fix PR55433

2013-01-18 Thread Vladimir Makarov
On 13-01-18 1:34 PM, Steven Bosscher wrote: On Fri, Jan 18, 2013 at 7:25 PM, Vladimir Makarov wrote: PR target/55433 * lra-constraints.c (curr_insn_transform): Reuse original insn for secondary memory move. (inherit_reload_reg): Use rclass instead of cl for

[PATCH] Fix up English grammar in an error msg

2013-01-18 Thread Marek Polacek
As the subject says. Ok for trunk? 2013-01-19 Marek Polacek * cfgloop.c (verify_loop_structure): Fix up grammar. --- gcc/cfgloop.c.mp2013-01-19 00:34:50.857710526 +0100 +++ gcc/cfgloop.c 2013-01-19 00:35:03.310764236 +0100 @@ -1344,7 +1344,7 @@ verify_loop_structure (void)

Re: [patch] PR inline-asm/55934

2013-01-18 Thread Vladimir Makarov
On 13-01-17 6:45 PM, Steven Bosscher wrote: Hello Vlad, Attached is my attempt to fix PR55934, an error recovery issue in LRA with incorrect constraints in an asm. I'm not 100% sure this is all correct (especially the LRA insn data invalidating in lra-assigns.c) but it appears to fix the PR wit

Re: [PING^5] PR 54805: __gthread_tsd* in vxlib-tls.c

2013-01-18 Thread Maxim Kuvyrkov
On 19/01/2013, at 9:18 AM, rbmj wrote: >>> -150,7 +158,7 @@ static __gthread_once_t tls_init_guard = >>> need to read tls_keys.dtor[key] atomically. */ >>> >>> static void >>> -tls_delete_hook (void *tcb ATTRIBUTE_UNUSED) >>> +tls_delete_hook (void *tcb) >> >> Don't remove ATTRIBUTE_UNUSE

Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

2013-01-18 Thread Jason Merrill
Sorry it's taken so long for me to respond to this; I forgot about it over the holiday break. The patch is in good shape now, just a few tweaks left: On 12/19/2012 01:21 PM, Dodji Seketeli wrote: + tree aps;/* instance of ARGUMENT_PACK_SELECT +

Re: C++ PATCH for target/54908 (thread_local vs emutls)

2013-01-18 Thread Jack Howarth
ted with... /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/testsuite/g++/../../xg++ -B/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/testsuite/g++/../../ /sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20130118/gcc/testsuite/g++.dg/tls/thread_local-wrap3.C -fno-diagnostics-show-caret -n

Re: C++ PATCH for target/54908 (thread_local vs emutls)

2013-01-18 Thread Jason Merrill
On 01/18/2013 09:20 PM, Jack Howarth wrote: The proposed patch eliminates all of the previous failures from PR54908 at both -m32/-m64 on x86_64-apple-darwin12 but seems to introduce a new set of failures... FAIL: g++.dg/tls/thread_local-wrap3.C scan-assembler _ZTH1i FAIL: g++.dg/gomp/tls-wra