Re: [PATCH, i386]: AMD bdver3 enablement

2012-11-12 Thread Uros Bizjak
On Mon, Nov 12, 2012 at 6:34 AM, Gopalasubramanian, Ganesh wrote: >> You can see from the changes of sse.md that this is functionally a no-op >> change. > Sseshuf replaces sselog. > So, do you mean it should be added with sselog instead of sseadd? > Adding it with sseadd (instead of sselog) influ

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-12 Thread Eric Botcazou
> This is a target-specific blockage insn, but with the general form > found in all targets defining it. The default blockage is an empty > asm-volatile, which is what cse_insn recognized. The blockage insn is > there to "prevent scheduling" of the critical insns and register > values. It's almo

Re: [patch RFA middle-end] Fix PR target/41993

2012-11-12 Thread Uros Bizjak
On Tue, Nov 6, 2012 at 9:12 AM, Eric Botcazou wrote: >> 2012-11-05 Uros Bizjak >> Kaz Kojima >> >> PR target/41993 >> * mode-switching.c (create_pre_exit): Set return_copy to >> last_insn when copy_start is a pseudo reg. It looks to me, that we in fact want: --cu

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread Eric Botcazou
> I strongly doubt that they will be different from the options > supported both in cc and fbe in the Solaris Studio 12.3 release: They need to provide some form of backward compatibility though, they cannot break the interface of 'as' like that. Apparently 'fbe' has had its own set of -xarch v

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Jakub Jelinek
On Sat, Nov 10, 2012 at 07:54:34PM +0100, Tobias Burnus wrote: > 2012-11-10 Tobias Burnus > Jakub Jelinek > > * asan.c (maybe_instrument_builtin_call): Set *iter > to gsi for the call at the end. > (transform_statements): Leave loop when gsi_end_p. But IMHO it

Re: [patch RFA middle-end] Fix PR target/41993

2012-11-12 Thread Eric Botcazou
> It looks to me, that we in fact want: > > --cut here-- > Index: mode-switching.c > === > --- mode-switching.c(revision 193407) > +++ mode-switching.c(working copy) > @@ -330,7 +330,7 @@ > short_bloc

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Jakub Jelinek
On Fri, Nov 09, 2012 at 12:03:09PM -0800, Kostya Serebryany wrote: > Why depending on gtest is bad? Because gcc already has way too many dependencies (starting from gmp, mpfr, libmpc, graphite dependencies, java depenencies), adding another one just for the sake of a couple of asan tests would mak

Re: [PATCH, i386]: Implement post-reload vzeroupper insertion pass

2012-11-12 Thread Uros Bizjak
On Mon, Nov 12, 2012 at 9:51 AM, Vladimir Yakovlev wrote: > We have not do any changes in mode-switching.c if we use > pass_mode_switching.pass.execute () for call of the > optimize_mode_switching() in i386.c. Even better ;) In addition to this patch, there are two remaining patches for avx vz

[patch] PR51477

2012-11-12 Thread Steven Bosscher
Hello, In this PR, a set to a global reg is removed by fast-dce and ud-dce. Such sets should always be preserved. The proposed fix is to make global regs always live. This is done in the df-* parts of the patch from Jakub (the test case is also his). In addition, ud-dce should consider sets of gl

Re: [PATCH,AArch64] Optimise comparison where intermediate result not used

2012-11-12 Thread Marcus Shawcroft
On 06/11/12 18:49, Ian Bolton wrote: OK for trunk? Cheers, Ian 2012-11-06 Ian Bolton * gcc/config/aarch64/aarch64.md (*compare_neg): New pattern. * gcc/testsuite/gcc.target/aarch64/cmn.c: New test. * gcc/testsuite/gcc.target/aarch64/adds.c: New test. * gcc/tes

Re: [PATCH,AArch64] Use CSINC instead of CSEL to return 1

2012-11-12 Thread Marcus Shawcroft
On 06/11/12 18:56, Ian Bolton wrote: Where a CSEL can return the value 1 as one of the alternatives, it is usually more efficient to use a CSINC than a CSEL (and never less efficient), since the value of 1 can be derived from wzr, rather than needing to set it up in a register first. This patch

Re: [PATCH] Handle abortTransaction with RTM

2012-11-12 Thread Torvald Riegel
On Fri, 2012-11-09 at 21:54 +0100, Andi Kleen wrote: > > I'm not sure this is quite true. If a libitm-executed transaction is > > It's just a convention. You don't have to use it. That's true ... > Not doing it will > just make abort profiling harder. ... but I disagree with this one. This wo

(committed) gcc/diagnostic.c: Add missing va_end call

2012-11-12 Thread Tobias Burnus
An minor obvious fix, found by Coverity. Committed as Rev. 193428 after all-language-bootstrap/regtesting on x86-64-gnu-linux. Tobias Index: gcc/ChangeLog === --- gcc/ChangeLog (Revision 193427) +++ gcc/ChangeLog (Arbeitskopie) @@

[Patch, Fortran, committed] PR55272 - Fix module handling of coarray scalars

2012-11-12 Thread Tobias Burnus
Thanks for the report Damian! And sorry for the breakage. Fixed with the following obvious patch (committed as Rev. 193429) after an all-language bootstrap/regtesting Tobias Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeL

Re: [PATCH 03/11] Emit GIMPLE directly instead of gimplifying GENERIC.

2012-11-12 Thread Dodji Seketeli
[I am replying to several emails at once as I believe they are logically connected] Tobias Burnus writes: > I tried the 01/10 to 10/10 patch series but it doesn't trigger for the > following test case: > > #include > #include > > int > main() { > int *i; > i = malloc(10*sizeof(*i)); > fr

Re: [PATCH 02/10] Initial asan cleanups

2012-11-12 Thread Dodji Seketeli
> On 2012-11-02 15:57 , Dodji Seketeli wrote: > > > /* AddressSanitizer, a fast memory error detector. > > - Copyright (C) 2011 Free Software Foundation, Inc. > > + Copyright (C) 2011, 2012 Free Software Foundation, Inc. > > I *think* we should only mention 2012, but I don't know if code in

Re: [PATCH 01/10] Initial import of asan from the Google branch into trunk

2012-11-12 Thread Dodji Seketeli
Tobias Burnus writes: > * -fno-address-sanitizer doesn't work (it does in Clang); it is > explicitly disabled via RejectNegative in gcc/common.opt > Fixed in common.opt by removing the RejectNegative. I am thus sending the updated patch. * common.opt: Add -faddress-sanitizer option.

Re: [PATCH 05/10] Implement protection of stack variables

2012-11-12 Thread Dodji Seketeli
Diego Novillo writes: > I believe they layout the stack from right to left (top is to the > right). Feels like reading a middle earth map. Kostya, is my > recollection correct? Yes, Konstantin replied to this already but I forgot to update the patch cover letter (that I keep in the commit log

Re: [PATCH 06/10] Implement protection of global variables

2012-11-12 Thread Dodji Seketeli
Diego Novillo writes: > On 2012-11-02 16:01 , Dodji Seketeli wrote: > > > * varasm.c: Include asan.h. > > (assemble_noswitch_variable): Grow size by asan_red_zone_size > > if decl is asan protected. > > (place_block_symbol): Likewise. > > (assemble_variable): If decl is asan

Re: [PATCH 09/10] Instrument built-in memory access function calls

2012-11-12 Thread Dodji Seketeli
Diego Novillo writes: > On 2012-11-02 16:05 , Dodji Seketeli wrote: > >> +static bool >> +maybe_instrument_builtin_call (gimple_stmt_iterator *iter) >> +{ >> + gimple call = gsi_stmt (*iter); >> + location_t loc = gimple_location (call); >> + >> + if (!is_gimple_call (call)) >> +return fal

Re: [PATCH 10/10] Import the asan runtime library into GCC tree

2012-11-12 Thread Dodji Seketeli
Diego Novillo writes: > On 2012-11-02 16:10 , Dodji Seketeli wrote: > >> * configure.ac: Add libsanitizer to target_libraries. >> * Makefile.def: Ditto. >> * configure: Regenerate. >> * Makefile.in: Regenerate. >> * libsanitizer: New directory for asan runtime. Conta

Re: [PATCH 05/10] Implement protection of stack variables

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 12:30:37PM +0100, Dodji Seketeli wrote: > + For this function, the stack protected by asan will be organized as > + follows, from the top of the stack to the bottom: > + > + Slot 1/ [red zone of 32 bytes called 'RIGHT RedZone'] > + > + Slot 2/ [24 bytes for variable 'a'] > +

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Dodji Seketeli
Tobias Burnus writes: > The attached test case ICEs (segfault) both on the asan branch and on > the trunk with Dodji's patches: Thank you for reporting this. I believe the neqw series of patches I have juste posted address this issue. To ease the testing, you can check out an updated git tree

Re: [PATCH] [AArch64] Refactor Advanced SIMD builtin initialisation.

2012-11-12 Thread James Greenhalgh
Hi, This patch is a cleanup of the initialisation code for the SIMD builtins in the AArch64 port. We do this in preparation for later patches supporting TARGET_BUILTIN_DECL and TARGET_VECTORIZE_BUILTIN_VECTORIZABLE_FUNCTION. This patch supersedes another, similar patch I posted a few weeks ago

bit_field_ref of constructor of vectors

2012-11-12 Thread Marc Glisse
Hello, this patch lets us fold a bit_field_ref of a constructor even when the elements are vectors. Writing a testcase is not that convenient because of the lack of a dead code elimination pass after forwprop4 (RTL doesn't always remove everything either), but I see a clear difference on this

Re: libstdc++ PATCH to add abi tag to complex::real/imag

2012-11-12 Thread Jason Merrill
On 11/12/2012 01:50 AM, Marc Glisse wrote: When we are changing the whole type, I assume the point of using this attribute instead of the standard solutions (move it to some other (inline) namespace, for instance) is the -Wabi-tag warning? Right. Jason

[PING, PATCH v2, ARM] 64-bit shifts in NEON

2012-11-12 Thread Ulrich Weigand
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01521.html Ping. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@de.ibm.com

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread Rainer Orth
Eric Botcazou writes: >> I strongly doubt that they will be different from the options >> supported both in cc and fbe in the Solaris Studio 12.3 release: > > They need to provide some form of backward compatibility though, they cannot > break the interface of 'as' like that. Apparently 'fbe' h

Re: [wwwdocs] Update Fortran secrion in 4.8/changes.html

2012-11-12 Thread Gerald Pfeifer
On Tue, 21 Aug 2012, Tobias Burnus wrote: >> I noticed you are using ..., as in e, >> which we usually don't. Why that? > My impression was that a one-letter didn't stand out enough and > looked rather odd; if you think it improves consistency or readability, > feel free to change it. That's a

Re: [wwwdocs] Update Fortran secrion in 4.8/changes.html

2012-11-12 Thread Tobias Burnus
Gerald Pfeifer wrote: One question: in general we are using the term "command-line option". You are introducing two uses of "flag", and the two existing uses of that are also in the Fortran section. Is this Fortran terminology or would it be fine to make this more consistent? Well, "flag" is G

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread Eric Botcazou
> No, quite the contrary. as is just a (sometimes partial) backport of > Studio fbe, though it's hard to tell exactly which Studio version of fbe > forms the basis of as. Especially for the Solaris 10 as patches, only > particular bugfixes/enhancements have been backported. > > Backward compatib

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Tobias Burnus
Dodji Seketeli wrote: I believe the neqw series of patches I have juste posted address this issue. Thanks a lot for your merging work! I am really looking forward to have it available on the trunk! I guess that your updated patch fixes the issue as it incorporates Jakub's patch. (I have not

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread Rainer Orth
Eric Botcazou writes: >> No, quite the contrary. as is just a (sometimes partial) backport of >> Studio fbe, though it's hard to tell exactly which Studio version of fbe >> forms the basis of as. Especially for the Solaris 10 as patches, only >> particular bugfixes/enhancements have been backpo

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Dodji Seketeli
Following a request from Jakub, and given the fact that the patch set have been reviewed by Diego, I have committed the last set of patches I have posted to trunk. This will hopefully ease the polishing work that has started already. I am of course watching for the fall-outs. --

Re: [PATCH 05/10] Implement protection of stack variables

2012-11-12 Thread Dodji Seketeli
Jakub Jelinek writes: > On Mon, Nov 12, 2012 at 12:30:37PM +0100, Dodji Seketeli wrote: >> + For this function, the stack protected by asan will be organized as >> + follows, from the top of the stack to the bottom: >> + >> + Slot 1/ [red zone of 32 bytes called 'RIGHT RedZone'] >> + >> + Slot 2/

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: > Following a request from Jakub, and given the fact that the patch set > have been reviewed by Diego, I have committed the last set of patches I > have posted to trunk. Thanks, I've committed as obvious the following formatting clean

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 04:45:55PM +0100, Tobias Burnus wrote: > First, I have a small hyphen fix patch, which is on top of your > merge branch. (The "asan" branch itself is okay.) This patch is preapproved with appropriate ChangeLog entry. Thanks. > --- invoke.texi.orig2012-11-12 15:41:31.00

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Tobias Burnus
Jakub Jelinek: On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: Following a request from Jakub, and given the fact that the patch set have been reviewed by Diego, I have committed the last set of patches I have posted to trunk. Thanks, I've committed as obvious the following for

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Dodji Seketeli
Jakub Jelinek writes: > The bug is elsewhere, the following patch should fix this > (and I've reordered the assignments according to the call arg > number, so that it is more readable at the same time). > Ok for trunk? > > 2012-11-12 Jakub Jelinek > > * asan.c (instrument_builtin_call) :

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Konstantin Serebryany
Folks, please remember that the Clang flag has recently changed to -fsanitize=address (-fsanitize=thread). This is hopefully the last syntax change there. --kcc On Mon, Nov 12, 2012 at 8:45 AM, Tobias Burnus wrote: > Jakub Jelinek: > >> On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wr

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Markus Trippelsdorf
Another ICE: % cat test.ii int i; % g++ -faddress-sanitizer -c -g -O1 test.ii test.ii:1:7: internal compiler error: Segmentation fault int i; ^ 0xa5cb5f crash_signal /home/markus/gcc/gcc/toplev.c:334 inconsistent DWARF line number info 0x4cf588 cp_classify_record /home

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Xinliang David Li
On Mon, Nov 12, 2012 at 12:45 AM, Jakub Jelinek wrote: > On Fri, Nov 09, 2012 at 12:03:09PM -0800, Kostya Serebryany wrote: >> Why depending on gtest is bad? > > Because gcc already has way too many dependencies (starting from gmp, mpfr, > libmpc, graphite dependencies, java depenencies), adding a

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-v3/include -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121112/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121112/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121112/libstdc++

Re: [Darwin] Do not enable -fvar-tracking at -O0

2012-11-12 Thread Mike Stump
On Nov 9, 2012, at 1:42 AM, Eric Botcazou wrote: > this is a regression present on the mainline and 4.7 branch. -fvar-tracking > is automatically enabled on Darwin when -g is passed, including at -O0. This > results in bloated and incomplete debug info. > OK for mainline and 4.7 branch? Ok.

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Wei Mi
On Fri, Nov 9, 2012 at 11:13 AM, Jakub Jelinek wrote: > On Fri, Nov 09, 2012 at 11:05:37AM -0800, Wei Mi wrote: >> gtest integrate multiple tests into the same file with each test being >> a single line check. I cannot think out a method to migrate it to >> dejagnu without using gtest, except spl

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
> -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-v3/include/x86_64-apple-darwin12.2.0 > > -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-v3/include > > -I/sw/src/fink.build/gcc48-4.8.0-1000/gc

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Tobias Burnus
Jack Howarth wrote: Copying over the lib/interception/mach_override directory from llvm.org's compiler-rt 3.2 branch into libsanitizer/interception allows the build of libsanitizer to proceed. I noticed that the mach_override subdirectory has a license file which shows... I was about to point

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Mike Stump
On Nov 12, 2012, at 9:32 AM, Wei Mi wrote: > Using setjmp/longjmp to do multiple tests in a single testfile, the > test statements in the front could affect the tests in the back. gtest > will fork a new process for every test statement. Some targets don't have fork. :-( Ah.

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Dodji Seketeli
Hello Jack, Jack Howarth writes: >> >> Dodji, >> I am finding that at r193442 bootstrapping on >> x86_64-apple-darwin12 fails with... >> ../../../../gcc-4.8-20121112/libsanitizer/interception/interception_mac.cc:16:41: >> fatal error: mach_overr

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread Richard Henderson
On 10/22/2012 08:39 PM, David Miller wrote: > + /* Compare and Branch is limited to +-2KB. If it is too far away, > + change > + > + cxbne X, Y, .LC30 > + > + to > + > + cxbe X, Y, .+12 > + ba,pt xcc, .LC30 > + nop */ Based on your no-control-after cbcond comment at the

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 06:37:06PM +0100, Tobias Burnus wrote: > Jack Howarth wrote: >> Copying over the lib/interception/mach_override directory from >> llvm.org's compiler-rt 3.2 branch into libsanitizer/interception >> allows the build of libsanitizer to proceed. I noticed that the >> mach

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 06:13:08PM +0100, Markus Trippelsdorf wrote: > Another ICE: > > % cat test.ii > int i; > > % g++ -faddress-sanitizer -c -g -O1 test.ii > test.ii:1:7: internal compiler error: Segmentation fault > int i; >^ The RECORD_TYPE doesn't have lang specific payload al

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 09:32:04AM -0800, Wei Mi wrote: > Using setjmp/longjmp to do multiple tests in a single testfile, the > test statements in the front could affect the tests in the back. gtest > will fork a new process for every test statement. The forked process > will do only one test and s

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Andrew Pinski
On Mon, Nov 12, 2012 at 10:05 AM, Jakub Jelinek wrote: > On Mon, Nov 12, 2012 at 09:32:04AM -0800, Wei Mi wrote: >> Using setjmp/longjmp to do multiple tests in a single testfile, the >> test statements in the front could affect the tests in the back. gtest >> will fork a new process for every tes

[PATCH] AIX large toc support

2012-11-12 Thread David Edelsohn
AIX has added its equivalent to PPC64 Linux Large TOC support. The appended patch implements GCC support and enables it if the AIX system tools support the new relocs. This is not the default for XLC and will not be the default for GCC. GCC testsuite produces same results if run with -mcmodel=la

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Konstantin Serebryany
Hi, I don't insist that we use gtest for gcc-asan, I just say that this is the simplest approach to get 2.5K test suite into gcc, and the only approach my team will be able to maintain. gtest is not as portable as the rest of gcc, but neither is asan run-time library (which is more platform-specif

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 06:55:32PM +0100, Dodji Seketeli wrote: > Hello Jack, > > Jack Howarth writes: > >> > >> Dodji, > >> I am finding that at r193442 bootstrapping on > >> x86_64-apple-darwin12 fails with... > > >&g

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-12 Thread Wei Mi
For TODO_update_ssa, when we insert tsan_write(&a), current function's ssa_renaming_needed flag will be set in finalize_ssa_defs because we insert non-ssaname vdef. An assertion in execute_todo will check whether we have TODO_update_ssa set when current function's ssa_renaming_needed flag is set. T

Re: [PATCH 10/10] Import the asan runtime library into GCC tree

2012-11-12 Thread H.J. Lu
On Mon, Nov 12, 2012 at 3:47 AM, Dodji Seketeli wrote: > Diego Novillo writes: > >> On 2012-11-02 16:10 , Dodji Seketeli wrote: >> >>> * configure.ac: Add libsanitizer to target_libraries. >>> * Makefile.def: Ditto. >>> * configure: Regenerate. >>> * Makefile.in: Regenerat

(committed) Add libquadmath files to contrib/gcc_update

2012-11-12 Thread Tobias Burnus
Used HJ's commit as motivation to also add the generated files of libquadmath files to the gcc_update file. Committed as . Tobias Index: contrib/ChangeLog === --- contrib/ChangeLog (Revision 193447) +++ contrib/ChangeLog (Arbeitsko

libgo patch committed: Force first letter of error message to lowercase

2012-11-12 Thread Ian Lance Taylor
One minor difference between the gc and gccgo libraries is that the error messages returned by the gc library force the first letter of the error message to be lower case. This normally doesn't matter, but of course it does matter for code that compares error strings directly. Such code is of cour

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread David Miller
From: Rainer Orth Date: Mon, 12 Nov 2012 16:46:37 +0100 > Eric Botcazou writes: > >>> No, quite the contrary. as is just a (sometimes partial) backport of >>> Studio fbe, though it's hard to tell exactly which Studio version of fbe >>> forms the basis of as. Especially for the Solaris 10 as p

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread David Miller
From: Eric Botcazou Date: Mon, 12 Nov 2012 09:35:48 +0100 >> I strongly doubt that they will be different from the options >> supported both in cc and fbe in the Solaris Studio 12.3 release: > > They need to provide some form of backward compatibility though, they cannot > break the interface o

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread David Miller
From: Richard Henderson Date: Mon, 12 Nov 2012 09:56:21 -0800 > On 10/22/2012 08:39 PM, David Miller wrote: >> + /* Compare and Branch is limited to +-2KB. If it is too far away, >> + change >> + >> + cxbne X, Y, .LC30 >> + >> + to >> + >> + cxbe X, Y, .+12 >> + ba,pt xcc, .

[PATCH] Fix some VEC_COND_EXPR ICEs (PR tree-optimization/55281)

2012-11-12 Thread Jakub Jelinek
Hi! This patch fixes two ICEs on the testcases, one is ICE in expand_vector_condition which wouldn't handle VECTOR_CST as first argument of VEC_COND_EXPR (plus a change to make sure it is folded earlier if possible), and the vectorizable_condition change makes sure the condition is actually using

Re: [patch] PR51477

2012-11-12 Thread Richard Henderson
On 11/12/2012 01:04 AM, Steven Bosscher wrote: > gcc/ > PR rtl-optimization/51447 > * df-scan.c (df_get_entry_block_def_set): Add global regs to the set. > * df-problems.c (df_lr_local_compute): Make global regs always live. > * dce.c (deletable_insn_p): Make insns setting a

[PATCH] Fix force_nonfallthru_and_redirect with asm goto (PR rtl-optimization/54127)

2012-11-12 Thread Jakub Jelinek
Hi! The following testcase was ICEing on powerpc64-linux. While force_nonfallthru_and_redirect properly adjusted the LABEL_REFs in asm goto from the old fallthru block to a new one, it didn't adjust LABEL_NUSES and didn't adjust JUMP_LABEL resp. REG_LABEL_TARGET. Fixed thusly, bootstrapped/regtes

Re: [PATCH] Fix some VEC_COND_EXPR ICEs (PR tree-optimization/55281)

2012-11-12 Thread Richard Henderson
On 11/12/2012 11:43 AM, Jakub Jelinek wrote: > 2012-11-12 Jakub Jelinek > > PR tree-optimization/55281 > * tree-vect-generic.c (expand_vector_condition): Accept any > is_gimple_val rather than just SSA_NAME if not COMPARISON_CLASS_P. > * fold-const.c (fold_ternary_loc):

Re: [PATCH] Fix force_nonfallthru_and_redirect with asm goto (PR rtl-optimization/54127)

2012-11-12 Thread Richard Henderson
On 11/12/2012 11:48 AM, Jakub Jelinek wrote: > 2012-11-12 Jakub Jelinek > > PR rtl-optimization/54127 > * cfgrtl.c (force_nonfallthru_and_redirect): When redirecting > asm goto labels from BB_HEAD (e->dest) to target bb, decrement > LABEL_NUSES of BB_HEAD (e->dest) and i

Re: [asan] Patch - fix an ICE in asan.c

2012-11-12 Thread Markus Trippelsdorf
On 2012.11.12 at 19:02 +0100, Jakub Jelinek wrote: > On Mon, Nov 12, 2012 at 06:13:08PM +0100, Markus Trippelsdorf wrote: > > Another ICE: > > > > % cat test.ii > > int i; > > > > % g++ -faddress-sanitizer -c -g -O1 test.ii > > test.ii:1:7: internal compiler error: Segmentation fault > > int

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread H.J. Lu
On Thu, Nov 1, 2012 at 12:52 PM, wrote: > From: Dodji Seketeli > > Hello, > > The set of patches following this message represents the work that > happened on the asan branch to build up the Address Sanitizer work > started in the Google branch. > > Address Sanitizer (aka asan) is a memory error

Re: [libbacktrace] Use getexecname() on Solaris

2012-11-12 Thread Ian Lance Taylor
On Wed, Nov 7, 2012 at 5:50 AM, Rainer Orth wrote: > Gerald Pfeifer writes: > >> Just a small note, in the following >> >> +#ifdef __FreeBSD__ >> +# define DEFAULT_PROCESS_FILENAME "/proc/curproc/file" >> +#elif defined(HAVE_GETEXECNAME) >> +# define DEFAULT_PROCESS_FILENAME getexecname

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Ian Lance Taylor
On Mon, Nov 12, 2012 at 12:39 PM, H.J. Lu wrote: > > Don't we need a bugzilla component for Sanitizer? "other"? Ian

[v3] remove non-standard name from

2012-11-12 Thread Jonathan Wakely
std::atomic_future was removed by N3170 * include/std/future (atomic_future): Remove declaration of non-standard name. Tested x86_64-linux, committed to trunk, 4.7 to follow. commit 27ccc75ad9c7955aa432f0dc35de94965b7fc3e6 Author: Jonathan Wakely Date: Mon Nov 12 21:37:57 2012

Fix duplicated messages in .ccp dumps

2012-11-12 Thread Eric Botcazou
They show up when a lattice value changed is to CONSTANT. Tested on x86_64-suse-linux, applied on mainline as obvious. 2012-11-12 Eric Botcazou * tree-ssa-ccp.c (dump_lattice_value) : Fix duplication. -- Eric BotcazouIndex: tree-ssa-ccp.c ==

PATCH: PR other/55292: libsanitizer doesn't support x32

2012-11-12 Thread H.J. Lu
Hi, Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Linux/x32. OK to install? Thanks. H.J. -- 2012-11-12 H.J. Lu PR other/55292 * sanitizer_common/sanitizer_linux.cc (internal_mmap): Use __NR_mmap if __

[PATCH] A pass which merges constant stores to bitfields

2012-11-12 Thread Andrew Pinski
Hi, I know we are in stage3, I thought I would send this out now for review as I finally have it ready for consumption as I finally got around to removing the limitation of it only working on big-endian. This pass was originally written by Adam Nemet while he was at Cavium. I modified it to work

Re: [PATCH] A pass which merges constant stores to bitfields

2012-11-12 Thread Andrew Pinski
On Mon, Nov 12, 2012 at 4:50 PM, Andrew Pinski wrote: > Hi, > I know we are in stage3, I thought I would send this out now for > review as I finally have it ready for consumption as I finally got > around to removing the limitation of it only working on big-endian. > This pass was originally wri

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-12 Thread Joseph S. Myers
On Mon, 12 Nov 2012, Andrew Pinski wrote: > Also does gtest support cross testing; that is testing over rsh/ssh > and testing via a simulator? We should require that as a requirement > also when it comes to testing infrastructures. Unfortunately the existing guality tests work by C sources built

[committed] Fix call branch shortening on PA

2012-11-12 Thread John David Anglin
The attached change fixes PR target/55195. A recent change to shorten_branches broke branch shortening on PA. Several years ago we changed to using function calls to estimate the length of the call patterns because the "cond" expressions became unmanageable. The functions returned the maximum cu

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-11-12 Thread Sriraman Tallam
Hi Jason, Made the changes. Also fixed one more segfault bug when ifunc is not supported. Thanks, -Sri. On Sun, Nov 11, 2012 at 9:04 PM, Jason Merrill wrote: > On 11/09/2012 08:33 PM, Sriraman Tallam wrote: >> >> + /* Skip calling decls_match for versioned functions. */ >> +

Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-12 Thread Hans-Peter Nilsson
While the fallout(*) from the libsanitizer commit is handled, it's obvious it should have a noconfigdirs= section in toplevel/configure.ac like the other target libs. Here's what I committed after observing that a cris-elf build passed, where it previously failed building libsanitizer which wrongl

Re: PATCH: PR other/55292: libsanitizer doesn't support x32

2012-11-12 Thread Diego Novillo
On Mon, Nov 12, 2012 at 6:36 PM, H.J. Lu wrote: > Hi, > > Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses > __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Linux/x32. > OK to install? Patches to libsanitizer should be sent upstream. We should only contain a copy of the master in

Re: PATCH: PR other/55292: libsanitizer doesn't support x32

2012-11-12 Thread H.J. Lu
On Mon, Nov 12, 2012 at 6:02 PM, Diego Novillo wrote: > On Mon, Nov 12, 2012 at 6:36 PM, H.J. Lu wrote: >> Hi, >> >> Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses >> __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Linux/x32. >> OK to install? > > Patches to libsanitizer should

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-11-12 Thread Jason Merrill
On 11/12/2012 08:11 PM, Sriraman Tallam wrote: + && !targetm.target_option.function_versions (fn, +TREE_PURPOSE (match))) The second argument should be lined up with the left paren if it's on a different line. Perhaps formatting this as && !(targetm.target_option.f

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-11-12 Thread David Miller
From: Rainer Orth Date: Fri, 26 Oct 2012 11:14:33 +0200 > I tried a bootstrap on Solaris 11.1, but ran into lots of comparison > failures I've not yet investigated. I started working on this patch again, in order to incorporate Richard Henderson's feedback, and I am now getting a comparison fail

Re: PATCH: PR other/55292: libsanitizer doesn't support x32

2012-11-12 Thread Andrew Pinski
On Mon, Nov 12, 2012 at 6:02 PM, Diego Novillo wrote: > On Mon, Nov 12, 2012 at 6:36 PM, H.J. Lu wrote: >> Hi, >> >> Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses >> __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Linux/x32. >> OK to install? > > Patches to libsanitizer should

[PATCH] Include tm_p.h in asan.c

2012-11-12 Thread David Edelsohn
gcc/asan.c probably should have been split into two files because it works at multiple levels. But given that it invokes ASM_GENERATE_INTERNAL_LABEL, it needs to include tm_p.h to include -protos.h. Committed as obvious to allow AIX bootstrap to proceed. * asan.c: Include tm_p.h Index:

RE: [RFC] New feature to reuse one multilib among different targets

2012-11-12 Thread Terry Guo
> -Original Message- > From: Joseph Myers [mailto:jos...@codesourcery.com] > Sent: Saturday, November 10, 2012 12:35 AM > To: Terry Guo > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [RFC] New feature to reuse one multilib among different > targets > > On Fri, 9 Nov 2012, Terry Guo wrote: >

ASAN merge...

2012-11-12 Thread David Miller
This has broken the build on every Linux target that hasn't added the necessary cpu specific code to asan_linux.cc I'm working on the sparc bits, but I'm really surprised this happened.

Committed: Fix PR55257: g++.dg/debug/dwarf2/non-virtual-thunk.C and heads-up target maintainers

2012-11-12 Thread Hans-Peter Nilsson
...those of you who don't have the equivalent of the patch below in your ports, that is. You'll likely only notice through a slightly reduced debugging experience and g++.dg/debug/dwarf2/non-virtual-thunk.C failing. Yes, the docs should mention these functions need to be called IMHO obviously, bu

[PATCH] Get sparc building again after ASAN merge.

2012-11-12 Thread David Miller
libsanitizer/ * asan/asan_linux.cc (GetPcSpBp): Add sparc support. --- libsanitizer/ChangeLog.asan | 4 libsanitizer/asan/asan_linux.cc | 14 ++ 2 files changed, 18 insertions(+) diff --git a/libsanitizer/ChangeLog.asan b/libsanitizer/ChangeLog.asan index 7fe3c0c..

Re: PATCH: PR other/55292: libsanitizer doesn't support x32

2012-11-12 Thread H.J. Lu
On Mon, Nov 12, 2012 at 6:59 PM, Andrew Pinski wrote: > On Mon, Nov 12, 2012 at 6:02 PM, Diego Novillo wrote: >> On Mon, Nov 12, 2012 at 6:36 PM, H.J. Lu wrote: >>> Hi, >>> >>> Linux/x32 doesn't have __NR_mmap2/__NR_fstat64 and uses >>> __NR_mmap/__NR_fstat, just like Linux/x86-64. Tested on Li

Re: Patch: Print SImode register names to force addr32 prefix

2012-11-12 Thread H.J. Lu
On Sun, Nov 11, 2012 at 1:37 PM, H.J. Lu wrote: > On Fri, Nov 9, 2012 at 9:23 AM, Uros Bizjak wrote: >> On Fri, Nov 9, 2012 at 10:17 AM, H.J. Lu wrote: >> >>> Since x32 runs in 64-bit mode, for address -0x4300(%rax), hardware >>> sign-extends displacement from 32-bits to 64-bits and adds it

Re: Patch: Print SImode register names to force addr32 prefix

2012-11-12 Thread Uros Bizjak
On Tue, Nov 13, 2012 at 8:15 AM, H.J. Lu wrote: Since x32 runs in 64-bit mode, for address -0x4300(%rax), hardware sign-extends displacement from 32-bits to 64-bits and adds it to %rax. But x32 wants 32-bit -0x4300, not 64-bit -0x4300. This patch uses 32-bit regis

Re: [PATCH] Include tm_p.h in asan.c

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 10:13:08PM -0500, David Edelsohn wrote: > gcc/asan.c probably should have been split into two files because it > works at multiple levels. But given that it invokes > ASM_GENERATE_INTERNAL_LABEL, it needs to include tm_p.h to include > -protos.h. > > Committed as obvious t