On Mon, Nov 12, 2012 at 06:55:32PM +0100, Dodji Seketeli wrote:
> Hello Jack,
>
> Jack Howarth <howa...@bromo.med.uc.edu> writes:
> >>
> >> Dodji,
> >> I am finding that at r193442 bootstrapping on
> >> x86_64-apple-darwin12 fails with...
>
> >> ../../../../gcc-4.8-20121112/libsanitizer/interception/interception_mac.cc:16:41:
> >> fatal error: mach_override/mach_override.h: No such file or directory
> >> #include "mach_override/mach_override.h"
> >> ^
> >> compilation terminated.
>
> Thank you for pointing this out.
>
> > Copying over the lib/interception/mach_override directory from
> > llvm.org's compiler-rt 3.2 branch into libsanitizer/interception allows
> > the build of libsanitizer to proceed. I noticed that the mach_override
> > subdirectory has a license file which shows...
>
> Interesting.
>
> >
> > Copyright (c) 2003-2009 Jonathan 'Wolf' Rentzsch: <http://rentzsch.com>
> > Some rights reserved: <http://opensource.org/licenses/mit-license.php>
> >
> > Hopefully this subdirectory wasn't omitted for licensing reasons because
> > without it the bootstrap on darwin
> > is broken.
>
> Yeah, hopefully.
>
> Wei, is there any reason why the mach_override directory was left out of
> the libsanitizer commit? Maybe I missed something during my patch
> slicing?
Dodji,
I don't see the mach_override directory in the asan gcc branch either so
it appears to have never been ported from llvm's compiler-rt.
Jack
>
> Cheers.
>
> --
> Dodji
