Re: [C++ RFC / Patch] PR 51213 ("access control under SFINAE")

2012-07-14 Thread Paolo Carlini
Hi, and, first, thanks a lot for all the nice work and help on these issues! On 07/13/2012 12:55 AM, Jason Merrill wrote: diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index fec88eb..95c6464 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -8334,7 +8334,7 @@ apply_late_template_attributes (tree *decl_p,

Re: __int256

2012-07-14 Thread Richard Earnshaw
On 14/07/12 04:21, Mike Stump wrote: > On Jul 13, 2012, at 11:28 AM, Steven Bosscher wrote: >> On Fri, Jul 13, 2012 at 8:21 PM, Nathan Froyd wrote: >>> On Fri, Jul 13, 2012 at 10:36:35AM -0700, Mike Stump wrote: I just checked all in tree gcc targets, and none claim OImode support. >>> >>> ./

Re: [Patch, Fortran] PR 51758 - fix ICE with null() in elemental procedures

2012-07-14 Thread Mikael Morin
On 09/01/2012 15:45, Tobias Burnus wrote: > On 01/09/2012 03:34 PM, Mikael Morin wrote: >> The issue is that the code handling NULL() doesn't consume the gfc_ss >> struct created for it. Your fix, which advances to the next one anyway >> would work just well, but I think it is slightly cleaner to n

Re: [patch][fortran] Include coretypes.h in .c files, not in gfortran.h

2012-07-14 Thread Tobias Burnus
Steven Bosscher wrote: On Thu, Jul 12, 2012 at 11:29 AM, Tobias Burnus wrote: On 07/07/2012 11:28 PM, Steven Bosscher wrote: I must say, I am surprised that gfortran.h includes coretypes.h. The idea always was to try and keep the front end and the back end as much separated as possible, and in

Re: [Patch, Fortran] Add parsing support for assumed-rank array

2012-07-14 Thread Mikael Morin
Hello, I somehow was reading this in the standard: "An assumed-rank variable name shall not appear in a designator or expression except as an actual argument corresponding to a dummy argument that is assumed-rank..." with "...except in..." instead of "...except as...". Some of my comments were p

Re: [patch][fortran] Include coretypes.h in .c files, not in gfortran.h

2012-07-14 Thread Steven Bosscher
On Sat, Jul 14, 2012 at 3:23 PM, Tobias Burnus wrote: > Steven Bosscher wrote: >> >> On Thu, Jul 12, 2012 at 11:29 AM, Tobias Burnus wrote: >>> >>> On 07/07/2012 11:28 PM, Steven Bosscher wrote: I must say, I am surprised that gfortran.h includes coretypes.h. The idea always was to

Re: [patch] PR web/53919 - Add note to install.texi

2012-07-14 Thread Jonathan Wakely
Oops, this was meant for gcc-patches not gcc-bugs On 14 July 2012 14:45, Jonathan Wakely wrote: > PR c++/53919 > * doc/install.texi (Installing GCC): Refer to instructions for > released versions. Fix hyphenation. > > Whether or not we want the release-specific installation

Re: [patch] PR web/53919 - Add note to install.texi

2012-07-14 Thread Jonathan Wakely
On 14 July 2012 14:46, Jonathan Wakely wrote: > Oops, this was meant for gcc-patches not gcc-bugs Gah, and then I didn't forward the patch, I seem to have forgotten how to use gmail's UI :-\ Attached this time, here's the original mail again: PR c++/53919 * doc/install.texi (Ins

Re: [patch][fortran] Include coretypes.h in .c files, not in gfortran.h

2012-07-14 Thread Mikael Morin
On 14/07/2012 15:45, Steven Bosscher wrote: > On Sat, Jul 14, 2012 at 3:23 PM, Tobias Burnus wrote: >> Steven Bosscher wrote: >>> >>> On Thu, Jul 12, 2012 at 11:29 AM, Tobias Burnus wrote: On 07/07/2012 11:28 PM, Steven Bosscher wrote: > > I must say, I am surprised that gfortra

Re: [patch][fortran] Include coretypes.h in .c files, not in gfortran.h

2012-07-14 Thread Steven Bosscher
On Sat, Jul 14, 2012 at 4:06 PM, Mikael Morin wrote: > On 14/07/2012 15:45, Steven Bosscher wrote: >> On Sat, Jul 14, 2012 at 3:23 PM, Tobias Burnus wrote: >>> Steven Bosscher wrote: On Thu, Jul 12, 2012 at 11:29 AM, Tobias Burnus wrote: > > On 07/07/2012 11:28 PM, Steven Bossc

Re: [PATCH] Make LTO type merging cheaper

2012-07-14 Thread H.J. Lu
On Fri, Jul 13, 2012 at 1:11 AM, Richard Guenther wrote: > > A patch that's in my local tree for quite some time. This removes > redundant tests. > > LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2012-07-13 Richard Guenther > > * gimple.c (gimple_ty

[Fortran-dev] Merge from the trunk / C_F_Pointer cleanup

2012-07-14 Thread Tobias Burnus
Dear all, I have now merged the trunk into the fortran-dev branch (Rev. 189481). In particular, that brings c_f_pointer support to the branch and fixes some issues. Tobias

Re: [patch] Make asm_out_file a text write-only file again

2012-07-14 Thread Ian Lance Taylor
On Fri, Jul 13, 2012 at 12:30 PM, Steven Bosscher wrote: > > gcc/ > * toplev.c (init_asm_output): Open asm_out_file in 'w' mode. > > c-family/ > * c-pch.c (CHECK_NO_ASM_OUT_DURING_PCH): Do not define. > Remove code conditional on it. This is OK. Thanks. Ian

Re: [PATCH] Make LTO type merging cheaper

2012-07-14 Thread Uros Bizjak
Hello! >> A patch that's in my local tree for quite some time. This removes >> redundant tests. >> >> LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied. >> >> Richard. >> >> 2012-07-13 Richard Guenther >> >> * gimple.c (gimple_types_compatible_p_1): Remove redundant >>

Re: [PATCH] Make LTO type merging cheaper

2012-07-14 Thread H.J. Lu
On Sat, Jul 14, 2012 at 9:27 AM, Uros Bizjak wrote: > Hello! > > >>> A patch that's in my local tree for quite some time. This removes >>> redundant tests. >>> >>> LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied. >>> >>> Richard. >>> >>> 2012-07-13 Richard Guenther >>> >>>

[patch] Remove expand_expr_stmt

2012-07-14 Thread Steven Bosscher
Hello, This patch removes expand_expr_stmt and inlines+folds it into its only user. This relies on TARGET_STACK_PROTECT_FAIL being a CALL_EXPR. The documentation only says "a tree expression that (...) should involve a call to a @code{noreturn} function". I've changed this to explicitly state tha

PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread H.J. Lu
Hi, Revision 189453: http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html removes type attribute comparison in gimple_types_compatible_p_1 and caused PR middle-end/53959 and PR bootstrap/53963. This restores type attribute comparison. Tested on Linux/x86-64. OK to install? Thanks. H.J. ---

Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread Steven Bosscher
On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu wrote: > Hi, > > Revision 189453: > > http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html > > removes type attribute comparison in gimple_types_compatible_p_1 and > caused PR middle-end/53959 and PR bootstrap/53963. This restores type > attribute compariso

[patch] Move 'tree' accessor macros from flags.h to tree.h

2012-07-14 Thread Steven Bosscher
Hello, tree.h can depend on flags.h (and includes it) but flags.h should not depend on tree.h. The attached patch moves some macros from flags.h to tree.h because they use tree accessor macros. Looks quite obvious to me. Bootstrapped&tested on powerpc64-unknown-linux-gnu and on x86_64-unknown-lin

[patch][rft] Don't mess with debug_hooks in objc

2012-07-14 Thread Steven Bosscher
Hello, There is code in objc-act.c to save and restore debug hooks to work around a problem with the C front end. The C front end calls debug hooks before they have been initialized. This is a problem for dbxout, so there is code in dbxout.c to handle the problem, see dbxout.c:preinit_symbols. Th

[patch] Bail out if the same label is emitted twice

2012-07-14 Thread Steven Bosscher
Hello, Just another small cleanup. This probably made sense before function-at-a-time became the norm, 10 years ago. Bootstrapped&tested on powerpc64-unknown-linux-gnu and x86_64-unknown-linux-gnu. OK for trunk? Ciao! Steven * emit-rtl.c (emit_label_before): Do not allow the same label

[PATCH, i386]: Fix ix86_set_reg_reg_cost w.r.t. TFmode

2012-07-14 Thread Uros Bizjak
Hello! Recently, gcc was switched to enable TFmode moves in XMM registers also for TARGET_SSE. Sync reg-reg move cost calculation. 2012-07-14 Uros Bizjak * config/i386/i386.c (ix86_set_reg_reg_cost): Enable TFmode/TCmode for TARGET_SSE. Tested on x86_64-pc-linux-gnu {,-m32},

Re: __int256

2012-07-14 Thread Joseph S. Myers
On Fri, 13 Jul 2012, Mike Stump wrote: > I don't have time to re-implement __int128 support in the compiler for > you. > > So, are there any other specific actionable things I can do for you to > make the patch acceptable? No. The right way to make __int256 support - the feature, not the pres

Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread H.J. Lu
On Sat, Jul 14, 2012 at 11:54 AM, Steven Bosscher wrote: > On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu wrote: >> Hi, >> >> Revision 189453: >> >> http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html >> >> removes type attribute comparison in gimple_types_compatible_p_1 and >> caused PR middle-end/539

Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread H.J. Lu
On Sat, Jul 14, 2012 at 1:23 PM, H.J. Lu wrote: > On Sat, Jul 14, 2012 at 11:54 AM, Steven Bosscher > wrote: >> On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu wrote: >>> Hi, >>> >>> Revision 189453: >>> >>> http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html >>> >>> removes type attribute comparison

Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread Steven Bosscher
On Sat, Jul 14, 2012 at 10:23 PM, H.J. Lu wrote: > On Sat, Jul 14, 2012 at 11:54 AM, Steven Bosscher > wrote: >> On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu wrote: >>> Hi, >>> >>> Revision 189453: >>> >>> http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html >>> >>> removes type attribute comparison

Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

2012-07-14 Thread H.J. Lu
On Sat, Jul 14, 2012 at 1:41 PM, Steven Bosscher wrote: > On Sat, Jul 14, 2012 at 10:23 PM, H.J. Lu wrote: >> On Sat, Jul 14, 2012 at 11:54 AM, Steven Bosscher >> wrote: >>> On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu wrote: Hi, Revision 189453: http://gcc.gnu.org/ml/gcc-

[patch] Remove useless sets/clears of EDGE_CAN_FALLTHRU

2012-07-14 Thread Steven Bosscher
Hello, EDGE_CAN_FALLTHRU is internal to bb-reorder.c, set_edge_can_fallthru_flag() clears it on all edges and computes it fresh for bb-reorder. The test in rtl_verify_flow_info_1 has to stay because bb-reorder doesn't clean up the flag after it's done. Bootstrapped&tested on powerpc64-unknown-li

fix gcc.dg/pr53849.c

2012-07-14 Thread Mike Stump
This test requires pthreads, so, I've copied bits from another testcase that uses -pthreads in the same way. Checked it in. diff --git a/gcc/testsuite/gcc.dg/pr53849.c b/gcc/testsuite/gcc.dg/pr53849.c index 3b67010..eddc45f 100644 --- a/gcc/testsuite/gcc.dg/pr53849.c +++ b/gcc/testsuite/gcc.dg/p

Re: [PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

2012-07-14 Thread H.J. Lu
On Wed, Apr 25, 2012 at 12:14 PM, Jakub Jelinek wrote: > Hi! > > We have a splitter for reg1 = reg2 & 0x, but only if regnums > are different. But movl %edi, %edi is a cheaper variant of > andq $0x, %rdi even with the same register and doesn't clobber > flags, so this patch attemp

PATCH: fix typos in SH_ASM_SPEC

2012-07-14 Thread Sandra Loosemore
We've had this patch to add missing whitespace to the assembler spec string in the SH back end in our local tree for a couple of years. I think it's obvious enough that I've gone ahead and checked it in on mainline too. -Sandra 2012-07-14 Andrew Stubbs Sandra Loosemore

Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.

2012-07-14 Thread Tom Tromey
> "Eli" == Eli Zaretskii writes: Eli> I understand all that, but why would the eq_f function need to be an Eli> external function on its own? It is just to avoid other users having to write their own. Eli> E.g., if we were to write a qsort replacement, would we have a Eli> suitable string c

[Fortran-dev][Patch, Fortran] C_F_Pointer cleanup

2012-07-14 Thread Tobias Burnus
Dear all, that's a follow up cleanup to the patch, which has just been merged. Most parts should be really obvious and nice, however, the offset part isn't. As the offset is not part of the descriptor defined at DTS 29113:2012's "8.2 C descriptors" (p. 17), we will have to drop it at some poi