Hello!

>> A patch that's in my local tree for quite some time.  This removes
>> redundant tests.
>>
>> LTO bootstrapped and tested on x86_64-unknown-linux-gnu, applied.
>>
>> Richard.
>>
>> 2012-07-13  Richard Guenther  <rguent...@suse.de>
>>
>>         * gimple.c (gimple_types_compatible_p_1): Remove redundant
>>         type attribute comparisons.
>>         (gimple_canonical_types_compatible_p): Likewise.
>>
>
> I don't see why this is redundant since attributes aren't checked anywhere
> else.  Revert this part fixes:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53959

This patch also breaks LTO profiledbootstrap [1].

Even simple hello world compilation breaks at:

Starting program: /home/uros/gcc-build-fast/gcc/cc1 -O2 hello.c

Program received signal SIGSEGV, Segmentation fault.
update_path (path=path@entry=0xe8f775 "/usr/local/include", key=0x0)
at ../../gcc-svn/trunk/gcc/prefix.c:260
260           if (key[0] != '$')
Missing separate debuginfos, use: debuginfo-install
gmp-5.0.2-6.fc17.x86_64 libmpc-0.9-2.fc17.2.x86_64
mpfr-3.1.0-2.fc17.x86_64
(gdb) bt
#0  update_path (path=path@entry=0xe8f775 "/usr/local/include",
key=0x0) at ../../gcc-svn/trunk/gcc/prefix.c:260
#1  0x0000000000cb1545 in add_standard_paths (cxx_stdinc=0,
imultilib=0x0, iprefix=0x0, sysroot=0x0)
    at ../../gcc-svn/trunk/gcc/incpath.c:204
#2  register_include_chains (pfile=0x13cce70, sysroot=<optimized out>,
iprefix=0x0, imultilib=0x0, stdinc=1, cxx_stdinc=0,
    verbose=0) at ../../gcc-svn/trunk/gcc/incpath.c:462
#3  0x0000000000ba9a30 in c_common_post_options (pfilename=0x138e130)
at ../../gcc-svn/trunk/gcc/c-family/c-opts.c:894
#4  0x0000000000c5dd52 in process_options () at
../../gcc-svn/trunk/gcc/toplev.c:1212
#5  do_compile () at ../../gcc-svn/trunk/gcc/toplev.c:1832
#6  toplev_main(int, char**) (argc=3, argv=0x7fffffffddd8) at
../../gcc-svn/trunk/gcc/toplev.c:1939
#7  0x000000330bc21735 in __libc_start_main (main=0x74be10 <main>,
argc=3, ubp_av=0x7fffffffddd8, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>,
stack_end=0x7fffffffddc8) at libc-start.c:226
#8  0x0000000000a76075 in _start ()

The guard "&& key != 0" above the segfault is simply ignored.

[1] http://gcc.gnu.org/ml/gcc-regression/2012-07/msg00067.html

Uros.

Reply via email to