Re: [i386, patch, RFC] HLE support in GCC

2012-04-18 Thread Sergey Ostanevich
On Tue, Apr 17, 2012 at 6:41 PM, Andi Kleen wrote: >> I also have a question regarding AS compatibility. In case one built >> GCC using AS with support of HLE then using this GCC on a machine with >> old AS will cause fail because of usupported prefix. Can we support it > > I don't think that's a

PING: [PATCH] Fix PRs c/52283/37985

2012-04-18 Thread Christian Bruel
http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00191.html and discussed in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52283 I would like to close the associated PRs to fix a few discrepancies with the folding of constant expressions warnings. Original patch from Manu was slightly modified to refl

[PATCH] Fix out-of-bound array accesses in testcases

2012-04-18 Thread Richard Guenther
So, a patch of mine runs into the following testsuite issues. Fixed with the following patch, tested on x86_64-unknown-linux-gnu and committed. Richard. 2012-04-18 Richard Guenther * gcc.target/x86_64/abi/test_passing_unions.c: Avoid undefined array access. * gcc.tar

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-18 Thread Kirill Yukhin
http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00511.html

Re: [Fixinclude]: Fix typo and default to twoprocess on VMS

2012-04-18 Thread Tristan Gingold
On Apr 17, 2012, at 4:21 PM, Bruce Korb wrote: > Hi Tristan, > > On Tue, Apr 17, 2012 at 5:57 AM, Tristan Gingold wrote: >> Hi, >> >> one-process methodology cannot be used on VMS[...] >> But, when twoprocess is selected, gcc emits a warning[...] >> Ok for trunk ? > >> diff --git a/fixinclude

Re: [PATCH] Allow un-distribution with repeated factors (PR52976 follow-up)

2012-04-18 Thread Richard Guenther
On Tue, 17 Apr 2012, William J. Schmidt wrote: > The emergency reassociation patch for PR52976 disabled un-distribution > in the presence of repeated factors to avoid ICEs in zero_one_operation. > This patch fixes such cases properly by teaching zero_one_operation > about __builtin_pow* calls. >

Re: [PATCH] Fix __builtin_powi placement (PR52976 follow-up)

2012-04-18 Thread Richard Guenther
On Tue, 17 Apr 2012, William J. Schmidt wrote: > The emergency patch for PR52976 manipulated the operand rank system to > force inserted __builtin_powi calls to occur before uses of the call > results. However, this is generally the wrong approach, as it forces > other computations to move unnece

Re: [PATCH][ARM][Testsute] Skip thumb1 test in non-thumb1 target

2012-04-18 Thread Ramana Radhakrishnan
On 18 April 2012 04:02, Joey Ye wrote: > Fix the test case failed in ARM state. > >        * gcc.target/arm/thumb1-imm.c: Skip it in non-thumb1 target > > Index: gcc/testsuite/gcc.target/arm/thumb1-imm.c > === > --- gcc/testsuite/gcc.

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Richard Guenther
On Tue, Apr 17, 2012 at 6:15 PM, Steven Bosscher wrote: >> My goal for GCC 4.8 is to do just that: Move switch expansion to >> GIMPLE and add value profiling for switch expressions. > > And the idea is to put all that code in tree-switch-conversion.c. But > there are a few clean-ups I wish to do o

Re: [Fortran] Patch ping

2012-04-18 Thread Janne Blomqvist
On Mon, Apr 16, 2012 at 11:03, Tobias Burnus wrote: > Other patches with pending review: > - [Patch, libfortran] Combine get_mem and internal_malloc_size >  http://gcc.gnu.org/ml/fortran/2012-03/msg00127.html As I said in the original submission, "While the patch is large, it's also mechanical, h

Re: PING: [PATCH] Fix PRs c/52283/37985

2012-04-18 Thread Manuel López-Ibáñez
On 18 April 2012 10:29, Christian Bruel wrote: > > Is it OK for trunk, bootstrapped and regtested on x86 I think Joseph Myers is on vacation, and there are no other C FE reviewers, but since this is c-common and convert.c, perhaps Jason and/or Richard can review it? Thanks, Manuel.

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Richard Guenther
On Wed, 18 Apr 2012, Steven Bosscher wrote: > Hello, > > This is another step towards moving GIMPLE_SWITCH expansion to an > earlier point in the pipeline. > > With the attached patch, some of the logic from stmt.c:add_case_node() > is moved to gimplify.c:gimplify_switch_expr(). This includes: >

Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-18 Thread Richard Guenther
On Wed, Apr 18, 2012 at 4:15 AM, Maxim Kuvyrkov wrote: > Steven, > J"orn, > > I am looking into fixing performance regression on EEMBC's bitmnp01, and a > version of your combined patch attached to PR38785 still works very well.   > Would you mind me getting it through upstream review, or are the

Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-18 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 4:15 AM, Maxim Kuvyrkov wrote: > I am looking into fixing performance regression on EEMBC's bitmnp01, and a > version of your combined patch attached to PR38785 still works very well.   > Would you mind me getting it through upstream review, or are there any issues > with

[PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Kirill Yukhin
Hello guys, Since there is no more objections to my RFC, started here [1], I've implemented rest __atomic builtins in the same way. It corresponds to Spec, which can be found here [2]. Patch attached. ChangeLog entry: 2012-04-18 Kirill Yukhin * builtins.c (get_memmodel): Remove check

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Kirill Yukhin
Forgot to attach the patch :) On Wed, Apr 18, 2012 at 1:34 PM, Kirill Yukhin wrote: > Hello guys, > Since there is no more objections to my RFC, started here [1], > I've implemented rest __atomic builtins in the same way. > It corresponds to Spec, which can be found here [2]. > > Patch attached.

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Rainer Orth
Kirill Yukhin writes: > Forgot to attach the patch :) Just a nit: you're using `prefixies' throughout the patch. I guess this should be `prefixes' instead. Rainer -- - Rainer Orth, Center for Biotechnology, B

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Kirill Yukhin
Whoops, thank you. I'll fix it K On Wed, Apr 18, 2012 at 1:44 PM, Rainer Orth wrote: > Kirill Yukhin writes: > >> Forgot to attach the patch :) > > Just a nit: you're using `prefixies' throughout the patch.  I guess this > should be `prefixes' instead. > >        Rainer > > -- > ---

Re: PING: [PATCH] Fix PRs c/52283/37985

2012-04-18 Thread Richard Guenther
On Wed, Apr 18, 2012 at 11:06 AM, Manuel López-Ibáñez wrote: > On 18 April 2012 10:29, Christian Bruel wrote: >> >> Is it OK for trunk, bootstrapped and regtested on x86 > > I think Joseph Myers is on vacation, and there are no other C FE > reviewers, but since this is c-common and convert.c, per

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Uros Bizjak
On Wed, Apr 18, 2012 at 11:34 AM, Kirill Yukhin wrote: > Hello guys, > Since there is no more objections to my RFC, started here [1], > I've implemented rest __atomic builtins in the same way. > It corresponds to Spec, which can be found here [2]. Can you please implement printing of HLE prefix w

Re: [C++ Patch] PR 52422 (new patch)

2012-04-18 Thread Paolo Carlini
Hi again, Hi Jason, I have a new patch for this issue, another SFINAE issue noticed by Daniel. Compared to the last version, I extended the complain-ization ;) to a few more functions in typeck.c (I think the set is more consistent now) and thoroughly double checked that the return values of

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 11:10 AM, Richard Guenther wrote: > I wonder about > > @@ -1575,6 +1575,9 @@ gimplify_switch_expr (tree *expr_p, gimple_seq *pr >   tree switch_expr = *expr_p; >   gimple_seq switch_body_seq = NULL; >   enum gimplify_status ret; > +  tree index_type = TREE_TYPE (switch_expr

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Richard Guenther
On Wed, 18 Apr 2012, Steven Bosscher wrote: > On Wed, Apr 18, 2012 at 11:10 AM, Richard Guenther wrote: > > I wonder about > > > > @@ -1575,6 +1575,9 @@ gimplify_switch_expr (tree *expr_p, gimple_seq *pr > >   tree switch_expr = *expr_p; > >   gimple_seq switch_body_seq = NULL; > >   enum gimplif

[PATCH][1/2] Fix PR44688, set and preserve the maximum iterations of vectorizer prologue loops

2012-04-18 Thread Richard Guenther
Finally. Boostrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-04-18 Richard Guenther PR tree-optimization/44688 * cfgloop.h (record_niter_bound): Declare. * tree-ssa-loop-niter.c (record_niter_bound): Export. Update the estimati

Re: ARM hard-float linker path - consensus

2012-04-18 Thread Steve McIntyre
On Fri, Apr 13, 2012 at 06:37:11PM +0100, Steve McIntyre wrote: >Hi folks, > >As promised, here's minutes from the call we had this >afternoon. Spoiler: the result we've agreed is > > /lib/ld-linux-armhf.so.3 > >And here's a transcription of the minutes from > > https://wiki.linaro.org/OfficeofCT

Re: [google/integration] Add -Xclang-only option (issue6047048)

2012-04-18 Thread Diego Novillo
On Tue, Apr 17, 2012 at 23:38, Ollie Wild wrote: > 2012-04-17   Ollie Wild   > >        * gcc/common.opt (Xclang-only): New option. >        * gcc/doc/invoke.texi (Xclang-only): Document new option. >        * gcc/gcc.c (display_help): Print new option. >        (driver_handle_option): Support ne

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Andrew MacLeod
Stupid mailer.. sigh. trying again: On 04/18/2012 05:36 AM, Kirill Yukhin wrote: op = expand_normal (exp); - if (INTVAL (op) < 0 || INTVAL (op) >= MEMMODEL_LAST) + if (INTVAL (op) < 0) { warning (OPT_Winvalid_memory_model, "invalid memory model argument to builtin"

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Kirill Yukhin
Sure, thanks for prompt! On Wed, Apr 18, 2012 at 2:12 PM, Uros Bizjak wrote: > On Wed, Apr 18, 2012 at 11:34 AM, Kirill Yukhin > wrote: >> Hello guys, >> Since there is no more objections to my RFC, started here [1], >> I've implemented rest __atomic builtins in the same way. >> It corresponds

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Kirill Yukhin
On Wed, Apr 18, 2012 at 5:32 PM, Andrew MacLeod wrote: > Stupid mailer.. sigh.  trying again: > > > On 04/18/2012 05:36 AM, Kirill Yukhin wrote: > >>   op = expand_normal (exp); >> -  if (INTVAL (op) < 0 || INTVAL (op) >= MEMMODEL_LAST) >> +  if (INTVAL (op) < 0) >>     { >>       warning (OPT_Win

[PATCH][2/2] Fix PR44688, use the recorded maximum iterations in the unroller

2012-04-18 Thread Richard Guenther
This teaches loop-iv (RTL IV analysis) about loop->nb_iterations_upper_bound. It avoids poinless unrolling of vectorizer prologue loops for now. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2012-04-18 Richard Guenther PR rtl-optimization/44688 * loop-i

Re: [PATCH, i386, middle-end, tessuite] Intel TSX's HLE.

2012-04-18 Thread Jakub Jelinek
On Wed, Apr 18, 2012 at 06:16:02PM +0400, Kirill Yukhin wrote: > > In any case, I think it ought to check that the 16 reserved bits for memory > > model is correct (like it use to for the whole enum), and if it isn't, issue > > the warning and mask in SEQ_CST for the memory model portion. > Good po

[PATCH, alpha]: Fix atomic_ior_* pattern name

2012-04-18 Thread Uros Bizjak
Hello! This patch fixes alpha atomic_or vs atomic_ior confusion. 2012-04-18 Uros Bizjak * config/alpha/sync.md (fetchop_name): Change ior attribute to "or". Tested on alphaev68-pc-linux-gnu, committed to mainline and 4.7 branch. Uros. Index: config/alpha/sync.md

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 1:23 PM, Richard Guenther wrote: > I suppose generic tree handling routines are confused by NULL TREE_TYPE > and thus changing the docs to void_type_node would be more appropriate. I don't agree with that. The documented behavior is much older than either the Fortran or th

[patch] Fix CASE_LABEL_EXPR documentation in tree.def and tree-cfg.c

2012-04-18 Thread Steven Bosscher
Subject says all. Will commit as obvious. * tree.def (CASE_LABEL_EXPR): Fix documentation, mention all operands. * tree-cfg.c (edge_to_cases): Fix documentation. Index: tree.def === --- tree.def(revision 186526) +

Re: Continue strict-volatile-bitfields fixes

2012-04-18 Thread Thomas Schwinge
Hi! As it's been some time: this was the discussion about -fstrict-volatile-bitfields (as enabled by default on SH, for example) breaking some testsuite bits due to missed optimizations (even for bitfields that are not volatile). On Tue, 21 Feb 2012 09:40:07 +, Richard Earnshaw wrote: > On 2

Re: Continue strict-volatile-bitfields fixes

2012-04-18 Thread Richard Earnshaw
On 18/04/12 16:37, Thomas Schwinge wrote: > Hi! > > As it's been some time: this was the discussion about > -fstrict-volatile-bitfields (as enabled by default on SH, for example) > breaking some testsuite bits due to missed optimizations (even for > bitfields that are not volatile). > > On Tue, 2

Re: Continue strict-volatile-bitfields fixes

2012-04-18 Thread Bernd Schmidt
On 04/18/2012 06:14 PM, Richard Earnshaw wrote: > On 18/04/12 16:37, Thomas Schwinge wrote: >> gcc/testsuite/ >> * gcc.dg/tree-ssa/20030922-1.c: Compile with >> -fno-strict-volatile-bitfields. >> * gcc.dg/tree-ssa/foldconst-3.c: Likewise. >> * gcc.dg/tree-ssa/vrp15.c: Likewise.

[PATCH] Add -fdump-rtl--quiet

2012-04-18 Thread Andrew Stubbs
This patch scratches an itch I've had for a while. Basically it just reduces all tree and RTL dumps to just the function dump. This means that the files are easier to diff. This can still be combined with the other options of course: e.g. -fdump-rtl-all-quiet-slim is quite nice. Obviously,

Re: Wider modes for partial int modes

2012-04-18 Thread Richard Henderson
On 04/17/2012 04:08 PM, Bernd Schmidt wrote: > * machmode.h (CLASS_HAS_WIDER_MODES_P): True for MODE_PARTIAL_INT. > * expr.c (convert_move): Honor unsignedp when extending partial int > modes. > * genmodes.c (power_of_two_p, regular_mode, make_complex_modes, > emit_mod

Re: [Fortran] Patch ping

2012-04-18 Thread Bernhard Reutner-Fischer
On Tue, Apr 17, 2012 at 12:47:48AM +0200, Tobias Burnus wrote: >Approved but not yet committed: >Bernhard: >- [PATCH] gfortran testsuite: implicitly cleanup-modules, part 2 > http://gcc.gnu.org/ml/fortran/2012-04/msg00065.html Before actually pushing this, I ment to ask if we *want* to make sur

Symbol table 9/many: symtab verifier

2012-04-18 Thread Jan Hubicka
Hi, this patch introduce symbol table verificatoin facility. In addition to what can be broken out of cgraph verifier, the assembler hash consistency is checked. The patch also fixes one latent LTO bug caught by the verifier where we did not dissolve varpool same comdat group lists when bringing v

[C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
Hi, thus I'm handling this issue per the discussion in the audit trail: by adding a tsubst_flags_t parameter to 'joust' and 'tourney' and adjusting the callers. Then 'joust' deals with SFINAE as-if pedantic mode were unconditionally active. Tested x86_64-linux. Thanks, Paolo. /

Re: [PATCH] Add -fdump-rtl--quiet

2012-04-18 Thread Xinliang David Li
Why only rtl? Minor suggestion: use ir or il may be more intuitive: -fdump-rtl-all-ir thanks, David On Wed, Apr 18, 2012 at 9:35 AM, Andrew Stubbs wrote: > This patch scratches an itch I've had for a while. > > Basically it just reduces all tree and RTL dumps to just the function dump. > This m

[PATCH][Cilkplus] Fixing function param of is_elem_fn

2012-04-18 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilkplus branch affecting both C and C++ compilers. This patch will change the parameter from cgraph_node * to tree of type function declaration. Thanks, Balaji V. Iyer. diff --git a/gcc/ChangeLog.cilk b/gcc/ChangeLog.cilk index 6078abf..8627920 100644

Re: [Fixinclude]: Fix typo and default to twoprocess on VMS

2012-04-18 Thread Bruce Korb
Hi, When I approved a patch in 2008, there was a typo. I didn't notice and it was "fixed" by removing a formatting element. Your patch corrects the error. Please apply your changes to active branches. Thank you! Regards, Bruce

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 5:17 PM, Steven Bosscher wrote: > On Wed, Apr 18, 2012 at 1:23 PM, Richard Guenther wrote: >> I suppose generic tree handling routines are confused by NULL TREE_TYPE >> and thus changing the docs to void_type_node would be more appropriate. > > I don't agree with that. The

Re: [patch] Cleanup tree-switch-conversion a bit

2012-04-18 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 8:30 PM, Steven Bosscher wrote: > The Go bits approved on IRC by Iant, the Fortran bits are obvious, and > the rest was already approved. This is r186579 now. And because I managed to commit from the wrong tree, the fixed commit is r186580. Index: gimplify.c =

Re: [C++ Patch] PR 52363

2012-04-18 Thread Jason Merrill
On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can get away with checking LOOKUP_COMPLAIN; for p

[RFA] dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index.

2012-04-18 Thread Doug Evans
Hi. This patch adds DW_OP_GNU_addr_index to dwarf2.h. Ok to commit? 2012-04-18 Doug Evans * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index. Index: include/dwarf2.h === RCS file: /cvs/src/src/include/dwarf2.h,v

Re: Remove SETJMP_VIA_SAVE_AREA support

2012-04-18 Thread Mike Stump
On Jun 2, 2011, at 3:41 AM, Eric Botcazou wrote: > This removes the (undocumented) support for SETJMP_VIA_SAVE_AREA from the > compiler. > 2011-06-02 Eric Botcazou > * builtins.c (expand_builtin_setjmp_setup): Do not set calls_setjmp. > --- builtins.c(revision 174559) > +++ bui

Re: [PATCH] Add -fdump-rtl--quiet

2012-04-18 Thread Andrew Stubbs
On 18/04/12 19:00, Xinliang David Li wrote: Why only rtl? Minor suggestion: use ir or il may be more intuitive: -fdump-rtl-all-ir It isn't only RTL. It also applies to the tree dumps. I did say so in my message, although all the examples were RTL. Also, "ir" and "il" are not more intuitive t

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
Hi On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can get away with checking LOOKUP_COMPLAIN; fo

Re: [Fortran] Patch ping

2012-04-18 Thread Mike Stump
On Apr 18, 2012, at 9:57 AM, Bernhard Reutner-Fischer wrote: > Before actually pushing this, I ment to ask if we *want* to make > sure that we do not add superfluous cleanup-module calls in the > future (which would slow down testing needlessly)? I'd run you script again in another 6 months, and o

New Swedish PO file for 'gcc' (version 4.7.0)

2012-04-18 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Swedish team of translators. The file is available at: http://translationproject.org/latest/gcc/sv.po (This file, 'gcc-4.7.0.sv.po', has just

Re: [patch] Fix CASE_LABEL_EXPR documentation in tree.def and tree-cfg.c

2012-04-18 Thread Tom Tromey
> "Steven" == Steven Bosscher writes: Steven> Subject says all. Will commit as obvious. Steven> * tree.def (CASE_LABEL_EXPR): Fix documentation, mention all operands. Thank you. Tom

Re: [PATCH] Add -fdump-rtl--quiet

2012-04-18 Thread Xinliang David Li
On Wed, Apr 18, 2012 at 12:42 PM, Andrew Stubbs wrote: > On 18/04/12 19:00, Xinliang David Li wrote: >> >> Why only rtl? Minor suggestion: use ir or il may be more intuitive: >> -fdump-rtl-all-ir > > > It isn't only RTL. It also applies to the tree dumps. I did say so in my > message, although all

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
Hi again, Thus, if I don't ear from you, I'm probably going to add complain to build_user_type_conversion_1, hopefully I can manage, I remember that earlier today I tried and was dragging in a lot of changes... The below adds complain to build_user_type_conversion_1 and build_user_type_conversi

[Patch, fortran] PR 49010/24518 MOD/MODULO fixes, take 2

2012-04-18 Thread Janne Blomqvist
Hi, the attached patch implements a few fixes and cleanups for the MOD and MODULO intrinsics. - When the arguments are constant, use mpfr_fmod instead of the naive algorithms which are numerically unstable for large arguments. This extends the PR 24518 fix to constant arguments as well, and makes

[Patch, libfortran] Fix handling of temporary files

2012-04-18 Thread Janne Blomqvist
Hi, the attached patch implements some fixes for handling STATUS="SCRATCH" files. - Currently, we check GFORTRAN_TMPDIR, TMP, and TEMP environment variables, but not the POSIX and GNU standard TMPDIR. As specifying a temporary directory depending on the compiler used to create an application does

Re: [Patch, libfortran] Fix handling of temporary files

2012-04-18 Thread Manfred Schwarb
Hi Janne, - If the program is privileged, we shouldn't trust path style environment variables. The patch fixes this for TMPDIR and also for the logic figuring out where addr2line is. I did not test it, but if I remember right, the use of geteuid() and friends does prevent static compilation,

Re: Support for Runtime CPU type detection via builtins (issue5754058)

2012-04-18 Thread Sriraman Tallam
Ping. On Thu, Apr 12, 2012 at 4:14 PM, Sriraman Tallam wrote: > Ping. > > On Tue, Apr 3, 2012 at 12:47 PM, Sriraman Tallam wrote: >> Hi, >> >> i386 maintainers -  Is this patch ok? >> >> Thanks, >> -Sri. >> >> On Mon, Apr 2, 2012 at 5:48 PM, Sriraman Tallam wrote: >>> On Mon, Apr 2, 2012 at 5:3

Re: [C++ Patch] PR 52363

2012-04-18 Thread Paolo Carlini
On 04/18/2012 09:00 PM, Jason Merrill wrote: On 04/18/2012 01:44 PM, Paolo Carlini wrote: + cand = tourney (candidates, tf_warning_or_error); This seems unlikely to do the right thing; we can get here in both SFINAE and non-SFINAE situations. In build_user_type_conversion_1 I think we can

Re: [C++ Patch] PR 52363

2012-04-18 Thread Jason Merrill
On 04/18/2012 08:30 PM, Paolo Carlini wrote: Thus, it seems to me that with above change it's just that we don't have any hope of fixing latent SFINAE bugs in turney called by build_user_type_conversion_1 per the above. And, at this time, we don't have any evidence of such bugs. We've just been