Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Paolo Carlini
On 10/20/2011 12:32 AM, Jason Merrill wrote: Surely we should only make this change for function members. Thanks Gaby and Jason. So, what about the below? Tested x86_64-linux. Paolo. /cp 2011-10-19 Paolo Carlini PR c++/31423 PR c++/48630 * type

Re: [SH] PR 50694 - SH2A little endian does not actually work

2011-10-19 Thread Kaz Kojima
Oleg Endo wrote: > the attached patch addresses PR 50694 and also does some cleanups in > sh.md. > > I haven't run the testsuite with this one since it's basically just text > replacements, except for the changed cmpgeusi_t insn. However, CSiBE > didn't show any code size changes with the change

Re: new patches using -fopt-info (issue5294043)

2011-10-19 Thread Rong Xu
OK. I'll keep it in mind. We probably won't include all the messages in one shot. But we do plan to add all of them finally because we believe they are helpful for tracking the performance. -Rong On Wed, Oct 19, 2011 at 4:33 PM, Andi Kleen wrote: > x...@google.com (Rong Xu) writes: > >> After so

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Gabriel Dos Reis
On Wed, Oct 19, 2011 at 6:36 PM, Paolo Carlini wrote: > On 10/20/2011 12:32 AM, Jason Merrill wrote: >> >> Surely we should only make this change for function members. > > Thanks Gaby and Jason. So, what about the below? I believe the effect of your new patch is that if will always emit the sugge

Avoid -mno-accumulate-outgoing-args in tests on Windows target

2011-10-19 Thread Joseph S. Myers
The -mno-accumulate-outgoing-args option does not work with the stack probing used on Windows targets, giving a warning and so causing tests using that option to fail. This patch makes three tests not use that option on affected targets, like sse-10.c (see

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Paolo Carlini
On 10/20/2011 02:00 AM, Gabriel Dos Reis wrote: I believe the effect of your new patch is that if will always emit the suggest "did you forget "()"?" for member functions, even in the case where the current suggestion is correct. Using the type context would prevent that regression. If you could

Re: [SH] PR 50694 - SH2A little endian does not actually work

2011-10-19 Thread Oleg Endo
On Thu, 2011-10-20 at 08:40 +0900, Kaz Kojima wrote: > The patch makes 4 logically separable changes into one. It'd > be better to split it to 4 independent patches. > The changes except cmpgeusi_t look essentially OK to me. But > please test them as usual for both endian. Sure, no problem. Wi

[cxx-mem-model] compare_exchange implementation II

2011-10-19 Thread Andrew MacLeod
OK, here's the updated patch. I also made the changes to the C++ include files to use __atomic_compare_exchange in the header file. I think I covered everything that was mentioned previously... Bootstraps and no new regressions on x86_64-unknown-linux-gnu. Andrew * optabs.h (direct_o

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Gabriel Dos Reis
On Wed, Oct 19, 2011 at 7:09 PM, Paolo Carlini wrote: > On 10/20/2011 02:00 AM, Gabriel Dos Reis wrote: >> >> I believe the effect of your new patch is that if will >> always emit the suggest "did you forget "()"?" for member functions, >> even in the case where the current suggestion is correct.

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Gabriel Dos Reis
On Wed, Oct 19, 2011 at 7:47 PM, Gabriel Dos Reis wrote: > On Wed, Oct 19, 2011 at 7:09 PM, Paolo Carlini > wrote: >> On 10/20/2011 02:00 AM, Gabriel Dos Reis wrote: >>> >>> I believe the effect of your new patch is that if will >>> always emit the suggest "did you forget "()"?" for member funct

Re: [C++ Patch] PR 48630 (PR 31423)

2011-10-19 Thread Paolo Carlini
Hi, I think I made a suggestion in my previous message: -- decouple this particular diagnostic from 'incomplete type' error. Because it has nothing to do with incomplete type error. -- once the diagnostic is decoupled, you could "grep" for all the places where cxx_incomplete_type_e

Re: [v3] tr2: bool_set, dynamic_bitset, ratio

2011-10-19 Thread Ed Smith-Rowland
On 10/19/2011 06:48 PM, Benjamin Kosnik wrote: Hi Edward! I have reviewed and selectively merged your development branch, libstdcxx-tr2-ideas-branch, into trunk. As ISO C++ is now looking at new library efforts for TR2 (and N2965 has already been checked in to trunk) I thought it well-timed. Pl

[PATCH] Use can_create_pseudo_p() in the sparc backend.

2011-10-19 Thread David Miller
Committed to trunk. gcc/ * config/sparc/sparc.c (sparc_expand_move): Use can_create_pseudo_p. (sparc_emit_set_const32): Likewise. (sparc_emit_set_const64_longway): Likewise. (sparc_emit_set_const64): Likewise. (sparc_legitimize_pic_address): Likewi

Re: [PATCH, i386, PR50766] Fix incorrect mem/reg operands order

2011-10-19 Thread Kirill Yukhin
Thank you guys, Updated patch is attached. Test fails wihout and passing with the fix. ChangeLog entry: 2011-10-20 Kirill Yukhin PR target/50766 * config/i386/i386.md (bmi_bextr_): Update register/ memory operand order. (bmi2_bzhi_3): Ditto. (bmi2_pdep_3

Re: RFA: Improve tree-ssa-sink block selection

2011-10-19 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/18/11 01:44, Paolo Bonzini wrote: > On 10/18/2011 07:10 AM, Jeff Law wrote: >> --- 467,475 if (gimple_code (use) != GIMPLE_PHI) { sinkbb = >> gimple_bb (use); ! sinkbb = select_best_block (frombb, >> gimple_bb (use), stmt); >> >> !

Re: [PATCH, i386, PR50766] Fix incorrect mem/reg operands order

2011-10-19 Thread Uros Bizjak
On Thu, Oct 20, 2011 at 6:39 AM, Kirill Yukhin wrote: > Updated patch is attached. Test fails wihout and passing with the fix. > > ChangeLog entry: > 2011-10-20  Kirill Yukhin   > >        PR target/50766 >        * config/i386/i386.md (bmi_bextr_): Update register/ >        memory operand order.

[Patch, gcc, testsuite] Adjust optimization levels for some cases.

2011-10-19 Thread Terry Guo
Hello, These four cases check the amount of the desired instructions. At O2 level, some factors like loop unroll will increase the amount of them. This patch is proposing to adjust the optimization level to O1 (the minimal requirement) to avoid such impact. In this way, the cases are more robust.

<    1   2