Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Jason Merrill
On 07/27/2011 01:54 PM, Dodji Seketeli wrote: + /* Set of typedefs that are used in this function. */ + struct pointer_set_t * GTY((skip)) used_local_typedefs; Is there a reason not to just use TREE_USED for this? + /* Vector of locally defined typedefs, for + -Wunused-local-typedefs

Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 08:34 AM, Paolo Bonzini wrote: + temp = rtl_hooks.gen_lowpart_no_emit (mode, x); This line is obviously spurious, sorry. + if (no_emit) + return rtl_hooks.gen_lowpart_no_emit (mode, x); + else +return gen_lowpart (mode, x); Paolo

[PATCH] Fix PR49893

2011-07-29 Thread Richard Guenther
This fixes a latent issue in predictive commoning - we shouldn't try to optimize invariant volatile references. The following patch simply disables handling of all volatile references similar to possibly throwing ones. Bootstrap and regtest in progress on x86_64-unknown-linux-gnu. Richard. 201

[PATCH] Fix VRP handling of undefined state

2011-07-29 Thread Richard Guenther
I noticed that for binary expressions VRP contains the same bugs that CCP once did (it treats UNDEFINED * 0 as UNDEFINED). Then I noticed we never hit this bug because we never end up with any range being UNDEFINED - which is bad, because this way we miss value-ranges for all conditionally initia

[testsuite] XFAIL gcc.dg/tree-ssa/pr42585.c on Tru64 UNIX (PR tree-optimization/47407)

2011-07-29 Thread Rainer Orth
As Martin analyzed in the PR, those failures are expected, so I'm XFAILing them. Tested with the appropriate runtest invocations on alpha-dec-osf5.1b and i386-pc-solaris2.11, installed on mainline. Rainer 2011-07-29 Rainer Orth PR tree-optimization/47407 * gcc.dg/tre

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Paolo Carlini
Hi, I think -Wunused and -Wall should imply -Wunused-local-typedefs unless the user specifies -Wno-unused-local-typedefs. IMHO, this is a very good idea looking forward, but then I think we should make sure the warning plays well with system headers either as-is or together with some other pend

Re: Allow IRIX Ada bootstrap with C++

2011-07-29 Thread Rainer Orth
Andreas, > Wouldn't it be cleanest to adjust the prototype of __gnat_error_handler > to reality, and cast it when assigning to sa_handler (not sa_sigaction, > which is only valid if SA_SIGINFO is set)? probably, provided g++ accepts that. I'd have to run two bootstraps (C and C++) to check this.

Re: [C++0x] contiguous bitfields race implementation

2011-07-29 Thread Richard Guenther
On Fri, Jul 29, 2011 at 4:12 AM, Aldy Hernandez wrote: > On 07/28/11 06:40, Richard Guenther wrote: > >> Looking at the C++ memory model what you need is indeed simple enough >> to recover here.  Still this loop does quadratic work for a struct with >> N bitfield members and a function which store

Re: [Patch,AVR]: PR49313

2011-07-29 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02424.html Richard Henderson wrote: > On 07/27/2011 09:12 AM, Georg-Johann Lay wrote: >> PR target/49313 >> * config/avr/libgcc.S (__ffshi2): Don't skip 2-word instruction. >> (__ctzsi2): Result for 0 may be undefined. >> (__ctzhi2):

[PATCH] Fix comparison type in builtin folding

2011-07-29 Thread Richard Guenther
I noticed the following when LTOing libgfortran into polyhedron with -Ofast which delays signbit folding and exposes the bogus comparison type to the new stricter type checking. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-07-29 Richard Guenther * buil

[trans-mem] verify_types_in_gimple_seq_2 glitch

2011-07-29 Thread Patrick Marlier
In tree-cfg.c (line ~3921), there is a little glitch. Index: tree-cfg.c === --- tree-cfg.c (revision 176864) +++ tree-cfg.c (working copy) @@ -3918,7 +3918,7 @@ break; case GIMPLE_TRANSACTION: - err |= ve

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Dodji Seketeli
Jason Merrill writes: > On 07/27/2011 01:54 PM, Dodji Seketeli wrote: >> + /* Set of typedefs that are used in this function. */ >> + struct pointer_set_t * GTY((skip)) used_local_typedefs; > > Is there a reason not to just use TREE_USED for this? I wasn't sure if that flag wasn't (or couldn

Commit: 4.5: Fix typo in rx.c

2011-07-29 Thread Nick Clifton
Hi Guys, I am applying the patch below to the 4.5 branch to fix a typo in the code to check the setpsw builtin. Cheers Nick gcc/ChangeLog 2011-07-29 Nick Clifton * config/rx/rx.c (rx_expand_builtin): Fix typo checking the setpsw builtin. Index: gcc/config/rx/rx.c ===

Re: Mention avx2 patch

2011-07-29 Thread Kirill Yukhin
Agreed, but I have no idea, how to work with wwwdocs at all. H.J., could you please move ix86/avx to "inactive" section? Thanks, K On Thu, Jul 28, 2011 at 2:26 PM, Gerald Pfeifer wrote: > On Thu, 28 Jul 2011, Kirill Yukhin wrote: >> Ping > > Oh, sure.  I had somehow thought this had been applie

Re: [trans-mem] verify_types_in_gimple_seq_2 glitch

2011-07-29 Thread Aldy Hernandez
On 07/29/11 05:25, Patrick Marlier wrote: In tree-cfg.c (line ~3921), there is a little glitch. Index: tree-cfg.c === --- tree-cfg.c (revision 176864) +++ tree-cfg.c (working copy) @@ -3918,7 +3918,7 @@ break; case GIMPLE_TRANSACTI

Re: PATCH: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread Uros Bizjak
On Thu, Jul 28, 2011 at 3:24 PM, H.J. Lu wrote: In x32, thread pointer is 32bit and choice of segment register for the thread base ptr load should be based on TARGET_64BIT.  This patch implements it.  OK for trunk? >>> >>> -ENOTESTCASE. >>> >> >> There is no standalone testcase.  T

[PATCH, ARM] Support NEON's VABD with combine pass

2011-07-29 Thread Dmitry Melnik
This patch adds two define_insn patterns for NEON vabd instruction to make combine pass recognize expressions matching (vabs (vsub ...)) patterns as vabd. This patch reduces code size of x264 binary from 649143 to 648343 (800 bytes, or 0.12%) and increases its performance on average by 2.5% on

[Committed,AVR]: Addendum to fix thinko in PR49687

2011-07-29 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02391.html (reg:DI 18) does not cover (reg:HI 26) which also contributes to the register footprint of implicit libgcc calls. I should return to elementary school and learn counting again... Installed as obvious, passed without regressions. http://gcc

C++ PATCH for c++/49808 (failure with reference non-type template argument)

2011-07-29 Thread Jason Merrill
Here, the problem was that we weren't calling convert_from_reference when substituting the argument for a non-type template parameter as we do in other places that might produce a reference. Once that change was made, I had to adjust a couple of other functions to deal with getting a reference

Re: [C++0x] contiguous bitfields race implementation

2011-07-29 Thread Aldy Hernandez
On 07/28/11 06:40, Richard Guenther wrote: Looking at the C++ memory model what you need is indeed simple enough to recover here. Still this loop does quadratic work for a struct with N bitfield members and a function which stores into all of them. And that with a big constant factor as you bui

Re: [C++0x] contiguous bitfields race implementation

2011-07-29 Thread Aldy Hernandez
Yes. Together with the above it looks then optimal. Attached patch tested on x86-64 Linux. OK for mainline? * expr.c (get_bit_range): Handle *MEM_REF's. Index: expr.c === --- expr.c (revision 176824) +++ expr.c

PATCH, v2: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread Uros Bizjak
Hello! ABI specifies that TP is loaded in ptr_mode. Attached patch implements this requirement. 2011-07-29 Uros Bizjak * config/i386/i386.md (*load_tp_x32): New. (*load_tp_x32_zext): Ditto. (*add_tp_x32): Ditto. (*add_tp_x32_zext): Ditto. (*load_tp_): D

Re: [PATCH PR43513, 1/3] Replace vla with array - Implementation.

2011-07-29 Thread Tom de Vries
On 07/28/2011 12:22 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: > >> On 07/27/2011 05:27 PM, Richard Guenther wrote: >>> On Wed, 27 Jul 2011, Tom de Vries wrote: >>> On 07/27/2011 02:12 PM, Richard Guenther wrote: > On Wed, 27 Jul 2011, Tom de Vries wrote: >

[PATCH, ARM] Support NEON's VABD with combine pass

2011-07-29 Thread Dmitry Melnik
This patch adds two define_insn patterns for NEON vabd instruction to make combine pass recognize expressions matching (vabs (vsub ...)) patterns as vabd. This patch reduces code size of x264 binary from 649143 to 648343 (800 bytes, or 0.12%) and increases its performance on average by 2.5% on

Re: [Patch,AVR]: PR49687 (better widening 32-bit mul)

2011-07-29 Thread Georg-Johann Lay
Richard Henderson wrote: > On 07/27/2011 06:21 AM, Georg-Johann Lay wrote: >> +(define_insn_and_split "*mulsi3" >> + [(set (match_operand:SI 0 "pseudo_register_operand" >> "=r") >> +(mult:SI (match_operand:SI 1 "pseudo_register_operand" >> "r") >> +

PATCH, v2: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread Uros Bizjak
[ For some reason this post didn't reach gcc-patches@ ML archives... ] Hello! ABI specifies that TP is loaded in ptr_mode. Attached patch implements this requirement. 2011-07-29  Uros Bizjak          * config/i386/i386.md (*load_tp_x32): New.        (*load_tp_x32_zext): Ditto.        (*add_tp_x

[patch tree-optimization]: Fix for PR/49806

2011-07-29 Thread Kai Tietz
Hello, this patch fixes regression of bug report PR middle-end/49806, which was caused due unhandled type-cast patterns reasoned by boolification of compares and type-cast preserving from/to boolean types. ChangeLog 2011-07-29 Kai Tietz PR middle-end/49806 * tree-vrp.c (ha

Re: PATCH: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 11:31 AM, Uros Bizjak wrote: > On Thu, Jul 28, 2011 at 8:30 PM, H.J. Lu wrote: > >> TP is 32bit in x32  For load_tp_x32, we load SImode value and >> zero-extend to DImode. For add_tp_x32, we are adding SImode >> value.  We can't pretend TP is 64bit.  load_tp_x3

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Paolo Carlini
Hi, I think -Wunused and -Wall should imply -Wunused-local-typedefs unless the user specifies -Wno-unused-local-typedefs. I actually first tried this (actually adding it to -Wall -extra and -Wunused) and found out the following issue. A typedef can be defined in a macro in a system header, be e

Re: [PATCH 4/6] Shrink-wrapping

2011-07-29 Thread Bernd Schmidt
On 07/29/11 00:31, Richard Earnshaw wrote: > This causes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49891 Fixed with this. Bernd Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 176904) +++ gcc/ChangeLog (working c

Re: [PATCH] Fix PR48648: Handle CLAST assignments.

2011-07-29 Thread Sebastian Pop
Hi Tobi, On Thu, Jul 28, 2011 at 12:13, Tobias Grosser wrote: >> +  struct clast_user_stmt *body >> +    = clast_get_body_of_loop ((struct clast_stmt *) stmt); > > I am not a big fan of using clast_get_body_of_loop as it is buggy. > Introducing new uses of it, is nothing what I would support. Do

Re: PATCH: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 9:00 AM, H.J. Lu wrote: > On Thu, Jul 28, 2011 at 8:59 AM, H.J. Lu wrote: >> On Thu, Jul 28, 2011 at 7:59 AM, Uros Bizjak wrote: >>> On Thu, Jul 28, 2011 at 4:47 PM, H.J. Lu wrote: >>> > In x32, thread pointer is 32bit and choice of segment register for the >

Re: PATCH: Fix config/i386/morestack.S for x32

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 1:07 PM, Richard Henderson wrote: > On 07/28/2011 12:42 PM, H.J. Lu wrote: >> +#ifdef __LP64__ >>       movq    %rax,%fs:0x70           # Save the new stack boundary. >> +#else >> +     movl    %eax,%fs:0x40           # Save the new stack boundary. >> +#endif > > Please mac

Re: [PATCH] Fix PR49876: Continue code generation with integer_zero_node on gloog_error

2011-07-29 Thread Sebastian Pop
On Thu, Jul 28, 2011 at 02:58, Richard Guenther wrote: > On Wed, Jul 27, 2011 at 8:49 PM, Sebastian Pop wrote: >> When setting gloog_error, graphite should continue code generation >> without early returns, as otherwise the SSA representation would not >> be complete.  So set the new expression t

Re: [trans-mem] verify_types_in_gimple_seq_2 glitch

2011-07-29 Thread Patrick Marlier
Thanks to remind me (once again) the rules... Bootstrapped and tested successfully with: make check-gcc RUNTESTFLAGS=tm.exp Changelog: * tree-cfg.c: Fix typo. -- Patrick Marlier On 07/29/2011 01:14 PM, Aldy Hernandez wrote: On 07/29/11 05:25, Patrick Marlier wrote: In tree-cfg.c (lin

[PATCH][1/2] Fix PR49806, promote/demote binary operations in VRP

2011-07-29 Thread Richard Guenther
This factors out a worker for extract_range_from_binary_expr that operates on two value-ranges instead of two stmt operands and adjusts predicates used as needed. This is a prerequesite for [2/2] which will introduce the ability to promote/demote binary operations using range information to both

[PATCH][2/2][RFC] Fix PR49806, promote/demote binary operations in VRP

2011-07-29 Thread Richard Guenther
This is the actual patch for fixing the binary expression cases in PR49806 - adding unary expressions is easy but will slightly convolute the code. Only lightly tested sofar, bootstrap and regtest pending for x86_64-unknown-linux-gnu. Any comments on general profitability issues? Thanks, Richa

Re: [RS6000] asynch exceptions and unwind info

2011-07-29 Thread Alan Modra
On Fri, Jul 29, 2011 at 10:57:48AM +0930, Alan Modra wrote: > Except that any info about r2 in an indirect call sequence really > belongs to the *called* function frame, not the callee. I woke up > this morning with the realization that what I'd done in > frob_update_context for indirect call sequ

Re: [PATCH] Saner return value for gen_lowpart_no_emit

2011-07-29 Thread Richard Sandiford
Paolo Bonzini writes: > For some reason, when I "invented" gen_lowpart_no_emit I defaulted it > to returning the original value of X. Since gen_lowpart_no_emit is > mostly used to return simplifications, the correct thing to return when > conversion fails is NULL. As a follow-up, every use in si

Re: PATCH: PR target/47715: [x32] TLS doesn't work

2011-07-29 Thread Uros Bizjak
On Thu, Jul 28, 2011 at 3:47 PM, H.J. Lu wrote: TLS on X32 is almost identical to TLS on x86-64.  The only difference is x32 address space is 32bit.  That means TLS symbols can be in either SImode or DImode with upper 32bit zero.  This patch updates tls_global_dynamic_64 to su

Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 2:31 AM, Paolo Bonzini wrote: > On 07/28/2011 11:30 AM, Uros Bizjak wrote: >> >> >  convert_memory_address_addr_space has a special PLUS/MULT case for >> >  POINTERS_EXTEND_UNSIGNED<  0. ?It turns out that it is also needed >> >  for all Pmode != ptr_mode cases. ?OK for tru

Re: [RS6000] asynch exceptions and unwind info

2011-07-29 Thread David Edelsohn
On Thu, Jul 28, 2011 at 9:27 PM, Alan Modra wrote: > Right, but I was talking about the normal case, where the unwinder > won't even look at .glink unwind info. > >> The whole problem is that toc pointer copy in 40(1) is only valid >> during indirect call sequences, and iff ld inserted a stub?  I

Re: PATCH, v2: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread H.J. Lu
On Fri, Jul 29, 2011 at 4:01 AM, Uros Bizjak wrote: > [ For some reason this post didn't reach gcc-patches@ ML archives... ] > > Hello! > > ABI specifies that TP is loaded in ptr_mode. Attached patch implements > this requirement. > > 2011-07-29  Uros Bizjak   > >        * config/i386/i386.md (*lo

Re: PATCH, v2: PR target/47715: [x32] Use SImode for thread pointer

2011-07-29 Thread H.J. Lu
On Fri, Jul 29, 2011 at 6:18 AM, H.J. Lu wrote: > On Fri, Jul 29, 2011 at 4:01 AM, Uros Bizjak wrote: >> [ For some reason this post didn't reach gcc-patches@ ML archives... ] >> >> Hello! >> >> ABI specifies that TP is loaded in ptr_mode. Attached patch implements >> this requirement. >> >> 2011

Re: PING Re: PATCH: move Valgrind header checks from "valgrind" to "misc" checking

2011-07-29 Thread Laurynas Biveinis
Pinging yet again... 2011/7/22 Laurynas Biveinis : > PING again... > > 2011/5/28 Laurynas Biveinis : >> PING >> >> http://codereview.appspot.com/4250047 >> http://gcc.gnu.org/ml/gcc/2011-01/msg00363.html >> >> this patch moves Valgrind header detection from "valgrind" checking to "misc" >> and ena

Re: [RS6000] asynch exceptions and unwind info

2011-07-29 Thread Alan Modra
On Fri, Jul 29, 2011 at 09:16:09AM -0400, David Edelsohn wrote: > Which has the problem? Which are you trying to solve? And how is > your change solving it? Michael's save_toc_in_prologue emit_frame_save writes unwind info for the wrong frame. That r2 save is the current r2. What we need is in

Re: [PATCH, RFC] PR49749 biased reassociation for accumulator patterns

2011-07-29 Thread William J. Schmidt
I found a handful of degradations with this patch from an earlier test version, which demonstrate the incorrectness of this comment: On Wed, 2011-07-27 at 10:11 -0500, William J. Schmidt wrote: > + However, the rank of a value that depends on the result of a loop- > + carried phi should still

[PATCH, i386]: Re-define pic_32bit_operand back to define_predicate

2011-07-29 Thread Uros Bizjak
Hello! With recent developments, there is no need for pic_32bit_operand to be defined as special predicate with explicit mode checks anymore. Implicit mode checks (including VIODmode bypass) of normal predicates work OK now. 2011-07-28 Uros Bizjak * config/i386/predicates.md (pic_32bi

Re: [Patch,AVR]: Fix PR29560 (map 16-bit shift to 8-bit)

2011-07-29 Thread Georg-Johann Lay
Richard Henderson wrote: > On 07/27/2011 10:00 AM, Georg-Johann Lay wrote: >> Richard Henderson wrote: +;; "*ashluqihiqi3.mem" +;; "*ashlsqihiqi3.mem" +(define_insn_and_split "*ashlqihiqi3.mem" + [(set (match_operand:QI 0 "memory_operand" "=m") +(subreg:QI (ashift:

Re: PING Re: PATCH: move Valgrind header checks from "valgrind" to "misc" checking

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 03:27 PM, Laurynas Biveinis wrote: Pinging yet again... 2011/7/22 Laurynas Biveinis: PING again... 2011/5/28 Laurynas Biveinis: PING http://codereview.appspot.com/4250047 http://gcc.gnu.org/ml/gcc/2011-01/msg00363.html this patch moves Valgrind header detection from "valgrind"

Re: [PATCH] ARM fixed-point support [4/6]: allow overriding of fixed-point helper function names

2011-07-29 Thread Bernd Schmidt
On 07/29/11 16:58, Julian Brown wrote: > * fixed-bit.c (BUILDING_FIXED_BIT): Define macro. This appears to be unused in this patch? Bernd

Re: [backport] arm,rx: don't ICE on naked functions with local vars

2011-07-29 Thread DJ Delorie
> Probably. Thanks for the leg-work. I'll approve the patch as-is. May I apply it to the 4.5 and 4.6 branches? The same patch applies as-is to both.

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Dodji Seketeli
Jason Merrill writes: > On 07/27/2011 01:54 PM, Dodji Seketeli wrote: >> + /* Set of typedefs that are used in this function. */ >> + struct pointer_set_t * GTY((skip)) used_local_typedefs; > > Is there a reason not to just use TREE_USED for this? > >> + /* Vector of locally defined typedefs

Re: [trans-mem] verify_types_in_gimple_seq_2 glitch

2011-07-29 Thread Aldy Hernandez
On 07/29/11 07:40, Patrick Marlier wrote: Thanks to remind me (once again) the rules... Bootstrapped and tested successfully with: make check-gcc RUNTESTFLAGS=tm.exp OK for branch. Thanks.

Re: [PATCH] ARM fixed-point support [6/6]: target-specific parts

2011-07-29 Thread Julian Brown
On Thu, 30 Jun 2011 14:42:54 +0100 Richard Earnshaw wrote: > > OK to apply? Tested alongside the rest of the patch series, in both > > big & little-endian mode. > > [snip] > > Please put the iterator definitions in iterators.md I've done this, and made a few other changes as required by the new

Re: [PATCH] ARM fixed-point support [4/6]: allow overriding of fixed-point helper function names

2011-07-29 Thread Julian Brown
On Fri, 29 Jul 2011 17:26:07 +0200 Bernd Schmidt wrote: > On 07/29/11 16:58, Julian Brown wrote: > > * fixed-bit.c (BUILDING_FIXED_BIT): Define macro. > > This appears to be unused in this patch? It's used by the later patch: http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02686.html Cheers,

Re: [PATCH] ARM fixed-point support [4/6]: allow overriding of fixed-point helper function names

2011-07-29 Thread Bernd Schmidt
On 07/29/11 17:48, Julian Brown wrote: > On Fri, 29 Jul 2011 17:26:07 +0200 > Bernd Schmidt wrote: > >> On 07/29/11 16:58, Julian Brown wrote: >>> * fixed-bit.c (BUILDING_FIXED_BIT): Define macro. >> >> This appears to be unused in this patch? > > It's used by the later patch: > > http://gc

[PATCH, i386]: Remove tp_or_register_operand predicate

2011-07-29 Thread Uros Bizjak
Hello! tp_or_register_operand predicate is not used. 2011-07-29 Uros Bizjak * config/i386/predicates.md (tp_or_register_operand): Remove predicate. Tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: predicates.md =

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Jason Merrill
On 07/29/2011 08:36 AM, Dodji Seketeli wrote: Looking into this a bit, it seems to me that I can access cfun->language->base (of type c_language_function) from inside either the C or C++ FE only, as the type of cfun->language -- which is of type struct language_function -- is only defined either

Re: [PATCH] ARM fixed-point support [6/6]: target-specific parts

2011-07-29 Thread Richard Earnshaw
On 29/07/11 16:47, Julian Brown wrote: > On Thu, 30 Jun 2011 14:42:54 +0100 > Richard Earnshaw wrote: > >>> OK to apply? Tested alongside the rest of the patch series, in both >>> big & little-endian mode. >>> [snip] >> >> Please put the iterator definitions in iterators.md > > I've done this, a

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Jason Merrill
On 07/29/2011 03:35 AM, Dodji Seketeli wrote: So do you guys think we should add it nonetheless and just add -Wno-unused-local-typedefs to the tests that exhibit the above issue before fixing PR preprocessor/7263? Does your set of linemap patches fix the issue? In that case, we can add it whe

Re: [pph] Free buffers used during tree encoding/decoding

2011-07-29 Thread Gabriel Charette
I just stashed all my changes and pulled in the latest svn HEAD this morning to check if I was seeing these failures: Repository Root: svn+ssh://gcc.gnu.org/svn/gcc Repository UUID: 138bc75d-0d04-0410-961f-82ee72b054a4 Revision: 176906 Node Kind: directory Schedule: normal Last Changed Author: cro

-freorder-function is broken

2011-07-29 Thread Xinliang David Li
The attached patch fixed the problem. The root cause of the problem is due to the ordering change of profile_estimation and tree_profile pass. In trunk, the function/node frequency is not computed after profile annotation is done leading to missing information. Another side effect of this breakage

Re: [PATCH] [google] [annotalysis] Fix remove operation from pointer_set in case of hash collisions

2011-07-29 Thread Ollie Wild
Okay for google/gcc-4_6. Ollie On Tue, Jul 26, 2011 at 7:27 PM, Delesley Hutchins wrote: > > Le-Chun added the additional routine to remove pointers from a set; > that code is unique to annotalysis.  I can't easily include a test > case, because the bug is difficult to trigger.  It occurs only w

Re: [PATCH, RFC] PR49749 biased reassociation for accumulator patterns

2011-07-29 Thread William J. Schmidt
Here is the final version of the reassociation patch. There are two differences from the version I published on 7/27. I removed the function call from within the MAX macro per Michael's comment, and I changed the propagation of the rank of loop-carried phis to be zero. This involved a small chang

[gomp3.1] Allow const qualified static data members with no mutable members in firstprivate clauses

2011-07-29 Thread Jakub Jelinek
Hi! My clarification request for ambiguity in the new OpenMP 3.1 standard http://www.openmp.org/forum/viewtopic.php?f=10&t=1198 has been resolved in that const qualified static data members with no mutable members should be allowed in firstprivate clauses. The following patch implements it, regtes

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Dodji Seketeli
Jason Merrill writes: > On 07/29/2011 03:35 AM, Dodji Seketeli wrote: >> So do you guys think we should add it nonetheless and just add >> -Wno-unused-local-typedefs to the tests that exhibit the above issue >> before fixing PR preprocessor/7263? > > Does your set of linemap patches fix the issue

[DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Dimitrios Apostolou
Hello list, the attached patch achieves a performance improvement by first recording DF_REF_BASE DEFs within df_get_call_refs() before the DF_REF_REGULARs are recorded in df_defs_record(). BASE DEFs are also recorded in REGNO order. Improvement has been measured as follows, for compiling tcp_i

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Paolo Bonzini
On 07/29/2011 07:23 PM, Dimitrios Apostolou wrote: 2011-07-29 Dimitrios Apostolou Paolo Bonzini (df_def_record_1): Assert a parallel must contain an EXPR_LIST at this point. Receive the LOC and move its extraction... (df_defs_record): ... here. Rewrote lo

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Dodji Seketeli
Jason Merrill writes: > On 07/29/2011 08:36 AM, Dodji Seketeli wrote: >> Looking into this a bit, it seems to me that I can access >> cfun->language->base (of type c_language_function) from inside either >> the C or C++ FE only, as the type of cfun->language -- which is of type >> struct language

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Kenneth Zadeck
were these tested on any platform aside from x86? On 07/29/2011 01:26 PM, Paolo Bonzini wrote: On 07/29/2011 07:23 PM, Dimitrios Apostolou wrote: 2011-07-29 Dimitrios Apostolou Paolo Bonzini (df_def_record_1): Assert a parallel must contain an EXPR_LIST at this

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Dimitrios Apostolou
Completely forgot it: Tested on i386, no regressions. Dimitrios

Patch for C++ build on HP-UX and to implement -static-libstdc++

2011-07-29 Thread Steve Ellcey
I recently discovered that after moving to the C++ bootstrap, the IA64 HP-UX GCC compiler would build and test OK, but if you tried to run the installed compiler you would get an error about not being able to find libgcc_s.so.0. Joseph and Rainer pointed me at definining gcc_cv_ld_static_dynamic,

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Kenneth Zadeck
i really think that patches of this magnitude having to with the rtl level should be tested on more than one platform. kenny On 07/29/2011 01:39 PM, Dimitrios Apostolou wrote: Completely forgot it: Tested on i386, no regressions. Dimitrios

[committed] Fix OpenMP shared var handling in nested parallels (PR middle-end/49897)

2011-07-29 Thread Jakub Jelinek
Hi! This is something that happened to work in 4.4 and earlier, before DECL_GIMPLE_FORMAL_TEMP_P removal. If use_pointer_for_field needs to return true because something is shared in a nested parallel and thus in-out wouldn't work, as each thread would have its own location, and that var isn't ad

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Dimitrios Apostolou
On Fri, 29 Jul 2011, Kenneth Zadeck wrote: i really think that patches of this magnitude having to with the rtl level should be tested on more than one platform. I'd really appreciate further testing on alternate platforms from whoever does it casually, for me it would take too much time to s

Re: Patch for C++ build on HP-UX and to implement -static-libstdc++

2011-07-29 Thread Rainer Orth
Steve, > Index: gcc/configure.ac > === > --- gcc/configure.ac (revision 176899) > +++ gcc/configure.ac (working copy) > @@ -3240,6 +3240,13 @@ >*-*-solaris2*) > gcc_cv_ld_static_dynamic=yes > ;; > + *-

Re: Patch for C++ build on HP-UX and to implement -static-libstdc++

2011-07-29 Thread Steve Ellcey
On Fri, 2011-07-29 at 20:00 +0200, Rainer Orth wrote: > Steve, > > > Index: gcc/configure.ac > > === > > --- gcc/configure.ac(revision 176899) > > +++ gcc/configure.ac(working copy) > > @@ -3240,6 +3240,13 @@ > >

[lra] another patch to decrease ARM code size degradation.

2011-07-29 Thread Vladimir Makarov
The patch decrease code size degradation on ARM (SPEC2000 was used) by improving hard regno preferences for reload and inheritance pseudos, more accurate cost evaluation of alternatives with early clobbers, fixing missed copies for shuffling reload and inheritance pseudos, fixing missed removal

Re: Patches ping

2011-07-29 Thread Ayal Zaks
> [PATCH, SMS 3/4] Optimize stage count > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01341.html This patch for minimizing the stage count (which also refactors and cleans up the code) is approved. Have some minor comments below, followed by some thoughts for possible follow-up improvements. Than

Re: Patches ping

2011-07-29 Thread Ayal Zaks
>[PATCH, SMS 4/4] Misc. fixes http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01342.html Sure, this is fine. (Sorry for all the previous '?'s..). Thanks, Ayal. 2011/7/20 Revital Eres > > Hello, > > [PATCH, SMS 3/4] Optimize stage count > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01341.html > > [P

Re: PATCH: Use long long for 64bit int in config/i386/64/sfp-machine.h

2011-07-29 Thread NightStrike
On Thu, Jul 28, 2011 at 3:45 PM, H.J. Lu wrote: > Hi Ian, > > For 64bit x86 targets, long is 32bit for x32 and win64.  But long long > is always 64bit.  This patch removes _WIN64 check.  OK for trunk? Isn't that what int64_t is for?

Re: Patches ping

2011-07-29 Thread Ayal Zaks
> [PATCH, SMS] Fix calculation of issue_rate > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01344.html This is ok (with the updated Changelog). Alternatively, we can have a local variable for holding the issue_rate. Ayal. 2011/7/20 Revital Eres : > Hello, > > [PATCH, SMS 3/4] Optimize stage coun

Re: [PATCH, PR 49886] Prevent fnsplit from changing signature when there are type attributes

2011-07-29 Thread Martin Jambor
Hi, On Thu, Jul 28, 2011 at 06:52:05PM +0200, Martin Jambor wrote: > pass_split_functions is happy to split functions which have type > attributes but cannot update them if the new clone has in any way > different parameters than the original. This can lead to > miscompilations in cases like the

Re: [PATCH] PR c++/33255 - Support -Wunused-local-typedefs warning

2011-07-29 Thread Jason Merrill
On 07/29/2011 10:27 AM, Dodji Seketeli wrote: Jason Merrill writes: On 07/29/2011 08:36 AM, Dodji Seketeli wrote: Looking into this a bit, it seems to me that I can access cfun->language->base (of type c_language_function) from inside either the C or C++ FE only, as the type of cfun->language

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Steven Bosscher
On Fri, Jul 29, 2011 at 7:57 PM, Dimitrios Apostolou wrote: > On Fri, 29 Jul 2011, Kenneth Zadeck wrote: > >> i really think that patches of this magnitude having to with the rtl level >> should be tested on more than one platform. > > I'd really appreciate further testing on alternate platforms fr

Re: [DF] [performance] generate DF_REF_BASE REFs in REGNO order

2011-07-29 Thread Kenneth Zadeck
you are the best kenny On 07/29/2011 05:48 PM, Steven Bosscher wrote: On Fri, Jul 29, 2011 at 7:57 PM, Dimitrios Apostolou wrote: On Fri, 29 Jul 2011, Kenneth Zadeck wrote: i really think that patches of this magnitude having to with the rtl level should be tested on more than one platfo

Re: PATCH: PR target/47766: [x32] -fstack-protector doesn't work

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 1:03 PM, Uros Bizjak wrote: > On Thu, Jul 28, 2011 at 9:03 PM, H.J. Lu wrote: > This patch adds x32 support to UNSPEC_SP_XXX patterns.  OK for trunk? >>> >>> http://gcc.gnu.org/contribute.html#patches >>> >> >> Sorry. I should have mentioned testcase in: >> >> http://

Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant

2011-07-29 Thread H.J. Lu
On Thu, Jul 28, 2011 at 11:34 PM, Paolo Bonzini wrote: > Ok, you removed ignore_address_wrap_around, so we're almost there. > > On 07/28/2011 07:59 PM, H.J. Lu wrote: >> >> @@ -712,7 +715,16 @@ convert_modes (enum machine_mode mode, enum >> machine_mode oldmode, rtx x, int uns >>    if (GET_CODE (

PATCH: [x32]: Check TARGET_LP64 for SIZE_TYPE/PTRDIFF_TYPE

2011-07-29 Thread H.J. Lu
Hi, X32 is 32bit. This patch checks TARGET_LP64 for SIZE_TYPE/PTRDIFF_TYPE. OK for trunk? Thanks. H.J. --- 2011-07-29 H.J. Lu * config/i386/x86-64.h (SIZE_TYPE): Check TARGET_LP64 instead of TARGET_64BIT. (PTRDIFF_TYPE): Likewise. diff --git a/gcc/config/i386/x86-6

Re: [pph] Free buffers used during tree encoding/decoding

2011-07-29 Thread Lawrence Crowl
I removed the build directories and rebuilt. Everything worked. There are gremlins in the machine. On 7/29/11, Gabriel Charette wrote: > I just stashed all my changes and pulled in the latest svn HEAD this > morning to check if I was seeing these failures: > > Repository Root: svn+ssh://gcc.gnu.

Re: [PATCH 1/7] Linemap infrastructure for virtual locations

2011-07-29 Thread Jason Merrill
On 07/16/2011 07:37 AM, Dodji Seketeli wrote: +/* Returns the highest location [of a token resulting from macro + expansion] encoded in this line table. */ +#define LINEMAPS_MACRO_HIGHEST_LOCATION(SET) \ + LINEMAPS_HIGHEST_LOCATION(SET, true) + +/* Returns the location of the begining of the

Re: [PATCH] Use HOST_WIDE_INTs in gcd and least_common_multiple.

2011-07-29 Thread Richard Henderson
On 07/28/2011 10:47 PM, Sebastian Pop wrote: > 2011-01-28 Sebastian Pop > Joseph Myers > > * Makefile.in (hwint.o): Depend on DIAGNOSTIC_CORE_H. > * hwint.c: Include diagnostic-core.h. > (abs_hwi): New. > (gcd): Moved here... > (pos_mul_hwi): New. >

Re: [PATCH] libtool -- don't print warnings with --silent

2011-07-29 Thread John David Anglin
Ping? On 9-Jul-11, at 7:03 PM, John David Anglin wrote: The attached patch fixes the boehm-gc testsuite on hppa2.0w-hp- hpux11.11. Without it, libtool always generates an informational warning when linking causing the entire boehm-gc testsuite to fail. Ok? Ralf would you please install in

[v3] docbook biblioid/imagedata markup fixes

2011-07-29 Thread Benjamin Kosnik
As noted earlier today, this removes various warnings when processing doc/xml/* files. tested x86/linux -benjamin2011-07-29 Benjamin Kosnik * doc/xml/manual/build_hacking.xml: Markup imagedata changes. * doc/xml/manual/policy_data_structures.xml: Same. * doc/xml/class.txml: Remove biblio

Re: [PATCH] Fix PR47594: Sign extend constants while translating to Graphite

2011-07-29 Thread Sebastian Pop
Hi Richi, On Thu, Jul 28, 2011 at 03:58, Richard Guenther wrote: > So maybe we can instead try to avoid using unsigned arithmetic > for symbolic niters if the source does not have it unsigned? Ok, so what about the attached patch that makes niter use the original type as much as possible? I.e.

C++ PATCH for c++/49867 (ICE with case label in lambda)

2011-07-29 Thread Jason Merrill
When we enter a local class, including a lambda, we are no longer in the scope of any enclosing loops or switches, and we should adjust the parser state accordingly. Tested x86_64-pc-linux-gnu, applying to trunk. commit 72900624cbb7b7ded0deb615c5175fe34531914a Author: Jason Merrill Date: Fri