Re: [PATCH] pch bug fix (take 2, PR pch/59436)

2014-01-06 Thread Jeff Law
On 01/01/14 16:08, Jakub Jelinek wrote: On Wed, Jan 01, 2014 at 07:53:48PM +0100, Jakub Jelinek wrote: Without any gengtype.c changes, I wonder if just following change wouldn't do it, gengtype considers only char and unsigned char pointers as strings with the special strlen handling, all other

Re: [PATCH] pch bug fix (take 2, PR pch/59436)

2014-01-01 Thread Mike Stump
On Jan 1, 2014, at 3:08 PM, Jakub Jelinek wrote: > if (memcmp (tmp_optabs, this_target_optabs, sizeof (struct target_optabs))) > -TREE_OPTIMIZATION_OPTABS (optnode) = (unsigned char *) tmp_optabs; > +TREE_OPTIMIZATION_OPTABS (optnode) = (void *) tmp_optabs; Oh, the cast isn't necessary.

Re: [PATCH] pch bug fix (take 2, PR pch/59436)

2014-01-01 Thread Mike Stump
On Jan 1, 2014, at 3:08 PM, Jakub Jelinek wrote: > On Wed, Jan 01, 2014 at 07:53:48PM +0100, Jakub Jelinek wrote: >> Without any gengtype.c changes, I wonder if just following change wouldn't >> do it, gengtype considers only char and unsigned char pointers as strings >> with the special strlen ha

Re: pch bug fix

2014-01-01 Thread Mike Stump
On Dec 31, 2013, at 11:46 PM, Jakub Jelinek wrote: > On Tue, Dec 31, 2013 at 10:39:58PM -0800, Mike Stump wrote: >> In testing for wide-int, we discovered that someone seems to have blown >> pch > Thanks for tracking this down, this sounds like PR59436. To confirm that, one would need to either,

[PATCH] pch bug fix (take 2, PR pch/59436)

2014-01-01 Thread Jakub Jelinek
On Wed, Jan 01, 2014 at 07:53:48PM +0100, Jakub Jelinek wrote: > Without any gengtype.c changes, I wonder if just following change wouldn't > do it, gengtype considers only char and unsigned char pointers as strings > with the special strlen handling, all other scalar types are treated > differentl

Re: pch bug fix

2014-01-01 Thread Jakub Jelinek
On Wed, Jan 01, 2014 at 08:46:31AM +0100, Jakub Jelinek wrote: > Thanks for tracking this down, this sounds like PR59436. How have you > managed to track it down? I also wonder why it doesn't seem to affect 4.8 > when it also has the same change. > > Based on the comments in gengtype.c, I'd expe

Re: pch bug fix

2013-12-31 Thread Jakub Jelinek
On Tue, Dec 31, 2013 at 10:39:58PM -0800, Mike Stump wrote: > In testing for wide-int, we discovered that someone seems to have blown > pch. The problem is that the optabs field is not a string. It's size is > not determined by strlen. strlen are the semantics gty attaches to > unsigned char * d

pch bug fix

2013-12-31 Thread Mike Stump
In testing for wide-int, we discovered that someone seems to have blown pch. The problem is that the optabs field is not a string. It's size is not determined by strlen. strlen are the semantics gty attaches to unsigned char * data. By defeating the type of optabs to being any other type, th