On Jan 1, 2014, at 3:08 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Wed, Jan 01, 2014 at 07:53:48PM +0100, Jakub Jelinek wrote:
>> Without any gengtype.c changes, I wonder if just following change wouldn't
>> do it, gengtype considers only char and unsigned char pointers as strings
>> with the special strlen handling, all other scalar types are treated
>> differently it seems, and signed char aliases everything too.
>> 
>> Or s/signed char/void/ in the patch is perhaps even better.
> 
> I've bootstrapped/regtested this on x86_64-linux and i686-linux,
> and hopefully verified the problem from the PR is gone, by running over
> 610 successful PCH write + PCH read cycles as described in
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59436#c14 , no failures
> with the patch, while on a tree from yesterday without the patch I could
> reproduce it 17 times, on average every 22 iterations (from 2 to 81).

Yup.  That sounds like the same bug then.

> Ok for trunk (and after a while for 4.8)?

I thought my fingers tried this version for some reason…   certainly I like 
this version better than mine.  I've tried this, and indeed it fixes my bug, 
so, I withdraw my version and endorse this one, thanks.

Reply via email to