Re: misc VRP cleanups for value_range API

2018-11-08 Thread Richard Biener
On Thu, Nov 8, 2018 at 3:34 PM Aldy Hernandez wrote: > > > > On 11/8/18 9:31 AM, Richard Biener wrote: > > On Thu, Nov 8, 2018 at 1:42 PM Aldy Hernandez wrote: > >> > >> Stupid boring changes. > >> > >> OK? > > > > Well, IMHO using m_min is making clear you are accessing a member > > while using

Re: misc VRP cleanups for value_range API

2018-11-08 Thread Aldy Hernandez
On 11/8/18 9:31 AM, Richard Biener wrote: On Thu, Nov 8, 2018 at 1:42 PM Aldy Hernandez wrote: Stupid boring changes. OK? Well, IMHO using m_min is making clear you are accessing a member while using min () does not. There is already prior art here. I believe I discussed this before a

Re: misc VRP cleanups for value_range API

2018-11-08 Thread Richard Biener
On Thu, Nov 8, 2018 at 1:42 PM Aldy Hernandez wrote: > > Stupid boring changes. > > OK? Well, IMHO using m_min is making clear you are accessing a member while using min () does not. So no, please do not make this kind of changes? Richard.

misc VRP cleanups for value_range API

2018-11-08 Thread Aldy Hernandez
Stupid boring changes. OK? * tree-vrp.c (value_range::check): Do not access internals directly. (value_range::singleton_p): Same. (value_range::type): Same. (vrp_finalize): Use value_range API. diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp