Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Rainer Orth
Ian Lance Taylor writes: > On Wed, Jun 11, 2014 at 6:57 AM, Rainer Orth > wrote: >> >> Ok, I'll have a look unless some other solution can be found. > > There are other, less efficient, ways that this could be compiled, but > a common symbol seems like the right solution. > > Basically, every ty

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Ian Lance Taylor
On Wed, Jun 11, 2014 at 6:57 AM, Rainer Orth wrote: > > Ok, I'll have a look unless some other solution can be found. There are other, less efficient, ways that this could be compiled, but a common symbol seems like the right solution. Basically, every type descriptor now points to a zero value

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Rainer Orth
Ian Lance Taylor writes: > On Wed, Jun 11, 2014 at 5:01 AM, Rainer Orth > wrote: >> Ian Lance Taylor writes: >> >>> On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth >>> wrote: Ian Lance Taylor writes: > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Ian Lance Taylor
On Wed, Jun 11, 2014 at 5:01 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth >> wrote: >>> Ian Lance Taylor writes: >>> I have committed a patch to libgo to merge from revision 18783:00cce3a34d7e of the master library. This revision

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-11 Thread Rainer Orth
Ian Lance Taylor writes: > On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth > wrote: >> Ian Lance Taylor writes: >> >>> I have committed a patch to libgo to merge from revision >>> 18783:00cce3a34d7e of the master library. This revision was committed >>> January 7. I picked this revision to merge

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Gary Funck
On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: > There is no bug here, the control flow is just too complicated > for the compiler to sort out. I don't know why I'm > not seeing the warning [...] We have these compilation flags set: CFLAGS='-g3 -O3' CFLAGS_FOR_BUILD='-g3 -O3' CFL

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
And I also forgot to attach the patch. Sorry about this. On Mon, Jun 9, 2014 at 5:37 PM, Ian Lance Taylor wrote: > Forgot to CC gofrontend-dev. > > On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: >> On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: >>> On 06/04/14 18:28:17, Ian Lance T

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
Forgot to CC gofrontend-dev. On Mon, Jun 9, 2014 at 5:36 PM, Ian Lance Taylor wrote: > On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: >> On 06/04/14 18:28:17, Ian Lance Taylor wrote: >>> I have committed a patch to libgo to merge from revision >>> 18783:00cce3a34d7e of the master library. >>

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Ian Lance Taylor
On Mon, Jun 9, 2014 at 1:12 PM, Gary Funck wrote: > On 06/04/14 18:28:17, Ian Lance Taylor wrote: >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. > > Based on trunk rev. 211365, we're seeing this warning: > > libgo/runtime/chan.c:484:7: erro

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-09 Thread Gary Funck
On 06/04/14 18:28:17, Ian Lance Taylor wrote: > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e of the master library. Based on trunk rev. 211365, we're seeing this warning: libgo/runtime/chan.c:484:7: error: ‘received’ may be used uninitialized in this function [-We

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-06 Thread Ian Lance Taylor
On Fri, Jun 6, 2014 at 2:12 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revision to merge to because the next revision >> del

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-06 Thread Rainer Orth
Ian Lance Taylor writes: > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e of the master library. This revision was committed > January 7. I picked this revision to merge to because the next revision > deleted a file that is explicitly merged in by the libgo/merge.

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Ian Lance Taylor
On Thu, Jun 5, 2014 at 9:38 AM, Uros Bizjak wrote: > >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revision to merge to because the next revision >> deleted a file that is explicitl

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Uros Bizjak
Hello! > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e of the master library. This revision was committed > January 7. I picked this revision to merge to because the next revision > deleted a file that is explicitly merged in by the libgo/merge.sh > script. crypt

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Ian Lance Taylor
On Thu, Jun 5, 2014 at 3:24 AM, Matthias Klose wrote: > Am 05.06.2014 03:28, schrieb Ian Lance Taylor: >> I have committed a patch to libgo to merge from revision >> 18783:00cce3a34d7e of the master library. This revision was committed >> January 7. I picked this revision to merge to because the

Re: libgo patch committed: Merge from revision 18783 of master

2014-06-05 Thread Matthias Klose
Am 05.06.2014 03:28, schrieb Ian Lance Taylor: > I have committed a patch to libgo to merge from revision > 18783:00cce3a34d7e of the master library. This revision was committed > January 7. I picked this revision to merge to because the next revision > deleted a file that is explicitly merged in