The HTML formatting was off (again), so I used git send-email as someone
recommended to me in the IRC. Patch is here:
https://gcc.gnu.org/ml/gcc-patches/2019-07/msg01670.html
I... think it's good, there? Apologies for all the noise; it's a bit hard
getting used to these tools.
Sincerely,
JeanHeyd
I think I got the tabs right...? You would not believe how unbelievably
hard it is, just to mail a diff!
-
07-24-2019ThePhD
gcc/
* escaped_string.h: New. Refactored out of tree.c to make more
broadly available (e.g. to parser.c, cvt.c).
* tree.c: remove escaped_string class
gcc/c-
Hi JeanHeyd,
Just some patch-technical comments:
On Mon, Jul 22, 2019 at 01:53:23AM +0200, JeanHeyd Meneide wrote:
> diff --git a/.gitignore b/.gitignore
> index b53f60db792..8988746a314 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -55,3 +55,6 @@ REVISION
> /mpc*
> /gmp*
> /isl*
> +
> +#
Oops. I learned that %< and %> do not get applied as part of the string
arguments, only the initial format string. So, updated patch:
-
diff --git a/.gitignore b/.gitignore
index b53f60db792..8988746a314 100644
--- a/.gitignore
+++ b/.gitignore
@@ -55,3 +55,6 @@ REVISION
/mpc*
/gmp*
I think I managed to fix all of the issues. Do let me know if I missed
anything!
--
diff --git a/.gitignore b/.gitignore
index b53f60db792..8988746a314 100644
--- a/.gitignore
+++ b/.gitignore
@@ -55,3 +55,6 @@ REVISION
/mpc*
/gmp*
/isl*
+
+# ignore some editor-specific files
+.vscod
On Sat, Jul 20, 2019 at 03:48:40PM -0600, Martin Sebor wrote:
> On 7/20/19 11:29 AM, JeanHeyd Meneide wrote:
> >+[[nodiscard(123)]] int check1 (void); /* { dg-error "nodiscard attribute
> >argument.*must be a string" } */
>
> Using .* might be safe in a test with a single line of output but
> not
On 7/20/19 11:29 AM, JeanHeyd Meneide wrote:
Dear GCC Community,
This patch implements the recently accepted p1301: [[nodiscard("should
have a reason")]]. Aaron Ballman implemented it for Clang in
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190715/280158.html
-- this is in pr
