Hi JeanHeyd, Just some patch-technical comments:
On Mon, Jul 22, 2019 at 01:53:23AM +0200, JeanHeyd Meneide wrote: > diff --git a/.gitignore b/.gitignore > index b53f60db792..8988746a314 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -55,3 +55,6 @@ REVISION > /mpc* > /gmp* > /isl* > + > +# ignore some editor-specific files > +.vscode/* The dotfiles are earlier in this file. Do we want this here at all? A user of this IDE should probably have something like this in his global .gitignore, instead. (Oh, and it should be a separate patch, anyway). > \ No newline at end of file That is wrong; please end all (text) files with a newline. > diff --git a/gcc/ChangeLog b/gcc/ChangeLog Don't put changelogs in the diff; instead, put them *before* the patch. > index 711a31ea597..1c70f9d769f 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -52,6 +52,12 @@ > * gcc/config/or1k/predicates.md (volatile_mem_operand): New. > (reg_or_mem_operand): New. > > +2019-07-22 ThePhD <phdoftheho...@gmail.com> > + > + p1301 > + * escaped_string.h: New. Refactored out of tree.c to make more > + broadly available (e.g. to parser.c, cvt.c). > + > 2019-07-21 Iain Sandoe <i...@sandoe.co.uk> > > * config/rs6000/rs6000.c (TARGET_NO_PROTOTYPE): Move from here... No one else but you can ever apply that like this. Also, you're adding and entry to the middle of a changelog? > diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog > index e6452542bcc..0c3bdbc2fd1 100644 > --- a/gcc/c-family/ChangeLog > +++ b/gcc/c-family/ChangeLog > @@ -1,3 +1,9 @@ > +2019-07-22 ThePhD <phdoftheho...@gmail.com> > + > + p1301 > + * c-family/c-lex.c: increase [[nodiscard]] feature macro > + value (final value pending post-Cologne mailing) Sentences end in a full stop. Sentences start with a capital letter. All lines in a changelog are indented with a tab (not with a space). > - "ignoring return value of %qD, " > - "declared with attribute nodiscard", fn)) > - inform (DECL_SOURCE_LOCATION (fn), "declared here"); > + "ignoring return value of %qD, " > + "declared with attribute %<nodiscard%>%s%s", fn, > pre_msg, raw_msg)) > + inform (DECL_SOURCE_LOCATION (fn), "declared here"); Your email client wraps lines. This line is much too long, too. Your email client ate those tabs as well it seems? Please fix that. Segher
