Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-29 Thread Mike Stump
On Oct 29, 2013, at 3:20 AM, Richard Biener wrote: > Can you please get rid of PARTIAL_INT_MODE_NAME by > making the name a required argument to PARTIAL_INT_MODE? Sure, easy to do. * machmode.def (PARTIAL_INT_MODE): Add precision and name. * genmodes.c (PARTIAL_INT_MODE): Add pre

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-29 Thread Richard Biener
On Mon, Oct 28, 2013 at 9:16 PM, Mike Stump wrote: > Ping? Can you please get rid of PARTIAL_INT_MODE_NAME by making the name a required argument to PARTIAL_INT_MODE? Ok with that change (given target maintainers are ok with this). Thanks, Richard. > On Oct 18, 2013, at 10:03 AM, Mike Stump w

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread Mike Stump
On Oct 28, 2013, at 1:30 PM, DJ Delorie wrote: > Who needs to approve this? THe target maintainers, or some global maintainer? So Richard said he'd review/approve it… He's been busy clearing out a backlog or email/patches and reviewing wide-int stuff… when next he comes up for air, I suspect

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread DJ Delorie
Who needs to approve this? THe target maintainers, or some global maintainer?

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread Mike Stump
Ping? On Oct 18, 2013, at 10:03 AM, Mike Stump wrote: > On Oct 18, 2013, at 4:24 AM, Richard Biener > wrote: >> I agree. Btw, the "implementation defined" precision of PDI on SH-5 >> definitely >> looks interesting, but I wonder how you can perform "implementation defined" >> arithmetic on th

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-18 Thread Mike Stump
On Oct 18, 2013, at 4:24 AM, Richard Biener wrote: > I agree. Btw, the "implementation defined" precision of PDI on SH-5 > definitely > looks interesting, but I wonder how you can perform "implementation defined" > arithmetic on that PDI mode then ;) Easy, perform it in the maximal size support

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-18 Thread Richard Biener
On Tue, Sep 17, 2013 at 7:37 PM, Richard Sandiford wrote: > Mike Stump writes: >> +/* Partial integer modes are specified by relation to a full integer >> + mode. */ >> +#define PARTIAL_INT_MODE(M,PREC) \ >> + make_partial_integer_mode (#M, "P" #PREC #M, PR

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-05 Thread Oleg Endo
On Fri, 2013-09-27 at 11:38 -0700, Mike Stump wrote: > Can the sh people weigh in on this? Are the PSI and PDI precisions 32 and 64? PSI is used for representing FPSCR (floating point control register), which has only max. 22 bits (as far as I know). PDI is used on SH-5 for representing target a

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-27 Thread Mike Stump
Can the sh people weigh in on this? Are the PSI and PDI precisions 32 and 64? On Sep 17, 2013, at 10:24 AM, Mike Stump wrote: > On Sep 16, 2013, at 8:41 PM, DJ Delorie wrote: >> m32c's PSImode is 24-bits, why does it have "32" in the macro? >> >> /* 24-bit pointers, in 32-bit units */ >> -PART

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-17 Thread Mike Stump
On Sep 17, 2013, at 10:24 AM, Mike Stump wrote: > On Sep 16, 2013, at 8:41 PM, DJ Delorie wrote: >> m32c's PSImode is 24-bits, why does it have "32" in the macro? >> >> /* 24-bit pointers, in 32-bit units */ >> -PARTIAL_INT_MODE (SI); >> +PARTIAL_INT_MODE_NAME (SI, 32, PSI); > > Sorry, fingers

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-17 Thread Richard Sandiford
Mike Stump writes: > +/* Partial integer modes are specified by relation to a full integer > + mode. */ > +#define PARTIAL_INT_MODE(M,PREC) \ > + make_partial_integer_mode (#M, "P" #PREC #M, PREC, __FILE__, __LINE__) > +/* Partial integer modes are specified

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-17 Thread Mike Stump
On Sep 16, 2013, at 8:41 PM, DJ Delorie wrote: > m32c's PSImode is 24-bits, why does it have "32" in the macro? > > /* 24-bit pointers, in 32-bit units */ > -PARTIAL_INT_MODE (SI); > +PARTIAL_INT_MODE_NAME (SI, 32, PSI); Sorry, fingers copied the wrong number. Thanks for the catch. Index: gcc/

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-16 Thread DJ Delorie
m32c's PSImode is 24-bits, why does it have "32" in the macro? /* 24-bit pointers, in 32-bit units */ -PARTIAL_INT_MODE (SI); +PARTIAL_INT_MODE_NAME (SI, 32, PSI);

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-16 Thread Mike Stump
On Sep 16, 2013, at 2:09 AM, Richard Biener wrote: >> Here is the patch to add precision to partial int modes. I included >> switching over the rs6000 port to the new scheme so one can get a feel for >> that it would look like. > Can you instead of adding PARTIAL_INT_MODE_N change all existing

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-16 Thread Richard Biener
On Fri, Sep 13, 2013 at 10:23 PM, Mike Stump wrote: > On Sep 13, 2013, at 1:08 AM, Richard Sandiford > wrote: We don't really model that properly yet. Partial modes are just defined using something like: PARTIAL_INT_MODE (SI); > > True, but, all ports are trivial to fix so t

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-14 Thread Mike Stump
On Sep 14, 2013, at 1:57 AM, Richard Sandiford wrote: > How about a three-operand version: the name of the partial mode, > the name of the memory mode, and the precision? I like creating the name via algorithm. It leads to predictable names, and easy to understand names. P60DI is obvious to a

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-14 Thread Richard Sandiford
Mike Stump writes: > Here is the patch to add precision to partial int modes. I included > switching over the rs6000 port to the new scheme so one can get a feel > for that it would look like. > > I could trivially convert the remaining ports: > > config/bfin/bfin-modes.def:PARTIAL_INT_MODE (DI);

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-09-13 Thread Mike Stump
On Sep 13, 2013, at 1:08 AM, Richard Sandiford wrote: >>> We don't really model that properly yet. Partial modes are just defined >>> using something like: >>> >>> PARTIAL_INT_MODE (SI); True, but, all ports are trivial to fix so that the precision is included and for the interface to change