Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-12 Thread juzhe.zhong--- via Gcc-patches
Thanks Richard. I have addressed all comments on V7 patch: https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624220.html Drop vlse/vsse codegen optimization in RISC-V backend, instead I will support LEN_MASK_STRIDED_LOAD/LEN_MASK_STRIDE_STORE in the future. Thanks. juzhe.zh...@rivai.ai

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-12 Thread juzhe.zh...@rivai.ai
Subject: Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization On Wed, 12 Jul 2023, juzhe.zh...@rivai.ai wrote: > Thanks Richard. > > Is it correct that the better way is to add optabs > (len_strided_load/len_strided_store), > then expand LEN_M

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-12 Thread Richard Biener via Gcc-patches
uzhe.zh...@rivai.ai > > From: Richard Biener > Date: 2023-07-12 15:27 > To: juzhe.zh...@rivai.ai > CC: jeffreyalaw; gcc-patches; Kito.cheng; Robin Dapp; richard.sandiford > Subject: Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV > auto-vectorization > On Wed, 12

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-12 Thread juzhe.zh...@rivai.ai
expand_scatter_store_optab_fn of internal-fn.cc Am I right? Thanks. juzhe.zh...@rivai.ai From: Richard Biener Date: 2023-07-12 15:27 To: juzhe.zh...@rivai.ai CC: jeffreyalaw; gcc-patches; Kito.cheng; Robin Dapp; richard.sandiford Subject: Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization On

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-12 Thread Richard Biener via Gcc-patches
On Wed, 12 Jul 2023, juzhe.zh...@rivai.ai wrote: > I understand your concern. I CC Richards to see whether this piece of codes > is unsafe. > > Hi, Richard and Richi: > > Jeff is worrying about this codes in "expand_gather_scatter" of supporting > len_mask_gather_load/len_mask_scatter_store i

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-11 Thread juzhe.zh...@rivai.ai
I understand your concern. I CC Richards to see whether this piece of codes is unsafe. Hi, Richard and Richi: Jeff is worrying about this codes in "expand_gather_scatter" of supporting len_mask_gather_load/len_mask_scatter_store in RISC-V port. The codes are as follows: +/* Return true if i

Re: Re: [PATCH V5] RISC-V: Support gather_load/scatter RVV auto-vectorization

2023-07-11 Thread juzhe.zh...@rivai.ai
Hi, Jeff. >> Hmm, I'm not sure this is safe, especially if gimple->rtl expansion is >> complete. While you might be able to get REG_EXPR, I would not really >> expect SSA_NAME_DEF_STMT to be correct. At the least it'll need some >> way to make sure it's not called at an inappropriate time. I thi