Re: RFC ThreadSanitizer tests

2013-12-05 Thread Mike Stump
On Dec 4, 2013, at 10:12 PM, max wrote: > Here is a patch with initial ThreadSanitizer testsuite. It basically adds > several tests from upstream LLVM testsuite. > It works fine on x86_64 with patch from > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59188 applied. > Ok to commit Ok. > should

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Yury Gribov
>> Ok to commit? > Sure, that was the "Ok, thanks." in the previous mail. Commited in r205704. -Y

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Maxim Ostapenko
> 2013-12-05 Max Ostapenko < m.ostape...@partner.samsung.com > > 2013-12-05 Max Ostapenko actually. Ok, I'm sorry, I'll fix it. Ok to commit? -Maxim 2013-12-05 Max Ostapenko * c-c++-common/tsan/atomic_stack.c: New test. * c-c++-common/tsan/fd_pipe_race.c: New test.

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 02:51:44PM +0400, Maxim Ostapenko wrote: > >2013-12-05 Max Ostapenko > >2013-12-05 Max Ostapenko actually. > > Ok, I'm sorry, I'll fix it. Ok to commit? Sure, that was the "Ok, thanks." in the previous mail. Jakub

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 02:19:35PM +0400, Maxim Ostapenko wrote: > > Instead of mentioning the directory in the ChangeLog, > > mention the individual test files. > > ... > >* g++.dg/dg.exp: Prune tsan subdirectory. > > Thanks, I fixed the ChangeLog file. > > > how long does it take to run mak

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Maxim Ostapenko
> Instead of mentioning the directory in the ChangeLog, > mention the individual test files. > ... >* g++.dg/dg.exp: Prune tsan subdirectory. Thanks, I fixed the ChangeLog file. > how long does it take to run make check-gcc check-g++ RUNTESTFLAGS=tsan.exp ? > How much memory does it need?

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 12:30:21PM +0400, Konstantin Serebryany wrote: > my 2c: running all upstream tsan tests (ninja check-tsan) takes 10 > seconds on my (beefy) machine and requires rather little memory. > Of course, you need lots of *virtual* memory. *virtual* memory is acceptable, not very ni

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Konstantin Serebryany
my 2c: running all upstream tsan tests (ninja check-tsan) takes 10 seconds on my (beefy) machine and requires rather little memory. Of course, you need lots of *virtual* memory. On Thu, Dec 5, 2013 at 12:07 PM, Jakub Jelinek wrote: > On Thu, Dec 05, 2013 at 10:12:36AM +0400, max wrote: >> Hello,

Re: RFC ThreadSanitizer tests

2013-12-05 Thread Jakub Jelinek
On Thu, Dec 05, 2013 at 10:12:36AM +0400, max wrote: > Hello, > > Here is a patch with initial ThreadSanitizer testsuite. It basically > adds several tests from upstream LLVM testsuite. > It works fine on x86_64 with patch from > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59188 applied. > > Ok t