On Thu, Dec 05, 2013 at 10:12:36AM +0400, max wrote:
> Hello,
> 
> Here is a patch with initial ThreadSanitizer testsuite. It basically
> adds several tests from upstream LLVM testsuite.
> It works fine on x86_64 with patch from
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59188 applied.
> 
> Ok to commit or should we wait for fix for 59188?

How costly the tests are?  I see that the tests have at most 3 threads,
so it hopefully doesn't affect that much parallel testing, but how long
does it take to run make check-gcc check-g++ RUNTESTFLAGS=tsan.exp ?
How much memory does it need?

> 2013-12-05  Max Ostapenko <m.ostape...@partner.samsung.com>

One extra space missing before <.
> 
>       * c-c++-common/tsan: New folder with tests added.

Instead of mentioning the directory in the ChangeLog, mention
the individual test files.
        * c-c++-common/tsan/atomic_stack.c: New test.
...

>       * lib/tsan-dg.exp: New testfiles.

                         : New file.

>       * gcc.dg/tsan/tsan.exp: New testfiles.

                              : New file.

>       * g++.dg/dg.exp: Add tsan directory to the list
>       of folders that are handled specially.

        * g++.dg/dg.exp: Prune tsan subdirectory.


        Jakub

Reply via email to