Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-09 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jan 4, 2013 at 7:57 PM, Eric Botcazou wrote: >>> Eric, any comments? >> >> Richard's patch seems fine to me, modulo the name of the routine; I'd rather >> use maybe_emit_group_store or something along these lines. > > Ok, fine with me - you're clearly more experie

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-05 Thread Richard Biener
On Fri, Jan 4, 2013 at 7:57 PM, Eric Botcazou wrote: >> Hmm, how would anyone else get at the "padding" info dealing with the >> parallel? This looks broken if we need access to the type :/ > > Yes, you need to access the type for return values, but that's not really new. Ick :/ >> Eric, any co

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-04 Thread Eric Botcazou
> Hmm, how would anyone else get at the "padding" info dealing with the > parallel? This looks broken if we need access to the type :/ Yes, you need to access the type for return values, but that's not really new. > Eric, any comments? Richard's patch seems fine to me, modulo the name of the ro

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-04 Thread Richard Biener
On Thu, Jan 3, 2013 at 7:42 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Jan 2, 2013 at 5:36 PM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Sun, Dec 23, 2012 at 10:43 AM, Richard Sandiford wrote: > Some of the maths builtins can expand to a call

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-03 Thread Richard Sandiford
Richard Biener writes: > On Wed, Jan 2, 2013 at 5:36 PM, Richard Sandiford > wrote: >> Richard Biener writes: >>> On Sun, Dec 23, 2012 at 10:43 AM, Richard Sandiford >>> wrote: Some of the maths builtins can expand to a call followed by a bit of postprocessing. With 4.8's PARALLEL re

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-03 Thread Richard Biener
On Wed, Jan 2, 2013 at 5:36 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Sun, Dec 23, 2012 at 10:43 AM, Richard Sandiford >> wrote: >>> Some of the maths builtins can expand to a call followed by a bit >>> of postprocessing. With 4.8's PARALLEL return optimisations, these >>> emb

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-02 Thread Richard Sandiford
Richard Biener writes: > On Sun, Dec 23, 2012 at 10:43 AM, Richard Sandiford > wrote: >> Some of the maths builtins can expand to a call followed by a bit >> of postprocessing. With 4.8's PARALLEL return optimisations, these >> embedded calls might return a PARALLEL of pseudos, but the postproce

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2013-01-02 Thread Richard Biener
On Sun, Dec 23, 2012 at 10:43 AM, Richard Sandiford wrote: > Some of the maths builtins can expand to a call followed by a bit > of postprocessing. With 4.8's PARALLEL return optimisations, these > embedded calls might return a PARALLEL of pseudos, but the postprocessing > isn't prepared to deal

Re: RFA: Fix ICE on PARALLEL returns when expand builtins

2012-12-26 Thread Andrew Pinski
On Sun, Dec 23, 2012 at 1:43 AM, Richard Sandiford wrote: > Some of the maths builtins can expand to a call followed by a bit > of postprocessing. With 4.8's PARALLEL return optimisations, these > embedded calls might return a PARALLEL of pseudos, but the postprocessing > isn't prepared to deal w