Re: Ping: C-family stack check for threads

2011-09-20 Thread Joseph S. Myers
Please post your pings under a more meaningful subject line that indicates that this is an ARM back-end and middle-end patch. It's not a C-family patch, C-family maintainers can't give it any useful review. -- Joseph S. Myers jos...@codesourcery.com

Re: Ping: C-family stack check for threads

2011-09-05 Thread Thomas Klein
On 09/05/11 09:45, Ye Joey wrote: + /* check if we can use one of the argument registers r0..r3 as long as they + * not holding data*/ + for (reg = 0; reg<= LAST_ARG_REGNUM&& i< 2; reg++) ... + n = (reg + 1) % 4; Avoid immediate register number. use ARG_REGISTER (1) to replace "r

Re: Ping: C-family stack check for threads

2011-09-05 Thread Ye Joey
On Mon, Sep 5, 2011 at 1:45 AM, Thomas Klein wrote: > +static int > +stack_check_work_registers (rtx *workreg) > +{ > + int reg, i, k, n, nregs; > + > + if (crtl->args.info.pcs_variant <= ARM_PCS_AAPCS_LOCAL) > +{ > + nregs = crtl->args.info.aapcs_next_ncrn; > +} > + else > +n

Re: Ping: C-family stack check for threads

2011-08-02 Thread Thomas Klein
Hello Here is my next try to put the stack check into rtl at prologue stage. To me, it was not as easy as I hoped. I've had little problems to get push/pop and the compare/jump working. Hoping the way i choose is acceptable. With rtl no extra pool to hold pointer or size values is required any mo

Re: Ping: C-family stack check for threads

2011-07-13 Thread Hans-Peter Nilsson
On Sun, 3 Jul 2011, Thomas Klein wrote: > Ye Joey wrote: > > Thomas, > > > > I think your are working on a very useful feature. I have ARM MCU > > applications running of out stack space and resulting strange > > behaviors silently. I'd like to try your patch and probably give > > further comm

Re: Ping: C-family stack check for threads

2011-07-05 Thread Richard Henderson
On 07/04/2011 03:25 PM, Thomas Klein wrote: > There is a emit_multi_reg_push but is there something like > emit_multi_reg_pop, too. There's a multi-reg push because that's one instruction. > Are the other operations (compare, branche, ..) still allowed? Of course. Everything is still allowed.

Re: Ping: C-family stack check for threads

2011-07-04 Thread Thomas Klein
Richard Henderson wrote: On 07/03/2011 08:06 AM, Thomas Klein wrote: > +/* > + * Write prolouge part of stack check into asm file. > + * For Thumb this may look like this: > + * push {rsym,ramn} > + * ldr rsym, .LSPCHK0 > + * ldr rsym, [rsym] > + * ldr ramn, .LSPCHK0 + 4 >

Re: Ping: C-family stack check for threads

2011-07-03 Thread Richard Henderson
On 07/03/2011 08:06 AM, Thomas Klein wrote: > +/* > + * Write prolouge part of stack check into asm file. > + * For Thumb this may look like this: > + * push {rsym,ramn} > + * ldr rsym, .LSPCHK0 > + * ldr rsym, [rsym] > + * ldr ramn, .LSPCHK0 + 4 > + * add rsym, rsym, ramn > + * cmp sp,

Re: Ping: C-family stack check for threads

2011-07-03 Thread Thomas Klein
Ye Joey wrote: Thomas, I think your are working on a very useful feature. I have ARM MCU applications running of out stack space and resulting strange behaviors silently. I'd like to try your patch and probably give further comments - Joey Hi Due to convention of of thumb prologue to rt

Re: Ping: C-family stack check for threads

2011-06-29 Thread Ye Joey
On Fri, Jun 24, 2011 at 11:51 PM, Thomas Klein wrote: > > Hi > > This is a ping of (http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01226.html). > Repeating my request. > > I would like to have a stack check for threads with small amount of stack > space per thread. > (I'm using a ARM Cortex-M3 micr