On Sun, 3 Jul 2011, Thomas Klein wrote: > Ye Joey wrote: > > Thomas, > > > > I think your are working on a very useful feature. I have ARM MCU > > applications running of out stack space and resulting strange > > behaviors silently. I'd like to try your patch and probably give > > further comments
I also think this will be a very useful feature (not just "for threads"), and I hope you'll persevere through the review process. ;) Not your first patch and you have copyright assignments in place, so that's covered. The first thing I see is that you need to fix the issues regarding the GCC coding standards, <http://gcc.gnu.org/codingconventions.html> as that is a hurdle for reviewers, and you don't want that. Be very careful. I haven't ran contrib/check_GNU_style.sh myself but maybe it'll be helpful. The second issue I see is that documentation for the new patterns is missing, that should go in gcc/doc/md.texi, somewhere under @node Standard Names. I can imagine there'll be a thing or two to tweak regarding them and that best reviewed through the documentation. Generally, as much as possible should be general and not ARM-specific. If you need helper functions, add them to libgcc. > > Regards > Thomas Klein > > gcc/ChangeLog > 2011-07-03 Thomas Klein<th.r.kl...@web.de> <mailto:th.r.kl...@web.de> > > * opts.c (common_handle_option): introduce additional stack checking > parameters "direct" and "indirect" > * flag-types.h (enum stack_check_type): Likewise > * explow.c (allocate_dynamic_stack_space): > - suppress stack probing if parameter "direct", "indirect" or if a > stack-limit is given > - do additional read of limit value if parameter "indirect" and a > stack-limit symbol is given > - emit a call to a stack_failure function [as an alternative to a trap > call] No bullet list in the changelog, please. Individual sentences. Follow the existing format; full sentences with capitalization and all that. brgds, H-P
