On Wed, Jul 13, 2016 at 09:05:26PM +0200, Marc Glisse wrote:
> > > Unrelated question: are there cases where __builtin_fallthrough() has any
> > > impact on code generation?
> >
> > It should not -- my implementation gets rid of all __builtin_fallthrough()
> > during gimple-low, before most of the
On Tue, Jul 12, 2016 at 10:10:23AM -0600, Jeff Law wrote:
> On 07/11/2016 01:43 PM, Marek Polacek wrote:
> > The switch fallthrough has been widely considered a design defect in C, a
> > misfeature or, to use Marshall Cline's definition, evil. The overwhelming
> > majority of the time you don't wa
Coming back to this...
On Tue, Jul 12, 2016 at 03:00:43PM -0600, Martin Sebor wrote:
> > This patch is accompanied by more than 2000 lines of new tests to get the
> > warning covered though I'm sure folks will come up with other test cases
> > that I hadn't considered (hi Martin S. ;).
> >
> > Th
Where the comments just say "Fall through", or equivalent, and there's
no other explanation I think those comments are now redundant and should
be removed.
So remove:
/* Fall through. */
but keep things like:
/* Fall through - if the lane index isn't a constant then
On Wed, Jul 13, 2016 at 03:35:10PM -0700, Bruce Korb wrote:
> Actually, it occurs to me:
>
> On Wed, Jul 13, 2016 at 11:23 AM, Marek Polacek wrote:
> > My current implementation warns here, but the warning can be suppressed
> > by adding /* FALLTHRU */ or [...]
>
> that the traditional "lint-ean
Actually, it occurs to me:
On Wed, Jul 13, 2016 at 11:23 AM, Marek Polacek wrote:
> My current implementation warns here, but the warning can be suppressed
> by adding /* FALLTHRU */ or [...]
that the traditional "lint-ean" spelling is "/* FALLTHROUGH */", so
why would the abbrev be accepted and
On Wed, 13 Jul 2016, Marek Polacek wrote:
On Wed, Jul 13, 2016 at 08:39:28PM +0200, Marc Glisse wrote:
On Wed, 13 Jul 2016, Marek Polacek wrote:
Does "__attribute__((fallthrough));" have any advantages over
"__builtin_fallthrough()"?
Not a strong argument, but compilers that don't know the
On Wed, Jul 13, 2016 at 11:39 AM, Marek Polacek wrote:
> Most likely what you saw was in cxx_pretty_printer::declaration_specifiers.
I only saw it once and, of course, it was once too often. ;)
If you fix it, it would sooth my sensibilities as the fixincludes maintainer,
making mine a small voice
On Wed, Jul 13, 2016 at 08:39:28PM +0200, Marc Glisse wrote:
> On Wed, 13 Jul 2016, Marek Polacek wrote:
>
> > Does "__attribute__((fallthrough));" have any advantages over
> > "__builtin_fallthrough()"?
>
> Not a strong argument, but compilers that don't know the construct will give
> an error o
On Wed, Jul 13, 2016 at 11:30:34AM -0700, Bruce Korb wrote:
> > On Mon, Jul 11, 2016 at 01:36:02PM -0700, Bruce Korb wrote:
> > [[putrid code deleted]]
> >> Does this patch mean that the above got fixed? I mean, if you're
> >> going to fret over linguistic tags to make falling through explicit,
>
On Wed, 13 Jul 2016, Marek Polacek wrote:
Does "__attribute__((fallthrough));" have any advantages over
"__builtin_fallthrough()"?
Not a strong argument, but compilers that don't know the construct will
give an error on the builtin, and just a warning on the attribute (and
ignore the comment
> On Mon, Jul 11, 2016 at 01:36:02PM -0700, Bruce Korb wrote:
> [[putrid code deleted]]
>> Does this patch mean that the above got fixed? I mean, if you're
>> going to fret over linguistic tags to make falling through explicit,
>> it would seem the above code is pretty sore-thumby, yes?
>
> My cur
On Mon, Jul 11, 2016 at 01:36:02PM -0700, Bruce Korb wrote:
> I'm curious about this. In the process of developing a code analysis
> tool, I found some GCC code that was, basically:
>
> switch (v) {
> case 0:
> if (e) {
> do_something();
> } else {
> case 1:
> do_something_else();
>
On Mon, Jul 11, 2016 at 04:28:32PM -0400, NightStrike wrote:
> On Mon, Jul 11, 2016 at 3:43 PM, Marek Polacek wrote:
> > But then the [[fallthrough]] attribute was
> > approved for C++17 [1], and that's what has got me to do all this.
> > ...
> > I added a new builtin,
> > __builtin_fallthrough,
This patch is accompanied by more than 2000 lines of new tests to get the
warning covered though I'm sure folks will come up with other test cases
that I hadn't considered (hi Martin S. ;).
This warning is enabled by default for C/C++. I was more inclined to put this
into -Wall, but our common.o
On Tue, Jul 12, 2016 at 11:40:01AM -0600, Martin Sebor wrote:
> On 07/12/2016 10:04 AM, Marek Polacek wrote:
> > On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote:
> > > On 07/12/2016 04:30 AM, Marek Polacek wrote:
> > > > On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote:
> > >
On 07/12/2016 10:04 AM, Marek Polacek wrote:
On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote:
On 07/12/2016 04:30 AM, Marek Polacek wrote:
On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote:
If [[fallthrough]]
was approved for C++17 is there sth similar proposed for C? Li
On 07/11/2016 01:43 PM, Marek Polacek wrote:
The switch fallthrough has been widely considered a design defect in C, a
misfeature or, to use Marshall Cline's definition, evil. The overwhelming
majority of the time you don't want to fall through to the next case, but it is
easy to forget to "brea
On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote:
> On 07/12/2016 04:30 AM, Marek Polacek wrote:
> > On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote:
> > > If [[fallthrough]]
> > > was approved for C++17 is there sth similar proposed for C? Like a
> > > keyword
> > > __Fall
On 07/12/2016 04:30 AM, Marek Polacek wrote:
On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote:
On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote:
The switch fallthrough has been widely considered a design defect in C, a
misfeature or, to use Marshall Cline's definition, evil.
On Tue, Jul 12, 2016 at 04:42:21PM +0200, Bernd Schmidt wrote:
> On 07/12/2016 04:19 PM, Marek Polacek wrote:
> >
> >>>@@ -30191,6 +30200,7 @@ rs6000_adjust_cost (rtx_insn *insn, rtx link,
> >>>rtx_insn *dep_insn, int cost)
> >>> && (INSN_CODE (dep_insn) >= 0)
> >>>
On 07/12/2016 04:19 PM, Marek Polacek wrote:
@@ -30191,6 +30200,7 @@ rs6000_adjust_cost (rtx_insn *insn, rtx link, rtx_insn
*dep_insn, int cost)
&& (INSN_CODE (dep_insn) >= 0)
&& (get_attr_type (dep_insn) == TYPE_MFFGPR))
return 2;
+ g
On Tue, Jul 12, 2016 at 04:22:30PM +0200, Bernd Schmidt wrote:
> On 07/12/2016 04:14 PM, Jakub Jelinek wrote:
> >On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote:
> >>On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote:
> >>>From http://security.coverity.com/blog/2013/Sep/gimme
On 07/12/2016 04:14 PM, Jakub Jelinek wrote:
On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote:
On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote:
From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html:
Thanks, this is useful.
We also suppress a case labe
On Tue, Jul 12, 2016 at 09:10:54AM -0500, Segher Boessenkool wrote:
> Hi Marek,
>
> On Mon, Jul 11, 2016 at 09:59:39PM +0200, Marek Polacek wrote:
> > 2016-07-11 Marek Polacek
> >
> > PR c/7652
> > * config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass): Likewise.
>
> Likewise?
On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote:
> From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html:
Thanks, this is useful.
> We also suppress a case label if there is a comment that matches
> [^#]fall.?thro?u, even if it's not on the last line.
Our current plan i
On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote:
> On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote:
> > From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html:
>
> Thanks, this is useful.
>
> > We also suppress a case label if there is a comment that matches
Hi Marek,
On Mon, Jul 11, 2016 at 09:59:39PM +0200, Marek Polacek wrote:
> 2016-07-11 Marek Polacek
>
> PR c/7652
> * config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass): Likewise.
Likewise? Like what? :-)
> --- gcc/gcc/config/rs6000/rs6000.c
> +++ gcc/gcc/config/rs6000/
On Mon, Jul 11, 2016 at 4:34 PM, Jakub Jelinek wrote:
> On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote:
>> On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote:
>> > > I explained why supporting the classic lint style comment wouldn't fly.
>> >
>> > Not convincing, it worked f
On Tue, Jul 12, 2016 at 01:24:15PM +0200, Bernd Schmidt wrote:
> On 07/11/2016 09:43 PM, Marek Polacek wrote:
> > This warning is enabled by default for C/C++. I was more inclined to put
> > this
> > into -Wall, but our common.opt machinery doesn't seem to allow that (ugh!).
>
> Add me to the li
On 07/11/2016 09:43 PM, Marek Polacek wrote:
This warning is enabled by default for C/C++. I was more inclined to put this
into -Wall, but our common.opt machinery doesn't seem to allow that (ugh!).
Add me to the list of folks opposed to enabling this unconditionally or
as part of any other -
On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote:
> On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote:
> > The switch fallthrough has been widely considered a design defect in C, a
> > misfeature or, to use Marshall Cline's definition, evil. The overwhelming
> > majority of the t
On Tue, Jul 12, 2016 at 12:22:55PM +0200, Richard Biener wrote:
> > @@ -254,6 +260,7 @@ parse_table_entry (char *p, struct ld_plugin_symbol
> > *entry,
> > break;
> > }
> > /* FALL-THROUGH. */
> > +lto_fallthrough ();
>
> This shows me that it would be nice to simply g
On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote:
> The switch fallthrough has been widely considered a design defect in C, a
> misfeature or, to use Marshall Cline's definition, evil. The overwhelming
> majority of the time you don't want to fall through to the next case, but it
> is
> easy
On Mon, Jul 11, 2016 at 9:58 PM, Marek Polacek wrote:
> 2016-07-11 Marek Polacek
>
> PR c/7652
> * lto-plugin.c (lto_fallthrough): Define.
> (parse_table_entry): Use it.
>
> diff --git gcc/lto-plugin/lto-plugin.c gcc/lto-plugin/lto-plugin.c
> index 51afc52..ffdf54a 10064
On 11 July 2016 at 20:57, Marek Polacek wrote:
>
> 2016-07-11 Marek Polacek
>
> PR c/7652
> * libsupc++/hash_bytes.cc: Use __builtin_fallthrough.
>
> diff --git gcc/libstdc++-v3/libsupc++/hash_bytes.cc
> gcc/libstdc++-v3/libsupc++/hash_bytes.cc
> index 2e5bbfa..818331f 100644
>
> "Marek" == Marek Polacek writes:
Marek> +++ gcc/gcc/java/jcf-dump.c
Marek> @@ -926,6 +926,8 @@ print_constant (FILE *out, JCF *jcf, int index, int
verbosity)
Marek>if (verbosity > 0)
Marek> fprintf (out, "Fieldref: %ld=", (long) JPOOL_USHORT2 (jcf,
index));
Marek>
On Mon, Jul 11, 2016 at 04:43:57PM -0400, David Malcolm wrote:
> On Mon, 2016-07-11 at 22:34 +0200, Jakub Jelinek wrote:
> > On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote:
> > > On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote:
> > > > > I explained why supporting the clas
On Mon, 2016-07-11 at 22:34 +0200, Jakub Jelinek wrote:
> On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote:
> > On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote:
> > > > I explained why supporting the classic lint style comment
> > > > wouldn't fly.
> > >
> > > Not convincin
On Mon, 2016-07-11 at 22:20 +0200, Marek Polacek wrote:
> On Mon, Jul 11, 2016 at 10:11:52PM +0200, Jakub Jelinek wrote:
> > On Mon, Jul 11, 2016 at 10:08:02PM +0200, Eric Botcazou wrote:
> > > > After I'd completed the warning, I kicked off a bootstrap so as
> > > > to add
> > > > various gcc_fall
I'm curious about this. In the process of developing a code analysis
tool, I found some GCC code that was, basically:
switch (v) {
case 0:
if (e) {
do_something();
} else {
case 1:
do_something_else();
}
}
Does this patch mean that the above got fixed? I mean, if you're
going to f
On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote:
> On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote:
> > > I explained why supporting the classic lint style comment wouldn't fly.
> >
> > Not convincing, it worked fine for 30+ years of lints.
>
> So how can the compiler han
> I think that if *we* refuse to use __builtin_fallthrough, then we can't
> expect users to use it.
No disagreement, but this doesn't change my mind on the thing... IMO there
ought to be a simple & standard way of silencing the warning if it is enabled
by default, otherwise this will very likel
On Mon, Jul 11, 2016 at 3:43 PM, Marek Polacek wrote:
> But then the [[fallthrough]] attribute was
> approved for C++17 [1], and that's what has got me to do all this.
> ...
> I added a new builtin,
> __builtin_fallthrough, that prevents the warning from occurring. It can only
> be used in a swi
On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote:
> > I explained why supporting the classic lint style comment wouldn't fly.
>
> Not convincing, it worked fine for 30+ years of lints.
So how can the compiler handle
/* Never ever fall through here */
?
Marek
On Mon, Jul 11, 2016 at 10:11:52PM +0200, Jakub Jelinek wrote:
> On Mon, Jul 11, 2016 at 10:08:02PM +0200, Eric Botcazou wrote:
> > > After I'd completed the warning, I kicked off a bootstrap so as to add
> > > various gcc_fallthrough calls. There were a good amount of them, as
> > > expected. I
> I explained why supporting the classic lint style comment wouldn't fly.
Not convincing, it worked fine for 30+ years of lints.
-Andi
--
a...@linux.intel.com -- Speaking for myself only.
On Mon, Jul 11, 2016 at 10:08:02PM +0200, Eric Botcazou wrote:
> > After I'd completed the warning, I kicked off a bootstrap so as to add
> > various gcc_fallthrough calls. There were a good amount of them, as
> > expected. I also grepped various FALLTHRU/Falls through/...fall
> > thru.../... com
> After I'd completed the warning, I kicked off a bootstrap so as to add
> various gcc_fallthrough calls. There were a good amount of them, as
> expected. I also grepped various FALLTHRU/Falls through/...fall
> thru.../... comments in config/ and added gcc_fallthroughs to make it
> easier for peo
On Mon, Jul 11, 2016 at 01:01:05PM -0700, Andi Kleen wrote:
> Marek Polacek writes:
> >
> > This warning is enabled by default for C/C++.
>
> That's purely evil. So have to put your non standard builtin all over
> standards compliant code just to shut off a warning that is likely
> common. And yo
On Mon, Jul 11, 2016 at 1:01 PM, Marek Polacek wrote:
> On Mon, Jul 11, 2016 at 12:59:51PM -0700, Andrew Pinski wrote:
>> I don't like it being default turned on or even part of -Wall. As
>> evidence all of the patches that comes after this is the main reason
>> why.
>
> Ok, moving this to -Wextr
On Mon, Jul 11, 2016 at 12:59:51PM -0700, Andrew Pinski wrote:
> I don't like it being default turned on or even part of -Wall. As
> evidence all of the patches that comes after this is the main reason
> why.
Ok, moving this to -Wextra is rather trivial.
Marek
Marek Polacek writes:
>
> This warning is enabled by default for C/C++.
That's purely evil. So have to put your non standard builtin all over
standards compliant code just to shut off a warning that is likely
common. And you're not even supporting the classic lint style comment either.
I think i
2016-07-11 Marek Polacek
PR c/7652
* c-c++-common/Wswitch-unreachable-1.c: Add __builtin_fallthrough.
* c-c++-common/pr44832.c: Likewise.
* g++.dg/lto/20090128_0.C: Likewise.
* g++.dg/opt/pr14029.C: Likewise.
* g++.dg/opt/pr45412.C: Likewise.
On Mon, Jul 11, 2016 at 12:43 PM, Marek Polacek wrote:
> The switch fallthrough has been widely considered a design defect in C, a
> misfeature or, to use Marshall Cline's definition, evil. The overwhelming
> majority of the time you don't want to fall through to the next case, but it
> is
> eas
2016-07-11 Marek Polacek
PR c/7652
* config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass): Likewise.
(rs6000_legitimate_offset_address_p): Likewise.
(rs6000_emit_move): Likewise.
(altivec_expand_ld_builtin): Likewise.
(altivec_expand_st_buil
2016-07-11 Marek Polacek
PR c/7652
* config/alpha/alpha.c (alpha_rtx_costs): Likewise.
(alpha_legitimate_constant_p): Likewise.
(alpha_emit_setcc): Likewise.
(alpha_emit_xfloating_libcall): Likewise.
(alpha_function_value_1): Likewise.
(al
2016-07-11 Marek Polacek
PR c/7652
* objc-encoding.c (encode_type): Add gcc_fallthrough.
diff --git gcc/gcc/objc/objc-encoding.c gcc/gcc/objc/objc-encoding.c
index 41ac6a4..cc64e1b 100644
--- gcc/gcc/objc/objc-encoding.c
+++ gcc/gcc/objc/objc-encoding.c
@@ -622,6 +622,7 @@ enco
2016-07-11 Marek Polacek
PR c/7652
* lto-plugin.c (lto_fallthrough): Define.
(parse_table_entry): Use it.
diff --git gcc/lto-plugin/lto-plugin.c gcc/lto-plugin/lto-plugin.c
index 51afc52..ffdf54a 100644
--- gcc/lto-plugin/lto-plugin.c
+++ gcc/lto-plugin/lto-plugin.c
@@
2016-07-11 Marek Polacek
PR c/7652
* libsupc++/hash_bytes.cc: Use __builtin_fallthrough.
diff --git gcc/libstdc++-v3/libsupc++/hash_bytes.cc
gcc/libstdc++-v3/libsupc++/hash_bytes.cc
index 2e5bbfa..818331f 100644
--- gcc/libstdc++-v3/libsupc++/hash_bytes.cc
+++ gcc/libstdc++-v
2016-07-11 Marek Polacek
PR c/7652
* runtime/heapdump.c (dumpefacetypes): Add break.
diff --git gcc/libgo/runtime/heapdump.c gcc/libgo/runtime/heapdump.c
index d0cfb01..1ce8aa2 100644
--- gcc/libgo/runtime/heapdump.c
+++ gcc/libgo/runtime/heapdump.c
@@ -766,6 +766,7 @@ dumpefa
2016-07-11 Marek Polacek
PR c/7652
* cp-demangle.c (d_print_comp_inner): Use D_FALLTHRU.
(d_print_mod): Likewise.
* cplus-dem.c (demangle_signature): Likewise.
(demangle_fund_type): Likewise.
(do_hpacc_template_const_value): Likewise.
* d-
2016-07-11 Marek Polacek
PR c/7652
* libgomp.h (gomp_fallthrough): Define.
* oacc-init.c (resolve_device): Use gomp_fallthrough.
* testsuite/libgomp.c++/cancel-parallel-2.C: Add __builtin_fallthrough.
* testsuite/libgomp.c/cancel-parallel-2.c: Add __built
2016-07-11 Marek Polacek
PR c/7652
* soft-fp/soft-fp.h (_FP_FALLTHRU): Define.
* soft-fp/op-common.h: Use it.
diff --git gcc/libgcc/soft-fp/op-common.h gcc/libgcc/soft-fp/op-common.h
index 080ef0e..6691f50 100644
--- gcc/libgcc/soft-fp/op-common.h
+++ gcc/libgcc/soft-fp
2016-07-11 Marek Polacek
PR c/7652
* internal.h (CPP_FALLTHRU): Define.
* expr.c (_cpp_parse_expr): Use CPP_FALLTHRU.
* lex.c (search_line_fast): Likewise.
(lex_raw_string): Likewise.
(_cpp_lex_direct): Likewise.
(cpp_token_val_index): Lik
2016-07-11 Marek Polacek
PR c/7652
* libatomic_i.h (libat_fallthrough): New macro.
* gcas.c (libat_compare_exchange): Use libat_fallthrough.
* gexch.c (libat_exchange): Likewise.
* glfree.c (libat_is_lock_free): Likewise.
* gload.c (libat_load): L
2016-07-11 Marek Polacek
PR c/7652
* expr.c (java_truthvalue_conversion): Add gcc_fallthrough.
(type_assertion_hasher::hash): Likewise.
* jcf-dump.c (print_constant): Likewise.
* jcf-io.c (verify_constant_pool): Likewise.
* typeck.c (promote_type)
2016-07-11 Marek Polacek
PR c/7652
* config/i386/driver-i386.c (decode_caches_intel): Likewise.
(detect_caches_cpuid4): Likewise.
* config/i386/i386-c.c (ix86_target_macros_internal): Likewise.
* config/i386/i386.c (function_arg_advance_32): Likewise.
2016-07-11 Marek Polacek
PR c/7652
* go-system.h (go_fallthrough): New macro.
* gofrontend/escape.cc (Escape_analysis_assign::statement): Use it.
(Escape_analysis_assign::assign): Likewise.
* gofrontend/expressions.cc
(Binary_expression::do_get_b
2016-07-11 Marek Polacek
PR c/7652
* config/aarch64/aarch64-builtins.c (aarch64_simd_expand_args): Add
gcc_fallthrough.
* config/aarch64/aarch64-simd.md: Likewise.
* config/aarch64/aarch64.c (aarch64_expand_mov_immediate): Likewise.
(aarch64_print_operan
2016-07-11 Marek Polacek
PR c/7652
* Makefile.in (insn-attrtab.o-warn, insn-dfatab.o-warn,
insn-latencytab.o-warn, insn-output.o-warn, insn-emit.o-warn): Add
-Wno-switch-fallthrough.
* alias.c (find_base_value): Add gcc_fallthrough.
(find_base_ter
2016-07-11 Marek Polacek
PR c/7652
* call.c (add_builtin_candidate): Add gcc_fallthrough.
(add_builtin_candidates): Likewise.
(build_integral_nontype_arg_conv): Likewise.
(build_new_op_1): Likewise.
(convert_like_real): Likewise.
* cfns.h
2016-07-11 Marek Polacek
PR c/7652
* arith.c (eval_intrinsic): Add gcc_fallthrough.
* array.c (gfc_ref_dimen_size): Likewise.
(gfc_array_dimen_size): Likewise.
* cpp.c (gfc_cpp_handle_option): Likewise.
(cb_cpp_error): Likewise.
* decl.c (
2016-07-11 Marek Polacek
PR c/7652
* c-ada-spec.c (print_ada_macros): Add gcc_fallthrough.
(to_ada_name): Likewise.
(dump_generic_ada_node): Likewise.
(dump_nested_type): Likewise.
* c-common.c (warn_if_unused_value): Likewise.
(sizeof_poi
2016-07-11 Marek Polacek
PR c/7652
* c-array-notation.c (expand_array_notations): Add gcc_fallthrough.
* c-decl.c (pop_scope): Likewise.
(grokdeclarator): Likewise.
(get_parm_info): Likewise.
* c-objc-common.c (c_tree_printer): Likewise.
*
2016-07-11 Marek Polacek
PR c/7652
* builtins.c (expand_builtin): Handle BUILT_IN_FALLTHROUGH.
* builtins.def: Add BUILT_IN_FALLTHROUGH.
* common.opt (Wswitch-fallthrough): New option.
* doc/extend.texi: Document __builtin_fallthrough.
* doc/invok
76 matches
Mail list logo
