Re: [patch, libgfortran] PR67367 Program crashes on READ

2015-08-29 Thread Jerry DeLisle
On 08/28/2015 10:18 PM, Jerry DeLisle wrote: > I found that in read_buf where raw_read is called, no checks for errors were > being made, raw_read returns the number of bytes read or an error code. In > the > test case, an error occurs and we proceeded to use the resulting error code as > if it

Re: [patch, libgfortran] PR67367 Program crashes on READ

2015-08-29 Thread Jerry DeLisle
On 08/28/2015 11:59 PM, FX wrote: > Hi Jerry, > > The patch is OK, but I’m a bit puzzled about what the testcase does. > > It tests that we can OPEN a directory, but not READ from it? I didn’t know > that was expected (to be able to OPEN a directory), and I find it somewhat > puzzling. Can you

Re: [patch, libgfortran] PR67367 Program crashes on READ

2015-08-29 Thread FX
Hi Jerry, The patch is OK, but I’m a bit puzzled about what the testcase does. It tests that we can OPEN a directory, but not READ from it? I didn’t know that was expected (to be able to OPEN a directory), and I find it somewhat puzzling. Can you shed light on that? Thanks, FX