On 08/28/2015 11:59 PM, FX wrote:
> Hi Jerry,
> 
> The patch is OK, but I’m a bit puzzled about what the testcase does.
> 
> It tests that we can OPEN a directory, but not READ from it? I didn’t know 
> that was expected (to be able to OPEN a directory), and I find it somewhat 
> puzzling. Can you shed light on that?
> 
> Thanks,
> FX
> 

According to my man pages, open is used to open a directory as read only and
readdir must be used to actually read it.  It is not allowed to open a directory
with write access.  The test case is checking that the open works as expected
and the attempt to read using 'read' results in the error (no segfault)

Jerry

PS thanks for the review.

Reply via email to