ok for google branch.
David
On Wed, Jan 15, 2014 at 2:58 PM, Rong Xu wrote:
> attached is the updated patch.
>
> On Wed, Jan 15, 2014 at 10:51 AM, Rong Xu wrote:
>> On Wed, Jan 15, 2014 at 10:40 AM, Xinliang David Li
>> wrote:
>>> In libgcov-driver.c,
>>>
>>> 1) there are couple of places wit
On Wed, Jan 15, 2014 at 10:40 AM, Xinliang David Li wrote:
> In libgcov-driver.c,
>
> 1) there are couple of places with trailing white spaces (e.g, in
> gcov_sort_n_vals body), please remove
They are from the existing code. But I'll fix them.
> 2) gcov_exit_write_gcda in trunk takes eof_pos as a
In libgcov-driver.c,
1) there are couple of places with trailing white spaces (e.g, in
gcov_sort_n_vals body), please remove
2) gcov_exit_write_gcda in trunk takes eof_pos as an arg, and check it
before writing the header. I think this is more correct than in your
patch
3) It would be better to ke
