ok for google branch. David
On Wed, Jan 15, 2014 at 2:58 PM, Rong Xu <x...@google.com> wrote: > attached is the updated patch. > > On Wed, Jan 15, 2014 at 10:51 AM, Rong Xu <x...@google.com> wrote: >> On Wed, Jan 15, 2014 at 10:40 AM, Xinliang David Li <davi...@google.com> >> wrote: >>> In libgcov-driver.c, >>> >>> 1) there are couple of places with trailing white spaces (e.g, in >>> gcov_sort_n_vals body), please remove >> They are from the existing code. But I'll fix them. >> >>> 2) gcov_exit_write_gcda in trunk takes eof_pos as an arg, and check it >>> before writing the header. I think this is more correct than in your >>> patch >> That's true. But this logic is from the newer code in trunk. >> Current 4_8 code does not check this. I deliberately did this because I >> thought >> the backporting patch should not change this. >> >> I'll change to the trunk verison then. >> >> >>> 3) It would be better to keep the function order the same in trunk >>> (e.g, compute summary related, merge gcda and write gcda etc); it is >>> also helpful to keep LIPO related functions order in the same way as >>> in google/main so that a better diff can be done >>> 4) libdriver-profiler.c -- make the function ordering the same as in >>> google/main would be helpful. >> >> sure. I'll do this two items. Will send an updated patch soon. >> >>> >>> thanks, >>> >>> David >>> >>> On Wed, Jan 15, 2014 at 10:03 AM, Rong Xu <x...@google.com> wrote: >>>> The attached patch backports libgcov re-factoring patches from trunk. >>>> >>>> Tested with google internal benchmarks, SPEC2006, bootstrap and >>>> profiledbootstrap. >>>> >>>> OK for google/gcc-4_8 branch? >>>> >>>> -Rong
